Commits · a57d7533571e919940dc8d551450b4f7f20f74a9 · eriksson monteiro / tangled

08 Jul, 2020 40 commits

Roll WebRTC from 3444a49d77b0 to e88c95e516b6 (28 revisions) · a57d7533

chromium-autoroll authored Jul 08, 2020

https://webrtc.googlesource.com/src.git/+log/3444a49d77b0..e88c95e516b6

2020-07-08 hbos@webrtc.org [Stats] Add more rtc::Thread::ScopedDisallowBlockingCalls to getStats().
2020-07-08 tommi@webrtc.org Remove unused GuardedAsyncInvoker class
2020-07-08 handellm@webrtc.org Revert "Migrate test/time_controller to webrtc::Mutex."
2020-07-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b5359525..a69b9c61 (785857:786202)
2020-07-08 hbos@webrtc.org [Stats] Optimization: Minimize number of thread-invokes in getStats().
2020-07-08 mbonadei@webrtc.org Revert "Implement packets_(sent | received) for RTCTransportStats"
2020-07-08 handellm@webrtc.org Migrate modules/audio_device to webrtc::Mutex.
2020-07-08 handellm@webrtc.org VideoAnalyzer: remove lock recursions.
2020-07-08 handellm@webrtc.org Migrate test/pc/e2e to webrtc::Mutex.
2020-07-08 mbonadei@webrtc.org Add possibility to expand strings in the autoroller.
2020-07-08 handellm@webrtc.org Migrate test/time_controller to webrtc::Mutex.
2020-07-08 handellm@webrtc.org Migrate modules/congestion_controller to webrtc::Mutex.
2020-07-08 titovartem@webrtc.org Fix thread usage in PC level tests for getting to the IceConnected state
2020-07-08 handellm@webrtc.org Logging: reduce locking frequency by fixing TODO.
2020-07-07 handellm@webrtc.org Revert "Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex."
2020-07-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fa6a9612..b5359525 (785707:785857)
2020-07-07 handellm@webrtc.org Migrate pc/ to webrtc::Mutex.
2020-07-07 handellm@webrtc.org Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex.
2020-07-07 handellm@webrtc.org Migrate modules/remote_bitrate_estimator to webrtc::Mutex.
2020-07-07 handellm@webrtc.org Migrate video/adaptation and video/end_to_end_tests to webrtc::Mutex.
2020-07-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5f083e73..fa6a9612 (785559:785707)
2020-07-07 handellm@webrtc.org Migrate modules/audio_coding, audio_mixer/ and audio_processing/ to webrtc::Mutex.
2020-07-07 handellm@webrtc.org Migrate media/ to webrtc::Mutex.
2020-07-07 handellm@webrtc.org Migrate common_video/ and examples/ to webrtc::Mutex.
2020-07-07 ivoc@webrtc.org Update default max nr of packets to 200.
2020-07-07 handellm@webrtc.org Migrate modules/rtp_rtcp to webrtc::Mutex.
2020-07-07 handellm@webrtc.org Migrate modules/video_coding to webrtc::Mutex.
2020-07-07 titovartem@google.com Implement packets_(sent | received) for RTCTransportStats

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ida1605b68ce1bb4c568c7fddee238f84aeb98aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287775Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786300}

a57d7533

AW: rename pak GN variables · 06c0ace3

Nate Fischer authored Jul 08, 2020

This renames system_webview_pak_whitelist to
system_webview_pak_allowlist.

Fixed: 1101022
Test: build with `is_official_build = true`
Change-Id: I56a11427132d8b3b143a830ba9dba098fe39d697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285504
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786299}

06c0ace3

Roll Perfetto Trace Processor Linux from 0b81007941c4 to cdb7febb0552 · eb5614b7

chromium-autoroll authored Jul 08, 2020

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ie5b8e90808748c59f7c03a2ccfa63eb1338b83e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287375Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786298}

eb5614b7

Roll SwiftShader from 28159ee9c8e3 to 49a334846e76 (3 revisions) · 5a2ee24a

chromium-autoroll authored Jul 08, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/28159ee9c8e3..49a334846e76

2020-07-08 amaiorano@google.com Enable Kokoro LLVM 10 builds on Windows
2020-07-08 amaiorano@google.com Add llvm-10 configs for Windows
2020-07-08 amaiorano@google.com Copy and modify update.py for LLVM 10

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I6ff199ab3f09e2ccb0423809cee47a4a61cf055e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287770Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786297}

5a2ee24a

Clean up mojo::SyncCallRestrictions friends list · 1482d8c2

James Cook authored Jul 08, 2020

Clean up a couple items related to the (deleted) mojo pref service.

sync_preferences::PrefServiceSyncable doesn't make mojo calls anymore.

prefs::PersistentPrefStoreClient doesn't exist.

Bug: none
Change-Id: I7640290a94aa3c2697c825dc6929b239b9574f19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285920
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#786296}

1482d8c2

Change missing printer from a warning to an error · 65dbbdd3

Gavin Williams authored Jul 08, 2020

Any local printer available to be printed to should always be present
in CupsPrintersManager. So when requesting a printer status, if the
requested printer is not available in CupsPrintersManager, return a
Connecting to Device error.

Bug: 1059607
Change-Id: I010545a57c896be4111e4e647ecb82bbb6804ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287376Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786295}

65dbbdd3

Roll Perfetto Trace Processor Win from faef2531ecbb to 0b81007941c4 · d05731f5

chromium-autoroll authored Jul 08, 2020

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I9ad6107a3779a4f928cb4673acbabbf468c4f98e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287374Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786294}

d05731f5

Chrome OS - PIN Auto Submit - Feature flag · 6fac0d05

Renato Silva authored Jul 08, 2020

Add a feature flag for the PIN auto submit feature. Also add
methods to store the user's PIN length in local state.

Bug: 1075995
Change-Id: I2b307acefd5e39dd0deed747a0ef03c20be76899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287709
Auto-Submit: Renato Silva <rrsilva@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Renato Silva <rrsilva@google.com>
Cr-Commit-Position: refs/heads/master@{#786293}

6fac0d05

Roll FreeType from 0f35b042e02e to 96fb73efd5c6 (1 revision) · 9e06e752

chromium-autoroll authored Jul 08, 2020

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/0f35b042e02e..96fb73efd5c6

2020-07-07 wl@gnu.org Fix clang warnings.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: bungeman@google.com,drott@google.com,thestig@google.com
Change-Id: I7397766bf9b3c2d90235d8f94a169f261a7dec18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287769Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786292}

9e06e752

Remove cc::Layer check from CompositorAnimations::AttachCompositedLayers · 0145749a

Philip Rogers authored Jul 08, 2020

CompositorAnimations::AttachCompositedLayers no longer needs to check
for PaintLayers or the existence of a cc::Layer because these are now
guaranteed with Animation::CheckCanStartAnimationOnCompositor, called
from Animation::PreCommit, which checks if property tree nodes exist.

This patch enables future supports for composited animations without
PaintLayers (see: https://crrev.com/c/2250514).

Bug: 1101002
Change-Id: I414b48d2586038cb818239a51c4b716204464ec5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283383Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786291}

0145749a

[DevTools] Replace usages of GetRawDataResource · b9e27051

Kristian Kirs authored Jul 08, 2020

GetRawDataResource assumes that underlying files are not compressed,
whereas LoadDataResourceString automatically decompresses if necessary.

Bug: 1068407
Change-Id: I03b5833fb245460d60a3206985cc905efdbf6cd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270225Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786290}

b9e27051

Roll Chrome Win32 PGO profile from... · 7ed16895

chromium-autoroll authored Jul 08, 2020

Roll Chrome Win32 PGO profile from chrome-win32-master-1594202362-b0a6f43d52064bea3bb530e07058a845cbb3d6d1.profdata to chrome-win32-master-1594205767-6ce6d14294fc2a08f2b1164184f19ff8db079629.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome
Tbr: jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ib3935e0daad73d783cc9ff47c33e9355f45102e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287148Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786289}

7ed16895

Add update required EOL info on management page for CrOS only · 428e2e7b

Saurabh Nijhara authored Jul 08, 2020

As per the requirement of device policy, MinimumChromeVersionEnforced,
it is required to show message on the management page in case
update is required as per policy when device does not meet the minimum
chrome version but device cannot be updated as it has reached its end
of life.
A message is also to be shown on the OS settings page which would be
added in a subsequent CL.

Bug: 1048607
Change-Id: Ia014ee3e930bd9856e78878e7b189c021b7b9879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264293
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786288}

428e2e7b

[Kiosk] Restart Web App Kiosk in case of browser crash · 876cffa2

Anatoliy Potapchuk authored Jul 08, 2020

Previously, if the browser process crashed during Web kiosk session, we
would have just exited the session. This cl leverages the new kiosk
launch logic, where we abstract out KioskAppLauncher.

Bug: 1054382
Change-Id: Ia8bed81f839b7f7f81d703e8a03af58e768d0fb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279121
Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Anqing Zhao <anqing@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786287}

876cffa2

Revert "[LiteVideo] Do not attempt LiteVideos on Reloads/Forward-Back." · 35dc9176

Michael Crouse authored Jul 08, 2020

This reverts commit 6ea86d08.

Reason for revert: Tests are flaky on ChromeOS, so reverting until I can solve it. crbug/1103155

Original change's description:
> [LiteVideo] Do not attempt LiteVideos on Reloads/Forward-Back.
> 
> This change prevents LiteVideos from being attempted when the
> navigation is a reload or forward-back page transition. It also
> adds an entry for host of the navigation to the user blocklist to
> allow users to soft opt-out of the optimization if they reload
> frequently on a host.
> 
> A future change will clear the blocklist when the browser history
> is wiped.
> 
> Bug: 1096796
> Change-Id: I687d4c9cd0844d7475f6a3baedacebcf73a48845
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276681
> Commit-Queue: Michael Crouse <mcrouse@chromium.org>
> Commit-Queue: Tarun Bansal <tbansal@chromium.org>
> Auto-Submit: Michael Crouse <mcrouse@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Sophie Chang <sophiechang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#786127}

TBR=tbansal@chromium.org,sophiechang@chromium.org,rajendrant@chromium.org,mcrouse@chromium.org

Change-Id: Id708961e3c7f961a8670ad4c3eb2ee30881e7305
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1096796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287378Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786286}

35dc9176

Fix how content-type is set in WinHTTP network fetcher · 50ead5c5

Maciek Kumorek authored Jul 08, 2020


The WinHttpAddRequestHeaders expects a fully formatted header:
 Key: Value\r\n

Only the value of content-type header was passed. This change fixes
the issue.

Bug: 1102579
Change-Id: I1b432312bbba161f833de99dfda1ef9e4b39135d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283927Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Maciek Kumorek <makumo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#786285}

50ead5c5

Roll Skia from 5a33f21a483b to cfbb56c6e180 (6 revisions) · aae7c667

chromium-autoroll authored Jul 08, 2020

https://skia.googlesource.com/skia.git/+log/5a33f21a483b..cfbb56c6e180

2020-07-08 fmalita@chromium.org [skottie] Auto-orient fixes
2020-07-08 jvanverth@google.com Replace remainder of HRESULT checks with macro
2020-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8b80e852bd6c to 3688cb363ccd (9 revisions)
2020-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 92554d75f354 to 7622be0544b0 (6 revisions)
2020-07-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f6f11215cd93 to 28159ee9c8e3 (1 revision)
2020-07-08 robertphillips@google.com Update DDL test harness to use GrDirectContexts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1091259
Tbr: mtklein@google.com
Change-Id: I8e972d137003a43784862fe82e0c847e703f2f60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287771Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786284}

aae7c667

[Switch Access] Simplify auto-scan test · 3cb2dff5

Anastasia Helfinstein authored Jul 08, 2020

AX-Relnotes: n/a.
Bug: 897365
Change-Id: I8a3691d56d5a12d15d382ae8f7f60ef629fc75e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285077
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Auto-Submit: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786283}

3cb2dff5

Slightly cleanup description for RegisteredProtocolHandlers · e4e1e00e

Chris Sharp authored Jul 08, 2020

Change-Id: I2c3f9fbea344fd031e7249f2b9b6e18976472952
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286952
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786282}

e4e1e00e

[Sync] Fix reupload of bookmarks without favicons on iOS · cdca14f4

Rushan Suleymanov authored Jul 08, 2020

Prior to this patch any favicon change on iOS devices would cause
bookmark reupload on each remote update (which contained favicon).
Furthermore, any remote update with favicon could trigger favicon
changed event.

This CL checks if there is actual favicon in specifics before updating
current entity on favicon changed event coming from the BookmarkModel.
It is prevents entity from being reuploaded without favicon on
incremental remote update.

Bug: 1075709
Change-Id: Ie15dcc62160a0851b2ce8e40ce0ef20eff43f995
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283214
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786281}

cdca14f4

Trust Tokens: LOG(ERROR), not FATAL, on bad command-line key commitments · 3507c2ca

David Van Cleve authored Jul 08, 2020

Right now we LOG(FATAL) when a user provides bad Trust Tokens key
commitments through the command line (for local debugging). This was
intended to crash Chrome entirely when it's provided a syntactically
invalid command line flag during local testing, with the thought that
the user would want to know immediately that there was a problem with
their testing setup. Sadly, LOG(FATAL)ling from the network service
unfortunately just crashes the network service, not Chrome as a whole;
this network service crash is not directly user-visible and can lead to
confusing behavior like no pages loading.

This change alters the log line to a LOG(ERROR) so that the failure
remains consistently visible in the command line console without leading
to hard-to-diagnose behavior like pages failing to load.

Bug: None

Change-Id: I70a40b1057140f17754f4c8b479f64256d1bc54c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285466
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786280}

3507c2ca

[signin] Plumb Dice signin interception callback to the WebUI bubble · 4963f793

David Roger authored Jul 08, 2020

This CL adds a callback to the signin interception bubble.
The callback will be called when the user interacts with the inner
WebUI (in a follow-up CL) or when the bubble is closed.

Bug: 1076880
Change-Id: Ie09df4915965ea1b62c88b5569c7530936f13b2f
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279197
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786279}

4963f793

Create credential provider watchlist · ef507e63

Javier Ernesto Flores Robles authored Jul 08, 2020

Bug: N/A
Change-Id: I379eb1b6865715abbb93677bca12849e2af56243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287436
Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786278}

ef507e63

Safety check UI: update Chrome cleaner child states · b8a1dc17

Rainhard Findling authored Jul 08, 2020

* This CL aligns the Chrome cleaner child element behavior with the
  latest mocks for all states except the "safe" states, which will be
  updated in a separate CL.

Bug: 1087263
Change-Id: Ie2b05f879aa6b03ceff97d83f3376a701eedadb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276253
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786277}

b8a1dc17

[b4p/sign-out] Reduce expectations of sign-out bubble integration test · 46d888c9

Victor Hugo Vianna Silva authored Jul 08, 2020

This is a preparation to allow the user to choose which passwords to
save in the 'save unsynced credentials' bubble. To do so, we will
modify ManagePasswordsUIController::SaveUnsyncedCredentials() to take
the vector of credentials as a parameter.

BubbleObserver::AcceptSaveUnsyncedCredentialsPrompt() fakes the user
accepting the bubble in this integration test. If it is kept in the new
design, it would need to take the credentials as a parameter as well,
which renders some expectations in this test completely artificial.

So, after this CL, the test no longer verifies that accepting the bubble
stores the credentials in the profile store. Instead it only verifies
that the bubble is opened. The saving logic is still covered by unit
tests in ManagePasswordsUIController.

Bug: 1098672
Change-Id: I7a1d752b67934e31d968ac23475026fc0cdc4af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287315
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786276}

46d888c9

Reland "Android: Bump default target_sdk_version 24 -> SDK used to compile" · e0f5a1c0

Andrew Grieve authored Jul 08, 2020

This reverts commit fb07fcff.

Reason for reland: Not changing target_sdk_version for angle tests

Original change's description:
> Revert "Android: Bump default target_sdk_version 24 -> SDK used to compile"
>
> This reverts commit b7fb15b1.
>
> Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1099849
>
> Original change's description:
> > Android: Bump default target_sdk_version 24 -> SDK used to compile
> >
> > Why do this?
> > * It's best practice to target the latest sdk, so this makes for a
> >   better default.
> > * Many targets were neglecting to ever update this value

TBR=boliu@chromium.org,torne@chromium.org,agrieve@chromium.org,behdadb@chromium.org

Bug: 1099849
Change-Id: I95f36a2b88d2e7ad1d90222f25192c9a915550ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280981Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786275}

e0f5a1c0

[Telemetry SWX] Add bluetooth info · bf569c8f

Oleh Lamzin authored Jul 08, 2020

Add bluetooth info to the probe service.

Bug: b:158658869
Change-Id: Ic17d533e877dd1be3804587ca6126125dec7b869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275880
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Roland Bock <rbock@google.com>
Cr-Commit-Position: refs/heads/master@{#786274}

bf569c8f

bluetooth: Convert service creation callbacks to OnceCallback · ccb8622d

Reilly Grant authored Jul 08, 2020

This change converts callbacks related to Bluetooth Classic service
creation from base::Callback to base::OnceCallback. There should be no
functional change.

Bug: 834319
Change-Id: I99917e7e03a65013f23f4ebd607e1d7eb6a5da64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286589
Auto-Submit: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786273}

ccb8622d

Roll Perfetto from 0b81007941c4 to cdb7febb0552 (1 revision) · 02d5a56d

chromium-autoroll authored Jul 08, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/0b81007941c4..cdb7febb0552

2020-07-08 fmayer@google.com Merge "Keep track of whether client disconnected because of timeout."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I1329f16d4364f9dcb021cd7f992b2778e15e89e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287146Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786272}

02d5a56d

chromeos: enable ozone platform headless on CrOS · a599fb48

Polina Bondarenko authored Jul 08, 2020

IsRunningAsSystemCompositor must return false, because input
should be disabled on ozone platform headless.

BUG=b:160309778
TEST=manual

Change-Id: I8a97b166b42a581a275c305355f0c4434e5adbbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276426Reviewed-by: Michael Spang <spang@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Polina Bondarenko <pbond@chromium.org>
Auto-Submit: Polina Bondarenko <pbond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786271}

a599fb48

Roll Perfetto Trace Processor Linux from faef2531ecbb to 0b81007941c4 · 85867d03

chromium-autoroll authored Jul 08, 2020

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I5ba63704754faf862e2ef31a934c89463a147980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287372Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786270}

85867d03

Roll Catapult from 7cbda52a2db8 to 0c87b32429bf (1 revision) · 92c9a7c8

chromium-autoroll authored Jul 08, 2020

https://chromium.googlesource.com/catapult.git/+log/7cbda52a2db8..0c87b32429bf

2020-07-08 omerkatz@chromium.org heap: Add metric for time that cannot be moved to concurrent thread

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:986235
Tbr: rmhasan@google.com
Change-Id: I88dd95fac0446cb6db66811b834cf23a23ee5fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287144Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786269}

92c9a7c8

[Telemetry SWX] Add stateful partition info · d4d753df

Oleh Lamzin authored Jul 08, 2020

Add stateful partition info to the probe service.

Bug: b:158658869
Change-Id: Ie90406b06a790424c1f2771d6f718a16914a6591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275442
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Roland Bock <rbock@google.com>
Cr-Commit-Position: refs/heads/master@{#786268}

d4d753df

[ios] Fix handling of empty string in ~/setup-gn · 072896f3

Sylvain Defresne authored Jul 08, 2020

If a variable was initialised to an empty string, it would be
generated as `variable = ` instead of `variable = ""` when the
args.gn file was generated, breaking `gn gen`.

Convert the string to the correct format.

Bug: none
Change-Id: I6268623c3e6cd2c27bfdfc167a4a77779e01962f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282566
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786267}

072896f3

Roll Skia from 473c9f4cd9b2 to 5a33f21a483b (1 revision) · ced65277

chromium-autoroll authored Jul 08, 2020

https://skia.googlesource.com/skia.git/+log/473c9f4cd9b2..5a33f21a483b

2020-07-08 robertphillips@google.com Remove a Chrome staging flag

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1097484
Tbr: mtklein@google.com
Change-Id: I7807b4fdab1a992326968ee0267a470a5b09d4b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287139Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786266}

ced65277

[WPT] Remove fail expectation for foreign-object-scale-scroll.html · 20d7a9d0

Stephen Chenney authored Jul 08, 2020

The test is passing now, for some reason.

TBR: fs@opera.com
Bug: 1102917
Change-Id: Iaddc423007f9442e951ec20a02c4d29a2eabfdc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287710Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786265}

20d7a9d0

Roll src-internal from 14522a51c8d5 to d07980440d45 (2 revisions) · ceddb351

chromium-internal-autoroll authored Jul 08, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/14522a51c8d5..d07980440d45

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC huanzhong@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1090397,chromium:1094282,chromium:1102355,chromium:1102832
Tbr: huanzhong@google.com
Change-Id: I5befb23a958540e76f3b102c4922116f70159a4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287136Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786264}

ceddb351

[Telemetry SWX] Add fan info · 0f99699c

Oleh Lamzin authored Jul 08, 2020

Add fan info to the probe service.

Bug: b:158658869
Change-Id: Icfb3eea6af1999956cc854ef22f4ece6be42cb18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275441
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Roland Bock <rbock@google.com>
Cr-Commit-Position: refs/heads/master@{#786263}

0f99699c

Roll ANGLE from e6a6e45f3af0 to a3f6dc2fadb4 (6 revisions) · b22105d6

chromium-autoroll authored Jul 08, 2020

https://chromium.googlesource.com/angle/angle.git/+log/e6a6e45f3af0..a3f6dc2fadb4

2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from db06fce926b0 to 2a164e9680a5 (3 revisions)
2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e8b96e86fe2e to 3bae90706d26 (2 revisions)
2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f5ed7a69d5d6 to 29c9135d06f1 (3 revisions)
2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from abc9dff824c3 to 68bfbc219497 (1 revision)
2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f6f11215cd93 to 28159ee9c8e3 (1 revision)
2020-07-08 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 6a4da9da4215 to 7afbc0c8be3f (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: syoussefi@google.com
Change-Id: Iab10a4ce2eefef05c6cb6aa867292d6c0166269b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287135Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#786262}

b22105d6

[Telemetry SWX] Add backlight info · 97f15459

Oleh Lamzin authored Jul 08, 2020

Add backlight info to the probe service.

Bug: b:158658869
Change-Id: I9c9e19bbc3ee8f46517f9b06faf314280d40e823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274877
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Roland Bock <rbock@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#786261}

97f15459