- 08 Jan, 2021 40 commits
-
-
Clark DuVall authored
We are planning on running binary experiments for isolated splits enabled/disabled on M89. I want to make sure there are no problems with the disabled version before branch cut. I'll revert this CL after a couple days. Bug: 1150162 Change-Id: I20061a079e897058625506dab810c4584c200fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618367 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#841596}
-
Erik Chen authored
This is a reland of 8d4df26b Original change's description: > Set "dev" channel for all lacros builds. > > Linux-chrome (of which lacros is a variant) has its channel set as a > runtime environment variable by the launcher script. For Lacros, we must > set the environment variable from ash. For now, we always set "dev" for > all builds of Lacros. > > Change-Id: I840286b6fd5772701c3f6d927986405697b82097 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570448 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833460} Change-Id: I1d42534b8e289e1df63286658d9c7601357e82dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617099Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841595}
-
Kevin McNee authored
This test is flaky. Bug: 1144228 Change-Id: If00d25d5f3115ff203c9b333c5e617a2ece63657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618082 Commit-Queue: Kevin McNee <mcnee@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#841594}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f78841938e2d..6ddca3188e2e 2021-01-08 cpinnamaneni@microsoft.com keyboard accessiblity for Add new context menu in data grid 2021-01-08 jacktfranklin@chromium.org Workflow improvements to component docs 2021-01-08 tvanderlippe@chromium.org Use top level await in component_docs 2021-01-08 tvanderlippe@chromium.org Remove component_docs from GRD If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1164006 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I00fcbfb3bc7a020151af395bfa4ef77ae70ab524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841593}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/afc78f5e6ae9..11e6cfe60a92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If9319b67d5e281ce80d281d8472930f7f1e4b750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618366Reviewed-by:
-
Scott Violet authored
This is no longer used. BUG=none TEST=none Change-Id: Id063e0eb48ccb46c1d0ae40946a251c8d8f4882a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617121 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/11e6cfe60a92..61125414310a 2021-01-08 treehugger-gerrit@google.com Merge "tracing: Add macro for retrieving category group name from state pointer" 2021-01-08 treehugger-gerrit@google.com Merge "tracing: Allow dynamically computed categories with TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED" 2021-01-08 treehugger-gerrit@google.com Merge "tracing: Avoid clash with variables called |trace_id|" 2021-01-08 fmayer@google.com Merge "Expose heapprofd_client_api to mainline modules." 2021-01-08 hjd@google.com Merge "upkeep: Make loop variable const&" 2021-01-08 hjd@google.com Merge "trace_processor: Report error on traces <1us" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iefa411feb5b4b0c1068dae5d94cfdbd5e0483cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618236Reviewed-by:
-
David Van Cleve authored
This change adds a flag option to enable platform-provided trust token issuance (https://bit.ly/platform-provided-trust-tokens) in order to make manual testing easier. R=svaldez Bug: 1130248 Test: Confirmed old "Enabled" option -> PPTT off, new option -> PPTT on Change-Id: I191b08172147b3056a268fd630fcd07d7af6a5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616140 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#841589}
-
Richard Townsend authored
Attempts to fix an ASAN-detected crash for IsPrefetchOnly() Documents. Bug: 901056, 1164226, 1160665, 1164377 Change-Id: I74c75c58d3e2d9319f67997e3b08d1ab7d5e008d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618362Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#841588}
-
Owen Min authored
Using if defined instead of idef, and include build/build_config.h References: https: //chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#platform_specific-code Change-Id: I1336313e002eeee85496d31089349826a60fc34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618398Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841587}
-
David Grogan authored
When deriving flex base size of an svg that has an aspect ratio but no natural height or width, we were ignoring min/max sizes specified in the cross-axis direction, even though they should transfer through the aspect ratio and restrict the stretch fit into the available size. Bug: 1162704 Change-Id: If502de43a876e41e6f3784aea089edcd2467ba60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614470Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841586}
-
Matthew Porter authored
This change adds a check for the system animation setting prior to animating. This ensures when users explicitly opt into having no animations, that we honor that preference. Change-Id: I2a63a9ea40566932005a3e32b8ee061d9fc879a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617199Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Matthew Porter <matt.porter@microsoft.com> Cr-Commit-Position: refs/heads/master@{#841585}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f5aed172c693..fafb47739a31 2021-01-08 borenet@google.com [infra] Filter PathKit and CanvasKit tryjobs when cutting Chrome branch 2021-01-08 nifong@google.com debug build for wasm gm tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: I5e6917f6c08320260e5667d7475d0d09529536d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618229Reviewed-by:
-
Leonard Grey authored
Bug: 1152274 Change-Id: I68caf298c2009923b450619cd6ebb0ad4b94870d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615203Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#841583}
-
Gavin Williams authored
Extending to M91 for new enterprise printer status icons introduced in M89. Change-Id: I7c51781d77aa6a5a575460bcd2a03d80566a3533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616984 Auto-Submit: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#841582}
-
Brandon Wylie authored
TBR=blundell@chromium.org Bug: 1164414 Change-Id: Iabfd418962724d2ce28f44a9b4d1ef549d038c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618364 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Auto-Submit: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#841581}
-
Zhenyao Mo authored
1) GPU switching is considered and this CL made sure the hardware GPU info displayed in the about:gpu is the last active GPU before Chrome falls back to SwiftShader. 2) Don't put SwiftShader info into hardware GPU section. Before this CL, if we run Chrome with GPU acceleration off, SwiftShader ended up in the hardware GPU section. BUG=1154047 TEST=manual, gpu bots R=kbr@chromium.org Change-Id: I08ea41a25d40610e0d13da83f8b5dfeb50011b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613741Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#841580}
-
Ryan Sturm authored
Since there can be a time gap between when the url loader interceptor is handed off to content/ and when the throttles allow the request to proceed, there is a possibility of forwarding_client_ not being set up while the streaming request pointer is null. I suspect this is where the crash is coming from. Bug: 1164190 Change-Id: I1e68fa7898737ba71b68ec681903b88ece88c8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617858 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#841579}
-
Gil Dekel authored
This CL updates the display configurator API and tests to reflect unified modeset testing. Bug: b:176819129 Test: display_unittests && ozone_unittests Change-Id: Ib87bd884457320b0fafd764d818bb3b2b56d7364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613152 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e665c5ed..2033aa92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7357d897e15b75fc1a2775b5cab5a208b63797d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617564Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841577}
-
dpapad authored
- Replace call to CallJavascriptFunctionUnsafe with ResolveJavascriptCallback. - Replace chrome.send with cr.sendWithPromise. - Add JS type checking. Bug: 1028829 Change-Id: I7ed709930969e4afe153f850d96c5aa6adb7442b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616968 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841576}
-
Joao Victor Almeida authored
This CL presents an experiment (https://bit.ly/3iyQf8V) that discusses changing the prediction time used by ScrollPrediction to reduce the AverageLag in touch scrolls. It proposes to change the current prediction time used to predict scroll events. Currently, they're predicted at the BeginFrame time but the predicted delta will be presented to the user at Presentation time. This happens, on Windows, 2 frames after BeginFrame time, creating a lag between the user's intended scroll position and the one visible. It concludes that predicting with a 0.5 * (frame interval) advance is optimal in a 60Hz system. Please share your thoughts on the document :) The code in the CL is the required change for the finch experiments to verify the document's finding for a optimal prediction timing: 0.5 frame advance. The time advance can be: 1. Fixed value in ms (default +3.3ms) 2. Framerate dependent: ratio of frame interval (default 0.5) The fixed time and the framerate ratio can be passed as argument too. We will use this to gauge this prediction against the experiments with android jitter done by eirage@. Change-Id: I55281b11465f36e240594a6719c83b8df84111c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412214Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#841575}
-
Thomas Lukaszewicz authored
Now that inconsistencies with rounded corners have been addressed via layer masking where appropriate this CL the md rounded corners flag. Bug: 932970 Change-Id: Id24d23ef34066025274fdbaa4c2ff71cd755bc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597152Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#841574}
-
Max Curran authored
Change-Id: I191c850715587882d4f28b1895665addecdcdb73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613348Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#841573}
-
Michael Bai authored
Change-Id: Id6c5d6022942bfa7f34e4e25b96c650d0e07ddf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617123Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#841572}
-
Adam Rice authored
The web test external/wpt/websockets/stream/tentative/backpressure-receive.any.js started failing on Windows 10 with the switch to Python 3. It appears some additional buffering is happening in the OS. As a workaround, split the large message that is supposed to be delayed by backpressure into 16 parts. BUG=1155106 Change-Id: Ifa2b04e4857f3c537721735cec187f610c053d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613853 Commit-Queue: Domenic Denicola <domenic@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841571}
-
Caroline Rising authored
Add a reading list profile pref for whether the first use experience has been shown. Bug: 1109316 Change-Id: I62495a0804910e25c2b3498ed6923362b6b8447d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611445Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#841570}
-
Ken Rockot authored
Bug: 1004256 Change-Id: Iaaf8e601a7f3e400bd7aff5b60e8586e7adb43a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616519Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#841569}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1607b3aa8ccd..942976eacacf 2021-01-08 sergio.garcia.murillo@gmail.com Wire scalability_mode when simulcast is not in use (i.e. streams==1) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6238fcc7a9251700904d5457579ccbde8190e678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617426Reviewed-by:
-
Domenic Denicola authored
Fixed: 1148056 Change-Id: Id753248d13cf8332597b0c6592c9d8d9c43407ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615478Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841567}
-
Lijin Shen authored
Bug: 1157681 Change-Id: I109580de27420bafc9a57a4c83bedba18799bac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605417 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#841566}
-
Dave Tapuska authored
Move UnfreezableFrameMsg_DeleteProxy to be a method on the RemoteFrame. This is possible because associated channel messages are not currently frozen. BUG=993189 Change-Id: I9b09706686d4dc1b6bf7f499f1f5f90224380c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527517 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#841565}
-
Fredrik Söderqvist authored
MediaValuesInitialViewport was only used by |ViewportStyleResolver::initial_viewport_medium_|, but that in turn is never used. Remove the class and drop the unused ViewportStyleResolver field. Bug: 991610 Change-Id: I51bb5a8f5e967b16d6c1e0f473b76d4bbc76ff28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616562Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#841564}
-
Nick Diego Yamane authored
Factor out common helper test code into WaylandDragDropTest class, clean up and re-use it in both data and window drag controller unit tests. R=msisov@igalia.com, tonikitoo@igalia.com Bug: 1163544 Test: ozone_unittest --gtest_filter='*WaylandDataDragControllerTest.*' Change-Id: I91f34f2f189783472fb8aa20764da305a5cbe793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613684Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#841563}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/070ef598892a..afc78f5e6ae9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie57e77d2ae55c692d5937b336abfb54fdecc8843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618223Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3b1f7453a734..f78841938e2d 2021-01-08 tvanderlippe@chromium.org Fix lit_html_data_as_type to handle multiple data setters If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8357ff2b414f7222318b4e9e74dd511ae7571009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617425Reviewed-by:
-
Mark Cogan authored
There are relatively frequent crashes (see bug) originating from GridViewController inducing reentrancy into WebStateList. This happens when a state-mutating method (in this case, ActivateWebStateAt()) is called on WebStateList while it is still handling a different state- mutating method call. The initial method call triggers observer methods, then the observer method (usually very indirectly) calls another state- mutating method. Specifically for this bug, this sequence of events happens: 1) Something causes a new tab to be inserted (there are many ways to do this). 2) The tab insertion is observed by TabGridMediator, which calls the -insertItem:atIndex:selectedItemID: consumer method. 3) The consumer (the GridViewController) eventually calls [UICollectionView performBatchUpdates:completion:]. 4) Roughly 24 stack frames of UIKit calls happen. 5) [UICollectionViewDelegate -shouldSelectItemAtIndexPath:] is called. 6) GridViewController subsequently calls (eventually) [TabGridMediator -selectItemWithID], which calls ActivateWebStateAt(). I don't have repro steps, so I haven't seen a crash with the symbols for the UIKit stack frames in step (4), so I don't know what the collection view is doing to make this happen. The collection view docs say that -shouldSelectItemAtIndexPath: should *only* be called when the user taps on a cell, and never when the cell is programmatically selected. But it looks like that's still what's happening. Absent repro steps, this CL puts two layers of speculative fixes. First, TabGridMediator's selectItemWithID: method adds several early- return possibilities; it will now early-return if the selected item is already selected, and it will early-return if the web state list is locked for mutation. Note that it's unclear what will happen in this case, since the activation event might be triggering the tab being opened. Second, GridViewController sets an 'updating' flag while the collection view batch update is in progress, and doesn't handle cell selection while this flag is set. Either one of these should fix the crash, but since there aren't repro steps, I've added both. Bug: 1134663 Change-Id: Ia838a5da9b763dbe8b82acc69957327d96259261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614432 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:Mark Cogan <marq@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#841560}
-
Alexei Svitkine authored
This should speed up using feature / field trial params APIs. Bug: 1163921 Change-Id: Ieacd216cba47c259287b3b392bd00fa7077ac084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615481 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#841559}
-
Sebastien Marchand authored
A lot of the logic in this file dates from the Syzygy days, as we don't use it anymore there's no need to template the target that generates the installer. Change-Id: I810e059b6eb733324096389dca53853f080c672d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613328 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#841558}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/afc78f5e6ae9..11e6cfe60a92 2021-01-08 hjd@google.com Merge "upkeep: Remove redundant return" 2021-01-08 hjd@google.com upkeep: Remove unused using decls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic80e0d8a34e8705e95025ac19fd68a99137d99ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618226Reviewed-by:
-
