- 10 Jul, 2018 40 commits
-
-
Dominic Mazzoni authored
It was causing too many problems like being unable to inspect background tabs in chrome://accessibility and losing your place when switching tabs. We should come up with a better fix. Original change: crrev.com/c/1107207 TBR=nektar@chromium.org Bug: 854411, 856163, 856160 Change-Id: Iaef9b8ccbd47defba02e4e887f8219d00e77a808 Reviewed-on: https://chromium-review.googlesource.com/1131846Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#573876}
-
chrome://flagsCarlos IL authored
The previous description contained a long URL that was not wrapping, causing a scrollbar to show up in chrome://flags when the window for some window sized. The description was reworded to remove the URL. Bug: 860215 Change-Id: I687997b9eae09eb827a5483cf67ce9e0960a67b6 Reviewed-on: https://chromium-review.googlesource.com/1132083Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#573875}
-
Tiger Oakes authored
Updates to the infocard to improve style, readability and performance. An icon has been added to the center of the pie chart on container cards, similar to the icon shown on symbol cards. Text to describe the container type has also been added ("File", "Directory", etc) in the same style as the symbol type text. The infocard code has been rewritten to be class based, and the two types of cards inherit from the same base class. This improves readability of the code. The previous icon shown on the card is now cached. This means that if the next node displayed is of the same type (such as moving from a directory to another directory), then the corresponding icon will be reused instead of being cloned again. This improves performance by avoiding unnessecary garbage collection from the identical icon clones. Bug: 847599 Change-Id: Iabe9b5eca2173338aed3d99025d2cbd917aa7d0f Reviewed-on: https://chromium-review.googlesource.com/1132123Reviewed-by:agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#573874}
-
Thomas Guilbert authored
It appears that we can receive a null MediaTaskRunner when trying to create WMPI when the media thread is stopped. This causes a crash immediately after in HTMLMediaElement::StartPlayerLoad, when we try to post to |media_task_runner_| in PipelineImpl::SetVolume. It is unclear why the media thread would fail to start. The stack traces tied to the linked bug all show the Load timers being fired. This and the low crash rate suggest that it is an edge case of the defer load firing when the renderer is already going away. This CL checks for the value of MediaTaskRunner, and fails WMPI creation if we cannot acquire one. Bug: 775393 Change-Id: I05c4b1b4a191ac71f62eb69f9b0d11c1f5eb26e2 Reviewed-on: https://chromium-review.googlesource.com/1117645Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#573873}
-
Peter Mayo authored
Some of css/css-writing-modes sizing-orthog tests are passing. Let's latch in the successes. Bug: 626703 Change-Id: I9b065a8e03da4954a9737285ef7093330bc47ef3 Reviewed-on: https://chromium-review.googlesource.com/1131516Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#573872}
-
Khushal authored
The renderer drops the GrContext cache after a second of idle period, where idle period is identified as a continous period where the ContextProvider backing a GrContext is not used. Implement the same optimization for OOP raster in the GPU process. R=ericrk@chromium.org Bug: 859419,859635 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic2ae533212b94320cd8c1b8b1149cf5ba4ce686e Reviewed-on: https://chromium-review.googlesource.com/1123775Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#573871}
-
Kurt Horimoto authored
Bug: 861944 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I94b5233b12dab4809b7901d084c0aa76e02e4f35 Reviewed-on: https://chromium-review.googlesource.com/1130465 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#573870}
-
Zhongyi Shi authored
Connection Migration V2: split the QuicChromiumPacketWriter's write blocked status into two separate invariants. - |write_in_progress_| is tracking writer status, and is set when an asynchronous write doesn't complete, or HandleWriteError/MaybeRetryAfterWriteError is in progress. - |force_write_blocked_| is tracking whether writer should be forced blocked regardless of |write_in_progress_|. QuicChromiumClientSession will set force_write_blocked to true when no alternate network is available or connection migration is in progress to complete to ensure no packets can be written until migration completes. QuicChromiumClientSession::WriteToNewPacket will undo force writer blocked. If packet writer becomes unblocked immediately or after the in-flight write completes, QuicChromiumClientSession::OnWriteUnblocked will be invoked to send a packet after migration. The packet can be a cached packet if |packet_| is set. If there's no cached packet, a queued packet will be sent if there's any, and a ping packet will be sent if writer is still unblocked. See http://crbug.com/859674 for detailed motivations. Bug: 859674 Change-Id: Icdbbb5e14f8439c6601e2c19d9a03f05f17d4bc0 Reviewed-on: https://chromium-review.googlesource.com/1125286 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#573869}
-
Christian Fremerey authored
Follow-up for https://chromium-review.googlesource.com/c/chromium/src/+/1043646. Here we extend the support for raw file descriptors to the virtual device functionality. There is an incompatibility in the serialization of shared memory handles between the Mojo libraries used in Chromium vs. the older ones used in ChromiumOS. As a workaround, this CL allows clients of the virtual device API of the video capture service to ask it to use raw file descriptors for sharing shared memory handles instead. Note, this is only supported on platforms that use file descriptors for base::SharedMemoryHandle, i.e. Posix platforms. Design Doc: https://docs.google.com/document/d/1cmtWA8yua5sqjZC0tswVUZwJeQR-KSZBr3Mj1jUagKk/edit?usp=sharing Bug: 847598 Change-Id: I8a49e5181a622e14ea050cde27ad91ff7feda30d Reviewed-on: https://chromium-review.googlesource.com/1053210 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#573868}
-
Fernando Serboncini authored
Bug: 563816 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If09eece47845488c3da241b10bceb0e63aa06f7d Reviewed-on: https://chromium-review.googlesource.com/1131221 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573867}
-
Esmael El-Moslimany authored
Bug: 860699 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I16d40d0b7dbebffc6af6cf88d8f82cda39f42d47 Reviewed-on: https://chromium-review.googlesource.com/1130501 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573866}
-
danakj authored
WebImage is a wrapper for SkBitmap, which we can just use everywhere so create and pass around SkBitmaps directly, instead of WebImages. WebImage only has static methods left then, which are mostly used from outside of blink, though FromData() is used internally as well, so it seems it should stay in public/platform/ for now. Image gains Image::AsSkBitmapForCurrentFrame() as a means to convert the current frame to an SkBitmap without constructing a WebImage. R=bauerb@chromium.org, haraken@chromium.org TBR=jam Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieb71bde672d1acd84ec36a0e991d9ee44adba718 Reviewed-on: https://chromium-review.googlesource.com/1128365 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#573865}
-
Morten Stenshorne authored
Custom layout children may not establish new formatting contexts, and since the custom container itself is laid out by the legacy engine, we need to force its children to be laid out by legacy as well. Added a margin collapsing test that used to fail in NG because of this. Change-Id: Id320f60fb76b0ed6563fb2b88f6936ac37efc1fd Reviewed-on: https://chromium-review.googlesource.com/1131179Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#573864}
-
Chris Harrelson authored
It was fixed by CL 1125302, but the disable happened in parallel with that CL. Bug: 860031 Change-Id: If505fbcd255daf2da765f1d2f381c286d52efbe5 Reviewed-on: https://chromium-review.googlesource.com/1131815 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573863}
-
Koji Ishii authored
This patch changes NGPaintFragment::DebugName to be more informative to make reviewing paint changes easier, as suggested by atotic@ in CL:1128683. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3255788fea8de74319ffdcc4f4f6ca1e00e0b2e2 Reviewed-on: https://chromium-review.googlesource.com/1130955Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#573862}
-
Dmitry Bezheckov authored
R=thakis@chromium.org Test= base_unittests.ProcessTest.WaitForExitWithTimeout. To reproduce use memory sanitizer (msan) Bug: 861726 Change-Id: If82e2ae32ba71572fa0ec85595b4a00f9a046a1b Reviewed-on: https://chromium-review.googlesource.com/1126927Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573861}
-
Orin Jaworski authored
Answer icons were being rendered using an odd/even technique with a circle of diameter 24, but the internal icons were not properly sized. Now the icons are kept intact with the original design size of 16, and the circle is rendered manually. Bug: 841594 Change-Id: I5d31e43c4c0bdb70f6fe7dcbb85228a268d73571 Reviewed-on: https://chromium-review.googlesource.com/1130350Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#573860}
-
Francois Doray authored
A lot of tests indirectly depend on TabManager. To avoid having to initialize metrics::DesktopSessionDurationTracker in each of these tests once UsageClock is used in TabManager, this CL makes UsageClock resilient to the absence of metrics::DesktopSessionDurationTracker. Bug: 775644 Change-Id: I6ae9a5a01f867df483c334da6df1a7f6510a7702 Reviewed-on: https://chromium-review.googlesource.com/1131929Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#573859}
-
Mohsen Izadi authored
ServerGpuMemoryBufferManager uses a thread task runner to make sure tasks are run on the expected thread. This CL passes in a task runner to the constructor so this can be done against a thread other than the one that created the instance. This is to make ServerGpuMemoryBufferManager ready to be used in content where buffer allocation happens on IO thread. BUG=733482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie864e827de7f0464e2518316c4b7880a347f4074 Reviewed-on: https://chromium-review.googlesource.com/1131559 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#573858}
-
danakj authored
R=dcheng@chromium.org, gab@chromium.org, kylechar@chromium.org Change-Id: Ida5db202ad12fc66e671ca74ec8aa0b81c6159c9 Reviewed-on: https://chromium-review.googlesource.com/1131828Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#573857}
-
Min Qin authored
If download resumes when only service manager is running, download controller could be called when there is no BrowserThread. The BrowserThread will only be introduced when full browser is started. Remove these 2 DCHECks as they will no longer be accurate. BUG=842245 Change-Id: I8ae4819852465fa2a88240fddedf3c0b6dc0d8fb Reviewed-on: https://chromium-review.googlesource.com/1129627Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573856}
-
Lindsay Pasricha authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I56e160def6e650e65bd1861e6143894072546b4c Reviewed-on: https://chromium-review.googlesource.com/1118845 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573855}
-
Reilly Grant authored
This change updates the Web Bluetooth WebIDL files to match the recently merged pull request #402 by hiding interfaces which aren't useful in insecure contexts. Bug: 860798 Change-Id: I59fb1d0765754fce2eb6aefc458f550b09422c96 Reviewed-on: https://chromium-review.googlesource.com/1128462Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573854}
-
Mohsen Izadi authored
This is needed to remove GpuClient dependecny on content. Implementation of GpuClient::Create() still depends on ChildProcessHostImpl. That's not an issue as it would remain in content even after GpuClientImpl is moved to //components/viz/host/, probably in form of a standalone function. BUG=857216 TEST=none Change-Id: I725a1c13d60417c5b4da636d9789f7b989e9a42f Reviewed-on: https://chromium-review.googlesource.com/1126488Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#573853}
-
Charlie Andrews authored
BUG=861876 Change-Id: Ifa0a2429fea9fa6a5e5cd6f1845adbd9c4d5319f Reviewed-on: https://chromium-review.googlesource.com/1129961Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#573852}
-
Rohit Rao authored
Adds optional icons to the leading edge of these two cells. If one is set, the remaining contents of the cells will be inset to make room for the icon. The cells continue to display without an icon by default. Updates the cell catalog to include example cells with icons. BUG=805214 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie43424a527950cf789ea27b38c4851fb0adf6f97 Reviewed-on: https://chromium-review.googlesource.com/1131316 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573851}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e1b2236. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21159 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/resources mcasas@chromium.org: external/wpt/mediacapture-record tdresser@chromium.org: external/wpt/navigation-timing TBR=kereliuk No-Export: true Change-Id: I554f0e464b24ff92c5147547e433a3ba3e46aa6a Reviewed-on: https://chromium-review.googlesource.com/1131689 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#573850}
-
Eugene But authored
Flaky tests shoild be disabled with FLAKY_ prefix. This way the tests still run, bug do not close the tree. TBR=eirage@chromium.org Bug: 859910 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id5de49a341a9e249b03b724773d8d7681daf37c1 Reviewed-on: https://chromium-review.googlesource.com/1131927 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#573849}
-
Min Qin authored
Change-Id: Ib0c55d8584eaf1a63fb65c98d066a92b2a33338c Reviewed-on: https://chromium-review.googlesource.com/1132081Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573848}
-
David Tseng authored
Test: manual. Bug: 857540 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I50532c92c750ceb37ace2c8ec01b2eb3d572525c Reviewed-on: https://chromium-review.googlesource.com/1130014Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#573847}
-
braveyao authored
This cl is to add a red recording dot indicator for the tab that starts the desktop capture. This is part of the required UI change for the new getDisplayMaid API. Bug: 859981 Change-Id: I9e36f6a4c61802152936282ba5f3902db1f774cd Reviewed-on: https://chromium-review.googlesource.com/1125079 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573846}
-
Jialiu Lin authored
A couple of edits on enterprise policies based on feedback we got in launch review. Bug: 845038 Change-Id: Ie5536e9ce9a197d1b562571e5f247d58049234be Reviewed-on: https://chromium-review.googlesource.com/1130506 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#573845}
-
Sam Maier authored
Bug: 843745 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ica93601caaee202f17754a653fc7e954d39b5811 Merge-With: eureka-internal/184486 Reviewed-on: https://chromium-review.googlesource.com/1126171Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#573844}
-
Esmael El-Moslimany authored
Bug: 860077 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I57f482459eaa3f77603dc74025c543ce6a8e5c4f Reviewed-on: https://chromium-review.googlesource.com/1128204Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#573843}
-
Nick Harper authored
This removal was requested via email and verified via DNS. TBR=bnc@chromium.org Change-Id: Ic6800b4b1afea22415203f772dd40f76e4373edf Reviewed-on: https://chromium-review.googlesource.com/1131841Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#573842}
-
Michael Thiessen authored
Accidentally made a local change on the wrong branch that got landed with https://chromium-review.googlesource.com/c/chromium/src/+/1127850 TBR=cjgrant@chromium.org Change-Id: I19d1a92398021abab1308c3d0d7fa8695c92ebcf Reviewed-on: https://chromium-review.googlesource.com/1131916 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#573841}
-
Hiroshige Hayashizaki authored
This CL adds WPT tests for - WorkerLocation (wpt/workers/interfaces/WorkerGlobalScope/location/), - referrer (wpt/xhr/), and - API base URL (wpt/workers/baseurl/) that should reflect worker global scope's URL, for - classic shared workers and - module classic workers. Some tests are half-migrated to fetch_tests_from_worker()-style to test shared workers easily, while the tests for module workers uses the existing non-fetch_tests_from_worker()-style tests, because testharness.js can't be used from module scripts. Bug: 861564 Change-Id: I62fa415647da47e00bf7cbf4d7648f5d64377c04 Reviewed-on: https://chromium-review.googlesource.com/1128517 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#573840}
-
Joshua Pawlicki authored
This reverts commit 0bd5cafd. Reason for revert: Speculative revert: we observe flakiness in the test after the change landed along the lines of: ../../media/base/android/media_codec_bridge_impl_unittest.cc:455: Failure Value of: media_codec Expected: isn't NULL Actual: 4-byte object <00-00 00-00> Original change's description: > Android: Query encoder for supported pixel formats > > Test H264VideoEncodeAndValidate would fail on devices that don't > support COLOR_FORMAT_YUV420_SEMIPLANAR. This make it so the test > queries the encoder, and then take the color format from the > returned set. > > R=braveyao@chromium.org > > Bug: 860559 > Change-Id: I524a7e803e9781960a99308834bac4d361e0c442 > Reviewed-on: https://chromium-review.googlesource.com/1127469 > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Commit-Queue: Weiyong Yao <braveyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573361} TBR=jrummell@chromium.org,braveyao@chromium.org,seaduboi@amazon.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 860559 Change-Id: I160c1f0caa5088d7691da8445f0c8a11bb3faf0c Reviewed-on: https://chromium-review.googlesource.com/1132054Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#573839}
-
Patrick Monette authored
Bug: 846953 Change-Id: I33e710005af02f9e6a553cfc0ef18acd3eaa2d8f Reviewed-on: https://chromium-review.googlesource.com/1128371Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#573838}
-
Robert Sesek authored
Beta 3 18A326g added new locations for CVMS files. Bug: 850021 Test: Form controls render correctly in web content. Change-Id: I00f93a847d1dbb086edea318526aab74bddb54bc Reviewed-on: https://chromium-review.googlesource.com/1130163Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#573837}
-