- 14 Aug, 2018 40 commits
-
-
Scott Haseley authored
This reverts commit fd47d8d8. Reason for revert: Collected sufficient initial crash reports. Original change's description: > [scheduler] Replace DCHECK for frozen and visible state with DumpWithoutCrashing > > Changing the DCHECK that checks for the page scheduler being frozen when > the page is visible to DumpWithoutCrashing to collect more crash dump data. > > Bug: 873214 > Change-Id: I0f10ef13b0cf790cb38189273adf1ddc03030fc2 > Reviewed-on: https://chromium-review.googlesource.com/1172709 > Commit-Queue: Scott Haseley <shaseley@google.com> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582713} TBR=altimin@chromium.org,shaseley@google.com Change-Id: If15864678725a3939f5e0e03ddd4bcb97d220dcf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873214 Reviewed-on: https://chromium-review.googlesource.com/1175011Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#582996}
-
Paul Jensen authored
These tests are slow and only relvant to tools changes so there is no point in running them all the time. These tests fail on Windows, so this change prevents them from interfereing with large-scale-refactorings done on Windows that don't affect the tools. Bug: 871754 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iccf6042665a027efb181848508128ef435cdd22b Reviewed-on: https://chromium-review.googlesource.com/1172918 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#582995}
-
Wei Guan authored
Currently all available perception results are added to the perception sample as entities. When there are no entities, we dont know if there were no entities detected, or no detections were run at all. BUG=872764 Change-Id: I18d4b0f1a0e285f030e5d6f64a4c62c0dc23ae07 Reviewed-on: https://chromium-review.googlesource.com/1169311Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Wei Guan <weigua@chromium.org> Cr-Commit-Position: refs/heads/master@{#582994}
-
Antonio Gomes authored
This CL is a trivial fixup of https://crrev.com/c/1076947; it deletes some left-over code in ContentVerifier::BindURLLoaderFactoryRequestOnUIThread: |network::mojom::URLLoaderFactoryParamsPtr params|. TBR=rdevlin.cronin@chromium.org Bug=844926 Change-Id: I493c29034ba61b59a99a4c9d2fd0ebd1a5717145 Reviewed-on: https://chromium-review.googlesource.com/1174654Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#582993}
-
Annie Sullivan authored
This is part of a larger project to measure page load times starting at user input. One blocker for this is understanding how the beforeunload dialog might affect this metric. Bug: 750639 Change-Id: I7aef267a52353a6852dd82bad6c6c74a6fb82e51 Reviewed-on: https://chromium-review.googlesource.com/1162673 Commit-Queue: Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#582992}
-
Varun Khaneja authored
PVer3 is the old specification of the protocol to download blacklist updates and query full hashes from the Safe Browsing service. PVer4 replaced this code in crbug.com/543161 Overall changes: * Replaced the use of SafeBrowsingProtocolConfig with V4ProtocolConfig. * Made TestSafeBrowsingService() the base class for a all derivatives of SafeBrowsingService in tests. * Add CanCreateDatabaseManager and CreateDatabaseManager in ServicesDelegate::ServicesCreator to allow tests to create their own DatabaseManager, if they choose to. TBR=tnagel TBR'ing tnagel since the changes in annotations.xml are trivial: just deleting lines for files being deleted. *************** Note to Sheriff *************** If this CL breaks any builds or any tests, please feel free to revert immediately. Reviewers, please review the changes in the following files: rdevlin.cronin: chrome/browser/extensions/ ntfschr: android_webview/browser/aw_safe_browsing_ui_manager.cc davidben: chrome/browser/net/trial_comparison_cert_verifier_unittest.cc, chrome/browser/prerender/prerender_test_utils.cc tnagel: tools/traffic_annotation/summary/annotations.xml qinmin: chrome/browser/download/download_browsertest.cc bbudge: chrome/test/ppapi/ppapi_filechooser_browsertest.cc Bug: 754341 Change-Id: I889dfe42848b8579e26aed0ea92c86b38fdfb87a Reviewed-on: https://chromium-review.googlesource.com/1153969 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#582991}
-
Luna Lu authored
Change-Id: Iad62e7101e9bf880e7101fb761a472f743b9f1f8 Reviewed-on: https://chromium-review.googlesource.com/1159225 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#582990}
-
Min Qin authored
DownloadDB is based on levelDB, and we need to understand the initialization failures BUG=873735 Change-Id: I0408732645cdefbb94a9ce43df3f8053a5a5a024 Reviewed-on: https://chromium-review.googlesource.com/1173070 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#582989}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/193e9338017c..fc13545ed4c9 git log 193e9338017c..fc13545ed4c9 --date=short --no-merges --format='%ad %ae %s' 2018-08-14 benjhayden@chromium.org Reland Configure gae_ts_mon in chromeperf dashboard. Created with: gclient setdep -r src/third_party/catapult@fc13545ed4c9 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iada7d9672650472169dad40849c64e0c422628bf Reviewed-on: https://chromium-review.googlesource.com/1174792Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582988}
-
Achuith Bhandarkar authored
With DCHECKs on, these tests fail on ChromeOS. Bug: 873851 Test: These are the tests. Change-Id: I0f823918462dfb66c5fa8307e7d76150d8dacd6f Reviewed-on: https://chromium-review.googlesource.com/1173506Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#582987}
-
Istiaque Ahmed authored
This CL removes the temporary definition from extensions/common and uses the correct one from third_party/blink Bug: None Change-Id: Ic4e9f049055e6a442f42f351ab4c836a249c29cf Reviewed-on: https://chromium-review.googlesource.com/1173734Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582986}
-
rbpotter authored
Changing more settings to a button that does not use the default styles in print_preview/new/button_css.html removed the font: inherit styling. Restore it. Bug: 870645 Change-Id: Ic041c065f3d0f6d249a6817b740a8acaf963d38f Reviewed-on: https://chromium-review.googlesource.com/1162079 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582985}
-
Donn Denman authored
Renames the ContextualSearchRankerLogger interface to have a more generic name, in preparation for using it in a more generic way: to record outcomes that can later be sent to the server for logging and offline processing. The ContextualSearchRankerLogger is now the ContextualSearchInteractionRecoder. BUG=872902 Change-Id: Ic21bb32227c6587ba179509b369d8e1b48fc1d8e Reviewed-on: https://chromium-review.googlesource.com/1169968 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#582984}
-
Chris Mumford authored
This test is timing out (flaky 50%) on macOS 10.10 and 10.13. TBRing rakina@ for review and sunyunjia@ (owner of bug). TBR=rakina@chromium.org,sunyunjia@chromium.org Bug: 827209 Change-Id: I2818f917ccc88d9275014ed8971edb6469638856 Reviewed-on: https://chromium-review.googlesource.com/1174901Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#582983}
-
Weidong Guo authored
Changes: Assign generic container role to SearchResultSuggestionChipView to replace default button role, so that inner SuggestionChipView can be found by ChromeVox. Bug: 872943 Change-Id: I3a09dd9a76d11f9523b807fa5291f1aade38f84e Reviewed-on: https://chromium-review.googlesource.com/1171598Reviewed-by:
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: Id545ccd53b49f2fd808c2d6ab32409de73c445d0 Reviewed-on: https://chromium-review.googlesource.com/1172127Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#582981}
-
Shimi Zhang authored
In |window.print()| code path for Android, we have the call stack like this: PrintJobWorker::GetSettingsWithUI() -> PrintingContextAndroid::AskUserForSettings() -> PrintingContext.showPrintDialog() (Java) We have set |callback_| in |PrintingContextAndroid| to be |PrintJobWorker::GetSettingsDone()|, but didn't call it in later stage unless something fails. This CL makes |PrintingControllerImpl| call |PrintingContext.showSystemDialogDone()| no matter what happens. This is because the first |GetSettingsWithUI()| for |window.print()| on Android is only to wake up |PrintManager| to start printing job. We will set the real settings in later |GetSettingsWithUI()| call. Bug: 863297 Change-Id: I3be0a3dceab134db7a47e0c1b48ccd1802e74447 Reviewed-on: https://chromium-review.googlesource.com/1162754Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#582980}
-
Pedro Amaral authored
The fixes a hole that is present in the bottom toolbar when the horizontal tab switcher is not enabled. It also makes it easier to reach the new tab button which we expect to be more used than the toggle button. Change-Id: I7fa5bc192516d956a78704c4d90e2d656abd856c Reviewed-on: https://chromium-review.googlesource.com/1170193Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582979}
-
Alex Newcomer authored
This will enable: - New context menu UI for: - Application icons - Shelf context menus - Desktop context menus Note: - Removed tests whose functionality were already being tested. - MouseContextMenu already tests whether the ink drop is being shown, so there is no need for ShelfButtonShowsInkDropHighlightOnMenuShow. Bug: 871843 Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058 Reviewed-on: https://chromium-review.googlesource.com/1170985Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#582978}
-
Jialiu Lin authored
Clear individual Gaia password hash by monitoring account removal events. If it is the removal of a primary account (a.k.a chrome signin account), remove all Gaia hashes, otherwise, just remove individual Gaia password hashes. Renamed a couple of functions in PasswordStore to make them more readable. Changes in chrome_password_protection_service.cc are merely refactoring, no behavioral change. Bug: 844134 Change-Id: Idab2d375bb24ce2cdf568372b8b5ae283ac28169 Reviewed-on: https://chromium-review.googlesource.com/1171516 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#582977}
-
Yue Cen authored
Bug: 835029 Change-Id: I16d97c659054f135456131866962d78aa68e18ac Reviewed-on: https://chromium-review.googlesource.com/1173319Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582976}
-
James West authored
Grant screen access to web application and revoke it depending on whether a web application can be shown on the screen. Only show a web application when screen access has been granted. Bug: internal b/112164384 Test: manual Change-Id: I654f3a69395c1a84e33f38a84d52ba45060d96e2 Reviewed-on: https://chromium-review.googlesource.com/1164641Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: James West <jameswest@chromium.org> Cr-Commit-Position: refs/heads/master@{#582975}
-
Dave Tapuska authored
If a fullscreen element was requested fullscreen user scrolling is largely disabled on other layers. The overscroll would get reported to java and it would attempt then to scroll the root layer. Add checks whether the inner viewport scroll node is actually user scrollable. BUG=873626 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If527ae57641df19b683027f35a8494d3c482a066 Reviewed-on: https://chromium-review.googlesource.com/1173324Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#582974}
-
Etienne Bergeron authored
This reverts commit e1b21dc7. Reason for revert: 1) No longer needed 2) Slowing down omnibox Original change's description: > Add memory metric to trace event to investigate omnibox performance > > Adding estimated memory usage to the quick history provider. > it is suspected to be slow and cause jank on UI thread when memory usage > is high. > > These metrics will be received with slow-reports and will help to > investigate some jank on UI thread. > > R=mpearson@chromium.org > > Bug: 868419 > Change-Id: I344f84ec00f318fdb9db63c5b464b119a9d5e3eb > Reviewed-on: https://chromium-review.googlesource.com/1156847 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579919} TBR=mpearson@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 868419 Change-Id: I96785874209368579844e9c55052bc53de12a5a8 Reviewed-on: https://chromium-review.googlesource.com/1174692Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582973}
-
Becca Hughes authored
Add a toggle to the sound content settings page to toggle unified autoplay. Also adds a pref to store the user's preference. BUG=865548 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8d2ac3ee3bb15d8daccef1f3a120b028b92e189a Reviewed-on: https://chromium-review.googlesource.com/1145760 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#582972}
-
Elly Fong-Jones authored
This has been off by default since M67 and is actually dead in M69. Tbr: thakis@chromium.org Bug: 832676 Change-Id: Iba63da4b6c0d12fea4356bc5173b19ae46d4c510 Reviewed-on: https://chromium-review.googlesource.com/1172791Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582971}
-
Avi Drissman authored
BUG=873080 TEST=as in bug Change-Id: Icd75715ac42789c84870967b11c9917a972ae086 Reviewed-on: https://chromium-review.googlesource.com/1173342 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582970}
-
Victor Costan authored
Some AppCache unit tests incorrectly use GURL() to get an URL with a unique origin (different from other origins in the test). The way this works may change in the future, so tests should use real origins instead. This CL also cleans up some lifecycle issues in the files touched by the change. Bug: 768460 Change-Id: Iaff5228f599209f3803c0374abcd53720e9906a9 Reviewed-on: https://chromium-review.googlesource.com/1174103Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#582969}
-
Erik Luo authored
Console Commands and Results no longer show a repeat count bubble. It was possible to get consecutive Commands using expressions starting with 'await', which collapsed when they should not. Screenshot: https://imgur.com/a/8iOkL9p Bug: 871940 Change-Id: I1dc2306d13c1511daa92fcd678520f3e8706e853 Reviewed-on: https://chromium-review.googlesource.com/1173265Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#582968}
-
Tessa Nijssen authored
If there are no suggestions, the touch bar will show an empty NSCandidateListTouchBarItem. Instead of showing that, the browser window touch bar should appear if there are no suggestions. TextSuggestionsTouchBarControllerTest.MakeTouchBar was modified to test that a text suggestions touch bar is not created if there are no suggestions. Bug: 717553 Change-Id: I2eb3286e5a96b97bb8d7737ddf6db352698804b8 Reviewed-on: https://chromium-review.googlesource.com/1173407Reviewed-by:
Sarah Chan <spqchan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#582967}
-
Sam McNally authored
BrowserPluginGuest disables navigate_on_drag_drop for all browser plugin guests. For mime handlers navigating on default drag drops is desirable. After the mime handler is attached, update the web preferences to re-enable navigate_on_drag_drop so unhandled drag drops onto mime handlers result in navigations similar to other web content. Bug: 819761 Change-Id: I5b0165be1d8c52538b189194fc9cbca9c86d96a7 Reviewed-on: https://chromium-review.googlesource.com/1173944 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#582966}
-
Robert Liao authored
Developers should include bubble_dialog_delegate_view.h instead. This is part 3 of 3 for aligning BubbleDialogDelegateView with its filename. BUG=873422 Change-Id: Ifd33203baf4d057c476026394d2833d0701e25e3 Reviewed-on: https://chromium-review.googlesource.com/1171919 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#582965}
-
Peter Beverloo authored
Change-Id: Ia20886e1d26800e084ee63ef7604c7083e3479f1 Reviewed-on: https://chromium-review.googlesource.com/1170840Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#582964}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d4322a8630bc..32c7d4dfcdca git log d4322a8630bc..32c7d4dfcdca --date=short --no-merges --format='%ad %ae %s' 2018-08-14 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 378c434627aa..80ab360d2622 (1 commits) 2018-08-14 mtklein@google.com add dstAT param to xform steps Created with: gclient setdep -r src/third_party/skia@32c7d4dfcdca The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I368e81da43b77ddaf306cd452ef1ab5ed2035a8d Reviewed-on: https://chromium-review.googlesource.com/1174791Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582963}
-
Asanka Herath authored
Bug: none Change-Id: Ie9e3a47ec63d493c34e844ad0d99b97dcb8c3a7b Reviewed-on: https://chromium-review.googlesource.com/1169830 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#582962}
-
erikchen authored
The sources for validation_test_data was being listed as a directory rather than a list of files. This is incorrect -- directories cannot be listed as sources for the copy command in GN. This in turn caused isolate.py to think that the file .../data/validation was a dependency, which then caused isolate.py to throw an error since .../data/validation is a directory, not a file. This CL explicitly lists all file dependencies. Bug: 873208 Change-Id: I02ee6b28016bf36a612cd44079080274fcbf3744 Reviewed-on: https://chromium-review.googlesource.com/1171111Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582961}
-
Ryan Daum authored
- Discards events produced by additional fingers during a cast side swipe gesture. - Rework unit tests to use GMock, and add test for the multiple fingers. Bug: internal b/112314035 Test: on device and unit tests Change-Id: I8c8c33299521e3e05ec9d196d835e0f0c5f04563 Reviewed-on: https://chromium-review.googlesource.com/1174566Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#582960}
-
Chris Lu authored
Bug: 856621 Change-Id: I8bae0dff5d006338a682becb8e4fdb331bc81f77 Reviewed-on: https://chromium-review.googlesource.com/1169627 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#582959}
-
Hajime Hoshi authored
Now a widget is created after a (sub)frame and per-frame task runner can be passed. However a widget is destroyed not before a frame, which is inconsistent. We want to make it consistent by making a widget before a frame, and in this case, per-frame task runner would no longer be available. This CL makes RenderView always use a thread-local task runner instead. This CL introduces 'cleanup' task runner for cleaning up. We aim to V8 executions on the default task runner and other thread-local task runners, but V8 execution is inevitable on the cleanup phase. Then this CL separates such tasks on the new task runner. Change-Id: I5513e005796f9589eb269c526c2e6ae2b79c8dfd Reviewed-on: https://chromium-review.googlesource.com/1164873Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#582958}
-
Michael Lippautz authored
Tests were using WeakPersistent<T> from stack directly. This does not work anymore as soon as unified garbage collections also traverse the stack to find wrappers. Bug: chromium:843903 Change-Id: I1f93d631c7a6e0798903111416507e9fabd90f16 Reviewed-on: https://chromium-review.googlesource.com/1174538 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
