- 14 Nov, 2017 40 commits
-
-
Maksim Sisov authored
This CL doesn't bring any functionality changes. It just aligns the *Fullscreen word with other code around chromium. TBR=rjkroege@chromium.org Bug: 666958 Change-Id: I8c3937a5221641750846738c93f46496c00551b8 Reviewed-on: https://chromium-review.googlesource.com/768741 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#516301}
-
Dave Tapuska authored
Ensure we mask on the current keyboard modifer state so that all modifier keys can be detected. BUG=783793 Change-Id: I0dd0cfaabc32f6a8df0cbea793bbac43dbe3dcb6 Reviewed-on: https://chromium-review.googlesource.com/766667Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#516300}
-
Sylvain Defresne authored
Convert PasswordTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iab720008b6da7df451da230628f3a5c75fb72da0 Reviewed-on: https://chromium-review.googlesource.com/766789 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#516299}
-
Stephen McGruer authored
The change these were introduced to track was over 1.5 years ago. We collected the necessary data and the deprecation workaround was removed a year ago, so its time for these counters to be removed. Bug: 601672 Change-Id: I64f0e78152068000622421111765678b6ce798d7 Reviewed-on: https://chromium-review.googlesource.com/767056Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#516298}
-
Anita Woodruff authored
This reverts commit 7860090b. Reason for revert: Likely cause of ANR / DCHECK Original change's description: > [Android O] Clean up notification settings on channel migration > > - Previously when migrating to channels, the content settings were > simply copied over to the NotificationChannelsProviderAndroid from > the PrefProvider. > > - Now they are deleted from the PrefProvider as they are copied over > to the NCPA. > > - This avoids old content settings hanging around and getting > reinstated on channel deletion. > > Bug: 781524 > Change-Id: Ic00ddd4996e8a17775678193b6ffdb0b4d62d5fa > Reviewed-on: https://chromium-review.googlesource.com/760936 > Reviewed-by: Raymes Khoury <raymes@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Commit-Queue: Anita Woodruff <awdf@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515538} TBR=raymes@chromium.org,peter@chromium.org,awdf@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 781524,784823 Change-Id: I53d19029118bbd0c907ad1317f744e3e6e0a80c3 Reviewed-on: https://chromium-review.googlesource.com/768787Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#516297}
-
Sylvain Defresne authored
Convert InfoBarManagerImpl to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Remove unused method InfoBarManagerImpl::WebStateFromInfoBar as it accessed deprecated web_state() method. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I55574e425107a3306bc0ba2085d699d4008c3f44 Reviewed-on: https://chromium-review.googlesource.com/766750 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, payment handlers for "basic-card" would always be shown in desktop payments UI, even if their "capabilities" field did not match the merchant's request. This patch sends the full PaymentMethodData array to the ServiceWorkerPaymentAppFactory, so the factory can compare the "capabilities" of payment handlers for "basic-card" to the merchant's requested PaymentMethodData. The factory compares the capabilities only for "basic-card". After this patch, a payment handler for "basic-card" shows up in desktop payments UI only if its "capabilities" field matches the merchant request. Bug: 777470 Change-Id: I9b6c9f3371f8f3e2091d56aa087c0b98f0ff3278 Reviewed-on: https://chromium-review.googlesource.com/744541Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#516295}
-
Sergey Poromov authored
BUG=b/67617383 Change-Id: I0a8308d96e84256e363ce8127da7720b04e2aea6 Reviewed-on: https://chromium-review.googlesource.com/768493Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#516294}
-
Francois Doray authored
aura::WindowOcclusionTracker notifies interested windows when their occlusion state change. This will be used to release resources and throttle execution of occluded tabs. Time to recompute occlusion on a Samsung Chromebook Pro: 100 partially occluded windows*: 108us 50 partially occluded windows*: 50us * window 0 at position (x=0;y=0), window 1 at position (x=1;y=1), window 2 at position (x=2;y=2), etc. Benchmark code: https://chromium-review.googlesource.com/c/chromium/src/+/718979 Bug: 738387 Change-Id: I65e9e3eb58461e14eda280a133f0acb23a9f1c40 Reviewed-on: https://chromium-review.googlesource.com/679206 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#516293}
-
Sylvain Defresne authored
Convert HistoryTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0b3f3b63e599ad2327df155a75549248b8db9b1b Reviewed-on: https://chromium-review.googlesource.com/766749 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Convert FindTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69071028a6f8476734d19da1eeaa92e7e9751b6d Reviewed-on: https://chromium-review.googlesource.com/766748 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/74c8436f2c34..5b65a84b990e $ git log 74c8436f2..5b65a84b9 --date=short --no-merges --format='%ad %ae %s' 2017-11-13 robertphillips Resolve GrSurface/GrSurfaceProxy ref counting issue in GrResourceAllocator Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Iaabd39e651032547bdad75f188c2cabda7139094 Reviewed-on: https://chromium-review.googlesource.com/768548Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516290}
-
Ivica Bogosavljevic authored
Bug: Change-Id: If3c10d6225fb36f9b4e1f032b55fcddbf0bae572 Reviewed-on: https://chromium-review.googlesource.com/768675Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#516289}
-
Scott Chen authored
Setup work to change the welcome page visuals based on the DICE status of the profile. The new_welcome* files are exact copies of the original in this CL and there will be follow-up CLs to iterate on them. Bug: 782155 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If620f91b4b30b70ca34ac9db5fd1f27c893bd189 Reviewed-on: https://chromium-review.googlesource.com/751461 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#516288}
-
Dan Elphick authored
Add a new DatabaseTask, GetDeveloperIdsTask which reads the developer_ids from the database. To avoid multiple database look ups or hacks like encoding the key into the data, add a new method to ServiceWorkerContextWrapper, GetRegistrationUserKeysAndDataByKeyPrefix, that returns a map of the keys and their values. Also fix method description for ReadUserDataByKeyPrefix to say it returns STATUS_OK if no records are found in an otherwise successful read since that's what the code does. Add a unit test for ReadUserDataByKeyPrefix that verifies that the above comment change is correct. Bug: 757760 Change-Id: I40baa5e1a9997cd2c7ed7b7f0094156b515127cd Reviewed-on: https://chromium-review.googlesource.com/764127 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#516287}
-
Sylvain Defresne authored
Convert FormSuggestionTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib6af771e783285a8efd6b6b640a38b76b4c7caac Reviewed-on: https://chromium-review.googlesource.com/766788 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Tatiana Gornak authored
BUG=739343 Change-Id: I5d22b76b8a321eccb82a1811ea1a906a93435ac4 Reviewed-on: https://chromium-review.googlesource.com/768730Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#516285}
-
Gauthier Ambard authored
This CL adds the Toolbar objects (coordinator/mediator/ViewController) created in ios/clean in ios/chrome/browser/ui/toolbar/clean. It will allow to modify and use them in chrome. For now those objects are not used in ios/chrome, to allow an easier review. All the content specific to ios/clean is removed, except the dispatcher protocols which are adapted to the ones used in ios/chrome. The classes are duplicated, with the one in ios/clean prefixed with "Clean". The constants and other utility files are moved. Having this code checkout in ios/chrome will allow to work on them more easily than having to import them file by file every time we need to use one. Bug: 784372 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia5eb513198b32a1d2f93603c36884c90d04cbbaf Reviewed-on: https://chromium-review.googlesource.com/766370Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#516284}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d301cfc6. With Chromium commits locally applied on WPT: 23705631 "service worker: Upstream sandboxed iframe test to WPT." Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/5245 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bajones@chromium.org: external/wpt/gamepad domenic@chromium.org, ricea@chromium.org, tyoshino@chromium.org: external/wpt/streams TBR=jsbell No-Export: true Change-Id: I5e5479f0de1868be63cd58b5acec42abbdaded4a Reviewed-on: https://chromium-review.googlesource.com/768448 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516283}
-
Ioana Pandele authored
The same logic used to sort passwords on other platforms will now be used on iOS too. This includes: - not displaying duplicates - removing all duplicates of an entry from the password store when this entry is selected for deletion. Bug: 764747 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I85070ed7563fcac482b13aa84bb126ff252a68b7 Reviewed-on: https://chromium-review.googlesource.com/766791 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4e1cd28a..9b3020fa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I3ff2cab7d45f3da4a7fdde9a5c2bfd3792d9c771 Reviewed-on: https://chromium-review.googlesource.com/768449Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#516281}
-
Yuki Shiino authored
This patch implements "call a user object's operation" steps of Web IDL from scratch discarding the existing implementation. The steps include (roughly speaking) a step to push a backup incumbent. Web IDL 3.9. User objects implementing callback interfaces https://heycam.github.io/webidl/#call-a-user-objects-operation Bug: 778580 Change-Id: Ib2929f866884095d01e46ae9f4483db2726bccd5 Reviewed-on: https://chromium-review.googlesource.com/763191 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#516280}
-
Martin Sramek authored
Bug: None Change-Id: Id977614b4ed9ac6862656a82dc9366dff3b0e049 Reviewed-on: https://chromium-review.googlesource.com/768415 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#516279}
-
Max Morin authored
These logs are still very noisy, possibly to the point where tests are failing due to the log spam. Only log every 10th glitch. Bug: None Change-Id: I5b29ce917561ab00074fb477dbc38670447101af Reviewed-on: https://chromium-review.googlesource.com/768728Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#516278}
-
Yutaka Hirano authored
Bug: 674329 Change-Id: Iac71ae590f2a94f47ae36e052b67f4ed91c4898d Reviewed-on: https://chromium-review.googlesource.com/768309 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#516277}
-
Sylvain Defresne authored
Convert FormInputAccessoryViewTabHelper to directly track registration with the observed WebState instead of relying on the deprecated code in WebStateObserver. Bug: 775684 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I74892db41e08aae6c9025d4ee7bcdd21246f3ffa Reviewed-on: https://chromium-review.googlesource.com/757336 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Andrey Kraynov authored
Use |const Node&| versions instead of deprecated ones. Explicitly check for nullptr node value if we can't be sure about it. No changes in behavior. Bug: 766448 Change-Id: Id0a625da0d7d70f1d9f97a1fc1cf17ccddf1a2ec Reviewed-on: https://chromium-review.googlesource.com/763632 Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#516275}
-
Miguel Casas-Sanchez authored
MojoVEA creates a VideoEncodeAcceleratorClient and puts it into a StrongBinding, sending the other end of the pipe to the remote mojo VideoEncodeAccelerator. This causes a race between the former and the latter going down. This CL addresses this issue by removing the StrongBinding, holding on to the internal VEAClient and moving the Binding explicitly to VideoEncodeAcceleratorClient. Bug: 781560 Change-Id: Id674b30a9403fa08de42c3036d56df28a5f43c51 Reviewed-on: https://chromium-review.googlesource.com/767349Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#516274}
-
Florent Castelli authored
The current specification uses DOMException and OverconstrainedError instead of NavigatorUserMediaError. Updates many internal errors to map to the proper error name. Bug: 721412 Change-Id: I7f3b35bb4435f139af290fd7460396ef2d375f29 Reviewed-on: https://chromium-review.googlesource.com/735324Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#516273}
-
Morten Stenshorne authored
TBR=eae@chromium.org Change-Id: I73eb0e57a0586893a9e6acd2b8afe61de7708ba5 Reviewed-on: https://chromium-review.googlesource.com/768673Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#516272}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/ff7aac5e4f5d..f4f293effbc6 $ git log ff7aac5e4..f4f293eff --date=short --no-merges --format='%ad %ae %s' 2017-11-06 bryan.bernhart Harden uniform array index parsing. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I77aafac267e1e6eb6964e28a2bf9330f582e5c72 Reviewed-on: https://chromium-review.googlesource.com/768355Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516271}
-
Marti Wong authored
Bug: 782127 Change-Id: Id683ed53061f2a34a73e5af96cb307c9b73d3069 Reviewed-on: https://chromium-review.googlesource.com/768509Reviewed-by:
-
Daniel Bratell authored
In Windows SendMessage is a macro that maps to either SendMessageA (Ascii) or SendMessageW (Unicode) so if you have a local function SendMessage it can be magically renamed. The code tried to avoid SendMessage problems by removing the macro, but in jumbo builds that made other headers in Windows fail because that code tried to use SendMessage. Instead the method is renamed SendIpcMessage for lack of better imagination. Bug: 784443 Change-Id: I75651542f0dae2a4df0f0dec1ca253de8c1def9b Reviewed-on: https://chromium-review.googlesource.com/766374Reviewed-by:
-
Ramin Halavati authored
A test is added to the trybots to check network traffic annotation's syntax, coverage, and other probable errors. Bug: 656607 Bug: 690323 Change-Id: Idf7a987fd5e75713a03421e8c7cb0b9c5caeaf55 Reviewed-on: https://chromium-review.googlesource.com/704735Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#516268}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/755a485cfb8a..445e9e3fa409 $ git log 755a485cf..445e9e3fa --date=short --no-merges --format='%ad %ae %s' 2017-11-09 perezju [devil] Remove device.GetMemoryUsageForPid() Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I66a1dcd01ab374a8de91d96f2856a5a63a6b1b1e Reviewed-on: https://chromium-review.googlesource.com/768431 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#516267}
-
Mathias Bynens authored
9fcebbe1 temporarily disabled these tests in preparation for shipping RegExp Unicode property escapes in V8. Now that Unicode property escapes have shipped, the test expectations can be updated accordingly, and the tests can be re-enabled. BUG=v8:4743 Change-Id: I6fc3add3692dd1da7da59b83704b98db415fcd8e Reviewed-on: https://chromium-review.googlesource.com/765368Reviewed-by:
-
Sylvain Defresne authored
Remove the -isPrerenderTab public property from Tab (keep it as a helper internal method as Tab is still responsible for most of the behaviour of the WebState during pre-rendering after this CL). A Tab is considered as pre-rendering if the corresponding WebState is owned by PreloadController. Currently most of the logic is still in Tab class itself, but once most of the code has been moved to tab helpers, a pre-rendering tab will only have a subset of the tab helpers, and the logic of cancelling the pre-rendering will move to PreloadController. Add a boolean to track when a pre-rendered Tab is converted to a real Tab in BrowserViewController (some of the callbacks invoked when the WebState is inserted in the WebStateList needs to know that the WebState was pre-rendering but most of the code want to be able to assert that no pre-rendering Tab is in TabModel). With this CL, TabModel does not contain any pre-rendering Tab at any point in time (this becomes a new invariant of the class). Bug: 754050 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8b5eeec8edc7911481ea28953dcc6a338ccfe87a Reviewed-on: https://chromium-review.googlesource.com/732263 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#516265}
-
Patrik Höglund authored
Found this bug when I saw files were getting uploaded (after landing chromium:767857), even when the test was succeeding. This is not WAI, it should only upload when the test fails. Turns out it's a bug in the test where we missed to delete one file. Bug: chromium:767857 Change-Id: I750173bc479bd9d084defb5e7cfbd63ef2d4c2ca Reviewed-on: https://chromium-review.googlesource.com/768667Reviewed-by:
-
Morten Stenshorne authored
Hopefully I'm not touching any flaky tests by doing this, but I need a clear overview over what's failing and not, so keeping them around was bad for coverage. TBR=atotic@chromium.org Change-Id: Ia19789bcc045ccd9731040c02a01ae76041da94e Reviewed-on: https://chromium-review.googlesource.com/768380Reviewed-by:
-
Patrik Höglund authored
The sound card has been re-installed on all win bots so this should work now. Bug: chromium:677256 Change-Id: I993f14dc8e6c4bb1ace09d1a793b1e79214209fe Reviewed-on: https://chromium-review.googlesource.com/768379Reviewed-by:
-
