- 03 Oct, 2018 40 commits
-
-
Hajime Hoshi authored
The default task runner should be avoided if possible. Bug: 870606 Change-Id: Id4a3a5cc11d7a101b9f80fc339142f43ad41e9c3 Reviewed-on: https://chromium-review.googlesource.com/c/1256473Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596165}
-
Yuta Kitamura authored
Now, (almost) nobody uses blink::WebThread in non-Blink code. This CL removes unused #include of web_thread.h in those files. Note that two files related to testing were still using WebThread indirectly. They call Platform()->MainThread()->GetTaskRunner() to obtain a task runner. These calls were replaced with scheduler:: GetSingleThreadTaskRunnerForTesting(). Bug: 826203 Change-Id: I954eb67e99f76bd992f0bcdd73498cfdccba0726 Reviewed-on: https://chromium-review.googlesource.com/c/1255747 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#596164}
-
Takashi Toyoshima authored
Now that the dynamic instantiation mode is the only mode that MidiService and MidiManager support, we can ensure that any MidiManager instance will be constructed and destructed on the same IO thread. This will allow us to remove complicated shutdown system that relies on Shutdown() and Finalize(). Now destructor should just work. Bug: 672793 Change-Id: I50cc843dd997f9de68492c13d7d845810020dcb9 Reviewed-on: https://chromium-review.googlesource.com/c/1249421 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596163}
-
Stephane Zermatten authored
This change is a quick and dirty way of making sure that scripts that expect a specific element on the page will get triggered, by checking for 20 seconds after a page load or after a script has finished. This is just enough to unblock further manual tests while we work on a proper solution. Bug: 806868 Change-Id: I218ba905a2eef586463c6335435e97cdca1657d0 Reviewed-on: https://chromium-review.googlesource.com/c/1256691Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#596162}
-
Javier Ernesto Flores Robles authored
Adds options to invert the direction of the animation and the position of the table view when presenting. Supporting presenting table views in the leading edge is required for the manual fallback UI: go/leftpresentation Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I1e8466bc90fe29fd77bb71fed1639bcbac14eb02 Reviewed-on: https://chromium-review.googlesource.com/c/1255242 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#596161}
-
Tetsui Ohkubo authored
This CL adds rounded corners and separator lines to notifications in UnifiedMessageListView. UnifiedMessageListView will replace MessageListView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=UnifiedMessageListViewTest BUG=769219 Change-Id: I9616b8d3e6505046448742e3f8936188e23e0129 Reviewed-on: https://chromium-review.googlesource.com/c/1258783 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596160}
-
Nico Weber authored
ToTAndroidOfficial is green after https://chromium-review.googlesource.com/1257202 so chances are this is fixed in the recent clang roll. Bug: 887272,889062 Change-Id: Iea7a64507cea2cc0410f851af68a5f9fc008b5ae Reviewed-on: https://chromium-review.googlesource.com/c/1258287 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596159}
-
Morten Stenshorne authored
We got borders and padding right, because we honor min-inline-size, but the space taken up by any scrollbar wasn't included there, because scrollbars are allowed to intrude into padding and border area to prevent the content box size from becoming negative (but this intrusion should be prevented for min/max size calculation, also when size containment is applied). Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iebeb3b5e358ba620d24b072543400dfe94fea5a0 Reviewed-on: https://chromium-review.googlesource.com/c/1256924Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#596158}
-
Egor Pasko authored
The tool was useful for benchmarking page loads optimized with prefetch predictor database. The code depends on the customtabs_benchmark. The latter got updated a few times without updating the caller, leading to this code being slightly rotten. We do not plan to benchmark resource prefetch predictor in the near future. Removing to reduce maintenance costs. Bug: 699080 Change-Id: Ic6d28015b0cabdf7e4b243633fd6ea967df77a1e Reviewed-on: https://chromium-review.googlesource.com/c/1256792Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596157}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8775060263d6..cfc9679f85fe git log 8775060263d6..cfc9679f85fe --date=short --no-merges --format='%ad %ae %s' 2018-10-03 hidehiko@chromium.org Remove stale cheets_release template. Created with: gclient setdep -r src/third_party/chromite@cfc9679f85fe The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8e3e8fdd2f7e5fcc3c75e34cd124950ed4c267b3 Reviewed-on: https://chromium-review.googlesource.com/c/1258420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596156}
-
Maksim Sisov authored
This CL adds a new functionality to the existing WaylandOutputManager and WaylandScreen classes. Now, it is possible to remove and change primary displays on hot plugs and removes. To test that functionality, a new test has also been added. The logic that assigns output ids has also been changed. Now, we are using numeric names that a Wayland compositor announces during Global and GlobalRemove calls. That is, each global object is assigned an unique numeric name, which can be freely used as an id. Bug: 890276, 875161 Change-Id: I775bdd40a946c9f0c5dde89eba6e36c4615e1f21 Reviewed-on: https://chromium-review.googlesource.com/c/1254146 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#596155}
-
Olivier Robin authored
Without frame messaging, messages can be receive after the frame is deleted. The current code DCHECKs because the frameID is empty in that case. Change-Id: I008803da50f166bfefe29159addaac2a69f15ec1 Reviewed-on: https://chromium-review.googlesource.com/c/1256804 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596154}
-
Tetsui Ohkubo authored
This CL implements auto collapsing / expanding of notifications in UnifiedMessageListView. UnifiedMessageListView will replace MessageListView. It's behind a flag: --enable-features=NewMessageListView Design doc: go/chrome-popup-refactoring TEST=UnifiedMessageListViewTest.CollapseOlderNotifications BUG=769219 Change-Id: Iff52b748c8a4faf9560586d049621b92baec68dc Reviewed-on: https://chromium-review.googlesource.com/c/1258668Reviewed-by:
-
Mathias Carlen authored
Before this patch, the expectation was that a precondition domain match meant a host match. The server has different rules and therefore nothing is matching. There were also precondition DCHECK failures due to empty element exists selectors. This patch changes the domain match behavior to a scheme and host match, ignoring port and trailing slash. It also filters empty elements_exist selectors. After this patch, the expectations around domain matches are again in line with the established rules on the server. Element exists matches are now guaranteed to not be empty. Note: There is still the question of an empty selector within an elements_exist. R=rouslan@chromium.org, szermatt@chromium.org Bug: 806868 Change-Id: I28b09a0b260ecefd60e21852cfdcd12150893ead Reviewed-on: https://chromium-review.googlesource.com/c/1249091 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#596152}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfd8fd1ee3a9..4b969b6f368a Created with: gclient setdep -r src-internal@4b969b6f368a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iaa56deb7d43b48cce43153ab61d00070b2d4cfc7 Reviewed-on: https://chromium-review.googlesource.com/c/1258418Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596151}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6a1afc01be80..2cbceb0be548 git log 6a1afc01be80..2cbceb0be548 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 hjd@google.com Merge "trace_processor_shell: Persist cmdline history" Created with: gclient setdep -r src/third_party/perfetto@2cbceb0be548 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I11f59aaaa7f322df7e807f01120d134dd2bb4877 Reviewed-on: https://chromium-review.googlesource.com/c/1258419Reviewed-by:
-
François Beaufort authored
https://github.com/WICG/shape-detection-api/pull/52 Change-Id: I9b61e86278c3344d74423443405c7f7dbda8c9ab Reviewed-on: https://chromium-review.googlesource.com/c/1257924Reviewed-by:
-
Alexander Dunaev authored
The session restore logic looked at the command line of the main browser process, which resulted in session loss if the browser is first launched as incognito and then another window is opened with some normal profile. This change introduces passing the command line of the new process to the session restore point so it decides whether to restore the session according to settings and command line both relevant to the profile that is to be loaded. R=sky@chromium.org Change-Id: I69de884b4d270da4d4cc358fe225255b3d4cb3b5 Reviewed-on: https://chromium-review.googlesource.com/c/1245368 Commit-Queue: Alexander Dunaev <voodoo@yandex-team.ru> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#596148}
-
Maksim Sisov authored
There is a new class called WmMoveResizeHandler in ui/platform_window/dir now. This class can be set as a property value to the PlatformWindow, which is derived from the PropertyHandler now. That is, whenever a platform, which implements a platform window supports interactive move/resize events, it can implement a WmMoveResizeHandler and call SetWmMoveResizeHandler to set the handler. DesktopWindowTreeHostPlatform creates a WindowEventFilter now, which is a pre target handler for double click and window interaction events (move,resize). It also gets a handler from the PlatformWindow and sets it to the WindowEventFilter. The handler can be null, which will mean the non-client events won't be handled. When an event comes, it is tested against possible hittest values and whether it's a left click event. If the test is positive, the last mouse pointer location is taken and DispatchHostWindowDragMovement is called. The DispatchHostWindowDragMovement call passes the hittest and the pointer location values to a set |handler_| if it exists, which has its own platform specific implementation to request a server to start move/resize interactions. For example, in case of Wayland, xdg_surface_move or xdg_surface_resize methods are used. In case of X11, _NET_WM_MOVERESIZE message atom along with the last mouse pointer location are sent, and an x11 server grabs a pointer and starts move/resizing operation on a window. The events are also marked as non-client to ensure mouse handlers are not stuck in a "mouse pressed mode" until release events are sent. Normally, when platforms starts interactive move/resize, release events are never sent by compositors, which results in the above mentioned problem. Bug: 854564 TEST: XdgVersionV5Test/WaylandWindowTest.DispatchWindowMove/0, XdgVersionV5Test/WaylandWindowTest.DispatchWindowResize/0, XdgVersionV6Test/WaylandWindowTest.DispatchWindowMove/0, XdgVersionV6Test/WaylandWindowTest.DispatchWindowResize/0. Change-Id: I30f9fc50d9ab50c4cb7c6e76a0a8723015e3c777 Reviewed-on: https://chromium-review.googlesource.com/c/1078248 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I2b5af4b25e190a564d9374c94b6f6d43be84da58 Reviewed-on: https://chromium-review.googlesource.com/c/1248245Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#596146}
-
Alexey Baskakov authored
TBR=tkent@chromium.org Bug: 891575 Change-Id: I03fc86727d16ac81bfde2a15afb5f45085f1ffa6 Reviewed-on: https://chromium-review.googlesource.com/c/1258665 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596145}
-
Maksim Sisov authored
This patch makes use of the PlatformScreen and ScreenOzone implementation. At this point, only basic functionality is added. Multi-display and other features will be added in a follow-up CL. How display fetching mechanism works: During the WaylandConnection::Initialize process, a Wayland compositor announces available global objects including a wl_output, which corresponds to one physical display. However, at this step, the WaylandScreen is not created, but the interface must be bound. Otherwise, we won't get properties of a wl_output aka physical display until something is changed on the display. That is, when a wl_output is announced, the WaylandConnection calls to a WaylandOutputManager, which creates a WaylandOutput wrapper class, and binds to the announced interface. As soon as the interface is bound, the Wayland compositor starts to send properties of the corresponding display through a wl_output_listener interface. After this, the WaylandOutput starts to receive property events, which are always stored and sent to a Delegate through a WaylandOutput::Delegate::OnOutputHandleMetrics, which WaylandOutputManager implements. The WaylandOutputManager then forwards those calls to the WaylandScreen (derived from the PlatformScreen), which it has a non-owned pointer to. Talking again about the WaylandScreen, once it is created, WaylandOutputManager has to manually tell the WaylandScreen about the existing WaylandOutputs and share their ids. The WaylandScreen starts to maintain a DisplayList based on those ids. Then, the manager calls the WaylandOutput::TriggerDelegateNotification() method, which triggers property update notifications of the existing WaylandOutputs. Once the browser is running, and the WaylandScreen exists, there is no need to manually trigger the updates. Instead, the WaylandOutputs immediately send the updates on each property change as described above. In the follow up cls, I will add more functionality and implement not implemented methods. Bug: 875161 Change-Id: I8d533149641bd5ee1970cd36c3c8601d5a81b7db Reviewed-on: https://chromium-review.googlesource.com/c/1236268 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Jinho Bang authored
This patch is initiated from this comment[1]. After this patch, the following small bugs are also fixed. - The PaymentResponse.details should always return same object. - If no details, should return empty object instead of undefined. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1226774/6/third_party/blink/renderer/modules/payments/payment_method_change_event.h#42 Bug: none Change-Id: Ib784013fbdedd42d30eb820a82d51ec4d08550f4 Reviewed-on: https://chromium-review.googlesource.com/c/1253862 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
There are some failures when validating URLLoaderClient method parameters, and one suspect is null data pipe. There are some callsites passing data pipes created with mojo::DataPipe without null checks. There are DCHECK in DataPipe constructors, but we suspect the assumption fails in the wild, so turn them to CHECK. Bug: 890468 Change-Id: I222af288ac17a439ac2cfbc4b1bd41c12cd4fb70 Reviewed-on: https://chromium-review.googlesource.com/c/1258686Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596142}
-
David Jean authored
- Stop filtering folders out of search results in mediator. - When user selects a Folder in search results, recompute and reset the stack of view controllers, so that the user is in proper place in the bookmark panel stacks for back button functionality. Video: https://drive.google.com/file/d/18-dhC7ZE4j5tounA9I6LiLNGBtTVyTJM/view?usp=sharing Bug: 886612 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7ac42afcaba937b278548f3a37b8d07b87dc4a67 Reviewed-on: https://chromium-review.googlesource.com/c/1254142 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#596141}
-
Hans Wennborg authored
../../content/browser/renderer_host/render_widget_targeter.cc:63:22: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] TracingUmaTracker& operator=(TracingUmaTracker&& tracker) = default; ^ ../../content/browser/renderer_host/render_widget_targeter.cc:73:13: note: move assignment operator of 'TracingUmaTracker' is implicitly deleted because field 'id_' is of const-qualified type 'const int' const int id_; ^ Bug: 890307 Change-Id: I233c101f236053f02ec3affb9ea2b4655ad98d49 Reviewed-on: https://chromium-review.googlesource.com/c/1256922Reviewed-by:Ken Buchanan <kenrb@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596140}
-
Hans Wennborg authored
../../extensions/browser/service_worker_task_queue.cc:77:21: note: move assignment operator of 'WaitingDidStartWorkerTask' is implicitly deleted because field 'extension_id' has no move assignment operator const ExtensionId extension_id; ^ Bug: 890307 Change-Id: Ifb5eac24bd150c9a20d170f0ef084334abfb6601 Reviewed-on: https://chromium-review.googlesource.com/c/1256807Reviewed-by:Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#596139}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ifc6a5df838d21e14090c5e3b66d89590f3516424 Reviewed-on: https://chromium-review.googlesource.com/c/1258417Reviewed-by:
-
Matt Falkenhagen authored
ServiceWorkerContainerHostPtr is cloned in several places, not just for worker fetch contexts now. Bug: 715640 Change-Id: I8670b4fea9e215a00b9a1c5788e7ca9a2e8eaca3 Reviewed-on: https://chromium-review.googlesource.com/c/1256466Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#596137}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe82844a1a45..dfd8fd1ee3a9 Created with: gclient setdep -r src-internal@dfd8fd1ee3a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I26ab69d72bc6320c9c4ce77f3982a20ee85acd73 Reviewed-on: https://chromium-review.googlesource.com/c/1258416Reviewed-by:
-
Hiroki Nakagawa authored
Using WebLocalFrameImpl in core/ is disallowed by core/DEPS. Bug: n/a Change-Id: Ie3f28322332132040850d89e9aaaf2d7a30a4fb9 Reviewed-on: https://chromium-review.googlesource.com/c/1257467Reviewed-by:
-
Amos Lim authored
Replace NullString with EmptyString since [TreatNullAs=NullString] is deprecated. This CL has no behavior changes. Bug: 497307, 831544 Change-Id: I4ae886b3f3b1159f67b9897e2e0f4f0423477f7f Reviewed-on: https://chromium-review.googlesource.com/c/1175589Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#596134}
-
Yuichiro Hanada authored
Chrome OS provides the fallback virtual keyboard for IMEs that provide their own HTML-based virtual keyboard. It's not useful for ARC IMEs because their UI is based on Android's View. This CL disables the fallback virtual keyboard while an ARC IME is active. Bug: 845079, 890677 Test: unit_tests Change-Id: I9a799cf049c886cdc25f7ae04a97d716e38338ea Reviewed-on: https://chromium-review.googlesource.com/c/1253318 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#596133}
-
Kenichi Ishibashi authored
In production, the loader factory runs on a background thread. Change-Id: If5261b012d96b714135118a2157092cb7fa983f2 Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/1256396 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Robert Ogden authored
This infobar notifies existing DataSaver users that this new feature will impact their secure page browsing as well. This is done on the first eligible pageload after the feature is released and enabled. A simple boolean pref keeps track of this state persistently. The user does not need to interact with the infobar. Once it has been shown one time it should not be shown again and this preview can be triggered. Prior to being shown, the preview should not be triggered on otherwise eligible page loads. Users who do not have DataSaver enabled should not see the infobar. Bug: 889124 Change-Id: I6eb52f516555980a0af90505637201669451c03f Reviewed-on: https://chromium-review.googlesource.com/c/1244903 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#596131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/deb512045e6a..be8193c9313a git log deb512045e6a..be8193c9313a --date=short --no-merges --format='%ad %ae %s' 2018-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 df836ff8f17d..607f907d47b0 (2 commits) Created with: gclient setdep -r src/third_party/skia@be8193c9313a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ib5d3b17cff2cd936e95c118cc737ce95f1b1c363 Reviewed-on: https://chromium-review.googlesource.com/c/1258414Reviewed-by:
-
Tarun Bansal authored
Enable the experiment to delay low priority requests on multiplexed connections. net-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/abRbGlGlNd0 loading-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/loading-dev/s22tVFiDru0 predictability-advice: http://shortn/_WJaP3jsRbk Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I6141733ec7bfbd45c6b3c3d8ed98857104dee442 Bug: 836552 Reviewed-on: https://chromium-review.googlesource.com/c/1257677Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL makes sure DetectedBarcode, DetectedFace, and DetectedText results can be passed as a message in postMessage(). Change-Id: If8e50d359a321816222a3fabfa9bb02c4106154a Reviewed-on: https://chromium-review.googlesource.com/c/1251549Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78bda58bfcba..fe82844a1a45 Created with: gclient setdep -r src-internal@fe82844a1a45 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia83cfed80a0f7c1d41f39542c0b1db3c1dd3b656 Reviewed-on: https://chromium-review.googlesource.com/c/1258415Reviewed-by:
-
Hwanseung Lee authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I361dbb5b1bf477623a772f1b0e6d074283bf6c5d Reviewed-on: https://chromium-review.googlesource.com/c/1258642Reviewed-by:
-
