GitLab

Revert of Build browser tests on all gpu release bots (patchset #1 id:1 of https://codereview.chromium.org/2841833003/ )

Reason for revert:
I don't think this CL is still needed after my fix for crbug.com/714976.

Original issue's description:
> Build browser tests on all gpu release bots
>
> Work-around as browser_tests are erroneously not rebuilt properly on
> gpu bots.
>
> BUG=chromium:714976
> TBR=kbr@chromium.org,fjhenigman@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2841833003
> Cr-Commit-Position: refs/heads/master@{#467292}
> Committed: https://chromium.googlesource.com/chromium/src/+/1d0ceecfb8153cce088d62bf28d9c94c6601de91

TBR=fjhenigman@chromium.org,kbr@chromium.org,hablich@chromium.org,phajdan.jr@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:714976

Review-Url: https://codereview.chromium.org/2846883004
Cr-Commit-Position: refs/heads/master@{#467921}

Peek() always takes a reference to an existing slot in a table. Therefore,
Peek() does not take a nullptr_t value, since nullptr_t is not stored in
the backing buffer.

BUG=715430
R=tzik@chromium.org

Review-Url: https://codereview.chromium.org/2844583004
Cr-Commit-Position: refs/heads/master@{#467920}

Intent to remove: https://groups.google.com/a/chromium.org/d/msg/Blink-dev/ZD3NWqkk-bo/1txGi7hiBgAJ
Spec: https://w3c.github.io/webcrypto/Overview.html#crypto-interface

BUG=641526

Review-Url: https://codereview.chromium.org/2838603002
Cr-Commit-Position: refs/heads/master@{#467919}

BUG=687375

Review-Url: https://codereview.chromium.org/2844103002
Cr-Commit-Position: refs/heads/master@{#467918}

There were circular deps between file_manager_commands and file_manager.
This change removes dependency from file_manager_commands to
file_manager by extracting an interface from FileManager needed for
file_manager_commands to compile.
Also inlined some simple methods in FileManager, which are used
only from file_manager_commands.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2846163002
Cr-Commit-Position: refs/heads/master@{#467917}

BUG=703848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811643002
Cr-Commit-Position: refs/heads/master@{#467916}

CMAA will be triggered by every readPixels call, even content does not be  changed or committed.

BUG=535198

TEST=conformance/readinging/fbo-remains-unchanged-after-read-pixels.html

Review-Url: https://codereview.chromium.org/2597933002
Cr-Commit-Position: refs/heads/master@{#467915}

This code was used in our old BLE protocol, which is now obsolete.

Review-Url: https://codereview.chromium.org/2843443003
Cr-Commit-Position: refs/heads/master@{#467914}

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2852573002
Cr-Commit-Position: refs/heads/master@{#467913}

- Removed dependency from file_transfor_controller to CommandHandler by
registering the needed function from FileManager to
FileTransferController as a constructor parameter.
- Added drop_effect_and_label to compile target.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2830223003
Cr-Commit-Position: refs/heads/master@{#467912}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9c9ac13a2b02..778079b344c8

$ git log 9c9ac13a2..778079b34 --date=short --no-merges --format='%ad %ae %s'
2017-04-27 cywang [shared_page_state] Fix unit test

Created with:
  roll-dep src/third_party/catapult
BUG=714803


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ic1b8f579e35bc46cd6673b97b780404f11552abc
Reviewed-on: https://chromium-review.googlesource.com/489669
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#467911}

Using UpdateUIState() is insufficient because it does not have the
mechanism to change 'add button disabled' state back to 'not disabled'. We
should explicitly call UpdateAddButtonStatus().

BUG=411618

Review-Url: https://codereview.chromium.org/2850723002
Cr-Commit-Position: refs/heads/master@{#467910}

This is a follow up from https://codereview.chromium.org/2807073002

This patch removed a generated instance of a PassRefPtr object being
copied into a RefPtr object.

All instances of PassRefPtr objects being copied into RefPtr objects
need to be wrapped in std::move to avoid introducing ref churn in
future changes when all PassRefPtr objects will be replaced with RefPtr
objects. In this case creating a local RefPtr just to copy the
PassRefPtr argument into, a std::move wrap doesn't make sense as it
would result in a final state where a RefPtr argument is moved into a
local RefPtr for no reason. So to handle this cases I have converted
the PassRefPtr argument to RefPtr in advance, and removed the local
RefPtr argument, instead using the passed RefPtr in the
method.

This patch
- Changed the argument passed from PassRefPtr to RefPtr
- Removed the logic for creating a local RefPtr argument
- Changed the naming logic to name RefPtr arguments as rpParamTypeName
- Removed the self.value variable and used self.name instead, as
  self.value was only used to store the name of the local RefPtr
  variable separate from the PassRefPtr argument
- Removed the comment in the header about PassRefPtr parameters
- Removed the base_name variable in build_param_name as this was
  causing a presubmit error from clashing with the global base_name

Changes to generated files:
https://gist.github.com/BugsNash/595ec7b86ce850d676aa8722f68abbf8/revisions

BUG=494719

Review-Url: https://codereview.chromium.org/2846723003
Cr-Commit-Position: refs/heads/master@{#467909}

This is split from https://codereview.chromium.org/2840523002/

This CL introduces "pending tasks struct" concept defined in the Worklet spec:
https://drafts.css-houdini.org/worklets/#pending-tasks-struct

The pending tasks struct is used as a kind of barrier closure: when
Worklet::addModule() is called, multiple WorkletGlobalScopes associated with the
Worklet may start module loading. The struct waits until they all are completed
and then resolves a promise. If one of them is failed, the struct immediately
rejects a promise and ignores following completions.

This CL also removes WorkletObjectProxy and the request id mechanism in
MainThreadWorklet using the pending tasks struct.

BUG=627945

Review-Url: https://codereview.chromium.org/2839123003
Cr-Commit-Position: refs/heads/master@{#467908}

To align with the spec, and also this is needed for inline module
scripts because NotifyNewSingleModuleFinished() is not called for
inline scripts.

This CL also makes DummyModulator to ignore RegisterModuleScript()
calls where it is not tested explcitly, because this CL makes
an additional RegisterModuleScript() call for CreateForTest() which is
not coupled with NotifyNewSingleModuleFinished().

This CL doesn't change the non-test behavior, because in the non-test
code ModuleScript::Create() is always coupled with
NotifyNewSingleModuleFinished() and thus this CL just makes
RegisterModuleScript() a little earlier.

BUG=594639, 715369

Review-Url: https://codereview.chromium.org/2850673002
Cr-Commit-Position: refs/heads/master@{#467907}

They are not used by anyone.

BUG=None

Review-Url: https://codereview.chromium.org/2846793002
Cr-Commit-Position: refs/heads/master@{#467906}

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/.

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements).

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase,
and now classes that were taking a dependency on WebViewImpl instead now take a
dependency on WebViewBase. This breaks the dependency chain and allows us to
start moving these classes out of Source/web into new homes in modules or core.
Note: WebViewBase is defined in core/exported/WebViewBase.h as is implements
public/web/WebView.h. Once this refactoring is complete WebViewBase will be
removed and these changes effectively reverted.

This CL moves the first portion of classes to use WebViewBase rather than
WebViewImpl, a followup CL will complete this move.

BUG=712963

Review-Url: https://codereview.chromium.org/2848513002
Cr-Commit-Position: refs/heads/master@{#467905}

Review-Url: https://codereview.chromium.org/2844253002
Cr-Commit-Position: refs/heads/master@{#467904}

The "Open" button was calling SendBannerAccepted, which made the
assumption that the app was being installed. Removed this call and
documented the method's semantics.

BUG=716313

Review-Url: https://codereview.chromium.org/2848703005
Cr-Commit-Position: refs/heads/master@{#467903}

Updates of message, proxy and agent are needed to forward capturer id to the
network process and eventually to the client.

BUG=chromium:679523, chromium:650926

Review-Url: https://codereview.chromium.org/2848753002
Cr-Commit-Position: refs/heads/master@{#467902}

The client_certs aren't actually part of the certificate request, rather the client_certs member was used to store the list of matching certificates on the client side and pass them through to the certificate selector.
Pass the list of certs through the relevant callbacks instead.

BUG=166642,394131

Review-Url: https://codereview.chromium.org/2838243002
Cr-Commit-Position: refs/heads/master@{#467901}

* Fixes an issue from crrev.com/467567, where it was possible to resize the
  sidebar without any limits on minimum or maximum width.
* Fixes an issue from crrev.com/467582, where text was colored white
  incorrectly in the bookmark add dialog.

BUG=692844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2850673003
Cr-Commit-Position: refs/heads/master@{#467900}

Per https://crbug.com/336424#c31 DeviceLightEvent is no longer on track
for standardization. This CL removes its implementation.

BUG=711577

Review-Url: https://codereview.chromium.org/2845763002
Cr-Commit-Position: refs/heads/master@{#467899}

Currently, tether settings appear as part of their own subpage. In the future, these settings will be merged with cellular networks under the "Mobile" subpage.

BUG=672263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2838323002
Cr-Commit-Position: refs/heads/master@{#467898}

If a download ends with CONTENT_LENGTH_MISMATCH error, chrome treat it as completed.
However, this could happen if server closes the connection too early.
And it causes the downloaded file size to be incorrect.
And with pause/resume functionalities, this could happen more frequently.
This change treats these download as interrupted if strong validators are present.
For downloads without strong validators, auto resumption could cause them to enter a restart->interrupt->restart cycle.
As a result, download is treated as completed if there are no strong validators.

BUG=453357

Review-Url: https://codereview.chromium.org/2832223004
Cr-Commit-Position: refs/heads/master@{#467897}

Currently NetworkHandler::NavigationPreloadCompleted() is using TimeTicks::Now()
to call LoadingFinished() of DevTools's Network event. But for normal requests
from the renderer, FrameFetchContext::DispatchDidFinishLoading() is using the
|finish_time| which is originated from ResourceRequestCompletionStatus's
completion_time.

NetworkHandler::NavigationPreloadCompleted() should use the same timing
information.

I found this difference while investigating the issue 712809. |completion_time|
is set when the request finished but, NavigationPreloadCompleted() isn't called
before the service worker finishes starting up.

BUG=712809

Review-Url: https://codereview.chromium.org/2844133005
Cr-Commit-Position: refs/heads/master@{#467896}

Resizing the content area no longer shows the scrollbars, so we don't need a
separate fade delay anymore.

BUG=606395
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2838053002
Cr-Commit-Position: refs/heads/master@{#467895}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/71c1795a..47389137

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2846173002
Cr-Commit-Position: refs/heads/master@{#467894}

Add sleep to SetWindowBounds to give chrome ui enough time to respond to devtools command.

BUG=chromedriver:1779

Review-Url: https://codereview.chromium.org/2836023003
Cr-Commit-Position: refs/heads/master@{#467893}

As a result, removing locks and synchronizations.
Also changing the way we store and report the OOM protected state.
We now update the OOM protected state every time it changes as long as we
are bound (that happens only on the launcher thread).
When retrieving that OOM protected state (which happens on the IO
thread), we return that state directly without the need of a lock.

BUG=714657

Review-Url: https://codereview.chromium.org/2840303002
Cr-Commit-Position: refs/heads/master@{#467892}

This is preparation for https://codereview.chromium.org/2850673002
to create a place to insert RegisterModuleScript() both for
Create() and CreateForTest().

This doesn't change the behavior.

BUG=594639, 715369

Review-Url: https://codereview.chromium.org/2844413003
Cr-Commit-Position: refs/heads/master@{#467891}

Editor used to update layout after applying commands for setting
frame selection. Now that setting frame selection no longer requires
clean layout, this patch removes these layout update calls.

BUG=590369
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2729313002
Cr-Commit-Position: refs/heads/master@{#467890}

Some ozone platforms (e.g. drm) expects to be able to watch a file
descriptor, so use a TYPE_IO message-loop for the gpu process host
thread.

BUG=715957
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2852553003
Cr-Commit-Position: refs/heads/master@{#467889}

R=rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2844923002
Cr-Commit-Position: refs/heads/master@{#467888}

This patch prunes a call site of the deprecated function to improve code
health.

BUG=698633
TEST=n/a; no behavioral change

Review-Url: https://codereview.chromium.org/2849573002
Cr-Commit-Position: refs/heads/master@{#467887}

Revert of Roll ANGLE f584177..e8b3551 (patchset #1 id:1 of https://codereview.chromium.org/2849583003/ )

Reason for revert:

Findit(https://goo.gl/kROfz5) identified CL at revision 467881 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZhMGE3ZTY2ZGQxNTgzYWI3MTQzNmYyNmVlMzYyMjc4NDM3ZTE5NzIM

Original issue's description:
> Roll ANGLE f584177..e8b3551
>
> https://chromium.googlesource.com/angle/angle.git/+log/f584177..e8b3551
>
> BUG=715875,705865
> TBR=jmadill@chromium.org, geofflang@chromium.org
>
> TEST=bots
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2849583003
> Cr-Commit-Position: refs/heads/master@{#467881}
> Committed: https://chromium.googlesource.com/chromium/src/+/fa0a7e66dd1583ab71436f26ee362278437e1972

TBR=jmadill@chromium.org,geofflang@chromium.org,ynovikov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=715875,705865

Review-Url: https://codereview.chromium.org/2846763004
Cr-Commit-Position: refs/heads/master@{#467886}

This patch makes EBoxDecoration break an enum class for better type
safety.

BUG=684966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2845893002
Cr-Commit-Position: refs/heads/master@{#467885}

This change helps us avoid duplication in the MarkerType-specific list
implementations I'm going to add. Instead of having one
DocumentMarkerListEditor::AddMarker() method that works for
GenericDocumentMarkerListImpl, but then requires each of the other list
implementations to implement the method separately, we'll have one method,
AddAndMergeOverlapping(), that works for Spelling/Grammar markers (and can be
moved into SpellCheckMarkerList once we eliminate
GenericDocumentMarkerListImpl), and another method
AddWithoutMergingOverlapping(), that can be used for the other marker types.
GenericDocumentMarkerListImpl will choose which to use based on the type of the
inserted marker.

Right now both of these methods create a RenderedDocumentMarker from the
passed-in DocumentMarker. I will move this piece out of the method once not all
marker list implementations are still creating RenderedDocumentMarkers.

BUG=707867

Review-Url: https://codereview.chromium.org/2842263002
Cr-Commit-Position: refs/heads/master@{#467884}

VideoResourceUpdater uses weak pointers within the class only.
Hence, it does not have to inherit SupportsWeakPtr.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2838713004
Cr-Commit-Position: refs/heads/master@{#467883}

Before this CL, when instantiation was reattempt for previously errored module,
ModuleTreeLinker::Instantiate() crashed.

This CL updates the code to follow whatwg/html update:
https://github.com/whatwg/html/pull/2559
so that we rethrow previous error when instantiation is reattempt.
TEST=webkit_unit_test --gtest_filter=ModuleTreeLinkerTest.FetchTreePreviousInstantiationFailure
BUG=594639,714521

Review-Url: https://codereview.chromium.org/2839563002
Cr-Commit-Position: refs/heads/master@{#467882}