- 21 Aug, 2019 40 commits
-
-
Hiroki Nakagawa authored
For shared workers, this CL makes ApplicationCacheHost use BrowserInterfaceBrokerProxy bound with SharedWorkerGlobalScope (SharedWorkerHost) instead of legacy InterfaceProvider bound with blink::Platform::Current(). Along with that, this CL moves ApplicationCacheHostForWorker instance from WebSharedWorkerImpl on the main thread to SharedWorkerGlobalScope on the worker thread. This change removes thread-hops after shared worker script fetch (see SharedWorkerReportingProxy::DidFetchScript()). Note: This is a preparation for AppCache support with PlzDedicatedWorker. Each (nested) DedicatedWorkerGlobalScope on the worker thread will have its own ApplicationCacheHost like shared workers. Note: Currently, frames and shared workers have different code paths to create AppCache host/backend (see TODO comment in ApplicationCacheHost::BindBackend()). These will be integrated by a follow-up CL: https://chromium-review.googlesource.com/c/chromium/src/+/1758038 Change-Id: I331d13bc64051ffe883fe51e2dfa5b4597a3c947 Bug: 718652, 945673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746128 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688934}
-
Jan Wilken Dörrie authored
This change adds time metrics for the leak detection feature. Bug: 986298 Change-Id: Ida4bdd50adfa5d9b3fda910f70a26375b5031525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760921 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#688933}
-
Ioana Stefan authored
The refactoring of TaskInfo has been realized in a previous commit. This change had the following bug: the setting of task extras was moved to multiple places through the code and one setting was mistakenly forgotten, namely the setting of the task extras for periodic tasks with GcmNetworkManager. This CL relands the first changes and fixes the problem. A test is added to check this problem. Bug: 995264 Reland "[BackgroundTaskScheduler] TaskInfo refactoring" This is a reland of 8fb37f86 Original change's description: > [BackgroundTaskScheduler] TaskInfo refactoring > > The BackgroundTaskScheduler does not offer at the moment the possibility of scheduling a task at an exact moment. In preparation for this feature, the existing code is going to be updated first. > > This CL refactors the way in which specific task information is kept. A more object-oriented approach is implemented, based on the discussion in this Design doc: https://docs.google.com/document/d/1o9BS5qwv10QVN3Df6W2m4QKjSo1DXdGIgLf8p2l0PYc/edit?usp=sharing. Changes have been made only in the way timing info for a task is kept and not in the way pre-requisites information is kept. Updates have also been added to the test files. > > This change does not affect the interface exposed by the TaskInfo class. > > TBR=rouslan@chromium.org > > Bug: 970160 > Change-Id: I2985ca68da4e6db18f47e0fd1769db3138850cb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707365 > Commit-Queue: Richard Knoll <knollr@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687603} Bug: 970160 Change-Id: I5a2cd49dabc5d399600b7f7ba855ddb19f5118e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760744 Commit-Queue: Ioana Stefan <ioanastefan@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#688932}
-
Thomas Tangl authored
Bug: 966388 Change-Id: I193f190a9f4d6f17afa172f29a079a2d893d4015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762507Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#688931}
-
Omer Katz authored
- Switch Member<> internals to using std::atomic<T*> instead of T* for writing (via mutator) and reading (via marking visitors). Reading via mutator remain non-atomic. - This is required for supporting concurrent marking while mutator is running. - All accesses are relaxed and do not introduce fences. For correctness see https://bit.ly/oilpan-concurrent-marking - Drive-by: Use WeakMember<T>* instead of T** for weakness processing to enforce atomic access. Bug: 986235 Change-Id: I456df63dffca6a2645c11b5827bb34a5022004a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749088 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#688930}
-
Yoshisato Yanagisawa authored
Compilers used for Simple Chrome is different from Chromium, we should enable ATS. Bug: 981433 Change-Id: I81aca2b28cf41c91888488eae8fee9284826f254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763508 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688929}
-
Yoshisato Yanagisawa authored
In commit 0e67738e, I made wrong builders to be triggered. Let me fix to trigger RBE one. Bug: 981433 Change-Id: I2f7ed9109a943c7caf9b9244934930ff8d2d4e12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763509 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688928}
-
Henrik Boström authored
This was reported as flaky. I am unable to reproduce, which could mean that the issue is fixed, or it could mean that it only flakes on certain setups (OS, builds, hardware, etc). To aid investigation I am speculatively re-enabling it; worst case it gets disabled again. Bug: 993020 Change-Id: I375aeefeffaa9498d962539063a7f9a003a4dad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761285Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688927}
-
Hans Wennborg authored
It warns about implicit fallthroughs in switch cases. Before Clang r369414 the warning only applied to C++ code, but now it also fires in C code. Chromium has a few instances where it warns, so disable the warning until those have been cleaned up. TBR=thakis Bug: 995993 Change-Id: I436a4650088744322e6451cdf661a264efb7b283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757928Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#688926}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bc62722b80a6..0cbdc7a2c35b git log bc62722b80a6..0cbdc7a2c35b --date=short --no-merges --format='%ad %ae %s' 2019-08-20 dneto@google.com Remove unimplemented method declaration (#2804) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0cbdc7a2c35b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: I753aee46d9805c42af159b500b3b2eca64478d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688925}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6d653c02dd24..ed4906f89d3d git log 6d653c02dd24..ed4906f89d3d --date=short --no-merges --format='%ad %ae %s' 2019-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 95609e6d923a..34cccdc65d79 (2 commits) 2019-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src bc62722b80a6..0cbdc7a2c35b (1 commits) Created with: gclient setdep -r src/third_party/angle@ed4906f89d3d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: chromium:None,chromium:None Change-Id: If12fd6a166911bdd824c7bcf28549f76822e8945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688924}
-
Christopher Lam authored
Bug: 976578 Change-Id: Iad31642a92fd872bfc7681761270dfdd901d67c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763349 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#688923}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread. This CL enables the following to pass when ServiceWorkerOnUI is enabled: - SameSiteDataRemoverBrowserTest.TestClearDataWithStorageRemoval - SameSiteDataRemoverBrowserTest.TestClearDataWithoutStorageRemoval Bug: 824858 Change-Id: Iaace639ff7425d4c933d18c5662cd67024790fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763351Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688922}
-
Yoshisato Yanagisawa authored
In the recipe, we configured to make the builders use chromium.fyi master instead of chromium.goma master. That caused build failures on builders. Bug: 981433 Change-Id: I5cdedb13191104d151e9e83dc1b2839a91d00837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763278 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#688921}
-
Anastasiia Nikolaienko authored
In WebDialogView override ShouldShowCloseButton to return delegate-> ShouldShowCloseButton (which, as before, returns true by default). This allows to hide close button in dialogs which override WebDialogDelegate. Bug: 991022 Change-Id: I0aa8ec7104a9e29eb96625f4ec15228b6df9338f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749009Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#688920}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dbd569afc423..9f22c42088e3 Created with: gclient setdep -r src-internal@9f22c42088e3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ied6bb65e58c8d1b7940f808be16095bd23df9c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763371Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688919}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5817e13649be..378a17b20f14 git log 5817e13649be..378a17b20f14 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 dberris@chromium.org PinpointScheduler: Handle errors in task_updates Created with: gclient setdep -r src/third_party/catapult@378a17b20f14 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:988912 Change-Id: Id72519457aa96153a055231bbcf151c2bdb3ae3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763370Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688918}
-
Hans Wennborg authored
Starting with a one-liner for finding what files differ between two dirs. Bug: none Change-Id: Ibb85f066ab1da79b70795691b6213f3d91fd9a58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761604 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#688917}
-
Canon Mukai authored
Change error message "Illegal constructor" to "Cannot create writer when a WritableStream is locked" in getWriter(). Bug: 803008 Change-Id: Ie5393abf280075f3df9ad6a6dfd7135c0024fa7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762258Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#688916}
-
Matt Falkenhagen authored
The thread ServiceWorkerContextCore lives on (the "core thread") will move from the IO thread to the UI thread. This CL enables ClearSiteDataHandlerBrowserTest.StorageServiceWorkersIntegrationTest to pass when ServiceWorkerOnUI is enabled. Bug: 824858 Change-Id: Icde4c1b6dea04e66a4fe282c80ea74cf824e53e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763275Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688915}
-
Kent Tamura authored
Resource access should be delegated to embedder via blink::Platform and content::ContentClient. This policy inherits from content [1]. [1] https://cs.chromium.org/chromium/src/content/DEPS?type=cs&q=ui/base/resource+file:content/DEPS&sq=package:chromium Change-Id: I2238340e3fcfaac08b63d575cf9f9cf4cefa74a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757412 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#688914}
-
Yoshisato Yanagisawa authored
In commit 903f667f9a6ac53dd8654ae3efcf9670e6e2c477, the builder name to trigger was wrong, and expected builders was not triggered. Bug: 981433 Change-Id: Ia4141f4e54e699ef2e8b00a913286231a862e566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763350Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#688913}
-
David Jean authored
Remove unneeded variable from metrics_mediator.mm, and add expiration date to histograms.xml. Bug: 988395 Change-Id: I5aa06802b6c48c9be8b6cc9f92dd6e2fa4b4c1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746005 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688912}
-
Javier Ernesto Flores Robles authored
Bug: 974255 Change-Id: I71fa0de20bb5ca69eb5e122d6bb898cc6a69c56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762216 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#688911}
-
Alan Cutter authored
When a PWA sync updates the name of an app it would also mark it as locally installed even if it wasn't originally. This CL fixes that bug. Bug: 901226 Change-Id: If8ac2d4c36673436b133f94e36f5ca5338846ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761868 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#688910}
-
Nicholas Verne authored
The completion callback is now posted as a task. Bug: 995188 Change-Id: Icf81d4884d23388d967e78509deb2c293538a22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763274 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688909}
-
Alexey Baskakov authored
AppSet is a utility object which carries iterators (references) to the underlying WebAppRegistry. AppSet is like a shallow copy of the registry, which enables users to use handy API: for (WebApp& web_app : registrar->AllApps()) { } AppSet doesn't support registration and unregistration of WebApp while iterating (DCHECKed). AppSet hides the std::map: a map with std::pair key-value pairs is an implementation detail of WebAppRegistrar. Implementation note: The range-for C++11 syntax produces code equivalent to the following: (__range, __begin and __end are for exposition only): { auto && __range = range_expression ; for (auto __begin = begin_expr, __end = end_expr; __begin != __end; ++__begin) { range_declaration = *__begin; loop_statement } } i.e. { auto && all_apps = registrar->AllApps() ; for (auto __begin = all_apps.begin(), __end = all_apps.end(); __begin != __end; ++__begin) { WebApp& web_app = *__begin; loop_statement } } Note: I implemented similar approach in base::ObserverList. Bug: 891172 Change-Id: I224829071c297ab3ef11fdf2ecc3a4ec8616283e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1293096 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#688908}
-
François Beaufort authored
By enabling blink binding only if kWebNfc feature is enabled, this will make sure the WebNFC API is not exposed to web developers when embedder does not implement NFC interface. Bug: 520391, 993327 Change-Id: I25c1ad4983b56e911d4e115423148588c2a64b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753822Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#688907}
-
Jeremie Boulic authored
util.bytesToString has no tests. Add tests of the current code implementation of util.bytesToString before further formatting modifications of the function (see bug). Test: browser_tests --gtest_filter="FileManagerJsTest.UtilTest" Bug: 977068 Change-Id: I55435916cd6e1b9fa3cfd7534e6eeabe95e3463d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761966Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#688906}
-
Sam Sebree authored
This is the final change required for JSON Modules to be utilized by developers. Following the acceptance of this change, if you run chromium with the JSONModules runtime flag, the following is now valid syntax: <script type="module"> import data from "./example.json"; </script> This change introduces several things: -It introduces the ability for ModuleScriptLoader to load JSON Modules -It introduces the ability for ModuleScriptFetcher to retrieve JSON resources -It introduces a new field to ModuleScriptCreationParams: response_mime_type_ -It introduces the JSONModules runtime flag to chromium This change corresponds with the following V8 change: https://chromium-review.googlesource.com/c/v8/v8/+/1761583 Bug: 967018 Change-Id: Ibcdb61659fb07047ffeead2ff4a55c450c183e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731108Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688905}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d44c9d246c56..f99b7960f433 git log d44c9d246c56..f99b7960f433 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6aca71d7d705..6d653c02dd24 (4 commits) 2019-08-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8cd21345..85a90848 (458 commits) Created with: gclient setdep -r src/third_party/skia@f99b7960f433 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:None,chromium:None Change-Id: I1f55bd73b05e931931a461d1990bb7723b9e41ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763093Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688904}
-
Hiroshige Hayashizaki authored
Bug: 990561 Change-Id: I64effe35d01e333daa0540a0ca60a72e00a9b5d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761891 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#688903}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3aac2d44b20d..34cccdc65d79 git log 3aac2d44b20d..34cccdc65d79 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 johnkslang@users.noreply.github.com Merge pull request #1872 from kainino0x/js-interface Created with: gclient setdep -r src/third_party/glslang/src@34cccdc65d79 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: I75118d198c0dcb15dc9484b7115f620ecae42705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763387Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688902}
-
Maksim Sisov authored
We must make sure that accessing surfaces map from different threads is safe. Otherwise, this is subject to races and unexpected crashes. Bug: 987950 Change-Id: I2e70e9c1ad48943be518c3571b7ca1fb91f8d51b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718406 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#688901}
-
Christopher Lam authored
This CL enables external app manifests to provide a "uninstall_and_replace" property which will migrate OS attributes (e.g app list position, shelf pin status) for an external app when it is freshly installed and uninstall the old app. Bug: 976578 Change-Id: Ie2de2b2a0c48d66448f596824e05b00ecfd5bf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735369Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#688900}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aaaf667b50b8..dbd569afc423 Created with: gclient setdep -r src-internal@dbd569afc423 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I93ada10e0a7d530b1e89beefd6c79dd12e6dd689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763215Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688899}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/775b1625ffb9..538193cb0f15 git log 775b1625ffb9..538193cb0f15 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@538193cb0f15 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic90482ab8fbd93b82924026fb30ac55a16cb802f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763221Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688898}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/396527c92105..6d653c02dd24 git log 396527c92105..6d653c02dd24 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 hckim.kim@samsung.com Vulkan: Set empty buffer to xfb descriptor set as an initial buffer Created with: gclient setdep -r src/third_party/angle@6d653c02dd24 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: Id42a48066984b2047b5083d635c458e1c8914443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762843Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688897}
-
Yoshisato Yanagisawa authored
In commit 0e67738e, I forgot to add builders in luci-scheduler. Let me fix that to make them triggered by CI. Bug: 981433 Change-Id: I17f3e0d433ec9c8395c14a3d4fef2bf7178c0dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762259Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#688896}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9415900f07c1..5817e13649be git log 9415900f07c1..5817e13649be --date=short --no-merges --format='%ad %ae %s' 2019-08-21 dberris@chromium.org PinpointScheduler: Use task_slices instead of properties Created with: gclient setdep -r src/third_party/catapult@5817e13649be The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:988912 Change-Id: I5fdf5e5634210c9b131fd2c1d96549a41cf61180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763218Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688895}
-