GitLab

PrefService's dtor is responsible to call CommitPendingWrite() so there is no need to call it here.

BUG=470501

Review URL: https://codereview.chromium.org/1036593005

Cr-Commit-Position: refs/heads/master@{#322535}

Revert of Update V8 to version 4.3.58. (patchset #1 id:1 of https://codereview.chromium.org/1037143002/)

Reason for revert:
multiple crashes in devtools tests

Original issue's description:
> Update V8 to version 4.3.58.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/e4dfe3b9..b08c7327
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
>
> Committed: https://crrev.com/4c27bf72e93e2649165e0d6a5d7e3e90efe9dc23
> Cr-Commit-Position: refs/heads/master@{#322511}

TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1040613002

Cr-Commit-Position: refs/heads/master@{#322534}

This patch reverts https://codereview.chromium.org/940373002, and adds
back in the ~2 lines and tests that are still relevant.

BUG=459154

Review URL: https://codereview.chromium.org/1032063002

Cr-Commit-Position: refs/heads/master@{#322533}

Hide "Keep this card locally" checkbox and tooltip while verifying card.
Space in the dialog is still reserved for the footer; it's just empty.

BUG=448572

Review URL: https://codereview.chromium.org/1040493003

Cr-Commit-Position: refs/heads/master@{#322532}

Grit's execution depends on the resource ID file, but this was not listed as a dependency in grit targets. This means that changing the resource ID file wouldn't re-run grit.

Review URL: https://codereview.chromium.org/1038213002

Cr-Commit-Position: refs/heads/master@{#322531}

If file browser handlers are specified in the manifest, and the permission is
missing, then they will be ignored. This CL adds a warning so users are aware
of it.

TEST=unit_tests: *FileBrowserHandlerManifestTest.InvalidFileBrowserHandlers*
BUG=470494

Review URL: https://codereview.chromium.org/1017163003

Cr-Commit-Position: refs/heads/master@{#322530}

TBR=tommi
BUG=471132

Review URL: https://codereview.chromium.org/1039103002

Cr-Commit-Position: refs/heads/master@{#322529}

In particular, make HistoryURL provider scoring
basically the same within regular mode and
prevent-inline-autocomplete mode (under the constraint
that we always need a valid default match first).
For what it's worth, the current code demotes (from
~1410) all non-URL-what-you-typed URLs (non-UWYT)
to 900 in prevent-inline-autocomplete mode.  If
there is a UWYT, though, these results will be
clustered / given a free ride to appear right
below it, scoring ~1200.  After this change, all
non-UWYT results will score the same in
prevent-inline-autocomplete and normal modes.
We instead rely on the allowed_to_be_default_match
bit to reorder results as necessary.

To implement this feature, we need knowledge of
whether the what-you-typed match is reasonable.
This change re-adds a variable
have_what_you_typed_match to HistoryURLParams.  This
variable was previously added in
https://codereview.chromium.org/347963002 for
a field trial and then later removed in
https://codereview.chromium.org/879053002

With this variable, the change is straightforward.
Don't change the scoring in prevent-inline-autocomplete
mode.  Instead, simply make sure the what-you-type
match gets added to the list in prevent-inline-mode.
We add it early on the list (using the Promote()
mechanism) so that it'll always appear in the final
set of suggestions.

Tested using about:omnibox

BUG=421772

Review URL: https://codereview.chromium.org/1022643002

Cr-Commit-Position: refs/heads/master@{#322528}

The initial reason for the blacklist was a bug that is now fixed.
A workaround was first developed in Chromium and then later
Nvidia actually fixed the root of the problem in their driver.
This patch removes the blacklist for 331.38 and newer drivers.

BUG=469979

Review URL: https://codereview.chromium.org/1032483002

Cr-Commit-Position: refs/heads/master@{#322527}

Fixes for iOS compile.

BUG=None

Review URL: https://codereview.chromium.org/1037573003

Cr-Commit-Position: refs/heads/master@{#322526}

Review URL: https://codereview.chromium.org/1037173003

Cr-Commit-Position: refs/heads/master@{#322525}

Review URL: https://codereview.chromium.org/1034283002

Cr-Commit-Position: refs/heads/master@{#322524}

Do not create or show the "Keep this card locally" checkbox footer
when !CanStoreLocally().

BUG=448572

Review URL: https://codereview.chromium.org/1040513002

Cr-Commit-Position: refs/heads/master@{#322523}

Error codes which CopyInForeignFile(CopyFileFromLocal) returns are defined in the definition of async_file_util.h.

BUG=413541
TEST=manually tested.

Review URL: https://codereview.chromium.org/1025553006

Cr-Commit-Position: refs/heads/master@{#322522}

This CL adds comments and DHCECKs clarifying the thread safety aspects of
VideoFrameProviderClientImpl.

BUG=336733

Review URL: https://codereview.chromium.org/1033563002

Cr-Commit-Position: refs/heads/master@{#322521}

OnPaint() is not part of the recursion, it won't have access to the
neccessary pieces to do recursion.

If you need to do painting while inside the recursion, this should
happen in PaintChildren(). So move the contents of OnPaint() to
PaintChildren().

R=pkasting
BUG=466426

Review URL: https://codereview.chromium.org/1016033011

Cr-Commit-Position: refs/heads/master@{#322520}

DocumentTabModelImpl now fires didSelectTab to its observers. This is done in
setLastShownId() instead of setIndex() for a few reasons:

* setIndex() has the side effect of bringing Tabs forward, which you may not
  want.

* setLastShownId() hopefully more faithfully tracks what Tab was last shown in
  the foreground, and is called by DocumentActivity.onResume().  This might
  still be incorrect (e.g. when opening a Tab in the background), but this is
  one of those weird cases where Android has two Activities in the foreground
  simultaneously.

* It's really difficult to actually indicate what brings a Tab back to the
  foreground.  Slap a TODO on there to actually fix it when an Observer actually
  needs to know the type.

BUG=443772

Review URL: https://codereview.chromium.org/1039513003

Cr-Commit-Position: refs/heads/master@{#322519}

R=brettw@chromium.org, jamesr@chromium.org
TBR=jamesr@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1035933002

Cr-Commit-Position: refs/heads/master@{#322518}

This patch adds the woff2 library [1] which is used to decode WOFF 2.0
web font file format. It's going to replace the old version of WOFF 2.0
decoder included in third_party/ots.

[1] https://github.com/google/woff2 (revision 445f5419)

BUG=434596
TEST=trybots

Review URL: https://codereview.chromium.org/954163002

Cr-Commit-Position: refs/heads/master@{#322517}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/fd3a91e..41f88f0

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1039493002

Cr-Commit-Position: refs/heads/master@{#322516}

BUG=none
R=noelutz@google.com

Review URL: https://codereview.chromium.org/1031963002

Cr-Commit-Position: refs/heads/master@{#322515}

Revert of Enable gpu_times for all platforms other than windows. (patchset #1 id:1 of https://codereview.chromium.org/1029423002/)

Reason for revert:

I'm seeing most perf bots failing gpu_times ever since this landed (Eg.
http://goo.gl/uLzMVe).

I missed this earlier because we had a bunch of persistent redness today caused by multiple bad V8 rolls and didn't notice this crept in as well.

Failure is just on cuteoverload.com with this error:
MarkerMismatchError: Number or order of timeline markers does not match provided labels

Original issue's description:
> Enable gpu_times for all platforms other than windows.
>
> R=nednguyen@google.com
> BUG=453131, 455292
>
> Committed: https://crrev.com/95325bb92cdce4b3c4fd93ae3509e72f89536c9c
> Cr-Commit-Position: refs/heads/master@{#322273}

TBR=nednguyen@google.com,dyen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453131, 455292

Review URL: https://codereview.chromium.org/1039083002

Cr-Commit-Position: refs/heads/master@{#322514}

TEST=Open suggest apps dialog in ar locale, the dialog button
    should be on the left
BUG=None

Review URL: https://codereview.chromium.org/1041463002

Cr-Commit-Position: refs/heads/master@{#322513}

Robolectric allows us to run tests that use Android code in the host
JVM. This means faster and more stable tests since we don't have to
deal with a device. This CL has the build file changes to build the
unit test suite, and two example tests that have been converted to
run with Robolectric.

BUG=448030

Review URL: https://codereview.chromium.org/994283006

Cr-Commit-Position: refs/heads/master@{#322512}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e4dfe3b9..b08c7327

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1037143002

Cr-Commit-Position: refs/heads/master@{#322511}

currently this flag is not used, but we'll soon flip it to off for desktop linux.

BUG=468045

Review URL: https://codereview.chromium.org/1012223002

Cr-Commit-Position: refs/heads/master@{#322510}

If someone suspends their computer and resumes more than a minute
later, the browser io thread may tick before the audio thread can
update the last tick time ==> crash :(

The solution is to disable hang detection during suspend and only
reenable it once resume completes; at which point we can update
the tick count. If we're actually hung, we'll crash after the next
interval elapses.

BUG=471046
TEST=none

Review URL: https://codereview.chromium.org/1036933003

Cr-Commit-Position: refs/heads/master@{#322509}

BUG=

Review URL: https://codereview.chromium.org/1036093002

Cr-Commit-Position: refs/heads/master@{#322508}

Add targets for epoll and chromium versions of the QUIC
client and server.

Review URL: https://codereview.chromium.org/1036023002

Cr-Commit-Position: refs/heads/master@{#322507}

This is temporary while we are adding runtime detection.

BUG=458645
TEST=4k and 1080p playback

Review URL: https://codereview.chromium.org/1016283003

Cr-Commit-Position: refs/heads/master@{#322506}

Default was recently changed to reject in:
https://codereview.chromium.org/955383003/

R=lcwu@chromium.org
BUG=internal b/19954002

Review URL: https://codereview.chromium.org/1041513002

Cr-Commit-Position: refs/heads/master@{#322505}

For extern comments, line wrapping sometimes has indentation. For instance:
/**
 * @param {FooBar} This is some foobar
 *     that has the comment wrapped.
 */
We should support this.  Add an optional parameter to the Code Comment method
to allow for comment indentation.

BUG=461039

Review URL: https://codereview.chromium.org/1010603007

Cr-Commit-Position: refs/heads/master@{#322504}

We redesigned the GpuMemoryBuffer interface to handle multiple buffers. These changes started with the purpose of making use of new EGL_LINUX_DMA_BUF_EXT capabilities[0] and followed by an attempt to change the high level API [1].

[0] https://code.google.com/p/chromium/issues/detail?id=439520
[1] https://codereview.chromium.org/962723002/

The future steps are:
- Add new GPUMemoryBuffer format gfx::GpuMemoryBuffer::YUV_420
  StrideInBytes() should take index as input
- Implement multi buffer support on GpuMemoryBufferFactoryOzoneNativeBuffer
  Change BufferToPixmapMap as std::map<std::pair<uint32_t, uint32_t>, ScopedVector<NativePixmap> > so that we can create multiple pixmaps(file descriptors) for single GpuMemoryBufferId
- Add support for multiple pixmaps in GLImageLinuxDMABuffer
- Implement support for GpuMemoryBufferImplSharedMemory
  Change GpuMemoryBufferHandle to contain std::vector<base::SharedMemoryHandle>
- Add support for GLImageSharedMemory and GLImageMemory
- Look for possible use cases of multiple buffers on Android, Mac, and Win platforms

The new functions added are as below:

class GFX_EXPORT GpuMemoryBuffer {
  // Maps each plane of the buffer into the client's address space so it can be
  // written to by the CPU. A pointer to plane K is stored at index K-1 of the
  // |data| array. This call may block, for instance if the GPU needs to finish
  // accessing the buffer or if CPU caches need to be synchronized. Returns
  // false on failure.
  virtual bool Map(void** data) = 0;

  // Fills the stride in bytes for the each plane of the buffer. The stride of
  // plane K is stored at index K-1 of the |stride| array.
  virtual void GetStride(uint32* stride) const = 0;
};

The classes effected by this change is as below(except the test implementations). Currently none of them supports multiple buffers as the format doesn't exist. They are going to be implemented per platform in future CLs.

                                +---------------+
                                |GpuMemoryBuffer|
                                +------+--------+
                                       |
                              +--------+----------+
                              |GpuMemoryBufferImpl|
                              ++----+-----+------++
                               |    |     |      |
                               |    |     |      |
+------------------------------++   |     |   +--+-------------------------+
|GpuMemoryBufferImplSharedMemory|   |     |   |GpuMemoryBufferImplIOSurface|
+-------------------------------+   |     |   +----------------------------+
                                    |     |
+-----------------------------------++  +-+-------------------------------+
|GpuMemoryBufferImplOzoneNatiVeBuffer|  |GpuMemoryBufferImplSurfaceTexture|
+------------------------------------+  +---------------------------------+
|ui::GpuMemoryBufferFactory          |
|OzoneNatiVeBuffer                   |
|          INITALIZES                |
| ui::GLImageOzoneNatiVePixmapDmaBuf |
| OR                                 |
| ui::GLImageOzoneNatiVePixmap       |
+------------------------------------+

BUG=439520
TEST= GpuMemoryBufferTest.* in gl_tests and GpuMemoryBufferImplTest.* in content_unittests.

Review URL: https://codereview.chromium.org/1024113003

Cr-Commit-Position: refs/heads/master@{#322503}

Currently, when the zoom level is set to a particular value, the
viewport's fitting type is unchanged. This can cause the zoom to be
manually set to one value, but be overridden if the viewport changes
size as it will automatically re-apply the zoom for the fitting type.
This CL fixes this by setting the fitting type to none when the zoom is
set manually.

BUG=470427

Review URL: https://codereview.chromium.org/1038573003

Cr-Commit-Position: refs/heads/master@{#322502}

The number of SCTs required for certificates with a validity period of over 14 months (but under 15) was incorrect. Fixed by not counting partial months.

BUG=470169

Review URL: https://codereview.chromium.org/1032093002

Cr-Commit-Position: refs/heads/master@{#322501}

BUG=466848

Review URL: https://codereview.chromium.org/1038143002

Cr-Commit-Position: refs/heads/master@{#322500}

Now that os and cpu_arch are no longer needed or used anywhere.

R=brettw@chromium.org, rockot@chromium.org
BUG=344767
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1017273002

Cr-Commit-Position: refs/heads/master@{#322499}

R=vmiura@chromium.org
BUG=471049, 467202

Review URL: https://codereview.chromium.org/1033093002

Cr-Commit-Position: refs/heads/master@{#322498}

Increase the maximum allowed remaining lifetime for the
receiver's self-signed cert to 4 days.

This is being increased from 2 days because errors are
being seen in the field because of sender clocks being off.

In the future, we might find a way to warn the user that
their clock might be off, but for now just changing the
tolerance seems the right approach.

BUG=467736

R=mfoltz@chromium.org

Review URL: https://codereview.chromium.org/1011133005

Cr-Commit-Position: refs/heads/master@{#322497}

So these tasks have been queueing with different path names than
those used by the template processor. The latter uses "Unix name"
equivalents of the API features, while the former was not.

For example, "apps/appviewTag" has been caching as such but the
template looks for "apps/appview_tag". It's unclear when this
incongruity appeared but it explains several "my-docs-arent-updating"
bugs that have appeared in the past several weeks.

This changes the refresh servlet to queue API refresh tasks using
API features in unix_name form, resolving the incongruity.

BUG=471019
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/1038993002

Cr-Commit-Position: refs/heads/master@{#322496}