- 12 Apr, 2018 40 commits
-
-
Marina Ciocea authored
Add function for creating input streams in audio::StreamFactory. This implementation is not used yet, and it uses a nullptr UserInputMonitor for now. UserInputMonitor will be moved to audio service in an upcoming CL. Design: http://drawings/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk Bug: 803102 Change-Id: Ie9633adfde67f42665bbc1fa3a2fa12b21171838 Reviewed-on: https://chromium-review.googlesource.com/999418 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550107}
-
Yoshifumi Inoue authored
This patch changes |NextWordPosition()| to utilize |TextOffsetMapping| to make |NextWordPosition()| to work with LayoutNG. This patch is a part of the patch[1]. [1] http://crrev.com/c/737981 Simplify word granularity handling Bug: 778507, 810579 Change-Id: I7e196b0ee390d68b93f2494333554279d6fbd42d Reviewed-on: https://chromium-review.googlesource.com/1004536 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#550106}
-
Nikunj Bhagat authored
Bug: 822100 Change-Id: Idf29d6ea4648dcdf65620fe406441f2983a0a8f6 Reviewed-on: https://chromium-review.googlesource.com/963843 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#550105}
-
Kent Tamura authored
Also, * Rename it to audit_non_blink_usage.py * Add //third_party/blink/tools to remove_stale_pyc_file.py target. Bug: 829697 Change-Id: I6848a5e64b599ce75fa0cea878fe7b17f432417c Reviewed-on: https://chromium-review.googlesource.com/1005644 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#550104}
-
Victor Costan authored
The SQLite cookie store has been migrated to schema version 10. The migration makes the store unusable by previous Chrome versions, so the compatible version should also be bumped. Change-Id: If430be6e925559b4e9ce119858df0f66f85ef833 Reviewed-on: https://chromium-review.googlesource.com/1008413Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#550103}
-
Kenichi Ishibashi authored
This fixes failures in http/tests/serviceworker/chromium/register-error-messages.html Bug: 715640 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id089672074157d5e861d7539ee08115cf7b55488 Reviewed-on: https://chromium-review.googlesource.com/1004555 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#550102}
-
Bill Orr authored
TBR=vollick@chromium.org BUG=824825 Change-Id: I22bb8ca8287ba4d774d56fe48c66f5d0fd25418d Reviewed-on: https://chromium-review.googlesource.com/1003139 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550101}
-
siyua authored
The Autofill.CreditCardInfoBar.Server histogram was split into { Autofill.CreditCardInfoBar.Server, Autofill.CreditCardInfoBar.Server.PreviouslyDenied, Autofill.CreditCardInfoBar.Server.PreviouslyAccepted}. This caused confusion as it went against precedent where sub-histograms shouldn't affect their parent's data, and as a result hid a lot of data behind the .PreviouslyAccepted and .PreviouslyDenied subhistograms. Here's what we want to happen instead, using Autofill.CreditCardInfoBar.Server as an example: 1) Autofill.CreditCardInfoBar.Server goes back to containing ALL data, not just a portion of it. 2) What used to go to Autofill.CreditCardInfoBar.Server should now go to Autofill.CreditCardInfoBar.Server.NoPreviousDecision so that the subhistograms are still useful. Bug: 827414 Change-Id: I432e98f4729318e3e060e280551286b2bcfb80b0 Reviewed-on: https://chromium-review.googlesource.com/997026 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:Evan Stade <estade@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#550100}
-
Patrick Noland authored
Replace JsonFetcher with ContextualSuggestionsFetch. Add no-op/null implementations of methods. Move Cluster definition to its own file. Make ContextualSuggestion a struct, and give it a builder. Adjust bridge to properly use new ContextualSuggestion struct. Add deps on services/network and content/public. R:fgorski@chromium.org, mmenke@chromium.org Bug: 807697 Change-Id: I6a41937a3ae934283f57a8516e2017531adb063d Reviewed-on: https://chromium-review.googlesource.com/1000174 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#550099}
-
Giovanni Ortuño Urquidi authored
Changes the logic to show the location bar any time a site is not secure e.g. if it displays mixed content, has a mixed content form, etc. Before, we would only show the location bar for dangerous sites e.g. invalid certificate, or if the site was not using https. Based on https://crrev.com/c/923226 by mgiuca. Bug: 811158 Change-Id: I72b59eaab031f20924057d1c7ec614f221c52c61 Reviewed-on: https://chromium-review.googlesource.com/1001075 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#550098}
-
Giovanni Ortuño Urquidi authored
Changes LocationBarView to also update its visibility based on the animation state. Before this patch, we would only update the height of the view which resulted in the LocationBarView's elements to still be focusable, even when the bar was supposed to be hidden. Bug: 822123 Change-Id: If8188bb11d5971072192036a4c644e3d3fb5e489 Reviewed-on: https://chromium-review.googlesource.com/1003932Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#550097}
-
Mounir Lamouri authored
This is a reland of a5439425 The CL failed after CQ because another CL that landed a couple of commits prior broke some assumptions made in the unit tests. Original change's description: > Media Controls: allow navigation with accessibility tools. > > The media controls auto-hide mechanism breaks accessibility tools. This > prevents the controls from fully hiding when navigated with > accessibility tools. Instead of marking themselves as `display:none;`, > this only mark the controls as hidden and will show them again if the > user navigates trough them again. Similar to using a mouse. > > Bug: 667833 > Change-Id: I7c2dbfd4b047e2955f6ffa9fb1a5f3bbe37878fd > Reviewed-on: https://chromium-review.googlesource.com/999637 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549774} TBR=dmazzoni@chromium.org, pfeldman@chromium.org Bug: 667833 Change-Id: I03bbe4858d456a9131b257ca709f7d8728e712f7 Reviewed-on: https://chromium-review.googlesource.com/1007075Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#550096}
-
Ryan Hamilton authored
to avoid unregistering static streams with the priority dependency state. Change-Id: I5dcbfdc3bf08c4b3d18b334c650fe267580f4221 Reviewed-on: https://chromium-review.googlesource.com/1008176Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#550095}
-
Bill Orr authored
VR runtime-backed controllers should only be exposed when WebXR or WebVR APIs are available. BUG=830935 Change-Id: I354be9e62e90e7acac3fd712fc3497c141373a47 Reviewed-on: https://chromium-review.googlesource.com/1003732 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550094}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Bug: 830489 Change-Id: If0f260c6c7d4ec9f8ca476bc6731e54f1d7cb7d2 Reviewed-on: https://chromium-review.googlesource.com/1005642Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550093}
-
Tom Anderson authored
Since libc++{abi} are included using -isystem and we compile with -MMD (not -MD), headers from these libraries will not be listed as dependencies. It's possible for libc++{abi} to be updated and for ninja to belive no rebuild is necessary. This CL adds defines for libc++{abi} to force a rebuild when the headers are updated. This CL also requires: https://chromium-review.googlesource.com/c/chromium/buildtools/+/1002869 R=thakis Change-Id: I4c48aa18643cd5fee1be23b6379569123e6fef51 Reviewed-on: https://chromium-review.googlesource.com/1002868 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#550092}
-
Cathy Li authored
Change-Id: I11e64d59194d6dbb52dd0b6f3ff2fefa8f796608 Reviewed-on: https://chromium-review.googlesource.com/999010Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#550091}
-
rbpotter authored
Add a timeout so that the list does not immediately begin changing. This will better match the behavior of the old UI. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5c9d3c3ff2ccd48b30dbb8ef34a86aceb3cbee3a Reviewed-on: https://chromium-review.googlesource.com/1007895Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#550090}
-
Anna Offenwanger authored
Most of the Origin Trial names do not have spaces, so update this one to match. Also, some things needs to alphabetized. Bug: 779691 Change-Id: Ic7c45e751b35817c4bbaceb0b9f451cd375e4840 Reviewed-on: https://chromium-review.googlesource.com/1006044Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550089}
-
Raphael Kubo da Costa authored
Follow-up to 5b84e88a ("Remove custom bindings for CSSStyleDeclaration"). The custom bindings code used to convert the property value to a string via V8StringResource<kTreatNullAsNullString> even though that does not match the setter's signature in the IDL file. Now that the bindings are being generated automatically, the IDL's signature was being respected and causing property values to be converted via V8StringResource<kTreatNullAndUndefinedAsNullString> Update the signature in the IDL so that we maintain compatibility with the older code. Bug: 764633 Change-Id: Ief868d4d3a0655f56e844d3b05cfbd771b2cf8da Reviewed-on: https://chromium-review.googlesource.com/1002878 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550088}
-
Jennifer Apacible authored
Currently, Picture-in-Picture window sizes are determined solely from calculating 20% of the primary display size. This change scales that initial size also adhere to the aspect ratio of the video size. BUG: 726621 829677 Change-Id: I61c26f0dc9d44ebf77620f875aed005b7594d88f Reviewed-on: https://chromium-review.googlesource.com/1001514 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#550087}
-
Yuwei Huang authored
We're about to launch the fullscreen exit UI, starting at 100% for Dev and Canary. Currently the flag for fullscreen exit UI is implemented as a command line switch, which can't be used with Finch experiment. This CL makes the flag base::Feature so that it can be controlled by experiment. Bug: 829606 Change-Id: I955439a4cf6cdd6196fa6d9d42faaebabbc373b0 Reviewed-on: https://chromium-review.googlesource.com/1008724 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#550086}
-
Kurt Horimoto authored
This CL adds a flag that forces the CRWWebViewContentView to always use the WKScrollView's contentInset rather than resizing the frame for fullscreen events. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I70f2d814a15a24a6a0df3874565d8a41325a162a Reviewed-on: https://chromium-review.googlesource.com/1009163 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#550085}
-
Guido Urdaneta authored
Also change WebSpeechRecognizerClient to wrap a WebPrivatePtr to SpeechRecognitionClientProxy instead of being an interface. Before this CL, content::SpeechRecognitionDispatcher kept a raw pointer to WebSpeechRecognitionClient to communicate with SpeechRecognitionClientProxy. This pointer can become dangling while SpeechRecognitionDispatcher is still alive due to Blink garbage collection. After this CL, WebSpeechRecognitionClient keeps the SpeechRecognitionClientProxy object in Blink alive while SpeechRecognitionDispatcher is still alive in content. Drive-by: Minor lint fixes in MockWebSpeechRecognizer. Bug: 829213 Change-Id: I520e96e3e9b9b56908c1ab02e02e49f82d4d2bf9 Reviewed-on: https://chromium-review.googlesource.com/1005063Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#550084}
-
khmel@google.com authored
This adds information about package installation started, finished and failed into app install logger. Bug: b/73277923 Test: unit_tests, manually Change-Id: I0903e72eef8090328d9d9e3a14d12473d1610fab Reviewed-on: https://chromium-review.googlesource.com/996302 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#550083}
-
Fergal Daly authored
This is trivial but it's unclear to someone unfamiliar with the code whether this is going to get the attached root or the containing root (and that method is 2 layers of inheritance away in Node.h). Change-Id: I804664d12e2a245db5eff5b5dc7b77a15b995dc0 Reviewed-on: https://chromium-review.googlesource.com/1009302Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#550082}
-
Jay Civelli authored
The predictor code has been simplified and does not need to know about resource requests priority anymore. As that code was supposed to be the only consumer of that field, removing it from resource_load_info.mojom. Bug: 829935 Tbr: tsepez@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I36e5da88fb4e55af2ad3e94c27be59dd30e1b9c3 Reviewed-on: https://chromium-review.googlesource.com/999829Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#550081}
-
junweifu authored
These points describe a well-defined area along the detected landmark. The modification of Spec has been merged with PR-40[1]. [1] https://github.com/WICG/shape-detection-api/pull/40 BUG=799319 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: If82ed74ab3c85afd7ac525b089b17839970e89c7 Reviewed-on: https://chromium-review.googlesource.com/997760Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Junwei Fu <junwei.fu@intel.com> Cr-Commit-Position: refs/heads/master@{#550080}
-
John Rummell authored
Now that CDMs use mojo exclusively, remove the Pepper APIs that are now unused. BUG=772160 TEST=compiles Change-Id: I1639e3ab7f6fbb3e328a8b9b7c2a2e57c6d5467e Reviewed-on: https://chromium-review.googlesource.com/1007885Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#550079}
-
Lei Zhang authored
Set it properly in callers that require PDF rendering, and read it in PDFiumEngine to pass the right rendering flags to PDFium. BUG=805926,824643 Change-Id: Ia2e8a22259bef1ca78fe425592eeb407bbc4ba35 Reviewed-on: https://chromium-review.googlesource.com/1000555Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#550078}
-
Mark Pearson authored
Split the omnibox entry into desktop, android, and iOS. For each separate target, add all missing features that are being tested in beta or stable. The only feature I skipped was entity suggestions, which as I understand it is being revised / reimplemented, so it's not something that should be actively tested. (Indeed, we probably should get rid of the experiment configs that are currently running with this feature, lest we end up start running a code path in the wild that isn't yet finished being revised.) Change-Id: I3c8826c1d00613242b1ab77f66e22574f6532bb0 Reviewed-on: https://chromium-review.googlesource.com/1000029 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#550077}
-
David Benjamin authored
https://crbug.com/762311 cleared this, but left the split in place. Clean up the split and unnecessary global. (The sampling profiler gives a more accurate stack anyway, so this split isn't useful anymore.) Bug: 424386 Change-Id: Ib71eba0cede89663b0d1e1ef12a37d2bef91ed1e Reviewed-on: https://chromium-review.googlesource.com/1003572 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#550076}
-
Raymond Toy authored
When a tail processing node is finished processing (because it now propagates silence), copy the node to another vector. On the main thread, process this vector by disabling any outputs. If this were done on the audio thread, disabling outputs can cause some handlers to be deleted which also can remove summing junctions. But summing junctions needed to be deleted in the main thread. Bug: 828826 Test: Run repro case and observe no crashes after many minutes. Change-Id: I14acf7f54d621ee83e6ed910a0784ec6a0a34b9d Reviewed-on: https://chromium-review.googlesource.com/996387Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550075}
-
Istiaque Ahmed authored
Migrate the last few relatively easier APis from AsyncExtensionFunction to UIThreadExtensionFunction: - info_private - gcm - input_ime - music_manager_private - alarms - dns - socket - system_cpu - system_memory - webcam_private Remove AsyncExtensionFunction class entirely. AsyncApiFunction used to extension from AsyncExtensionFunction, for the time being subsume AsyncExtensionFunction's functionality directly inside AsyncApiFunction. Bug: 829174, 829157 Change-Id: I2a509a08f0f802431776d76815fe2aa8f83b371b Reviewed-on: https://chromium-review.googlesource.com/1001792 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#550074}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3f22876932f75eaa61f61e6d5fd8183c14199caa Reviewed-on: https://chromium-review.googlesource.com/1009362 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#550073}
-
Hajime Hoshi authored
We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. This CL also introduces a new TaskType kInternalInspector. Bug: 830489 Change-Id: I8cd432f0f65ac9cd5ae98fd4be69e4986a87053c Reviewed-on: https://chromium-review.googlesource.com/1005652 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#550072}
-
dpapad authored
Latest version of Closure compiler is smarter and stricter. The errors need to be fixed to unblock rolling the latest Closure compiler version. Bug: 831004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2e22cfd40d621263532206e2f816048c6e6a3778 Reviewed-on: https://chromium-review.googlesource.com/1006179 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#550071}
-
Andrey Lushnikov authored
This patch adds CSS Variable palette to Spectrum in Styles Sidebar Pane. R=dgozman Change-Id: I5327b875d65039e8955e804e4b1b3208cd683a33 Reviewed-on: https://chromium-review.googlesource.com/1008998Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#550070}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: Idf6f5dd37a0c6d510a17a6f4c5546a86d9c07333 Reviewed-on: https://chromium-review.googlesource.com/983155Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#550069}
-
Tetsui Ohkubo authored
According to UX spec, labels in FeaturePodButton should show while hover background. In order to implement this, this CL adds FeaturePodLabelButton class. Also, this CL fixes FeaturePodIconButton padding which was different from UX spec. According to the spec, icon and labels in feature pod button are different click targets, which is still not implemented in this CL. It will be done in another CL. Screencast: http://dr/file/d/1FPylXzoO_xCTc8ywQU2NezUug9WgTz-q/view UX spec: http://shortn/_U7QSE9nhSk TEST=manual BUG=821671 Change-Id: I596abbf5226932c9ac4f342e29c83fa4cc12185d Reviewed-on: https://chromium-review.googlesource.com/1008942Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#550068}
-