- 25 Jun, 2018 40 commits
-
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3dd366c8c8c0..82901f0040da git log 3dd366c8c8c0..82901f0040da --date=short --no-merges --format='%ad %ae %s' 2018-06-25 hjd@google.com Merge "Add trace_processor bundle" 2018-06-22 hjd@google.com Add trace_processor bundle Created with: gclient setdep -r src/third_party/perfetto@82901f0040da The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib7ccf84e6d7a3e15a7f6210eefe853a4a40714dc Reviewed-on: https://chromium-review.googlesource.com/1113457 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570022}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7619aff4..b1475672 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I193f16d395c6944986843ab4c863708686fde334 Reviewed-on: https://chromium-review.googlesource.com/1113210Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570021}
-
Mattias Nissler authored
The test team found an issue where cryptohomed fails to deal with the state the TPM is in for the case when the update installation gets interrupted and recovery is invoked to retry and complete the update. Disable device-state preserving updates for now until the issue is resolved. BUG=chromium:854576 TEST=Triggering TPM firmware update via chrome://chrome will not invoke the device state preserving update flow. Change-Id: I4ac4d325bfbf953cfa14a501e871a3f9f59c699c Reviewed-on: https://chromium-review.googlesource.com/1111998Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#570020}
-
Florian Uunk authored
And expose it on WebDataServiceWrapper. Bug: 854643 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6c7f121f2004d952591ee9a3bd5178cb592d6877 Reviewed-on: https://chromium-review.googlesource.com/1086930 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#570019}
-
Hajime Hoshi authored
Change-Id: I5cbbd34ab7804946e73cce9e0fb49678e72dc414 Reviewed-on: https://chromium-review.googlesource.com/1113172Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570018}
-
kylechar authored
When running the GPU process for the OOP-D display compositor with GL disabled don't collect GPUInfo. This matches the behaviour without OOP-D where there GPU process isn't even started. We are seeing the GPU process crashes with OOP-D before the browser gets a GPUInfo object back and this may be the cause. Bug: 852863 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2e8ff1e99742cd360017c7d675b0b954de32b2d7 Reviewed-on: https://chromium-review.googlesource.com/1112340Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#570017}
-
Hajime Hoshi authored
This check was in MediaElementEventQueue but lost when merging this into EventQueueImpl. Bug: 846618 Change-Id: I354ab7a4787624c6269e6abd0a67eb0a63680ad6 Reviewed-on: https://chromium-review.googlesource.com/1113397Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570016}
-
Friedrich Horschig authored
This CL fixes the most common keyboard accessory crashes for 69. Before it, the filling coordinator removed the exact instance of a held password sheet from the accessory. It would crash when the password tab wasn't part of the accessory anymore - maybe due to race conditions. With this implementation, the filling coordinator just resets all tabs of the accessory. As it's the owner of the accessory, this just forces it into a sane state (which is exactly what the reset is meant to do). Next up: Removing remove methods. Bug: 855036, 854348 Change-Id: I73563856745bfe106f78f58c15b395ce614c107a Reviewed-on: https://chromium-review.googlesource.com/1113308 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#570015}
-
Max Morin authored
Also migrate the audio service to it. We want to add audio processing capabilities to the audio service, and the media/ code cannot depend on services/audio/, so we need the AudioInputController code in the audio service. There's a very sketched design doc for processing in the audio service at https://docs.google.com/document/d/1HJnii4kuBXshVM202TVPJt_9iDmlaCX-VhatjRxRbC4/edit#. Bug: 851959 Change-Id: Icabef727e6d309f86472d2fb401d7383051fa0ae Reviewed-on: https://chromium-review.googlesource.com/1104464 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#570014}
-
Hajime Hoshi authored
Change-Id: I721145f731cb12da42beae52b280fa5f253c6c51 Reviewed-on: https://chromium-review.googlesource.com/1111755Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570013}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e625dcb82db..29f3b8927f88 git log 2e625dcb82db..29f3b8927f88 --date=short --no-merges --format='%ad %ae %s' 2018-06-25 perezju@chromium.org [Telemetry] Disable flaky tests on mac Created with: gclient setdep -r src/third_party/catapult@29f3b8927f88 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:855885 TBR=sullivan@chromium.org Change-Id: Iff8453806d324ba6628a40cb5050712d7bfaabcd Reviewed-on: https://chromium-review.googlesource.com/1113060Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570012}
-
Peter Beverloo authored
TBR=rayankans, delphick Change-Id: I4cd89ee0fbc89efffadc545bf32fcafac0c77636 Reviewed-on: https://chromium-review.googlesource.com/1113312Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#570011}
-
Henrique Ferreiro authored
Bug: 852347 Change-Id: Ica3e0c748f05c0f7d1c714f006634de25b021f67 Reviewed-on: https://chromium-review.googlesource.com/1098257 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570010}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4f654365. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20222 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/resources yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=robertma No-Export: true Change-Id: Ia3ef1dbe5a19c10b93ac6f297bcb32894b2b793d Reviewed-on: https://chromium-review.googlesource.com/1113207 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#570009}
-
Marc Treib authored
The new ShouldSyncStart includes the "FirstSetupComplete" check. With this, StartupController doesn't have any knowledge of Sync setup state anymore. As a nice side effect, this allows us to remove SyncPrefs from StartupController. Bug: 854978 Change-Id: Ia9fb178cf5a81ada4288f4c33bcc48ced4f631f4 Reviewed-on: https://chromium-review.googlesource.com/1112241 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#570008}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0212faf7c41e..3dd366c8c8c0 git log 0212faf7c41e..3dd366c8c8c0 --date=short --no-merges --format='%ad %ae %s' 2018-06-22 taylori@google.com trace_processor: Match threads to processes using tgid. Created with: gclient setdep -r src/third_party/perfetto@3dd366c8c8c0 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: I394bdbf6d09cb900bf9f2a5c501703f4f83895c2 Reviewed-on: https://chromium-review.googlesource.com/1113059 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570007}
-
Roman Sorokin authored
BUG=chromium:831128 TEST=manual TBR=alemate@chromium.org Change-Id: Ib9368a9ba657b381601086357abf4b766ef7b984 Reviewed-on: https://chromium-review.googlesource.com/1112240Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570006}
-
Philipp Hancke authored
removes the last directly promise-based usage of getUserMedia BUG=836871 Change-Id: Ib0ef41b58c2fc3930d068d915cb569064db4542d Reviewed-on: https://chromium-review.googlesource.com/1106618 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#570005}
-
Harald Alvestrand authored
These attributes have been removed from the spec, or were never standard in the first place, and have zero usage. "Intent to remove" thread: https://groups.google.com/a/chromium.org/forum/#!topic/Blink-dev/kGS73zpPT0I Bug: 696669 Change-Id: Id999ab29c2a93fc7c36079196a8a924c01450066 Reviewed-on: https://chromium-review.googlesource.com/1110221 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#570004}
-
Pavel Feldman authored
Change-Id: Ic98de1070c3cee34a926ee0a95eb05cd62345ce6 Reviewed-on: https://chromium-review.googlesource.com/1113309Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570003}
-
Arthur Sonzogni authored
Document::CancelParsing() may cause Document::ShouldComplete() to return true. Document::CheckCompleted() needs to be called so that its DocumentLoader is marked to have finished its load. A lot of tests don't expect DidStopLoading() and DidStartLoading() to be fired when a new DocumentLoader starts and replaces the previous one. In FrameLoader::StartLoad(), Document::CancelParsing() is moved after the creation of the new provisional DocumentLoader so that the FrameLoader isn't temporarily without any non loading Document. If that happened, DidStopLoading() would be fired. There was also one small bug with site isolation. The condition |have_to_check_if_parent_is_completed| in HTMLFrameOwnerElement::DisconnectContentFrame() was too strict. The parent document may have completed its load, but not have sent DidStopLoading yet because its childs were still loading. Note: I am working on https://crbug.com/831155. Some tests that are relying on how things are scheduled in Blink are failing. This CL makes DownloadTest.TestMultipleDownloadsRequests to keep working. Here, while the current document is loading, a new navigation happens and cancels the parser of the current document without calling Document::CheckCompleted() on it. Then, it turns out the navigation is a download. The navigation is dropped. In the end the main frame doesn't know its iframe has finished loading and the test fails. Bug: 831155 Change-Id: Ib2de108e25991349b44ec4071fe61d57ca6e85a1 Reviewed-on: https://chromium-review.googlesource.com/1107808Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570002}
-
Naoki Fukino authored
Android container now supports content urls with /external_files to access all files on emulated external storage. We need to convert URLs under /run/arc/sdcard/write/emulated/0 on Chrome OS side to the content URLs. To share the path to Android files, the definition of kAndroidFilesPath is moved from volume_manager to path_util. Bug: 855982 Test: Manually tested on Kevin and Eve with a patch ag/4411504 on Android. Change-Id: Idb6fbd9aa697c306d953b0bcb7cf332ec9a26c19 Reviewed-on: https://chromium-review.googlesource.com/1113169 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#570001}
-
Peter Beverloo authored
Change-Id: I1ec42b183f800555145b4a78db898d61efaab456 Reviewed-on: https://chromium-review.googlesource.com/1113183 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#570000}
-
yusukes authored
These days, 'using namespace' is banned even in .cc files and 'git cl lint' actually detects violations. This CL addresses that as well as some IWYU issues. https://google.github.io/styleguide/cppguide.html#Namespaces BUG=b:74499980 TEST=git cl lint, unit_tests Change-Id: I0277f6a471aaf7050929d3ea43050eb4b663a956 Reviewed-on: https://chromium-review.googlesource.com/1113209Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569999}
-
jdoerrie authored
TBR=sadrul Bug: 856079 Change-Id: If2a53d4409d22142f27fc13ebb2dfcaf82afcc54 Reviewed-on: https://chromium-review.googlesource.com/1113304Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#569998}
-
Darren Shen authored
virtual/stable/http/tests/navigation/rename-subframe-goback.html times out on Linux. TBR=lukasza@chromium.org Bug: 855816 Change-Id: I56234dcc8c4adab0d2539a751467131fd2b8ceeb Reviewed-on: https://chromium-review.googlesource.com/1113161 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569997}
-
Matt Menke authored
It was used by the non-Mojo loading path, which was removed quite a while back. Bug: none Change-Id: I86c7b9b7cc950b3f89a00fcb57ff4f95a9a328b9 Reviewed-on: https://chromium-review.googlesource.com/1112465Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569996}
-
vitaliii authored
Connect ConsentSyncBridge to ConsentAuditor behind a feature on iOS. ConsentAuditor does not use the bridge at all yet. The bridge is wired to the auditor on all other platforms in https://chromium-review.googlesource.com/c/chromium/src/+/1084475. This CL is a part of a series to split user consents from user events into a separate datatype. Bug: 840357 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie47fb3241cfdd64f7962d9d8b62f28578a76c0a1 Reviewed-on: https://chromium-review.googlesource.com/1087269Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569995}
-
vitaliii authored
Previously I had to temporarily use USER_EVENTS in consent_sync_bridge_impl, because it was added before the new datatype. This CL fixes this. Bug: 840357 Change-Id: I4d21598c8155e44baa6b5d99de42416c00996243 Reviewed-on: https://chromium-review.googlesource.com/1095306Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569994}
-
Mirko Bonadei authored
If Abseil is not built with Chromium, this CL defines GTEST_HAS_ABSL=1 which enables pretty printers for Abseil types. At the moment only absl:optional and absl::string_view are supported. If a new printer will be added to gtest/gtest-printers.h, the deps list in third_party/googletest/BUILD.gn will have to be updated. Bug: None Change-Id: Ib3cf0eacc286367be2cba0d7b0d3dd9598147bc7 Reviewed-on: https://chromium-review.googlesource.com/1027711Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#569993}
-
yusukes authored
With this, such IMEs will be excluded from the available IME list for English. BUG=b:74499980 TEST=unit_tests Change-Id: Ied09c0c787bf54527229133a1d792cabbc4aac7c Reviewed-on: https://chromium-review.googlesource.com/1113206Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569992}
-
Gauthier Ambard authored
The condition for disabling the test was wrong, the test is failing on device. Bug: 855368 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6b3a5696e6cdec5b80e12bc3b74d81c443f8cd46 Reviewed-on: https://chromium-review.googlesource.com/1113186Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#569991}
-
Ilya Nikolaevskiy authored
Bug: 854735 Change-Id: I735d9140c5b6365ff3be9763138ac573e9180502 Reviewed-on: https://chromium-review.googlesource.com/1109967 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#569990}
-
yusukes authored
Android IMEs installed to Chrome OS will be associated with a special Chrome OS language name. This CL adds the fake language. BUG=b:74499980 TEST=ui_base_unittests Change-Id: If5f78cc22c8371ef6199b67563792bc008aaeab2 Reviewed-on: https://chromium-review.googlesource.com/1113205Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#569989}
-
Fergal Daly authored
The current NeedsRecheck checks whether the node's document version has increased by more than 1 but it does not notice when the node has moved to a new document. Since we cannot capture the original version of the final document for comparison, we have to assume that when the document changes, a recheck is needed. Bug: 837377 Change-Id: If83c4eaeb6b737768cc45c2f3a2241b03d3d2e75 Reviewed-on: https://chromium-review.googlesource.com/1109667Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569988}
-
Mohamed Amir Yosef authored
In order to compute the unique position of a newly created bookmark node, the unique positions of its siblings are required. This CL persists the unique position of synced bookmark nodes such that they are available across client restarts. Bug: 516866 Change-Id: I27c4ac9fbb25488792c6065dfd49069ef126863c Reviewed-on: https://chromium-review.googlesource.com/1107934 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#569987}
-
Jerry Lin authored
This patch adds fuzzer for password_generator_fips181_unittest.cc. R=vabr@chromium.org Bug: 847200 Change-Id: I83823e2315c459963ff020604272613482f15e78 Reviewed-on: https://chromium-review.googlesource.com/1109596 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#569986}
-
Darren Shen authored
This reverts commit c32a3d1e. Reason for revert: introduced flake, see https://crbug.com/855979 Original change's description: > Deflake one of TouchActionBrowserTest > > Some of the TouchActionBrowserTests are flaky. I was recently told by > sahel@ that setting speed_in_pixels_s to a very high number will ensure > there is one GSU only and will prevent the flaky. This does work, at > least locally. I have tried the test in this CL locally and it was > flaky without this change. With this change, I have ran this test 50 > times without any failure. > > This CL does that. Right now there are a few tests marked flaky, this > CL enables one of them first. I will monitor the flakiness dashboard > once this CL lands. If this does solve the problem, we will then enable > more tests. > > Bug: 833015 > Change-Id: I539703866094fb526e220c48aaf327836345b950 > Reviewed-on: https://chromium-review.googlesource.com/1101464 > Commit-Queue: Xida Chen <xidachen@chromium.org> > Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567692} TBR=tdresser@chromium.org,xidachen@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 833015 Change-Id: I53852330fc0702b5e0c240afed40ef514c8a136f Reviewed-on: https://chromium-review.googlesource.com/1113217Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569985}
-
Darren Shen authored
Timeout on linux. TBR=hiroshige@chromium.org Bug: 855860 Change-Id: Ieb872c12a54afa07baffbedb1f64a6280a489281 Reviewed-on: https://chromium-review.googlesource.com/1113158Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569984}
-
Kent Tamura authored
All of PopupOpeningObserver implementors are on GC heap, and having raw pointers to them is dangerous. This CL is a preparation to make blink::FileInputType a PopupOpeningObserver. Bug: 637639 Change-Id: Iee014462716cc3c3de91ddf365ab8644e2de5f2e Reviewed-on: https://chromium-review.googlesource.com/1113084 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569983}
-