- 11 Oct, 2019 40 commits
-
-
Torne (Richard Coles) authored
WebViewDelegate.getPackageId sometimes throws an exception complaining that it's unable to find the WebView package in the resource table. This looks like it might be some kind of obscure race caused by doing it on a background thread at the same time as WebView initialisation (which in some cases can also be manipulating the resource table). The goal of the background thread is to parallelize work for a startup time benefit, but the call to getPackageId is actually very fast (the expensive part is calling R.onResourcesLoaded). So, just do the package ID lookup on the main thread first and pass the ID in to the background task, in the hope that this avoids this hypothetical race. Bug: 995400 Change-Id: Id4479cdda54ee7b1aec273a491fa0f0f64ed348c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854466Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#705102}
-
Dominique Fauteux-Chapleau authored
Added fields per event type: "dangerousDownloadEvent": "contentType", "contentSize", and "trigger" "sensitiveDataEvent": "contentType", "contentSize", and "trigger" "largeUnscannedFileEvent": "contentType", "contentSize", and "trigger" Bug: 1006938 Change-Id: Ib20e1cee7eb339d15374b30880d161f55510a4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847799 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#705101}
-
Vasilii Sukhanov authored
The promo should be shown again 3 times starting from M79. Bug: 1013181 Change-Id: I3bcf46096f18aefc8d8894d34597aea24aa24601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855981 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#705100}
-
Yi Gu authored
In v2, if a hit test region is marked as kHitTestIgnore, this region and its descendants should be excluded from hit testing. However, in v1 this flag may be set in other scenarios [1]. When v2 is enabled by default, some tests will fail due to the inconsistent use of the flag. Using parameterized test to cover this issue until v1 is removed. [1] https://cs.chromium.org/chromium/src/components/viz/common/quads/surface_draw_quad.h?type=cs&g=0&l=50 Bug: None Change-Id: I8ffe49c291f827b83e52766ab549fcb6f245d3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839014Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705099}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/58a3ebb1bb9f..f5952b718415 git log 58a3ebb1bb9f..f5952b718415 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 tneda@google.com Merge "Adding support in flamegraph API for hovering over callsites and expanding them by clicking." 2019-10-11 treehugger-gerrit@google.com Merge "Fix VulkanMemoryAllocation typo in proto_parser" Created with: gclient setdep -r src/third_party/perfetto@f5952b718415 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I90a417d1f3fb2cab1a5064af8ef084323b44a080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705098}
-
Antonio Gomes authored
These files need to be moved to Blink as part of the phase 8 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/edit?ts=5d5c1757 Since they can get moved independently, this CL does so, so reviewing the main CL is eased. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I23f65a6187f2eb1402170ebf182552d054ad3fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839091 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#705097}
-
Mario Bianucci authored
run-swarmed.py was failing on Windows for two reasons: 1. Windows expects 'python' before calling a python script 2. Tasks on Windows Swarming bots are invoked via vpython, which isn't installed by default on them. This change adds 'python' to the list of arguments for any subprocess, and adds includes vpython with the isolates uploaded to Swarming via --cipd-package and --env-prefix args when the target OS is Windows. Bug: 1013382 Change-Id: I9b8edf9ebc2341cb72f8034ccec044f951745496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854462 Commit-Queue: Mario Bianucci <mabian@microsoft.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#705096}
-
Antonio Gomes authored
These testing classes are needed for peer_connection_tracker_unittest.cc, that will be Onion soup'ed next, together with various other classes and tests. For simplicity, this particular pair of files are moved independently, so the core CL is easier to review. Note that the classes got renamed to FakeRtcRtp{XXX}Impl, to mirror their respective non-fake classes, moved to Blink in [1], [2] and [3]. [1] https://crrev.com/c/1819801 [2] https://crrev.com/c/1819811 [3] https://crrev.com/c/1820060 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I3b8de656d96ef4148f6a08afb23080803a52255f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835799 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#705095}
-
Kevin Ellis authored
The implementation of cancel was aligned with the web-animations spec in: https://chromium-review.googlesource.com/c/chromium/src/+/1824058 Resolving the ready promise after the reject and reset is not to spec [1]. After the above patch we no longer resolve the ready promise after a cancel, so it is possible to already have a pending promise when we enter the "pending" state. This introduced a DCHECK failure when transitioning from an idle state to a pending state. Per above this DCHECK is incorrect so we remove it. Previously, when an animation was cancelled, the destructor for PlayStateUpdateScope will not only reject and reset the ready promise, but it will then resolve this new promise. When transitioning from idle to pending, an additional reset is performed with a check that we do not already have a pending promise. Spec: https://drafts.csswg.org/web-animations/#canceling-an-animation-section Bug: 1012384 Change-Id: Id40fc094f599463a5e3ab67715edde02bbec6720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853164 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#705094}
-
Daniel Vogelheim authored
Reason for removal: Origin Trials are time-limited, and this one has run out. We're removing the trial itself, as well as the test that tested feature initialization when performed via an origin trial token (977099). Bug: 739170 Change-Id: Ibfdf902c9125fe58111de82b48622f45db60c9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827285 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#705093}
-
Dominique Fauteux-Chapleau authored
Adds pattern matching to DomainsToNotCheckComplianceOfUploadedContent, DomainsToCheckComplianceOfDownloadedContent and DomainsToCheckForMalwareOfUploadedContent policies. This makes those policies more efficient by not needing to enumerate exact domains and also allows to match against more granular url properties, for instance by using patterns like 'http://*', 'https://server:8080/path' or '*'. The pattern matching used is the same one used by the URLBlacklist policy. To achieve this, this cl includes a refactor that puts that pattern matching code in a common util file. It is worth noting that this changes what the policies actually do and so DomainsToCheck* is no longer an appropriate name, they will be renamed in a different cl. Bug: 1008486 Change-Id: I71410849403f2fc54cefe34d94b0f64256f3e18a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841772Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#705092}
-
Kuang-che Wu authored
Reduce time complexity from O(n^2) to O(n) Bug: chromium:855272, chromium:1009098 Change-Id: I9365c7ae7135ec694a5b83ef47674461fc7f353e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854104Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705091}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c2b2bb02402..df640e6d14a5 git log 6c2b2bb02402..df640e6d14a5 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 borenet@google.com Revert "Roll recipe dependencies (trivial)." Created with: gclient setdep -r src/third_party/skia@df640e6d14a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I340772d3fbb8b53714d23b2bebcdf293b99b929c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705090}
-
Francois Beaufort authored
This CL makes sure a mediaType is required only if recordType is "json" or "opaque" in a NDEFRecord as described at https://w3c.github.io/web-nfc/#data-mapping Bug: 1013167 Change-Id: I22a6508b66e5e5e7f69ca295fd5281b02dcb2b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852215 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#705089}
-
David Roger authored
TBR=akihiroota Bug: 981100, 1013551 Change-Id: I50890923e35a6d6196a14dcdd48d40367d166f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856059Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705088}
-
Lily Chen authored
This code was previously using a CookieOptions that would exclude SameSite cookies. This could be a problem when cookies become SameSite by default, so this change switches this to use a CookieOptions that includes all cookies. Bug: None Change-Id: I29fdc5d05f0b6995e283104abb14729afc0a205a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849772Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705087}
-
Juan Antonio Navarro Perez authored
This is mostly an API change (*), the underlying implementation of AddMeasurement is still the same (via legacy values in Telemetry), so no behavior changes are expected. (*) Except for a few measurement descriptions which were tweaked for clarity. Depends on: https://chromium-review.googlesource.com/c/catapult/+/1840835 TBR=hablich@chromium.org Bug: 999484 Change-Id: I01c79f1741dbbde6d179c33bb91defade8fd0155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841551 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#705086}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3b819f3d8bbe..51bf20029462 git log 3b819f3d8bbe..51bf20029462 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 danilchap@webrtc.org Reduce number of RTPVideoSender::SendVideo parameters 2019-10-11 kwiberg@webrtc.org NetEqImpl::GetDecoderFormat: Return RTP clockrate, not codec sample rate Created with: gclient setdep -r src/third_party/webrtc@51bf20029462 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ib927efd86297943172e25bd1df20d5984daf0679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854812Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705085}
-
Javier Ernesto Flores Robles authored
Style all the views with the UI specification. Add support for dynamic type. Wrap contents in a scroll view for the bigger font sizes. Add support for horizontal and vertical size class changes. Present as Form on iPad. Bug: 1008862 Change-Id: I9a107bb14e9bd1669462c9a383243a213a970aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847339 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#705084}
-
Roman Sorokin authored
Bug: none Change-Id: I4e11bd9c8b81828df5b08bf9dae6788d478ebcee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855984Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705083}
-
Henrique Ferreiro authored
Convert the implementation and all users of the chrome_cleaner::mojom::EngineScanResults, EngineCleanupResults and EngineCommands interfaces. EngineRequests and EngineFileRequests will be migrated in a different CL. Bug: 955171 Change-Id: I792cdc4753626621ba9d53d908133297f4520999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831805Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#705082}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/464d407d..04988676 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff6705054579dd31df7ddeb52866d2ecf1deed1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855661Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705081}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/54b0677aeba5..d0458b338358 Created with: gclient setdep -r src-internal@d0458b338358 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ifd4444a2fef6ddcef7d3c107f36744e791c19a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854811Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705080}
-
Kamila authored
- Updated the indicator (explanation text, animation, blocked badge) for the mediastream image model, based on the state of the permissions on a system and site level according to the behavior described in the bug (#c1). - Show no indicator when: The user still has to make a decision (the system level prompt is open). - Update the location bar when the user blocks system level permissions. - Unit tests, testing the logic for camera/mic/camera+mic image model. Change-Id: Id65911e9c81c77b59e0e9678642dc95c9e31246d Bug: 1012729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776539 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#705079}
-
Rayan Kanso authored
Bug: 1013568 Change-Id: I9d5cdcf2175cbdadeda5ac718ae0a9cf137c936b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831870 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#705078}
-
Javier Ernesto Flores Robles authored
Update the table view in case the user is kicked out. Or logs out in multi-window. Bug: 986322 Change-Id: I45f1979bf27dfde6568fcaa525ab7443161342c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856078 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#705077}
-
Javier Ernesto Flores Robles authored
Updates the detail text of the switch based on the logged in status and the preference value. Bug: 986322 Change-Id: I11f346f003e756c4ab55e75992c7fdf16f1d7492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852090Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#705076}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/561ba7ee890b..58a3ebb1bb9f git log 561ba7ee890b..58a3ebb1bb9f --date=short --no-merges --format='%ad %ae %s' 2019-10-11 matthew.clarkson@arm.com tools(gen_amalgamated): quality of life improvements Created with: gclient setdep -r src/third_party/perfetto@58a3ebb1bb9f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Iba14b7cdfd009cf80d285efe5775c455c5130307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705075}
-
Chromium WPT Sync authored
Using wpt-import in Chromium db752d0b. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" 1644eff7 "Update scroll to text feature detectability API" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools jfernandez@igalia.com: external/wpt/css/css-align jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic7968bc458ce817750a700c4fd05f752afcd02ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855660Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705074}
-
Keishi Hattori authored
Replace ScopedPersistent in V8V0CustomElementLifecycleCallbacks with TraceWrapperV8Reference. Use of ScopedPersistent is discourage in favour of TraceWrapperV8Reference which is GC aware. Bug: 1013149 Change-Id: I3b45f15616d2b206d260f45519546e845a183c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855321 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#705073}
-
Peter E Conn authored
Bug: 1005736 Change-Id: I83b26daa7b15dd74df138c14cd58811deeb8712f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854126Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705072}
-
Pavel Shmakov authored
Change-Id: I74d0822b697f55a9d1e53a106a60d784c352a9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852214Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#705071}
-
Ingvar Stepanyan authored
It's not safe to cache source map object by just source map URL, because source map is always constructed with and associated with specific source URL, too, so reusing same source map object for various source URLs can end up resolving invalid locations, pointing to the first source URL it was constructed with. This change creates an aggregate source map ID, similar to the one in SDK.DebuggerModel, by concatenating source URL, ":" and source map URL. Such ID can then be used for caching and tracking purposes. There are more things that could be simplified here, but for now tried to make this change minimal and pretty much 1:1 replacement. Also removed obsolete applySourceMapEdit which doesn't seem to be used anywhere. Bug: 1012360 Change-Id: I131927a9f960526ba01412a39f22f036b1023caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848697 Commit-Queue: Ingvar Stepanyan <rreverser@google.com> Auto-Submit: Ingvar Stepanyan <rreverser@google.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#705070}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/1831621. This CL was uploaded by git cl split. R=yangguo@chromium.org Bug: 1007760 Change-Id: Id6da42c61527457fcb365f49ce3561bc0fce3399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849542 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705069}
-
Ewann authored
Fixing action buttons: - Check if the location bar is in steady state. If yes, the Copy button is displayed. If not, if there is selected text the Copy button is displayed. In other cases, the Copy button is hidden. - display Paste & Search for Copied Text buttons when omnibox is empty. - hide Select & Select All buttons when omnibox is empty. - display Select All button when selected text and hide Select button. Corresponding integration tests dded. Bug: 864984 Change-Id: I321546571272235eac0b749753f041bff0922608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786639 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705068}
-
Roman Sorokin authored
It's in fact user visible :) Bug: 1008270 Change-Id: I0b6dafea8883c9aaeb8e76f162dc427029752b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853924Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#705067}
-
Antonio Gomes authored
... and the respective unittest, transceiver_state_surfacer_unittest.cc This CL works out phase 7.4 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I25384e38468cdfaf5e5fa2157f8f5993f1591f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820062 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#705066}
-
David Roger authored
TBR=yhirano Bug: 1013523 Change-Id: Iad71979f640ed5ae42c7fe00982da2876935fb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855978Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705065}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=msramek@chromium.org Bug: 1007760 Change-Id: If363fd450c6a7118b8d622e8ae3b9c2777f96524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849541 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705064}
-
Maksim Moskvitin authored
In theory, keystore keys might not arrive together with NigoriSpecifics, for example, in case of throttling. To make USS implementation more robust in this situation, we allow pending keys in keystore mode. Cryptographer should be properly initialized once we receive keystore key, which was used for encryption of keystore_decryptor_token. This CL extends pending keys concept to keystore_decryptor_token, because we need to store it until decryption. Note: Directory implementation implicitly had this concept, since it stored NigoriSpecifics itself as the local state. Note: this CL doesn't add support for initialization of default Nigori in case bridge has no keystore keys. Bug: 922900 Change-Id: I9a138d2190e28b617789bb0632d3751fa226d8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840694 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#705063}
-