GitLab

CodeGen's only dependency on ErrorCode was one MakeInstruction()
overload, which can be removed by making the caller responsible for
converting the ErrorCode to a BPF_RET'able value. Fortunately, there
are only two uses of this function:

1. SandboxBPF::RetExpression() which is easily fixed by simply calling
ErrorCode::err() to get the ErrorCode's error value.

2. codegen_unittest.cc which is merely testing the BPF code generator,
and so any return values will do: no need to be seccomp-bpf return
values... so just replace them with simple integer values.  (While
here, change a few bare "BPF_RET" arguments to "BPF_RET + BPF_K" just
to be consistent.)

After this CL, CodeGen focuses solely on assembling programs for the
abstract BPF machine, while higher-level abstractions (primarily
SandboxBPF) are responsible for using it in a way that's semantically
meaningful for seccomp-bpf.

BUG=414363

Review URL: https://codereview.chromium.org/576673003

Cr-Commit-Position: refs/heads/master@{#295192}

Sending is controlled by a finch experiment.

The verdict from the server is ignored for now.

BUG=413967

Review URL: https://codereview.chromium.org/512513002

Cr-Commit-Position: refs/heads/master@{#295191}

I've also added the WTF namespace, which we still use.

R=erg@chromium.org

Review URL: https://codereview.chromium.org/574473002

Cr-Commit-Position: refs/heads/master@{#295190}

BUG=None

(inherit from the original issue)
TBR=stevenjb@chromium.org

Orignial issue description:

>  Minor cleanup in EasyUnlockClient
>
>  * arg names in GenerateEcP256KeyPairCallback typedef were reversed
>  * Make CreateSecureMEssage and UnwrapSecureMessage take structs (instead
>  of having long list of arguments)
>
>  BUG=None
>  TEST=existing unittests
>
>  Review URL: https://codereview.chromium.org/569813002
>
>  Cr-Commit-Position: refs/heads/master@{#294954}

Review URL: https://codereview.chromium.org/581463002

Cr-Commit-Position: refs/heads/master@{#295189}

This makes EasyUnlockService pure virtual base class and introduces
separate implementations for regular and signin profiles. Common code
for both service types is kept in EasyUnlockService class.

EasyunlockService for signin profile is left empty.

BUG=401634

Review URL: https://codereview.chromium.org/577683002

Cr-Commit-Position: refs/heads/master@{#295188}

This CL implements a WebRTC Desktop Capturer that captures from
the Aura Shell root window.

The capturer is used by the It2MeHost on Chrome OS.
|DesktopCaptureDeviceAura| cannot be re-used in our scenario
because is timer-driven as opposed to caller driven, which is
required by WebRTC.

The current implementation uses the layer API

desktop_window_->layer()->RequestCopyOfOutput(request.Pass())

to request the layer and its subtree to be rendered to a
|SkiaBitmap|.  It then copies the pixels to a WebRTC |DesktopFrame|.

BUG=411530

Review URL: https://codereview.chromium.org/543243003

Cr-Commit-Position: refs/heads/master@{#295187}

BUG=354046

Review URL: https://codereview.chromium.org/441553002

Cr-Commit-Position: refs/heads/master@{#295186}

- Use bundled binutils by adding to cflags -B
- Enables dwarf-fission based on bundling (maybe correct?)
- Makes differ normalize -B paths so they can be compared between gyp/gn.

R=brettw@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/568613002

Cr-Commit-Position: refs/heads/master@{#295185}

For each bound UDP socket, the Pepper layer in the plugin process maintains a
buffer to store received packets, and informs the browser process of available
buffer slots. The browser process does recvfrom and pushes the results to the
plugin process when there are available slots.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/563073002

Cr-Commit-Position: refs/heads/master@{#295184}

the code that checks that sockets API is available was checking that
chrome.socket.secure is defined without verifying that chrome.socket
is defined. As result the app would not connect.

BUG=414366

Review URL: https://codereview.chromium.org/567293005

Cr-Commit-Position: refs/heads/master@{#295183}

This creates a basic clipboard interface and uses it from
html_viewer. This is a minimal implementation and does not actually
interact with the system clipboard.

BUG=411039
First Committed: https://crrev.com/757286d8a2c778fe4622890140c9b9d2afd21063

Review URL: https://codereview.chromium.org/562483002

Cr-Commit-Position: refs/heads/master@{#295182}

Fix GN build for ozone and official.

TBR=cmasone@chromium.org

Review URL: https://codereview.chromium.org/552983004

Cr-Commit-Position: refs/heads/master@{#295181}

TBR=hclam

Review URL: https://codereview.chromium.org/576873002

Cr-Commit-Position: refs/heads/master@{#295180}

We need to show an empty bar for the user to drag extension actions into for
overflow when there are none currently overflowed. Obviously, this empty bar
should only be displayed when the user is dragging an extension action.

BUG=414386

Review URL: https://codereview.chromium.org/556293003

Cr-Commit-Position: refs/heads/master@{#295179}

Revert of Remove deprecated cursor event filter for Ozone (patchset #2 id:20001 of https://codereview.chromium.org/580553002/)

Reason for revert:
This appears to be causing ImmersiveFullscreenControllerTest.MouseEventsVerticalDisplayLayout to fail on Chromium OS Ozone bots.
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Ozone%20Tests%20%281%29&number=3404
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/3405

Original issue's description:
> Remove deprecated cursor event filter for Ozone
>
> Removes the old filter in favor of the new one which is enabled
> by default on non-Ozone CrOS builds.
>
> BUG=none
> TESTS=ran ash_unittests --gtest_filter=MouseCursorEventFilterTest.* on an Ozone build and manually tested on link_freon
>
> Committed: https://crrev.com/cee48a5ba8c24eb8b8ea7f789e3025ac79549a4d
> Cr-Commit-Position: refs/heads/master@{#295169}

TBR=oshima@chromium.org,dnicoara@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/567413003

Cr-Commit-Position: refs/heads/master@{#295178}

This patch adds a field to the BufferedFileStreamReader constructor, which says
how much bytes in total are going to be requested. This information is used for
an efficient buffering strategy.

TEST=unit_tests: *BufferingFileStreamReader*
BUG=398338

Review URL: https://codereview.chromium.org/470323003

Cr-Commit-Position: refs/heads/master@{#295177}

This patch was generated by running the rewrite_scoped_refptr clang tool
on a ChromeOS build.

BUG=110610

Review URL: https://codereview.chromium.org/569173006

Cr-Commit-Position: refs/heads/master@{#295176}

Added at https://codereview.chromium.org/306753003 but not included into
the GN build.

R=brettw@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/581483002

Cr-Commit-Position: refs/heads/master@{#295175}

Notes for discussion:

1) This API provides a low level interface to Chrome's video decoders. Chrome's implementations differ by codec and platform. H264 and VPX expect very different formats, so the plugin must know details about these codecs. In particular, some parsing of the stream is required to extract the frames, and during Reset, the plugin may have to parse into the frames to find start points and make sure the decoder is in the proper state to resume. Some platforms may only provide software implementations. Software and hardware decoders have very different latency and throughput.

2) The PP_VideoPicture struct (in pp_codecs.idl) exposes low level details about the texture format of the decoded pictures so the plugin can render the textures. These are platform-specific.

  GL_TEXTURE_2D is the standard one.
  GL_TEXTURE_RECTANGLE_ARB will be used by Mac in the future (but is not yet used).
  GL_TEXTURE_EXTERNAL_OES is used on ARM ChromeOS systems.

Plugins should be prepared to handle all of them.

3) The plugin continually calls GetPicture to pump the decoder. There is a little weirdness with Flush, where we signal the end of stream by returning PP_ERROR_ABORTED to the plugin's last GetPicture call.

BUG=281689

Review URL: https://codereview.chromium.org/540393003

Cr-Commit-Position: refs/heads/master@{#295174}

R=dbeam@chromium.org,tbreisacher@chromium.org
BUG=393873
TEST=third_party/closure_compiler/runner/how_to_test_compiler_pass.md

Review URL: https://codereview.chromium.org/557633002

Cr-Commit-Position: refs/heads/master@{#295173}

This reverts commit bd1cc624.

Original CL:
Refactor ExtensionManifestTest to allow usage in src/extensions
https://codereview.chromium.org/572813002

Reason:
Broke the official Win builders due to differences in how they report their
version channel.
http://master.chrome.corp.google.com:8011/builders/win%20trunk/builds/26150

BUG=414917
TEST=unit_tests
TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/578653005

Cr-Commit-Position: refs/heads/master@{#295172}

BUG=402005

Review URL: https://codereview.chromium.org/571533004

Cr-Commit-Position: refs/heads/master@{#295171}

BUG=413853

Review URL: https://codereview.chromium.org/574153002

Cr-Commit-Position: refs/heads/master@{#295170}

Removes the old filter in favor of the new one which is enabled
by default on non-Ozone CrOS builds.

BUG=none
TESTS=ran ash_unittests --gtest_filter=MouseCursorEventFilterTest.* on an Ozone build and manually tested on link_freon

Review URL: https://codereview.chromium.org/580553002

Cr-Commit-Position: refs/heads/master@{#295169}

BUG=408637

Review URL: https://codereview.chromium.org/561983002

Cr-Commit-Position: refs/heads/master@{#295168}

If the SafeBrowsing service couldn't come up with a definite verdict for
some reason (e.g. couldn't reach the backend or encountered some error)
it would default to a verdict of SAFE. This in turn could cause a
download that would've been considered dangerous due its file type to be
considered safe. This change introduces an UNKNOWN verdict that the
SafeBrowsing service can use to indicate that a verdict couldn't be
determined.

Downloads then uses that signal to revert to the old behavior of
displaying a dangerous downloads warning based on the file type.

BUG=269157

Review URL: https://codereview.chromium.org/565053002

Cr-Commit-Position: refs/heads/master@{#295167}

If a profile is signed in, but has a default name (because this is after
enabling the new profiles UI but the Gaia profile name hasn't been downloaded)
display the email address rather than the default profile name.
It's one step better.

BUG=412809
TEST=Start Chrome with an empty user data dir and
--disable-new-avatar-menu. Create two profiles, and sign one of them in
with a profile that has a clean sync (or reset the sync data after signin).
Make sure that the last active profile is the *not* signed in one
(so close all the browser windows for the signed in profile). Restart Chrome
with --enable-new-avatar-menu. You should be in the local profile. Choose "Switch
person" from the avatar menu. The user manager should display the other profile's
email address in the pod. Once you launch that profile, the name should update to
the gaia name.

Review URL: https://codereview.chromium.org/556003007

Cr-Commit-Position: refs/heads/master@{#295166}

Revert of Set the javac target and source to 1.7 (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/545363002/)

Reason for revert:
Not all bots have Java 7 yet :(

Original issue's description:
> Set the javac target and source to 1.7
>
> BUG=336589
> TBR=yfriedman@chromium.org
>
> Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b
> Cr-Commit-Position: refs/heads/master@{#295162}

TBR=cjhopman@chromium.org,yfriedman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=336589

Review URL: https://codereview.chromium.org/579543003

Cr-Commit-Position: refs/heads/master@{#295165}

include_next must be outside the include guard!

When naclports builds a package, it copies the headers from
$NACL_SDK_ROOT/include/$toolchain directly into the toolchain include
directories (i.e. toolchain/linux_x86_newlib/x86_64-nacl/usr/include).

This means that the same header is included twice in the header seach path,
e.g.:
$NACL_SDK_ROOT/include/newlib/foo.h
$NACL_SDK_ROOT/toolchain/linux_x86_newlib/x86_64-nacl/usr/include/foo.h

If include_next is inside the include guard, then the full include chain for
that header name will not be followed (it will stop when it hits the same
include guard).

BUG=none
R=bradnelson@google.com, sbc@chromium.org, bradnelson@chromium.org

Review URL: https://codereview.chromium.org/577763002

Cr-Commit-Position: refs/heads/master@{#295164}

the fly.

Instead register a new Dictionary,
browser.app_window_placement, at startup and put apps'
placement/size info in sub dictionaries.

Also migrate values from the old dynamically-registered
preferences to their new statically-registered home.

BUG=167256

Review URL: https://codereview.chromium.org/511393003

Cr-Commit-Position: refs/heads/master@{#295163}

BUG=336589
TBR=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/545363002

Cr-Commit-Position: refs/heads/master@{#295162}

I'm reasonably confident that all of the seccomp-bpf/*.h files are now
IWYU clean. There might still be some missing/superfluous #include lines
in some of the .cc files, but it should overall be much better than
before.

Two particular changes to note:

1. "base/basictypes.h" is deprecated in favor of <stdint.h> (for standard
*int*_t types) and/or "base/macros.h" for DISALLOW_*() macros.

2. This also moves the #include "foo.h" lines to the top of each foo.cc
file, per style guide.

BUG=408845

Review URL: https://codereview.chromium.org/570163003

Cr-Commit-Position: refs/heads/master@{#295161}

The code will continue to load the 200P pak file and fall back to those
resources, but the supported scale factor on @3x devices will now be 300P.

This CL adds a unittest to ensure that image conversion works properly when the
scale factor of the source image does not match the current supported scale
factor of the system.

BUG=413300
TEST=None

Review URL: https://codereview.chromium.org/574663003

Cr-Commit-Position: refs/heads/master@{#295160}

The previous fix for positive start times http://crrev.com/93c37f1b is
incomplete. It fixed seeking, but did not fix rendering. As such, the
media timeline will start playback from 0 and advance in real time to
any positive start time... even if the actual start is hours away.

When testing I used a test clip with a short positive start time so
did not notice the issue.  In attempting to write a layout test, I
retested with a larger start time which revealed the deficiency in my
first solution.

This change reverts the removal of Demuxer::StartTime() with the added
restriction that it must always be positive.  Pipeline uses this time
like it did before, during initialization and as a minimum bound for
seeking.

BUG=413292
TEST=four new tests! layout test forthcoming.

Review URL: https://codereview.chromium.org/575643002

Cr-Commit-Position: refs/heads/master@{#295159}

specified.

BUG=409724
TEST=SplitViewcontrollerTest.SplitModeActivation

Review URL: https://codereview.chromium.org/573803003

Cr-Commit-Position: refs/heads/master@{#295158}

BUG=none
TEST=cq
TBR=brettw

Review URL: https://codereview.chromium.org/576653003

Cr-Commit-Position: refs/heads/master@{#295157}

BUG=414467

Review URL: https://codereview.chromium.org/567643003

Cr-Commit-Position: refs/heads/master@{#295156}

Previously the local NTP thumbnails were stretched. We now make preserve
ratio preserved by setting height to "auto", but keep min-height to 100%
so if thumbnail is too short we won't see blank space.
To accommotate Material Design thumbnails, we make stored thumbnails
taller. In the thumbnail <iframe>, the extra height is hidden from view.

BUG=414878

Review URL: https://codereview.chromium.org/564973003

Cr-Commit-Position: refs/heads/master@{#295155}

This should increase the quantity of perf profiles collected for
chromiumos-wide-profiling by a factor of 8. Based on the current amount of
data received, this should increase the number of profiles collected to a
quantity less than it was before the collection scheduling was changed in
https://codereview.chromium.org/282093011/

TEST=Not really... This is just turning a knob. I did compile it.
BUG=chromium:413951

Review URL: https://codereview.chromium.org/559843007

Cr-Commit-Position: refs/heads/master@{#295154}

CreateTrailsFromString function accepts values for trails_string argument without last separator symbol

BUG=401298

Review URL: https://codereview.chromium.org/452923003

Cr-Commit-Position: refs/heads/master@{#295153}