- 05 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/555a304caa85..f9b4bfac44f9 git log 555a304caa85..f9b4bfac44f9 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-05 lamontjones@chromium.org api: recompile protos 2020-02-05 vapier@chromium.org gerrit_unittest: fix cookies_path reference 2020-02-04 ahassani@chromium.org cros-update.py: Execute scripts out of /usr/local/tmp/cros-update Created with: gclient setdep -r src/third_party/chromite@f9b4bfac44f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I05edef749819d97142466699fd315be069a51558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738565}
-
Friedrich Horschig authored
As described in the linked bug, the adapter assumed WindowAndroid to never be null which causes a crash. With this CL, the view will be initialized early on and if WindowAndroid is nullptr, the creation of the view (and the adapter) will be aborted. To do that, the unused constructor parameters for label width and length were removed. Bug: 1048849, 1049090 Change-Id: I60151a560907a984ba4e45ee949624400b8f86da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037672 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738564}
-
kylechar authored
Somehow ReadPixelsContext::request is null once it reaches OnRGBAReadbackDone() done. Add some checks to figure out how that can happen. Bug: 1048251 Change-Id: If74854b5b332b1af347647c4c1c234e995afa944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037846Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#738563}
-
Daniele Castagna authored
|origin_rect| in RemoveOverdrawQuads is currently not used for anything useful. This CL removes it. Test: viz_unittests Change-Id: Ie60f6a57699f1c100a7966ed6bb80fcd271b71bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037856Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#738562}
-
Sebastien Marchand authored
This metric will be used to understand the state of the system when memory pressure happens. More metrics will be added to this new MemoryPressureMetrics class later on. Change-Id: I2551c1ae5a36913a339ebbe4724d1637044b34f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028170 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#738561}
-
Shakti Sahu authored
This CL separates the public interfaces from the internal code of background task scheduler's Java code. 1 - The public classes/interfaces are left at top level components/background_task_scheduler while the implementation code is moved to internal/ 2 - Internal code is moved to a separate package as well. 3 - The factory will be a separate target that depends on public and internal. 4 - Some classes need to be referenced from both chrome/ and internal code, e.g. BackgroundTaskSchedulerFactory, Uma classes, SharedPref. To handle this, have two classes, e.g. BackgroundTaskSchedulerFactory and BackgroundTaskSchedulerFactoryInternal We should probably move the NativeBackgroundTask as well to components/ which will greatly help the dependent code to live in components/. Will think about it in a future CL. Bug: 1045765 Change-Id: Idddb3ed33789a735e920f33b7c0f3cb40e5e844a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021857 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#738560}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b55270f60f58..1f50e6be1c2a Created with: gclient setdep -r src-internal@1f50e6be1c2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia2ad12a58508eb7a955b269b921547b789bf26e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038187Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738559}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c3a1fc08224..712ebbb5b73b git log 7c3a1fc08224..712ebbb5b73b --date=short --first-parent --format='%ad %ae %s' 2020-02-05 philipp.hancke@googlemail.com disallow pairing ICE-TCP with a local ip address Created with: gclient setdep -r src/third_party/webrtc@712ebbb5b73b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1038754 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie876a93f29a350a7ffb7416f4fca3566c57d90bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038751Reviewed-by:
-
Mark Yacoub authored
If the device supports atomic APIs, Disable the CRTC using Atomic Modeset Commit instead of legacy API. BUG=987274 TEST=HardwareDisplayControllerTest.CheckDisableResetsProps, HardwareDisplayPlaneManagerAtomicTest.CheckPropsAfterDisable Change-Id: I79350079c73aa4d852354244b0eca282a63ac632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037712Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#738557}
-
Navid Zolghadr authored
Feel free to revert if it causes any regressions. Bug: 1000682, 1043966, 1006789 Change-Id: Idff11fb11513cbdfc2249e7822a26f3649f7a22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024540Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738556}
-
Michael van Ouwerkerk authored
Bug: 1049055 Change-Id: Ic4d0ed82c68a3a9105a50b112f8472a4f8272392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036106Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#738555}
-
Himanshu Jaju authored
Tests the public interfaces of WebRtcMessageHandler and its interactions with SharingServiceHost. Bug: 1021987 Change-Id: I6826dbf5ac6306ba2364517e19a06c142d9c13b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038695Reviewed-by:
-
Hitoshi Yoshida authored
We used to use a pseudo type "ScriptValue" instead of object type in code generator. But it doesn't work well in complex cases, e.g. sequence<object?>. This CL separate them, and makes "object" type work as it is. Bug: 839389, 1047081 Change-Id: I6dfa17459c1e88a2f441064afc11dca056169ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035480Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#738553}
-
Morten Stenshorne authored
The failure / skip expectation lines were copied from non-virtual TestExpectations, FlagExpectations/layout-ng-fragment-item and NeverFixTests. No failures were introduced by enabling LayoutNGFragmentTraversal itself. Bug: 1043787 Change-Id: I26a8cff3a700abbb076e309d5162c1da3440136b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036096Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738552}
-
arthursonzogni authored
There were two methods used to upgrade insecure requests: - ShouldModifyRequestUrlForCsp - ModifyRequestUrlForCsp This patch move them to the network service. A slight rename to make them clearer - ShouldModifyRequestUrlForCsp => ShouldUpgradeInsecureRequest. - ModifyRequestUrlForCsp => UpgradeInsecureRequest. Note: - IsOriginSecure is replaced by IsUrlPotentiallyTrustworthy. The previous one is deprecated. - This removes the dependency of content/common/content_security_policy/* over content/common/origin_util.h. This was preventing the first directory from being merged into the network service. - The argument |is_suresource_or_form_submssion| was always used with 'true'. It has been removed. Bug: 1021462 Change-Id: I10d200ec389242ac8854c97585bdc4c42010467c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038651 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#738551}
-
Oriol Brufau authored
Outside markers behave out-of-flowish, so their intrinsic contribution to the list item should be 0. In legacy, this is done by adding negative margins, so that the width of the marker plus its margins are 0. However, when calculating the intrinsic contributions of the children, the code uses the margins in the computed style, not the margins of the box. Therefore, the marker code used to replace the computed style with another one that had the changed margins. This approach was error-prone, for example special care was needed to reapply the previously calculated margins when the computed style changed, in order to avoid triggering unnecessary layout. However, this caused a problem: if 'list-style-position' changed, the old margins were preserved. But the margins depend on whether the marker is inside or outside! This patch fixes the problem and stops changing the computed style of the marker. For inside markers, margins don't depend on the size of the marker, and they were already applied to the computed style in style_adjuster.cc, so they work well. For outside markers, the patch skips them when calculating the intrinsic size of the list item. Bug: 1048672, 457718 TEST=external/wpt/css/css-pseudo/marker-intrinsic-contribution-001.html TEST=external/wpt/css/css-pseudo/marker-intrinsic-contribution-002.html The former test fails in LayoutNG because trailing marker spaces are not preserved, and fails in legacy due to the lack of 'content' support. Change-Id: Ic21603e9fe1b17b11237286dac3f207b1837a07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035962Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ec816af6e720..9c62f66c7235 git log ec816af6e720..9c62f66c7235 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 540662253ea3..b82ed734e767 (1 commits) Created with: gclient setdep -r src/third_party/angle@9c62f66c7235 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Iadfab14bc0292d6f75eafe0f38c99c7ad6754562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038183Reviewed-by:
-
Mikel Astiz authored
This is a reland of f52179a5 The feature was disabled by default before branching because some implementation parts were missing on Android. Original change's description: > Enable sync trusted vault support by default > > The feature is in a working state can be enabled by default. > > Bug: 1000146 > Change-Id: I66ef6f65d97234f47eaa76d1daafb8d3637692ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000702 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731898} Bug: 1000146 Change-Id: If2c11c87bbc021daaa6656f9e85b592302dd8327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035966Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738548}
-
Anton Bikineev authored
This is needed to prevent races in generational barrier and concurrent sweeper. Bug: 1029379 Change-Id: I80b7ece9a0b5d7c15844f220070833242125147c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005029Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#738547}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I9abd5f1f12d91ec58ae57aacfb0522c47a9d6ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038186Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0f6bcd18b2ef..7c3a1fc08224 git log 0f6bcd18b2ef..7c3a1fc08224 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 eshr@google.com Move initial quality experiment to adaptation module Created with: gclient setdep -r src/third_party/webrtc@7c3a1fc08224 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3891d05882c337bdbf19058102a87a6a6023cb3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038750Reviewed-by:
-
Michael Thiessen authored
This change locks the SchemeRegistry on first use, which required refactoring url_util.cc to differentiate between SchemeRegistry use for adding Schemes, and SchemeRegistry use for using Schemes. Tests can now only modify schemes after initialization by calling url::UnlockForTests(), which creates a scoped object that resets the schemes, so tests can't mistakenly leave global scheme state modified. This change required changes to browser startup to decouple scheme registration from ContentMain, found here: https://chromium-review.googlesource.com/c/chromium/src/+/1945926 Doc: https://docs.google.com/document/d/1kDKqBaq-b6EbUm0F4ea7ARoksUcj1KUx3qxFuSXEwM4/edit Bug: 783819 Change-Id: Idcac37ccae297735176eba20b50ced3f9e63f9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901591Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#738544}
-
Julian Pastarmov authored
This reduces the number of individual writes to the file and sets maximum update rate of 6 writes per minute. BUG=1013546 TEST=components_unittests:LoopbackServerTests Change-Id: I40a51051b449dd8f88582420f78079dd2187bd58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940687Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#738543}
-
Thomas Tellier authored
Bug: 1022758 Change-Id: I1d19aac9d03a75f220329aa27db96d45be347a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035673 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738542}
-
Javier Ernesto Flores Robles authored
This reverts commit 960c8468. Reason for revert: This breaks password breach and crashes due the coordinator never been register with the dispatcher. Bug: 1046346, 1048612 Original change's description: > [iOS][coordinator] Modernize Password Breach Coordinator. > > This CL modernizes the PasswordBreachCoordinator > - to use the superclass -initWithBaseViewController:browser: > initializer, > - to remove the public property for dispatcher, > - to update the naming and usage of ‘dispatcher’ parameters to > match the usage guidelines. > > Bug: 1029346 > Change-Id: I26064ad9d0cf024185a28c33483db5631c4c7cd7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000626 > Commit-Queue: Nazerke Kalidolda <nazerke@google.com> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731997} TBR=marq@chromium.org,stkhapugin@chromium.org,nazerke@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1029346 Change-Id: Ic02febc7d647d55ae893fb07117d81a76b1a17d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038770Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#738541}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f045c94a5ad1..d2b2837f5716 git log f045c94a5ad1..d2b2837f5716 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 fmayer@google.com Merge "Make ExperimentalFlamegraphNodesTable::Row init more explicit." Created with: gclient setdep -r src/third_party/perfetto@d2b2837f5716 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I31ed0aa8058744553cc71330fae475df2836ffed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038184Reviewed-by:
-
Mikel Astiz authored
This reverts commit b50b951d. Reason for revert: suspect of causing crashes in tests, e.g. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/60586 Original change's description: > [Tab Groups] Hide separator for tab next to a named header. > > Bug: 1046554 > Change-Id: I79f37516e26aeb0fea7261b20082c7f882485918 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036483 > Reviewed-by: Connie Wan <connily@chromium.org> > Commit-Queue: Charlene Yan <cyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738308} TBR=cyan@chromium.org,connily@chromium.org Change-Id: I586becb5914e17465a8849d6aa93c73b77c2fdd3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1046554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035896Reviewed-by:
-
Artem Sumaneev authored
BUG=chromium:1039304 TEST=None Change-Id: Ie8d3c5e858671aac80415dcb1cf8f90436513f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036004Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Artem Sumaneev <asumaneev@google.com> Cr-Commit-Position: refs/heads/master@{#738538}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I2f6a77de1c6d32682e5caa81bd673e3250d9b460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038155Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738537}
-
Maria Kazinova authored
Primarily to let it keep track of fields that have user input. Done via sharing FieldDataManager between AutoFillAgent and PasswordAutofillAgent. It was done to fix the problem of some user input not being saved when the page was changed at the moment of submission. The saving criteria was changed and interaction with FieldDataManager was added to always check for user typed input in addition to less trustworthy criteria (i.e. focusability that can be changed at the moment of submission). This is a fix for a previously reverted CL. Previous CL reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/1991623 Now the saving criteria is milder. Bug: 957444, 1006745 Change-Id: I902e734600d5818a984ad12e310b6cd821bc51e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035983Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#738536}
-
Wez authored
ScopedRunTimeout is intended to be used to fail tests if a loop is Run() for too long, rather than to Run() the loop for a specific length of time. Clean up some tests which were using ScopedRunTimeout inappropriately. TBR=gab,xiyuan,mmenke Bug: 1021777 Change-Id: I42e72bb4a2a69f4eff3c84dbaf56dfaf975c86d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036009Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#738535}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b350d45696f..b55270f60f58 Created with: gclient setdep -r src-internal@b55270f60f58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045478 Tbr: jbudorick@google.com Change-Id: Id1ae9ce8b9f5889bb4534d8920c16f430062e86d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038182Reviewed-by:
-
Hazem Ashmawy authored
Add the button to change WebView provider as a neutral dialog button instead of overriding the existing positive button to open the correct WebView DevUI. This error dialog is shown when the dev ui is launched from a package that is different from the selected as the system's webview provider. Fixed: 1041606 Test: Manually change WebView provider and go back to wrong dev ui, inspect the dialog to see the two buttons Change-Id: I21e8f5f4b2d3b9d9c608df0abbe299442e2e9453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036068Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#738533}
-
Yuzu Saijo authored
This CL changes DCHECKs to CHECKs in ServiceWorkerVersion::Restore ControlleeFromBackForwardCacheMap to figure out the cause of the crashes. Bug: 1021718 Change-Id: Ifdfe7772466b24ce18366d66895152b132b929c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035529 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Auto-Submit: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#738532}
-
Vladislav Kuzkokov authored
Bug: 1033439 Change-Id: I120e7c80f9a8a2f927f6aee0a57c8f3aa56614ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036181Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738531}
-
Mikel Astiz authored
Sample build failure where both failed: https://ci.chromium.org/p/chromium/builders/ci/win-asan/10148 TBR=benwells@chromium.org Change-Id: Iecc7d75fd41e2ded960ffdfd9e6f5f7bf3b3c8d0 Bug: 1048980,1049036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036069Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc3307c395e2..c631b7cc5f8c git log bc3307c395e2..c631b7cc5f8c --date=short --first-parent --format='%ad %ae %s' 2020-02-05 ehmaldonado@google.com Fix error on PRESUBMIT PostUploadHook Created with: gclient setdep -r src/third_party/skia@c631b7cc5f8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042324 Tbr: scroggo@google.com Change-Id: I353143759f21a32f771a83135386af05645a0ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038129Reviewed-by:
-
Maggie Chen authored
The Vulkan spec 1.2 and the Vulkan loader 1.2 were released in January 2020. Bug:775983 Change-Id: Ide4c904d210cd2d0e37c84f23b8a59f63c9f08c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037848 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#738528}
-
Rushan Suleymanov authored
Propagate specific error codes when commit failed from CommitContributor to ModelTypeSyncBridge. Bug: 1047123 Change-Id: I118ce292bb6c27049099334f12dab0f75da9d059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030903 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#738527}
-
David Jean authored
In the case of manual password saving, we need to skip the 'save password' infobar banner and let the user click the key badge to manually save or update the password. We also need to be able to remove the badge if user removes password. I've kept the badge handling as is, tied with the banner and infobar, even though we skip the banner. Works only for info reboot ui. Can be demo tested by patching 2012031 over this. Bug: 1045431 Change-Id: I0b208467910311ab0c86c4b90da593bb1827f93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019267 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
