- 07 Dec, 2020 40 commits
-
-
Joon Ahn authored
animation is per element without chaining as noted in the bug. Bug: 1155674 Change-Id: I42cc7447c2552007a37ab01c0d22ab7a143a912b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575719Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#834272}
-
Koji Ishii authored
This is probably because of <crbug.com/1152696>, where we call |PositionForPoint| after running even handlers. Bug: 1155733, 1150362, 1152696 Change-Id: I4ec0a685fa0507da2536d9cbff5d1e8da5076bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574557Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#834271}
-
Akihiro Ota authored
After 20 seconds of inactivity, a hint to activate ChromeVox will be announced and shown on screen. Design docs can be found in the crbug. This change also adds a suite of tests for the feature. Lastly, this change adds a Chrome OS feature which can be used to enable/disable the behavior. This is added just in case we want to toggle the behavior in the future. ChromeVox will be announced and shown on screen. Bug: 1124075 Change-Id: I35b82b3c76db89a7f30c2f31029f0d0e29ebd37d AX-Relnotes: After 20 seconds of inactivity, a hint to activate Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488081 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#834270}
-
Jan Krcal authored
This CL aligns the size of the WebUI back button with the mocks and thus also with the size of the native UI back button. Bug: 1126913 Change-Id: I72857d1a9cf870f75f0e0f16bd58f75544063c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577362 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#834269}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/682b3e2b91af..95a2d3216488 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC avi@google.com,grt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: avi@google.com,grt@google.com Change-Id: I59b81fc27bdb63672995c7dc4179c91c6cb7eb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577523Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834268}
-
Andy Paicu authored
This is needed in order to facilitate testing the feature. Bug: 1138595,1155511 Change-Id: Ib01969e48e5686b3ffed963745c5e85a1d802221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573076 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#834267}
-
adamta authored
Creates view controller to wrap Discover feed returned by Mulder. Will be used as the primary NTP scroll view so that feed scroll actions could be detected and to expose certain properties. Bug: 1114792 Change-Id: I8ee9160b70234c1e25e9a5ea721d8982b84b5f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576416 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#834266}
-
Raymond Toy authored
Previously, in BaseAudioContext::Clear() we called GetDeferredTaskHandler().ClearHandlersToBeDeleted(). But this was also called in DeferredTaskHandler::ContextWillBeDestroyed(), which is called in BaseAudioContext::~BaseAudioContext(). There's no need to call this twice while handling the audio context going away. Manually verified that the tests from issue 1125635 and 1153658 work, and the deadlock in issue 1136571 is gone. Bug: 1150065, 1153658 Change-Id: Iee15c31dc637bf82d66bfd79d5238b1f80813153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575418 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834265}
-
Bruce Dawson authored
Crash analysis suggests that items are being removed from the children_ vector while we are iterating over it. This can easily turn into an infinite loop as the iter == end condition is never met, and calling destructors on bad objects leads to confusing crashes. This checks for that condition in order to validate the theory and get closer to understanding these crashes. Bug: 1152152 Change-Id: If30d7943e3f6d69ec000a82b656b5086e21bb7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576034 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#834264}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607331580-48b245bff1ba8e6eb069e7a15838de53304e6a37.profdata to chrome-win64-master-1607341806-af6783e2515ff922f8cbb2f88290f0ca953ce5b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4d110c4b09cb1753ad3aa97fbc4494699f873a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834263}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c56ea91f6bd1..e1502e7972cb 2020-12-07 treehugger-gerrit@google.com Merge "metrics: Add test for combined_overall_rail_slices table" 2020-12-07 fmayer@google.com Merge "Update gen_bazel to set $(location CHANGELOG)" 2020-12-07 primiano@google.com Merge "MSVC + clang-cl: logging, VA_ARGS, popcount" 2020-12-07 lalitm@google.com Merge "docs: add docs with final expected state of checkpoint atoms" 2020-12-07 fmayer@google.com Merge "Return GetBuildId by reference." 2020-12-04 primiano@google.com Merge "Migrate comment to new proto_logging directory" 2020-12-04 primiano@google.com Merge "Use Soong to strip and dist trace_processor on host." 2020-12-04 treehugger-gerrit@google.com Merge "Small changes to make the codebase more Win friendly" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2d9f027632ea012356d84b8a322f56261351f5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577522Reviewed-by:
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /base/android/java/src/org/chromium/base. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=torne@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: I97b895b6d9065d2d040e07528d5e2f84b4fba5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575371 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#834261}
-
Batalov Vladislav authored
This test is flaky. Bug: 1154612 Change-Id: Ic91eb710a08f57f6d51b192ede05371012436ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574941Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#834260}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6ec4b0985f592f78cc9c6ab995cec62159fed748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576428Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#834259}
-
Etienne Pierre-doray authored
Context: Several worker_threads are woken up. Meanwhile progress is made and the desired number of workers is reduced. Problem: the first worker to wakeup will go back to sleep, even if it could pick up work. This effectively increase latency before work is picked up. Expected: a worker that was just woken up should pick up pending work. Fix: Avoid using GetDesiredNumAwakeWorkersLockRequired() to make a decision of going back to sleep. |max_tasks_| is used instead. If a worker is active and sees available work, it should *always* pick it up, unless prevented by |max_tasks_|. Drive by: call CanGetWorkLockRequired for early exit. There's no point attempting to wake up additional workers if the current worker was going back to sleep. Change-Id: I7c7243046372ec99444320256f2df8d32e0d07a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568903 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#834258}
-
Leonard Grey authored
Right now, this just caches the folded input string, but it's in anticipation of a new algorithm that will want to hold on to scratch space in between invocations. Why not just make one and pass it to all of the command sources: There's not *that* many sources, and it will complicate the interface. I'd rather revisit it later if it ends up being a problem than take on the extra complexity now. Doing it per source, OTOH, is a clear savings since some sources can have many candidates. Bug: 1014639 Change-Id: I85124976e50f0d0bcc33b307567738e97bee63d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575857Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#834257}
-
Rakina Zata Amni authored
With a flag, we can control which params we verify in which releases, so we won't block releases if we found inconsistencies with certain params. Bug: 1155414 Change-Id: I1fb608e20f1bc22025b12a5ec21d000151acb21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574649 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#834256}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607320769-266f8d6f8ffba3874a821f44f98b77515c76c883.profdata to chrome-win32-master-1607331580-9909f67f911bba407df7ff9d177d8d5f0f5ef14c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia000e8e60ef016dd4a5ef3d8a90d430180370164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577434Reviewed-by:
-
Jana Grill authored
Add the device type placeholders to IDS_RELAUNCH_REQUIRED_BODY, IDS_RELAUNCH_RECOMMENDED_BODY and IDS_RELAUNCH_RECOMMENDED_OVERDUE_BODY, replacing them with the actual device type in code. Additionally adjust the domain placeholder names and descriptions and add screenshots to make it easier for the translators to understand the usage of the texts. The domain placeholder is already populated using BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager, so no change was needed there. Bug: b:172682102, b:172682697, b:172682411 Test: Manual Change-Id: I1eeaaa279d2f59b6b4a9c51367bdeaf29821f72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570574Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#834254}
-
Justin Cohen authored
Correct NSUserActivityTypeBrowsingWeb handling for default browser. Bug: 1156134 Change-Id: I2595889731e71c8039f982122c64e044e5df64bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575151 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834253}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I28cb6fd06c75830df56db0f2c98ce289127c9abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552199 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834252}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I65e29c92f5c7bdc6a985391e076cb408895086e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551488 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3b959c00071..512ff75a0bad 2020-12-07 fmalita@chromium.org [svg] Initial <tspan> support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I12c35c858bcd98479b8d9126d871f6da65cd72b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577524Reviewed-by:
-
Clark DuVall authored
This reverts commit 9124dffe. Reason for revert: Breaking Android N: crbug.com/1156018c Original change's description: > Preload chrome split on startup > > The chrome split can take a long time to load, so we get significant > improvements in startup time if this work is offloaded to a background > thread. Ideally, we would give as much time as possible to allow this > preload to finish, which means running as much code as possible which > does not depend on the chrome split during the preload. This required > refactoring much of attachBaseContext into the base module, and moving > the pieces which could not be easily moved to the base module into > onCreate. > > The order of startup generally goes: > 1. Application.attachBaseContext > 2. Each provider is instantiated in order, and onCreate is called > 3. Application.onCreate > > If a provider lives in a split, it will call createContextForSplit on > the application. This will end up being the first thing needing the > chrome split, which will wait for the preload to complete. This is why > ChromeFileProvider was moved to the base module, so there could be more > time to preload. > > Pinpoint runs: > Pixel 2: https://pinpoint-dot-chromeperf.appspot.com/job/16925180d20000 > -7% messageloop_start_time > -3% first_contentful_paint_time > -3.8% navigation_commit_time > > Android Go: https://pinpoint-dot-chromeperf.appspot.com/job/115e53e7520000 > -18.7% messageloop_start_time > -1.5% first_contentful_paint_time > -2.1% navigation_commit_time > > A couple notes: > - setUsageAndCrashReportingFromNative was removed from UmaUtils because > it is never used, and allowed for much more easily bringing UmaUtils > into the base module. > - I wanted to make sure PureJavaExceptionHandler is still set up as > early as possible, so left it in attachBaseContext. This required > loading PureJavaExceptionReporter by reflection if an exception > happens, since it has many hooks into chrome code. > - MainDexApplicationImpl is no longer needed since all the common code > was moved to SplitCompatApplication > > Bug: 1150600 > Change-Id: Idd6c11293e47fa5e8bd6eb30c14535e60c204867 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570125 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833923} TBR=agrieve@chromium.org,cduvall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1150600, 1156018c Change-Id: I598c20df8c0f85536c83926642b13b8a8b207cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577540Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#834249}
-
Alex Turner authored
base::Bind is deprecated and should be replaced with the more explicit base::Bind{Once,Repeating}. The vast majority of this directory was already migrated, but a few uses remained, which this cl fixes. Bug: 1141533, 1007792 Change-Id: I4cbc94d654f23809c7b0de0b31a84d0e4dd0e659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561578Reviewed-by: -
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ea969d287bfe..0f0bcb39f3fc 2020-12-07 hta@webrtc.org Declare BaseChannel::media_channel_ const If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I411c20bfceff8eb7a59b6df70cfa4f06b414d7e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577519Reviewed-by:
-
Alexis Hetu authored
This cl changes the software backend used for running viz_unittests and cc_unittests from SwiftShader GL to SwANGLE (ANGLE on SwiftShader Vulkan). Other tests suites may be affected. From this cl, performance expectations for test runs will likely change. For example, cc_unittests appears to run faster, while viz_unittests and views_unittests appear to run slower. Note that this is still using the validating command decoder, and once the OOP Raster tests can run on the passthrough command decoder, we'll be able to use it and gain some performance on all these test runs. Bug: chromium:1060139 Change-Id: Ia243f05f3e9f54dc6f6dfaa3041021fc28818b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532042 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#834246}
-
Morten Stenshorne authored
Unless block-size constraints prevent it, attempt to make a multicol container at least as tall as its tallest piece of unbreakable content. This almost worked correctly, but not if the multicol container was nested inside another fragmentation context. It would then be constrained by the space left in the outer fragmentainer (in the case of the tests now fixed that was 0 space left). Don't attempt to make it shorter than the tallest piece of unbrekable content here, as that would actually make it (the multicol container fragment itself) fit in the current outer fragmentainer (while its contents would overflow), rather than breaking before the inner multicol container and retrying in the next outer fragmentainer. Bug: 829028 Change-Id: I94942832d6ac15ed2cfa96719810db702fea84a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576254Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#834245}
-
Xianzhu Wang authored
Previously empty viewport triggered DCHECK failure in user environments. Bug: 1155943, 1153428 Change-Id: I15f784a3196d412621a2ab7a4e9bf99f2efe133a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576777 Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834244}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdb2247e82e..c56ea91f6bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I542d5f2d15e2765c4b47088d4a3d74dff334c919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577539Reviewed-by:
-
Liviu Tinta authored
With an OOPIF, if the compositor cannot find a scroll node at all, then just ack the scrolls to the browser so they can be bubbled up to the parent frame. Taking this opportunity to do some cleanup (see comments on this CL for details): - Use ScrollThread::SCROLL_IGNORED for bubbling scrolls - Stop using ScrollThread::SCROLL_UNKNOWN, and instead use ScrollThread::SCROLL_ON_MAIN_THREAD or ScrollThread::SCROLL_IGNORED - Remove EventDisposition::DID_HANDLE_SHOULD_BUBBLE - Remove InputEventResultState::kConsumedShouldBubble (use InputEventResultState::kNotConsumed instead) - Rename ScrollStatus.bubble to ScrollStatus.viewport_cannot_scroll (use ScrollThread::DROP_EVENT if this is set to true) Bug: 1086625 Change-Id: I9aef88ed8fb7e8fb2aff8e1a478e10c402553b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562796Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#834242}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/698d1c0a0acb..3a59f15a6efc 2020-12-07 kimanh@chromium.org [LMI] Prettify buttons in LinearMemoryNavigator 2020-12-07 kimanh@chromium.org [LMI] Use arraybuffer-based types when opening the LMI 2020-12-07 tvanderlippe@chromium.org Report warnings instead of errors for missing method implementations 2020-12-07 mathias@chromium.org Clean up front_end/host/InspectorFrontendHost.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110202 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If114822611853340c0478ed3b4726ca6b5b6f48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575734Reviewed-by:
-
Jaeyong Bae authored
Currently, flex with CSS-wide keyword is serialized by shorthands. We should serialize into longhands per spec. So that it should include flex-basis, flex-grow, and flex-shrink properties. Bug: 1149779 Change-Id: I2431f89ac878d6d50686ce9faa75f9f4dd13f6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550331 Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Cr-Commit-Position: refs/heads/master@{#834240}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/00b77a80ab13..b8a3078bbec9 2020-12-07 bclayton@google.com Remove DAWN_USE_NEW_TINT_TRANSFORM_API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: Iad6a03005bead9363d8d796b28e1db979bcd1924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577516Reviewed-by:
-
Jordan Oroshiba authored
Bug: 1152891 Change-Id: I7286e35769fb66f3cc6792d9ae7dc0bfd460b35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537774Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Jordan Oroshiba <oroshiba@google.com> Cr-Commit-Position: refs/heads/master@{#834238}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202012070600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/fVqrzqnejoxXKgP8Q1x8KnBeyt9BgTlveT3nQam6WDsC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021 Tbr: help-app@grotations.appspotmail.com Change-Id: If279a3cf6f01fdadbf9f6ce195fd96b8066ec904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577521Reviewed-by:
-
Stephen McGruer authored
Bug: 997202 Change-Id: I45beb9e0ea3b0a905295e312664d010078306119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575452 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#834236}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdb2247e82e..c56ea91f6bd1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6835b8c264aac27bb990bb2a2a365ac539b0a58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575955Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8295f4267ab3..7bdee1ac459a 2020-12-05 drinkcat@chromium.org Revert "licensing: add ISC as notice-required" 2020-12-05 nerv@google.com usergroup_baseline: Add ap-process-manager to gwifi If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ib51a0b9fa97c3563d40753796dcb2d92999ff4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577518Reviewed-by:
-
Stephen McGruer authored
Now that blinkpy has basic support for fuzzy reftests, we can enable a bunch of tests. Most of them had slightly incorrect metadata, likely because reftests confusing interpret a single value N as a range of N-N rather than 0-N. Bug: 997202,1076121 Change-Id: Ic0bf778cde8996089ef48a4c4307a56f56ee8ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575206Reviewed-by:
-
