- 27 Jul, 2020 40 commits
-
-
Jonah Ryan-Davis authored
This logic was being duplicated on Mac because of an earlier change. Bug: chromium:914976 Change-Id: I724c3447f9ed50c54e0e448e994a74f693f05168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316150Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#791869}
-
Evan Stade authored
This test aborts if the OSK doesn't seem to work, which can be the case when a hardware keyboard is present. I found no better way to determine if the soft keyboard is disabled or force it to be enabled. The CQ bots appear to run with a soft keyboard and no hard keyboard, so they should run the test to completion. The presence of the OSK is verified by checking the size of the content when not in fullscreen, behavior that has always worked. This is because the behavior under test is respecting the OSK size when the content *is* in fullscreen, so aborting based on fs behavior would not have caught this bug (the bug would have made it seem as if there were no OSK). This is split off from the fix in case the test turns out to be flaky. Bug: 1107651 Change-Id: I803a67a4adef0bc4ee19b70a4d2ebd3126cd632f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315425Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#791868}
-
Boris Sazonov authored
Removes test asserts verifying ChromeSigninController state where it is redundant - both SigninFragmentTest and SigninSignoutIntegrationTest verify ChromeSigninController.isSignedIn after checking IdentityManager.hasPrimaryAccount, which is now the source of truth for the sign-in state. Bug: 1046412 Change-Id: I4ca41bc2c838a37e31a957390efc75cedac4202d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317212 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#791867}
-
Alice Wang authored
This CL changes the method AccountPickerCoordniator.Listener#goIncognito to default as it is not needed for all implementations of the listener. The non necessary empty implementations are also removed. Bug: 1093795 Change-Id: I5882d9c35294d2b9de9a59d1e76e5673df7250ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317799 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#791866}
-
Jonah Ryan-Davis authored
This reverts commit f844efb2. Reason for revert: Removed additional tests from commit Original change's description: > Revert "Explicitly name webgl/2 conformance tests on Windows" > > This reverts commit 539778cf. > > Reason for revert: not enough HW capacity for more tests > > Original change's description: > > Explicitly name webgl/2 conformance tests on Windows > > > > These tests should be explicit about using ANGLE's d3d11 backend. > > > > Bug: chromium:850252 > > Change-Id: I0f3d348edf38f845efeb5ba9d2a70f38b662efbf > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302413 > > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > > Cr-Commit-Position: refs/heads/master@{#790942} Bug: chromium:850252 Change-Id: I281612c7770ae8e33dce0d739e501455b8fd3dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315183 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#791865}
-
Curt Clemens authored
Interface to be implemented using leveldb-proto. See go/nearby-chrome-cert-manage Bug: b/154865267 Change-Id: Ibeb17fa2962c95bdf152d633d79cd78753457baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261218 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#791864}
-
Caroline Rising authored
Hover cards are currently rolling out to stable on Mac and hover card images are as well so we want to keep these metrics to monitor that. Bug: 1097849, 1097848 Change-Id: I0e56e9a26ec4723c751b74db020afdf988440ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315809Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#791863}
-
Yunke Zhou authored
Add FamilyLinkNoticeScreen after gaia sign-in to tell user supervision can be added via Family Link afterward. It should display when user selects sign in for a child and the child is older than 13 years old. Bug: 1101318 Change-Id: If7c9c491f2967da038b70cc3ebb7d1318ea86b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294861 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#791862}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/450afef18d5b..f81afad16767 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC adithyas@google.com,rsorokin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1033067,chromium:1098562,chromium:1105907 Tbr: adithyas@google.com,rsorokin@google.com Change-Id: I5e7038e94b75dd2c936d4900d003043e54ab5835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320192Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791861}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595829164-c22b50893110427f86ce6cde1b20f409df22cb84.profdata to chrome-mac-master-1595851043-c48b6bdf39deda41f847276998118df921bfd4ef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie81710b23f5279a5d712e72978df40d14ac81be8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791860}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cec3e4fd4e86..0bf389ba6cb5 2020-07-27 janscheffler@chromium.org Migrate `front_end/har_importer` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifd2583163fff8e93d7ed29dc5296fb423f9c40d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320190Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791859}
-
Antonio Gomes authored
R=msisov@igalia.com BUG=1109134 Change-Id: I076bf37cee8aae58782385463a5873ec98c12722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318548 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#791858}
-
Oriol Brufau authored
If a list item contains a block box, the layout tree is initially like: LayoutListItem {LI} LayoutBlockFlow (anonymous) LayoutListMarker {::marker} LayoutBlockFlow {P} LayoutText #text However, an outside ::marker should appear in the same line as the first non-marker text of the list item. Therefore, it's changed into: LayoutListItem {LI} LayoutBlockFlow (anonymous) LayoutBlockFlow {P} LayoutListMarker {::marker} LayoutText {#text} But this was not happening when dynamically toggling list-style-type between 'none' and some other value. The reason was that there was a 'NormalChildNeedsLayout()' condition, which would hold the 1st time, but in following layouts it would be false. This patch just removes that condition. Bug: 1107783 TEST=external/wpt/css/css-lists/change-list-style-type-002.html Change-Id: Ic82f1a474b0a0ddf2f2aab8a60afac299aa6e2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310359Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#791857}
-
Maksim Sisov authored
Sets touch device list from cmd line only for non-ozone/X11 for now and also doesn't set x11 error handlers if Ozone is used. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Id0520d4c5b66ad7a6b628b09f887c4a65e03d470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315887 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#791856}
-
Ryan Harrison authored
https://dawn.googlesource.com/tint.git/+log/433670b576c5..429aa812a02d $ git log 433670b57..429aa812a --date=short --no-merges --format='%ad %ae %s' 2020-07-23 dsinclair Add simple test runner. 2020-07-22 rharrison Fix BUILD.gn builds 2020-07-22 dsinclair [msl-writer] Only emit in/out structs if function call requires. Created with: roll-dep src/third_party/tint/src BUG=tint:123 Change-Id: Id73c77add1190c5d7705dbf5903d70fda2d0ade2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315489 Auto-Submit: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#791855}
-
Filip Gorski authored
Change-Id: Ib01298649740501540236e185717879179a5dff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317825 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#791854}
-
David Benjamin authored
The IO thread bits originally set up a URLRequestContext and friends, but that has been removed as of https://chromium-review.googlesource.com/c/1355136. Bug: 908955 Change-Id: I5d2cd6f53352d142d64b7fa1e9fef7ba9f1939a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314831Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#791853}
-
Omer Katz authored
The HashTraits for KeyValuePair were updated to allow concurrent marking, but HashMapValueTraits did not inherit that. kCanTraceConcurrently is moved from HashTraits<KeyValuePair> to KeyValuePairHashTraits so that it is inherited by HashMapValueTraits. Bug: 986235 Change-Id: Id33b6054db3b8bf044cab6ebfd0e1d677118fab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320169 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#791852}
-
Hitoshi Yoshida authored
A CL (https://crrev.com/c/2302972) seems to regress a performance test. This CL fixes the regression. ImageResource seems to be more frequently accessed, and creating base::optional<> in the hot spot would regress the performance. This CL reverted to use a reference of String in ParseType(), and to check ImageResource.type availability outside of the function. Bug: 1108870 Change-Id: Ie5de9aff7b9ca479452637a22c90a82c829147ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318494Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#791851}
-
Eleonora Rocchi authored
This CL adds an image button to restart the check passwords once the previous one has been completed successfully or if there has been an error in the previous check. It also adds the tests to verify the correct visibility of the button. IDS_ACCESSIBILITY_PASSWORD_CHECK_RESTART_BUTTON.png.sha1 image: https://storage.cloud.google.com/chromium-translation-screenshots/ead1b2a3b13694352574ef214e5945cb5aace20e Bug: 1109691, 1092444 Change-Id: I079d08820a3c98cefb4be2d7f3139a34dcfcc390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315339Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#791850}
-
Garrett Beaty authored
This reverts commit 9a66d347. Reason for revert: android-pie-arm64-rel is not a bottleneck for the CQ health Original change's description: > Temporarily disable chrome_public_test_apk on android-pie-arm64-rel. > > Bug: 1108071 > Change-Id: I2b8053233567b2478d3efd9eb3976000a6422bef > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311369 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790588} TBR=martiniss@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108071 Change-Id: I514d589541a79989c8e34cce26837a615887428f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318786Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#791849}
-
jonross authored
This test suite has been failing consistently for 11 days. One test crashes consistently: EGLFeatureControlTest.InvalidDisplay/ES2_OpenGL_NoFixture The other tests are all identified to not even run on this configuration. I'm adding an exception for this bot to not run the suite until the root cause can be addressed. TBR=ynovikov@chromium.org Bug: 1094629 Change-Id: If8eadabb03de0e54d11956bce50761cf71aadcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320408Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#791848}
-
David Jean authored
TBR=sdefresne@chromium.org Bug: 1109740 Change-Id: I7f0d80fabe01f264629311374a968da52f10e0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320275Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#791847}
-
Maksim Sisov authored
it was only limited to non-Ozone/X11. It's time to enable that for OS_LINUX instead as it can be either USE_X11 or USE_OZONE or both. Bug: 789065, 578890 Change-Id: I549f48b731cd9b4ae5d076be02c092939a6e3350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315888 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#791846}
-
Trent Begin authored
This change creates a connection with the cros_healthd service factory when the service connection is created. This will eventually allow Chrome services (NetworkHealth and NetworkDiagnostics) to be passed to cros_healthd when Chrome starts. Bug: chromium:1057739 Change-Id: I0b2142d40adeac4d1991b22642b4555acbf31b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303362 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#791845}
-
Dominique Fauteux-Chapleau authored
This will allow to override the URL used by BinaryUploadService::Request on Chromium builds for development purposes. Bug: 1108856 Change-Id: I8a4645b3fdb73c6268e0dbb790c539b1a2eb5824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314688 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#791844}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3f851efa2adc..c3ccd3a79714 2020-07-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 83825d55c7d5 to a0f1f5149d91 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I242fae423f74722e760931b9edd38b1b09b35367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320033Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791843}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/ui/sync. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1106699 Change-Id: I3b8aa9ab1e730ef7a3ad554311d4d69db0ab91e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316363 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#791842}
-
Stepan Khapugin authored
Makes blob: URLs just show the domain name, like all other URLs, and formats by clipping the head. Bug: 1080395 Change-Id: If9bf4921044dfd94bcd8cb79c53083ac49266f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310430 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#791841}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595785360-159b80f78c6519bfeba1228f89c3740bd393f1a5.profdata to chrome-win64-master-1595807480-d17b0499af342f0654e8c059a08be3424e0d8a06.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If770e07f4c2f7b2c67b2b1c1c1d07b51676f3eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319888Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791840}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I5309e4ace12277bf918ea8eed724db9cfc62154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319542Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791839}
-
Adithya Srinivasan authored
Bug: 1109768 Change-Id: Idc425021c9674e52a3b183f459efea3e34dd48ad Tbr: droger@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320132Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791838}
-
Dominic Schulz authored
This change is to avoid bootlooping on SWA installation. With this change, we will attempt the same version 3 times and then stop attempting reinstallation. We will try installation again when a new version is pushed. Formatting fixes Fix up the tests Abandon failed SWA install after 3 at same version First test code Bug: 1095523 Change-Id: I3139652767d94586e5dd6fc0c8070eae8a25cce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268207 Commit-Queue: Dominic Schulz <dominicschulz@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#791837}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: I03bb8b01f07d815036b536e1b4fec6bfbc7bf1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317880 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#791836}
-
Nicolas Ouellet-Payeur authored
This class makes it easy to starts multiple SandboxedUnpacker's in parallel, and get notified as soon as any of them completes. Since SandboxedUnpacker is disk-bound and often takes >2s to run, running them in parallel can be beneficial. Right now ParallelUnpacker is not used anywhere, but a follow-up CL will use it to make extensions update in parallel, which will speed up extension installs when many of them are queued at the same time (such as for force-installed extensions). Bug: 1103447 Change-Id: Ibc35588134fe0e91c4f7a243677181a08c642552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294563 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791835}
-
Peter Wen authored
Add -C as well for --output-directory to match ninja's syntax. Make it clear in the help text that there are easier ways to permanently specify a default output directory. Remove some unused fields and use f-strings. Bug: None Change-Id: I0a9ba8329095a5c6d8c46ddb63966f31d3307754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315093 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791834}
-
Kevin Ellis authored
Use requestAnimationFrames instead of setTimeouts in the ref tests to accommodate variability in timing. The background color is animated between green and red to better align with reftest guidelines. The test to slow down the animation was removed since it would be essentially equivalent to the zero playback rate test after the refactoring. Bug: 1108342, 1064127 Change-Id: Ie933b68cf45caabfa70fbe5deb881e120ea5e28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313157Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#791833}
-
Chris Sharp authored
Key is 'future_on' Change-Id: Ibef7b85ea6fa4853effb922b1d9d0383ec536e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300005Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#791832}
-
Karel Král authored
Provide more information by adding a trace event to WaitableEvent::Wait. Connect WaitableEvent::Signal with the end of WaitableEvent::TimedWait by a flow event. Make the implementation of WaitableEvent::Wait cross-platform and move it in waitable_event.cc. Bug: 1043616 Change-Id: I07d13d43e951d6fa223202ccd5f6a076559b416f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267160Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#791831}
-
Tommy Martino authored
This adds the string used for the entry point for the Link to Text (Shared Highlighting) feature. Bug: 1099268 Change-Id: Id1f990658d32a2c206d8b1115fe581493c42969e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315087Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791830}
-