- 17 Sep, 2019 40 commits
-
-
Christopher Gunadi authored
Dialogs that are non-modal should preferably inherit BubbleDialogDelegateView. Bug: 1004271 Test: browser_tests --gtest_filter="*Crostini*ViewBrowserTest*" Change-Id: I2abef29396e9d202bad28a0406b0f2c5e8e2fd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806678Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Cr-Commit-Position: refs/heads/master@{#697135}
-
Gyuyoung Kim authored
This CL replaces .mojom.h with .mojom-forward.h to reduce pre-processed size of logging_utils.h This CL has no behavior changes. Bug: 1001360 Change-Id: Idd305572c67e46a5f7a01937ec1d2e31fc62d8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808619Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#697134}
-
arthursonzogni authored
There was a bug in RenderFrameHost::DeleteRenderFrameHost(). Bug: 992894 Change-Id: I0fb3171814113a57ac2267a4442cf252d47d4de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807234Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#697133}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the media.mojom.AudioOutputStream interface, and adapt unit tests. Bug: 955171 Change-Id: I2a5fb08b9ff0b156385551d9a936e68834215276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803146 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#697132}
-
Michael Liao (WPT) authored
Example of submenu: https://imgur.com/fBFrvao According to W3C, elements should be marked as 'aria-haspopup = true' if: - it indicates the availability and type of interactive popup element - the popup element appears as a block of content that is on top of other content Context menu submenu items meet the criteria since the arrow indicates another context menu, and the submenu context menu is the popup element. Here is a W3C example of a similar construct that they mark as 'aria-haspopup = true': https://www.w3.org/TR/wai-aria-practices/examples/menubar/menubar-1/menubar-1.html Bug: 963183 Change-Id: I7cf82fb266847698555c7a81ecbd7f5b3827f26f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725163 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697131}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the content.mojom.RendererAudioOutputStreamFactory interface, and adapt unit tests. Bug: 955171 Change-Id: I1732245f699c7c05e1d771d1210fed60076322fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801151Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#697130}
-
Jérôme Lebel authored
The Sign-in interaction coordinator needs to cancel when -[MainController stopChromeMain] is called. Bug: 1002834 Change-Id: Ideb74b457c983203508757863da6a7ce9afad075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807213Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#697129}
-
Mikel Astiz authored
This reverts commit 1dc90fac. Reason for revert: suspect for causing flakes in DomDistillerViewerSourceBrowserTest.PrefPersist BUG=1004663 Original change's description: > Populate the distilled content slightly earlier > > Before this CL, the distilled content is injected on DidFinishLoad(), > or when the distillation finishes if it's later than DidFinishLoad(). > When the DidFinishLoad() event propagates to TalkBack, the distilled > content is usually not there yet, so TalkBack would announce the > content of the place-holding page. > > This CL populates the distilled content in DocumentLoadedInFrame() > instead of DidFinishLoad(). DocumentLoadedInFrame() is late enough to > execute JavaScript, and is early enough so that it's more likely that > the title and content can be picked up by TalkBack instead of the > placeholder. > > If distillation is finished by DocumentLoadedInFrame(), onload() event > would also be delayed, so that the accessibility focus is more likely > to be on the web content. Otherwise, the focus is usually on the close > button of the CustomTab (CCT), or nowhere. > > Note that this CL doesn't guarantee the distilled title is announced > by TalkBack. If distillation finishes later than > DocumentLoadedInFrame(), or if for some reason the accessibility focus > is on the close button of the CCT, the title would go unannounced like > before. > > Bug: 811417, 803474 > Change-Id: Iaf2ff988b427ca9af582622597b505e7a8aca8e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791048 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697074} TBR=dmazzoni@chromium.org,mdjones@chromium.org,wychen@chromium.org Change-Id: I6af4de1fa2a872402f9abe13321f5d1af8e09d75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 811417, 803474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807495Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#697128}
-
Wei Wang authored
This patch makes StartServiceWorker and StopServiceWorker the helper test utils which can be used by all tests. In this patch, we have already used the StartServiceWorker and StopServiceWorker in ServiceWorkerVersionTest, ServiceWorkerJobTest and ServiceWorkerRegistrationTest. In the next step, other tests will be changed as well. Bug: 931095 Change-Id: I91d70239b6d76498d01c2adba684fde3e7bff121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788251 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697127}
-
Miyoung Shin authored
This CL converts HidConnectionClientRequest in services and content to the new Mojo type. Bug: 955171 Change-Id: I993ee59359700e0cd87db38d777db3df1a288a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804708Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697126}
-
Lei Zhang authored
Use C++ structs for the data structures instead of C structs. This way, the caller can just pass in C++ data as is, and not worry about the C++ to C data conversion. PPAPI will do the conversion internally. Bug: 981448 Change-Id: Ief9c97e4e50c9f70413da80db5a9131c1fdcc123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794247 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#697125}
-
Mikel Astiz authored
Reland "Sheriff: Disable flaky test LocalSiteCharacteristicsDatabaseTest.FaviconUpdateFeatureUsage on Windows" This is a reland of 8c5a2293 Original change's description: > Sheriff: Disable flaky test LocalSiteCharacteristicsDatabaseTest.FaviconUpdateFeatureUsage on Windows > > TBR=fdoray@chromium.org > TBR=chrisha@chromium.org > > Bug: 1004641 > Change-Id: Iae6046cac12450732ea9b5ceff58f4372a8ac96d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808625 > Reviewed-by: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#697107} TBR=fdoray@chromium.org TBR=chrisha@chromium.org Bug: 1004641 Change-Id: I2467757c73f15cf7516238c630ef0f9ab17b228d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808857 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697124}
-
Miyoung Shin authored
This CL converts NFCRequest and NFCProviderPtr in content and blink to the new Mojo type. Bug: 955171, 978694 Change-Id: I58ef7bfeb5b0e2ba4b62bd245a94f054202b75fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806614Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 994491 Test: Record video < 1s, see if any "unable to save file" toast pop up. Change-Id: I544509ac0fb4bba0c743dd230e62abe17039eda4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806160 Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#697122}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f8486f2c5fb6..df432d5efb70 git log f8486f2c5fb6..df432d5efb70 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 48c8f915..c6edebc2 (390 commits) Created with: gclient setdep -r src/third_party/skia@df432d5efb70 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None Change-Id: Ieca0e8c39b516bd85cbdef8687ee587ff0d3b281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808503Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697121}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09b97e3151d8..eba8215b6f4c Created with: gclient setdep -r src-internal@eba8215b6f4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3e7bb1969627c511adcc836c1c8ec364abe989bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808502Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697120}
-
Kuo Jen Wei authored
The bug introduced by crrev/c/1778453 remove the mode selector default at app startup while the UI relayout will reference its width to place the preview. Fixed by making it invisible but still participating the layout. Bug: b/141149902 Test: Start CCA, see if the preview is placed correctly. Change-Id: I99b853133e7cb43f2856a768a8023c64f11fb51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807647Reviewed-by:
-
Hirokazu Honda authored
VA-API driver shares the ownership of the imported buffer. A caller doesn't have to keep NativePixmap after calling VaapiWrapper's CreateVASurfaceForPixmap(). This CL changes the code to release NativePixmap in CreateVASurfaceForPixmap(). This CL also introduces CreateVASurfaceForVideoFrame() to gather together code represented in multiple call sites. Bug: 1001413 Test: tast run video.DecodeAccel* Test: tast run camera.EncodeAccelJPEG Test: tast run camera.DecodeAccelJPEG Change-Id: Iaab8923a07d722a0851a07956dafb1ed70fa5c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787493 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#697118}
-
Alexey Baskakov authored
This code is disabled by default behind kDesktopPWAsWithoutExtensions base feature. WebAppSyncBridge should encapsulate the sync change processor and the unified store (LevelDB). Effectively, WebAppSyncBridge becomes the storage controller ("cloud" storage + local LevelDb). WebAppSyncBridge should handle and coordinate any changes. As a consequence: Rename AbstractWebAppDatabase to AbstractWebAppSyncBridge. In next CLs: 1) WebAppRegistry should become read-only model (M in MVC) for external subsystems other than WebAppSyncBridge. 2) The writeable batch updates API will be moved out of WebAppRegistry to WebAppSyncBridge. WebAppSyncBridge is C in MVC. 3) WebAppSyncBridge should use WebAppRegistry (the model) in one way dependency: we will erase AbstractWebAppSyncBridge interface. There will be no pointer from registry to sync bridge. Illustrational diagram is in progress. Bug: 860583 Change-Id: Idecbfdca14513b5826e91435cb945cbb5cca52a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803017 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:Marc Treib <treib@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#697117}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8647f945..146563ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I446185e21ae3f26175e416b4c49479b054b52dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806986Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697116}
-
Hirokazu Honda authored
mb_no_skip_coeff and loop_filter_adj_enable are set to 1 in crrev.com/c/1773662. After the change, the bitrate on encoding 180P frames becomes out of the expected range. For instance, the bitrate is 108292 (before) and 110183 (after) on eve when the requested bitrate is 100000. The latter one is not allowed because the difference from the requested one, 10183, is more than 0.1 * (requested bitrate). To fix the issue, this CL relaexes the upper limitation of a quantization parameter to 117 from 113. Then, the bitrate of the produced VP8 stream becomes 104793 on atlas. Bug: 1001900 Test: video.EncodeAccelVP8180PI420 on atlas and eve Test: video.EncodeAccelVP8* on atlas and eve Change-Id: Ib96c7f8271a7c69b4adcc7625d4a80f2f7a5f971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802901Reviewed-by:
Sreerenj Balachandran <sreerenj.balachandran@intel.com> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#697115}
-
Chih-Yu Huang authored
We need media::DecoderBuffer for passing input bitstream buffer. This CL adds a mojo struct for it. BUG=b:136716638 TEST=components_unittest --gtest_filter=VideoAcceleratorStructTraitsTest.* Change-Id: I96d23020630bb98b69e3ef1c3707e9dc31cb12ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699349Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#697114}
-
Colin Blundell authored
Change-Id: I34c964a0f7eddc336ca101dbfc64176cdb2f9d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805638Reviewed-by:
Darin Fisher <darin@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#697113}
-
Toni Barzic authored
Running animation while still in drag would cause the app list view change to kHalf/kPeeking or fullscreen state, in addition to changing the page shown in the app list view. Further more, moving mouse (provided that the drag was not ended in the meantime) would cause the view to jump back to the drag position. To avoid this, do not change the app list view bounds to the preferred bounds for the new state is drag is still in progress (the bounds will be updated once the drag ends). For this to be possible, when ending drag, the new drag state should be set before the new state. For code that requires the new state to be known during the state change, introduce ending_drag_ flag, that's set while state change caused by drag ending is in progress. (Currently, this is only used to determine whether animation to peeking state should layout app list at each frame) BUG=1004390 Change-Id: I080b47843576dec8b6fa8cecae4370c7959d9c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807064Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#697112}
-
Mikel Astiz authored
Revert "Sheriff: Disable flaky test LocalSiteCharacteristicsDatabaseTest.FaviconUpdateFeatureUsage on Windows" This reverts commit 8c5a2293. Reason for revert: Reason for revert: breaks the build. Original change's description: > Sheriff: Disable flaky test LocalSiteCharacteristicsDatabaseTest.FaviconUpdateFeatureUsage on Windows > > TBR=fdoray@chromium.org > TBR=chrisha@chromium.org > > Bug: 1004641 > Change-Id: Iae6046cac12450732ea9b5ceff58f4372a8ac96d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808625 > Reviewed-by: Fergus Dall <sidereal@google.com> > Cr-Commit-Position: refs/heads/master@{#697107} TBR=chrisha@chromium.org,fdoray@chromium.org,sidereal@google.com Change-Id: I94b4ffb61ae9e43d7a42e40deb5337ba446cb5b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807494Reviewed-by:
-
Luciano Pacheco authored
Bug: 778674 Change-Id: If9e6d943d7629a1f1fa8e9014b22f1deef1d0247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800903 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#697110}
-
Mario Sanchez Prada authored
Convert the remaining bits in //content/browser/media that still use the old mojo types for midi::mojom::MidiSession[Client,Provider} to the new mojo types, and adapt unit tests. Bug: 955171 Change-Id: I9f7fa7f992103ad9071ce134ee2c4d329372aad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804485Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#697109}
-
Ionel Popescu authored
This CL updates the used font for date popup UI to sans-serif. The colors for disabled, hover and selected state are also updated. Removed setUseMockTheme(false) from tests to avoid the need to rebase the test results for changes to the in-page controls (e.g. different border color). Bug: 1003625, 988155 Change-Id: I95486783d9dca6d262c111b78a40862c6d5d5945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808081 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
-
Fergus Dall authored
Sheriff: Disable flaky test LocalSiteCharacteristicsDatabaseTest.FaviconUpdateFeatureUsage on Windows TBR=fdoray@chromium.org TBR=chrisha@chromium.org Bug: 1004641 Change-Id: Iae6046cac12450732ea9b5ceff58f4372a8ac96d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808625Reviewed-by:
-
Fergus Dall authored
TBR=blundell@chromium.org TBR=droger@chromium.org TBR=treib@chromium.org TBR=vasilii@chromium.org Bug: 1004639 Change-Id: I6785f8f26b6bb34bd2e9e56d121f3a8df49498e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808624Reviewed-by:
-
Nicolas Ouellet-Payeur authored
Change-Id: I22d7e63b29cb5d707cc2e5a3d68a66b6a10eeac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803668 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#697105}
-
Mathias Bynens authored
This patch simplifies some utility methods by applying the following changes: 1) `type=text/css` is the implicit default for <style> elements and for <link rel=stylesheet>. Thus, we should omit it in those cases. This additionally reduces visual clutter in various places, including the elements pane when inspecting DevTools using DevTools. 2) Prefer `const` over `let` even in dynamically generated scripts, matching Google's JS style guide. 3) Simplify `leadZero` by leveraging `String.prototype.padStart`, which shipped in Chrome 51. BUG=v8:9396 Change-Id: I50d0b88ff9c9c2791a194d2f50445e4a561e3a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803929Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#697104}
-
Fergus Dall authored
Sheriff: Disable flaky test MediaRouterUIBrowserTest.EphemeralToolbarIconForDialog on Windows and Linux TBR=mfoltz@chromium.org TBR=btolsch@chromium.org TBR=takumif@chromium.org Bug: 1004635 Change-Id: Iaacfab10a842b16eebc4ca771626932ec9cb859d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808623Reviewed-by:
-
Wanming Lin authored
Covered two checkpoints: - Existing data should be read during the same tap if NFCPushOptions.ignoreRead is set to false. - Existing data should not be read during the same tap if NFCPushOptions.ignoreRead is set to true. Fixed bug in "setReadingMessage" func in external/wpt/resources/chromium/nfc-mock.js that |message| is of type NDEFMessageInit should have no compatibility and message properties. BUG=520391 Change-Id: I6fdc69ff96008142d179a801008e04e7979d6112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804324Reviewed-by:
Leon Han <leon.han@intel.com> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#697102}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0c0b073aed22..c6642beb8c78 git log 0c0b073aed22..c6642beb8c78 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 thestig@chromium.org Correctly draw text with pattern. 2019-09-17 thestig@chromium.org Test a different clip path in bug_632.in. 2019-09-17 thestig@chromium.org Simplify bug_632.in pixel test. Created with: gclient setdep -r src/third_party/pdfium@c6642beb8c78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I9b9270258b9d6165083556e79f1535a65ba7c74c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808232Reviewed-by:
-
Eric Willigers authored
Remov declarations for the PendingAppManagerImpl methods - void UninstallPlaceholderIfNecessary(); - void OnPlaceholderUninstalled(bool succeeded); that have no implementation and are never called. Change-Id: Idd61e501344f8b22f75a9706eff7a08bd0abdf04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804939 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#697100}
-
Dale Curtis authored
For simplicity during AudioDiscardHelper implementation, we just CHECK'd that some things couldn't happen. Turns out one of those cases is now happening (likely due to some ffmpeg change), so turn it into a failure case with a DLOG(ERROR). BUG=987121 R=chcunningham Change-Id: If18c313bb9aefd174dd428a15c2e1ce53254dedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807704 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#697099}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/db7a36f45698..01dfe4048205 git log db7a36f45698..01dfe4048205 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 jmadill@chromium.org Capture/Replay: Use resource ID maps in cpp replay. Created with: gclient setdep -r src/third_party/angle@01dfe4048205 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: Ia08b67425b560b128270e7faea72cebb5a5d8522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808235Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/007200e00a46..09b97e3151d8 Created with: gclient setdep -r src-internal@09b97e3151d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie0d67779215c273893891519d6665e37eba37e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808383Reviewed-by:
-
Fergus Dall authored
TBR=sky@chromium.org Bug: 1004633 Change-Id: I3be1fa72120b89a7b8a39ca91da0ac6ea16bd387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807645Reviewed-by:
-
