- 25 Sep, 2020 40 commits
-
-
Prashant Nevase authored
Using blink side dark mode for images, it is hard to implement caching mechanism for partially loaded bitmap image content, as content id for the image frame being rendered gets decided during rastering only. So caching of dark mode result will be deferred until default frame is completely received. This will help get correct classification results for incremental content received for the given image. Bug: 944413 Change-Id: I19f1a604659e3d9f52458c334824838cfa862d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428297Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#810611}
-
Frédéric Wang authored
Experimental font-size: scriptlevel(...) syntax was implemented in [1]. This CL updates it to match what was agreed with the CSSWG [2] as well as new WPT tests [3]: - Split scriptlevel(...) into math-depth: ... and font-size: math. - Rename auto to auto-add This CL also updates the MathML UA stylesheet to use the new syntax. To compute font-size, one need the inherited math-style and the inherited/computed math-depth. So math-style does not need to be High priority. Additionally Blink computes the High priority alphabetically, so math-depth must be handled specially. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2184131 [2] https://github.com/w3c/csswg-drafts/issues/5389 [3] https://github.com/web-platform-tests/wpt/pull/25694 Bug: 6606, 1023292 Change-Id: I8a5bf245fa6158633261ed167800fc5feb0c3564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423843 Commit-Queue: Frédéric Wang <fwang@igalia.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#810610}
-
Allen Bauer authored
Bug: 938501, 1130078 Change-Id: I04cf5751b0e3852ca02f456c2625a6b6bb815783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425106 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#810609}
-
Dylan Cutler authored
This API is suspected to leak cross-site entropy about users. This instrumentation reports digests of the values read using this API to UKM to determine the available entropy of the API for identifying users across sites. Bug: 973801 Change-Id: If16a73d332e07cdcf3067afb53017d08091bb9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424636 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#810608}
-
Asanka Herath authored
As a nice side-effect identifiable_surface.h becomes more portable. Bug: 973801 Change-Id: I4e7dbcc931e1f6ecd47f27a68ff0b8bc067f40ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430485 Auto-Submit: Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#810607}
-
Chris Fredrickson authored
This reverts commit 542cedb8. Reason for revert: We'd prefer to instrument the navigator.enumerateDevices method, instead of each individual MediaDeviceInfo object. Original change's description: > Instrument access to MediaDeviceInfo data. > > This cl causes the bindings generator to automatically collect UKM when > these attributes are accessed. This will be used to analyze how much > entropy leaked by this API can be used for cross-site tracking. > > Bug: 973801 > Change-Id: I29ea7ee1796c8152cab9f004229282b1b728b173 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421638 > Commit-Queue: Chris Fredrickson <cfredric@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809847} TBR=kinuko@chromium.org,cfredric@google.com Change-Id: Ib165710d1b3f81cee6a4f803e0fb154323c97272 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427325Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#810606}
-
Jan Wilken Dörrie authored
TBR=nektar Bug: 1132248 Change-Id: I63f10d7e3e30022f20fec86b35e5f4cb66d4121e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431504Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810605}
-
arthursonzogni authored
Some browsers do not implement COOP reporting. As a result, no reports are received after a 2.5s timeout. Waiting 2.5s many time can reach the global timeout. Sometime, this flakes in between FAIL and TIMEOUT. This patch makes the timeout to be infinite by default to get consistent failure. Bug: 1090273 Change-Id: I081b9c8e944fc50b391753ce0948392b88d3fd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428976Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810604}
-
Yaron Friedman authored
Reuse the same process but launch a new activity each time. We could do faster by not launching a new activity and only a new shell (content shells equivalent to "tab") but that broke some tests in subtle ways. This keeps it blackbox-y but more performant than otherwise. Change-Id: I00e6435739c9fb80b2d8790ce441c613e825631d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429546 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#810603}
-
Alex Gough authored
For instance, kBrowserProcessId allows for access to file:// urls and other urls, effectively allowing user data to be read and sent to the network. Change-Id: Iabbb9cdd56061a689c35f4b84550a78a4eed9957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429871Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#810602}
-
Jan Wilken Dörrie authored
This change replaces usages of autofill::PasswordForm with password_manager::PasswordForm in the file range password_manager* in the //components/password_manager/core/browser directory. Bug: 1067347 Change-Id: Iceabd48e9a064729ff040d05b3966f2dbd5567c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431027Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810601}
-
Ulan Degenbaev authored
The flag guards the new implementation of performance.measureMemory that queries PerformanceManager in the browser process. Bug: 1085129 Change-Id: Ic38e5593637bdb894d0780ee5aa463d2844c4bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428241Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810600}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4499bd576da..b398c83894c6 2020-09-25 alexrudenko@chromium.org Refactor source order tool 2020-09-25 jacktfranklin@chromium.org Fix focus border cut off on element breadcrumbs 2020-09-25 jacktfranklin@chromium.org Migrate SearchResultsPane to TypeScript 2020-09-25 tmathmeyer@chromium.org Convert user-showing strings to sentence case 2020-09-25 wolfi@chromium.org Move adorner styles to globally accessible location 2020-09-25 tvanderlippe@chromium.org Add singleton-instance lookup to sharedInstance 2020-09-25 tvanderlippe@chromium.org Add documentation for compression settings with squoosh.app 2020-09-25 changhaohan@chromium.org Remove debouncing adorner updates to pass flaky tests 2020-09-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-25 sigurds@chromium.org Use new resource loading for http and https resources 2020-09-25 tvanderlippe@chromium.org Rewire snippets project If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1066415,chromium:1069378,chromium:1131147,chromium:1131423,chromium:1131801 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic62f062339619c128d86f098cde35f1b4b4a2064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810599}
-
Andrei-Laurențiu Olteanu authored
Put UntrustedRequestTelemetryInfoUnknownCategory test below prime search routine. Bug: b:162051831 Change-Id: I933c71af138d5df2895967b9c90fbea6645f8c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428589 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#810598}
-
Christoph Schwering authored
The feature is enabled by default and is not subject to an active experiment. Bug: 1007974 Change-Id: I928dad477a82562022c0b753e6e768a9a3ccb028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411936 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810597}
-
Sebastien Lalancette authored
Only doable on iOS 14+ since on iOS 13 we're using a different "page size", resulting in a page with different width (and height). Bug: 1131558 Change-Id: Idf3f10d77787f2513ed37b258a69901e6891cb30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426963 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#810596}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8c7f5c3e. With Chromium commits locally applied on WPT: 8f02a380 "Use allow attribute for delegation in web serial WPT" c1a7d15a "[LayoutNG] Multicol baseline propagation support." f30daabb "[COOP] access reporting: test with redirects." 1117bd9f "Revert "FontAccess: Sort fonts in lexicographical order"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I33f7f5899a7601d6c6d91ed89976a6adc62999f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430506Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810595}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600991906-65f7bfb49ebbe3e14bdc8eed995291d523852457.profdata to chrome-win32-master-1601013503-f38bea78afe4f518e60cb51c463a620d383ff0cc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: I871d64d8005510cc32f4c61c6e8db9b67631ea46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431184Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810594}
-
François Doray authored
This reverts commit 11b3502f. Reason for revert: Suspect for compile failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/171087 Original change's description: > Change DLP rules policy to dict type > > - Changed DataLeakPreventionRulesList type to > dict and to use SchemaValidator instead of a simple > list. > > Bug: 1131904 > Change-Id: Ia7268abd7003856e26eee19bb4cb7970320392eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428984 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Maksim Ivanov <emaxx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810582} TBR=emaxx@chromium.org,poromov@chromium.org,nikitapodguzov@chromium.org,ayaelattar@chromium.org Change-Id: I01303c77c5da61b801fa42c21a8aaa4fd19a7e12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431784Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#810593}
-
François Doray authored
This reverts commit 1546f3b4. Reason for revert: Suspect for compile failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/171087 Original change's description: > Add policy logic to clipboard dlp controller > > 1. Changed EnterpriseClipboardDlpController logic > to be based on the policy logic in DlpRulesManager. > 2. Added DlpRulesManager::IsAnyRestrcitedComponents > to decide if any component is restricted. > > Bug: 1102332 > Change-Id: Ib1abc64c71540cb431f94d4dfae44212ef8d3597 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416451 > Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810586} TBR=poromov@chromium.org,nikitapodguzov@chromium.org,ayaelattar@chromium.org Change-Id: I547458826e6144e8d8c205926bf31cd95d0659a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1102332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431446Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#810592}
-
Gayane Petrosyan authored
Update user selection range so that first and last words are complete words, otherwise TextFragmentFinder will not find a match. For example, where '[' and ']' indicates user selection. "samp[le text that user sel]ected" will be changed to "[sample text that user selected]" Bug: 1129647 Change-Id: I5e2274b0e1ed0cc240fcea39ffcc369ab29ce171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424541 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810591}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I56e86e2752c0750003ca4ea34d6708eace705ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430224Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810590}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I68e843e59e240a597998f7280667e675eded8985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426770Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#810589}
-
Jamie Madill authored
Bug: b/168744561 Change-Id: I9b177ba46c2c9668d68d4812697b713c75f8324b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419032Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#810588}
-
Roman Sorokin authored
As a part of the COIL effort I found this file. Looks like it's not used anywere. Bug: none Change-Id: Id9abea74ae6b64abde531a2d2c8a12eabee3ca87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428973 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#810587}
-
Aya ElAttar authored
1. Changed EnterpriseClipboardDlpController logic to be based on the policy logic in DlpRulesManager. 2. Added DlpRulesManager::IsAnyRestrcitedComponents to decide if any component is restricted. Bug: 1102332 Change-Id: Ib1abc64c71540cb431f94d4dfae44212ef8d3597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416451 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810586}
-
Tim van der Lippe authored
This test has been replaced by the cross_tool_integration e2e-tests that live in the DevTools frontend repository. R=aerotwist@chromium.org Change-Id: Id6eb3c0e000c9ca5d2e61efefb3bd3e9d740aa51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429024 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810585}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600991906-91a7adfbdc345922f7abfd948645ae0f618ee88b.profdata to chrome-win64-master-1601013503-170d2d1d55cdbd64ec85654eee6bce6ad2a17ca2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ibb78d800ec923b622a31ac877b028730f50681d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810584}
-
Elizabeth Popova authored
Initially when the usage of test clocks was unified [1], there was an exception for Next* functions in autofill_test_utils that used base::Time::Now instead of AutofillClock::Now. However later, probably because of presubmit suggestion, it was replaced with AutofillClock::Time as well [2]. Also unified usage of Next* functions. Might be the cause of test flakiness. [1]https://chromium-review.googlesource.com/c/chromium/src/+/1850434 [2]https://chromium-review.googlesource.com/c/chromium/src/+/2103654 Bug: 1108232 Change-Id: I025075126f7cc387d5744b21f1199ddb22d00f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428986 Commit-Queue: Elizabeth Popova <lizapopova@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#810583}
-
Aya ElAttar authored
- Changed DataLeakPreventionRulesList type to dict and to use SchemaValidator instead of a simple list. Bug: 1131904 Change-Id: Ia7268abd7003856e26eee19bb4cb7970320392eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428984 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810582}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df53732e1b69..8f47f320f6f3 2020-09-25 hjd@google.com Merge "Reland: Make GuessTraceType more selective about proto traces" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I67788c97e9da1ae6641c763dd76ad8f6f3735fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810581}
-
Nico Weber authored
As far as I know, chrome-for-chromeos no longer links with gold, so we can clean up the code a bit here. No intended behavior change. Bug: none Change-Id: Idc0ee540b2ec8031cf33e483e161c118bebb4035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429442 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#810580}
-
Yi Gu authored
The test used to count on base::StatisticsRecorder::FindHistogram() to test the metric is not logged. However, FindHistogram() is static and it may observe values from previous test runs. The proper way should be using ExpectTotalCount(0) [1] which takes this situation into consideration. [1] https://source.chromium.org/chromium/chromium/src/+/master:base/test/metrics/histogram_tester.cc;l=70 Bug: 1132038 Change-Id: I3134c6bccba0670a583e3ec97972a358f68fef9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430123 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#810579}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I08d46bb90a1b958e0e14e9ed9c23cb716313748e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430089Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810578}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f1c8428..c325a422 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2ece51ff6a4d95ff0f62bec56237782eb2b01e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428731Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810577}
-
Maksim Ivanov authored
Change tests in webview_login_browsertest.cc to calculate the expected fingerprint dynamically at runtime, rather than hardcode it as hex strings in the test code. This simplifies the tests maintenance and also makes them more readable, by replacing magic hex blobs with human-readable cert file names. The main purpose of these tests is anyway the login-screen behavior, and not the cert fingerprint calculation, therefore it's presumably not very important to have "golden" data hardcoded in these tests. Bug: 905994 Change-Id: Ie8ee63d6a54087fa77ae64e7c487b19b0c884be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426705Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810576}
-
Reda Tawfik authored
1. Sends the origin of current focused field from native to Java. 2. Shows a warning message in a `ModalDialog` when 'Use other password' button is clicked. 3. Adds a controller test for the warning dialog. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1129351#c7 Bug: 1129351, 1104132 Change-Id: I921b679898ac9c0e84dd9310c38d957d3f31e294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416358 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810575}
-
Miguel Casas authored
Encoding for Vaapi has 4 parts: (1) copying the video frame contents, (2) submitting some buffers, (3) executing the encode, and finally (4) downloading the encoded chunk. During crrev.com/c/2344526 I was taking a look at the chrome traces for it and reckoned it'd be good to split out some of them, namely this CL adds more targeted metrics for: - In part 1, for the libyuv copy-conversion that takes the majority of the time. - In part 4, for the SyncSurface (largest part), with a smaller share taken by copying the encoded chunk out. No new functionality intended. Bug: b/166646505 Change-Id: Id0f6dbcb4c119e2692c2fa7ab999100e1cac77b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427069Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#810574}
-
Mikel Astiz authored
These tests experience setup slowness on Mac leading to flakiness, so let's add a few traces to confirm this hypothesis and narrow down the source of the slowness. Bug: 1131588 Change-Id: Idc077fab344c17d64a98cdc4146dd049d37b02f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431026Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#810573}
-
Christian Dullweber authored
Bug: 1077766 Change-Id: Ia20915a0be0be09ef6567c9d418b8778f7887437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424291Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#810572}
-