- 03 Apr, 2020 40 commits
-
-
Karandeep Bhatia authored
In certain specific and rare edge cases, we might end up setting ruleset prefs for an uninstalled extension. This can happen in: - RulesMonitorService::OnRulesetLoaded: This is dispatched when the extension rulesets are loaded. We reset the ruleset checksums if the extension was re-indexed due to a schema change. - RulesMonitorService::OnDynamicRulesUpdated: This is dispatched when the dynamic rules for an extension are updated on disk. Return early in both these cases to ensure we don't incorrectly modify extension prefs for an uninstalled extension. BUG=1067441 Change-Id: Ib2d1a94265ab73871b8ae791481fe0ec25234d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131222 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756410}
-
Matt Jones authored
This patch attempts to deflake more TabsTest tests by using the new TouchCommon infra and loading new tabs via the test rule. The test was run 100 times locally without flaking. Bug: 799728 Change-Id: Ic26b9fb5c25d911d13a0a6280357c91eef32985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134652Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#756409}
-
Lukasz Anforowicz authored
This CL fixes a NetworkService DCHECK failure/crash that is behind the layout test flakiness under wpt/fetch/cross-origin-resource-policy as pointed out in https://crbug.com/1067445#c17. Bug: 1067445 Change-Id: I3c516a09f68a722f6dad555f6467379e7d8fe2d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136028Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#756408}
-
Danan S authored
Also improved some comments and renamed the following to clarify their purposes: section_container -> install_permissions_section_container ParentPermissionSecton -> ParentPermissionInputSection Finally, moved install_permissions_section_container and its enclosing scroll view into the scope of the code that adds extension permissions view. This removed dead space created by the scroll view in the case there were no permissions to display. Bug: 1052097 Change-Id: I1393d732504c82d586705257f1c1b125640db5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134911 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756407}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/2ce5fda2fea8..e06125cb520f git log 2ce5fda2fea8..e06125cb520f --date=short --first-parent --format='%ad %ae %s' 2020-04-03 amaiorano@google.com Fix Chromium and Android build 2020-04-03 bclayton@google.com Debug: Add missing include. 2020-04-03 bclayton@google.com Vulkan/Debug: Create a PhysicalFile if DebugSource has no content 2020-04-03 bclayton@google.com Vulkan/Debug: Always provide the dap::Source::path 2020-04-03 bclayton@google.com CMake: Don't always regenerate OpenCLDebugInfo100.h 2020-04-03 amaiorano@google.com CMake: use gtest and gmock targets 2020-04-03 amaiorano@google.com CMake: split out atsc-encoder into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: clean up cppdap usage 2020-04-03 amaiorano@google.com CMake: split out Reactor into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out boost into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out libbacktrace into its own CMakeLists 2020-04-03 amaiorano@google.com CMake: split out subzero and llvm-subzero into their own CMakeLists Created with: gclient setdep -r src/third_party/swiftshader@e06125cb520f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I289bb442d8d930675c4e13f885935a416ded319f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135421Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756406}
-
Mario Bianucci authored
Currently, if you select a text on the page, hold down middle mouse button and start scrolling in either direction and leave the button, it deselects the text. This is due to incorrect position in widget information on an event. This CL fixes the bug by correctly populating the position in widget information on an event. As a side effect of populating the correct position, clicking in an OOPIF to end autoscrolling would result in the cursor not changing back to a pointer until the mouse was moved. This is because when auto- scrolling ends, a cursor update is scheduled, but the cursor update timer is tied to user interaction, and if user interaction doesn't occur after the click, the timer doesn't fire. This used to work because the cached value previously populated in the widget resulted in hit testing not reporting a remote frame, so the cursor was updated in EventHandler::HandleMouseMoveOrLeaveEvent. With this change, hit testing reports a remote frame, so it no longer updates in the same place. Therefore, in order to ensure that the cursor is correctly updated immediately after autoscrolling, CursorUpdate is called rather than just scheduling an update. Regressing change: crrev.com/c/1773540 Bug: 1054854 Change-Id: I6b5353529ab0b73c85c1dd0e0237d3e06c848a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116134Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#756405}
-
Theresa Wellington authored
BUG=980567 Change-Id: I45dfeb4ef93b1d73d3ada19f11f524baec40334a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135502 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#756404}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2af328044cf7..2d6db0b9fdd5 git log 2af328044cf7..2d6db0b9fdd5 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 michael.liao@microsoft.com [Applications - Clear Storage]: Fix pie chart focus 2020-04-03 leese@chromium.org Reland "Show unbound breakpoints as disabled" Created with: gclient setdep -r src/third_party/devtools-frontend/src@2d6db0b9fdd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066374 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icf1cd31097affc4a0cdae74022b0e5497fe685ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135419Reviewed-by:
-
Alexander Surkov authored
AccessibilityTreeFormatterMac as any other platform accessibility tree formatter should operate with platform tree, not platform-independent tree which AccessibilityTreeFormatterBrowser is responsible for. Adjust mac accessibility treedump tests to reflect mac accessibility tree, i.e. include indirected children and remove unknown children Bug: 1066578 Change-Id: I61d2429dbe6d899a018b4761ab5923086f0bf56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133419 Commit-Queue: Alexander Surkkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#756402}
-
Jordan Bayles authored
This patch reverts a previous patch that added diagnostics for a tricky SnooperNode::Render() bug. Most of the files had merge conflicts that required manual resolution. Bug: crbug.com/888478 Change-Id: I7ff4ff07df9cf845ebc500facbbc3487d20891c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128845Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#756401}
-
Brandon Wylie authored
Did some refactoring to allow for better test support. TBR=arbesser@google.com Bug: 1067714 Change-Id: Id18a0e1973c18c1ed9422748d6671cb012ce0f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133174 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#756400}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f687d90f4219..d9c51142bd01 git log f687d90f4219..d9c51142bd01 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 peah@webrtc.org AEC3: Add additional transparency-related killswitches Created with: gclient setdep -r src/third_party/webrtc@d9c51142bd01 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067597 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5ed8c32dfe63365dde8f495adf6edf3680484fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135981Reviewed-by:
-
Michael Thiessen authored
Change-Id: Iac30106a597ade4a6a7826bf5ed9890c94a1514f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135423Reviewed-by:
-
Henrique Nakashima authored
Change-Id: Ib0a5f6073de3d47120591dcd68707d1876e152ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129899 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#756397}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79679990ff54..7803f6a504e3 git log 79679990ff54..7803f6a504e3 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 treehugger-gerrit@google.com Merge "Move Frame Events to a separate table and add frame stats table" Created with: gclient setdep -r src/third_party/perfetto@7803f6a504e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Idf3e21e386fb2cc88b8cbd80a5bc3ecd762feedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135977Reviewed-by:
-
Jon Mann authored
This adds support for customizing seperate values for HTTP, secure HTTP, and SOCKS proxy hosts and ports. Bug: 966270 Change-Id: I88e83f2ca7f764e6eb32cd2ed214b392b289a95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135310Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#756395}
-
Henry Jian authored
This CL removes the use of callback for feature highlight. Because the callback is no longer needed, we're removing its use now. Bug: 1057234 Change-Id: I5ce9ba270851397da926f8c33a4e8c3cbc5d8fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122619Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Jon Mann authored
This change refactors last_modified_timestamp to last_connected_timestamp in order to more accurately represent what is stored. Bug: 966270 Change-Id: Id2ff3ee12604a0d93ed9c4ddf2d66d8cf6be9247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133548Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#756393}
-
Peng Huang authored
vkGetSemaphoreWin32HandleKHR, vkImportSemaphoreWin32HandleKHR, vkGetMemoryWin32HandleKHR and vkGetMemoryWin32HandlePropertiesKHR are added. They will be used for Vulkan and GL interop on Windows. Bug: 1067709 Change-Id: Ie735a25c31d41ac5af1d8734c5ba830b1f340465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135974 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#756392}
-
danakj authored
It depends on content_shell_lib, which no longer needs to depend on anything in renderer/web_test. R=avi@chromium.org Bug: 866140 Change-Id: I62b472b8ac3d22176ef6a55609b5ada80d50a540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134487 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756391}
-
Andy Paicu authored
Bug: 875521 Change-Id: I4d5a0930e090b6720646352d8e537e90faedc004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132413 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#756390}
-
Lei Zhang authored
- IDS_NTP_CUSTOM* were added in https://crrev.com/569519 and may have never been used. - IDS_NTP_DOWNLOAD* went unused as of https://crrev.com/647035. Change-Id: I1aa26d46c3d903d604bee218d5b2bf5da2afb14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135530Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756389}
-
Lei Zhang authored
- PrintPreview.RegeneratePreviewRequest.BeforeFirstData: The UMA is not interesting. - PrintPreview.ManagePrinters: https://crrev.com/518333 botched the data collection code, and https://crrev.com/613267 removed the method that should have collected the data. Along the way, initialize more PrintPreviewHandler member variables in the header. Bug: 1041532 Change-Id: I319d87c17d11ee9191e9feba6351fe93f5aa44fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135534Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756388}
-
Reilly Grant authored
The Wake Lock feature was supposed to be in Origin Trial from Chrome 79 to 82 however Chrome 82 has been canceled due to COVID-19 and so we are extending the OT through Chrome 83 to give us time to integrate recent specification changes that missed the branch point. Bug: 257511 Change-Id: I3df4ad65029b042eb8c9eada9bf7cae5f7cad4f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134400Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756387}
-
Peng Huang authored
This CL git rid of Posix suffix from ImportVkSemaphoreHandlePosix and GetVkSemaphoreHandlePosix, and rename gpu/vulkan/vulkan_posix_util.cc to gpu/vulkan/vulkan_util_posix.cc. gpu/vulkan/vulkan_util_posix.h is removed. Bug: 1067709 Change-Id: I49551052e2c20b4a7435f020c3f9ae0ec99e7821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135815 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#756386}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/31665eb818aa..52ecbf88d69c git log 31665eb818aa..52ecbf88d69c --date=short --first-parent --format='%ad %ae %s' 2020-04-03 btolsch@chromium.org Fix tsan race in discovery e2e tests Created with: gclient setdep -r src/third_party/openscreen/src@52ecbf88d69c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib1affb5821473b7573dafa0552fc201990ca9b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135973Reviewed-by:
-
spdonghao authored
Bug: 1061906 Change-Id: I798d592945cadcb5b375ee508369738224d78caa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132330Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#756384}
-
Junbo Ke authored
Casting content from a local server is broken because the request is auto upgraded to HTTPS. Bug: b/153100172 Test: CQ Change-Id: Ib3cb140df74cbc9336b245069c050163bac120ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135889Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#756383}
-
Samuel Huang authored
This CL adds more tests for FileUtils: * batchDeleteFiles() (not testing content URL deletion). * copyStream(). * copyStreamToFile(). * readStream(). * getUriForFile(). Bug: 1066730 Change-Id: I7ac4d2f1c5eecd82aebf931a797c9bac8a96d635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135814Reviewed-by:
-
Ryan Hansberry authored
These logs were previously incorrect making it slightly confusing to read debug logs after the fact. This CL makes it clear when advertisements are received and a connection is beginning to be created. Change-Id: I93ff8b8b415878c499844ae8b3b99d99f9f2a481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134770 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#756381}
-
Adam Langley authored
In the latest CTAP 2.1 draft, an authenticator can have a default credProtect level other than one. Previously, Chromium couldn't distinguish level one from not-specified thus, first, this change adds that distinction. Then there are additional complexities because Chromium sets a default credProtect level of two for discoverable credentials, but we don't want to override an authenticator default of three. Therefore the credProtect level for a request becomes a property that can only be resolved in the context of the specific authenticator that will receive the request. We already have a property like this: the Android ClientDataJSON extension. Thus pull these meta-level request properties into a different structure so that MakeCredentialRequestHandler can craft per-authenticator requests from that when needed. This isn't perfectly clean because the Windows API acts as an authenticator, but is actually a front for many authenticators. So we have to stuff |cred_protect_enforce| in the request object, despite it being a meta-level property. BUG=1057126 Change-Id: Id1c02d4689492d597f5f29674166b97a8e720d2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130869Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#756380}
-
Daniel Hosseinian authored
Add tests that show current printing behavior of contents being aligned to the bottom right corner of the printed page. Show the behavior for both portrait and landscape PDFs. Also show the behavior on large and small destinations. Bug: 919596 Change-Id: I1519f59b22e9c29f46c941e10b851f5d78d2fafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124986 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756379}
-
Christopher Cameron authored
A crash can result from the following sequence of events (as debugged by ellyjones): 1. displays_require_update_ is false 2. The configure timer ticks, ConfigureTimerFired is called 3. ConfigureTimerFired -> UpdateDisplaysIfNeeded, which is a noop because displays_require_update_ is false 4. ConfigureTimerFired -> NotifyDisplaysChanged, which starts iterating the list 5. One instance of NativeWidgetNSWindowBridge:: OnDisplayMetricsChanged calls ScreenMac::GetDisplayNearestWindow 6. Since the display list has not yet been updated (at step 3), that falls back to GetCachedDisplayForScreen (and its call to UpdateDisplaysIfNeeded is a noop) 7. Since the display list still hasn't been updated, GetCachedDisplayForScreen calls OnNSScreensMayHaveChanged, which sets displays_require_update_ to true 8. The iteration from step 4 resumes, and another instance of NativeWidgetNSWindowBridge::OnDisplayMetricsChanged runs 9. For *this* instance, displays_require_update_ is true, so UpdateDisplaysIfNeeded destroys the old version of displays_ 10. The iteration from step 4 resumes, now iterating on a destroyed displays_. Break this by removing the call to OnNSScreensMayHaveChanged from GetCachedDisplayForScreen, to see if it removes the crashes. Bug: 1033866 Change-Id: I1271c83d5456ab9c863969842816661c6b3e0569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135312Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#756378}
-
Sam Bowen authored
Bug: 1062408 Change-Id: Ifbfe36bb8b777c0fde98ce0666cb43a7aaeace6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135496Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#756377}
-
Dominic Farolino authored
This CL removes |ImageLoader::Task::request_url_| in favor of lazily parsing the image request's absolute URL when ImageLoader::Task is run. Currently ImageLoader::Task stores a KURL |request_url_|, which is a snapshot of the image's absolute URL, parsed relative to the image element's node document at the time ImageLoader::Task is queued. We shouldn't have to store a snapshot of the parsed URL, because the source URL at the time an ImageLoader::Task is run is the same as when the task is queued. The reason we stored a snapshot of the parsed URL is because what *can* change in between when an ImageLoader::Task is queued and run, is the document's base URL, via a `<base>` element. In https://crbug.com/569760 a CL was landed that takes this snapshot, so that if a `<base>` element was dynamically-inserted before the ImageLoader::Task was run, the URL would be unaffected by the addition of the `<base>`. However, the spec is very clear that the parsing of an image request's URL [1] happens after the microtask is run, meaning our snapshot is unnecessary, and incorrect. This CL: - Removes the snapshot - Fixes the associated test - Exports the test to external/wpt so other impls can benefit [1]: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:parse-a-url-2 Bug: 569760,1061685 Change-Id: I8d9e3dbefd27a26626bb930acc809196753c7506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103987 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#756376}
-
Andrey Kosyakov authored
This is the chrome-side counterpart of https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2128732 Bug: 1059577, 795595 Change-Id: Iec2ee772a42b4c7bc2249627c0839f7506f0cd1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129344Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#756375}
-
Sergey Ulanov authored
Previously DefaultDecoderFactory could crash when creating decoders after the GPU context has been lost because it was assuming that GetMediaContextProvider() always returns a valid result. Fixed it to it to validate the result before trying to use it. Bug: 1057959 Change-Id: I767a8fa7dcfcfb122be98449cc1aa46c43ceae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135531 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
-
Paul Moy authored
Instead of using magic numbers for test arguments, name them according to their function, e.g. kPositiveInt. This makes it clear what the number represents. Bug: chromium:1066251 Change-Id: Ie9525667d4fe62dcd0c61f39250f61cb9fc70fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134504 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756373}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/039884bb8c63..b70ef7756a4d Created with: gclient setdep -r src-internal@b70ef7756a4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I702e2801916a5c3b956259c37c5b04f409edd4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135971Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756372}
-
Stephen McGruer authored
This rolls testharness.js, idlharness.js, and webidl2.js from the external copy in external/wpt/resources/ to the internal copy in resources/, bringing us up to WPT SHA e343467e. Note that the webidl2.js changes are just tab characters present in the original file that I accidentally cleaned into spaces in the previous roll. Bug: 1067618, 1066131 Change-Id: I1ccdf13418e10ace29564695d3dd20a738a7a3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135540Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#756371}
-
