GitLab

This CL introduces "StyleCommands.h" to move the declarations of some
static functions related to style commands to the header file to make
EditorCommand simpler for improving code health.

Bug: 818552
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ic30cfa48855dbb482a92d2d2e2d657a9cdfb7ae7
Reviewed-on: https://chromium-review.googlesource.com/985596Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546779}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 786332
Change-Id: Id56592620375d8a62825511a93a825e135c28f60
Reviewed-on: https://chromium-review.googlesource.com/980015
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546778}

The code, url::Origin, that new CORS implementation relies on serializes
local file initiators to 'file://' rather than 'null'. This results in
CORS check failures even if the server allows 'null' origin to access.

Bug: 825567
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Icb387b6df6e1e6574ff90cad61f53400092cbcb3
Reviewed-on: https://chromium-review.googlesource.com/983276
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546777}

Rebaseline after r546365.

Tbr: falken@chromium.org,kinuko@chromium.org
Bug: 782958
Change-Id: I751ba813b526fef8efd758fc3e3b0967d550ffd4
Reviewed-on: https://chromium-review.googlesource.com/985675Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546776}

If the client does not encode any input buffer before calling Flush(),
then VEA could just reply the flush is completed.

Bug: b:74503577
Test: pass android.media.cts.MediaCodecTest#testSignalSurfaceEOS CTS
Test: pass video_encode_accelerator_unittest


Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic7e3b6d0eaa35cf0db2b5267ff63c4f1ae48123f
Reviewed-on: https://chromium-review.googlesource.com/981916
Commit-Queue: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546775}

Blink scheduler code is transitioning to a new directory structure.
This path moves PageScheduler and PageSchedulerImpl, and rewrites
include paths.

Bug: 826203
Change-Id: Ieeebbd77a4046ff6c7238baba0f7d34817839679
Reviewed-on: https://chromium-review.googlesource.com/985597Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546774}

This change is the first part of implementation for https://github.com/w3c/webcomponents/issues/468
This change adds an optional CSSStyleSheet in CustomElementOptions in
CustomElementRegistry.define() behind a flag.
The resulting CustomElementDefinition will contain the CSSStyleSheet.
Currently the stylesheet in the definition doesn't affect anything yet.

Intent to implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/RQVKGUjDz9U/discussion


Implementation plan doc: https://docs.google.com/document/d/1aA1emBlA20nVB0bmkcamjFdPEvcoBuRbp6p8QKcPz80/edit?usp=sharing

Bug: 824684
Change-Id: I4bf7c05700307d5e8e084c9893afb1779155c017
Reviewed-on: https://chromium-review.googlesource.com/975081
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546773}

Removing [CEReactions] from [PutForwards]-decorated readonly
attributes, as it is redundant there.

Bug: 700032
Signed-off-by: Yuhong Sha <yuhong.sha@samsung.com>
Change-Id: Ie0d26c8181a8a30ccb0b751a41b929e0ff4e64f4
Reviewed-on: https://chromium-review.googlesource.com/980273Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#546772}

This CL is just a refactoring so that we can lazyReattach nodes in once place.

In follow-up CLs, I'll reduce the number of LazyReattached nodes, unifying this with
dynamic programming code as HTMLSlotElement::LazyReattachDistributedNodesIfNeeded does.

Bug: 776656
Change-Id: I17813a39c57cc5bbea5e8c529805123ccabd4c69
Reviewed-on: https://chromium-review.googlesource.com/984917Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546771}

This reverts commit de2fa0a4.

Reason for revert: Builder ios-simulator-xcode-clang started failing in #45102 when this CL was landed.
See https://ci.chromium.org/buildbot/chromium.mac/ios-simulator-xcode-clang/?limit=100

For the error message see: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.mac%2Fios-simulator-xcode-clang%2F45102%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Error message snippet: 
408/3890] CXX obj/third_party/libyuv/libyuv_internal/row_gcc.o
FAILED: obj/third_party/libyuv/libyuv_internal/row_gcc.o 
/b/build/slave/cache/goma_client/gomacc clang++ -MMD -MF obj/third_party/libyuv/libyuv_internal/row_gcc.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_XCODE_VERSION=0920 -DCR_CLANG_REVISION=\"328575-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -I../../third_party/libyuv/include -ffp-contract=fast -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wundeclared-selector -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-undefined-var-template -Wno-address-of-packed-member -O0 -fno-omit-frame-pointer -gdwarf-2 -isysroot /b/build/slave/cache/xcode_ios_9c40b.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.2.sdk -stdlib=libc++ -mios-simulator-version-min=10.0 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++14 -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../third_party/libyuv/source/row_gcc.cc -o obj/third_party/libyuv/libyuv_internal/row_gcc.o
../../third_party/libyuv/source/row_gcc.cc:585:8: error: instruction requires: AVX-512 VBMI ISA AVX-512 VL ISA
      "vpermt2b   %%ymm1,%%ymm5,%%ymm0           \n"
       ^
<inline asm>:10:1: note: instantiated into assembly here
vpermt2b   %ymm1,%ymm5,%ymm0           
^
../../third_party/libyuv/source/row_gcc.cc:586:8: error: instruction requires: AVX-512 VBMI ISA AVX-512 VL ISA
      "vpermt2b   %%ymm2,%%ymm6,%%ymm1           \n"
       ^
<inline asm>:11:1: note: instantiated into assembly here
vpermt2b   %ymm2,%ymm6,%ymm1           
^
../../third_party/libyuv/source/row_gcc.cc:587:8: error: instruction requires: AVX-512 VBMI ISA AVX-512 VL ISA
      "vpermt2b   %%ymm3,%%ymm7,%%ymm2           \n"
       ^
<inline asm>:12:1: note: instantiated into assembly here
vpermt2b   %ymm3,%ymm7,%ymm2           
^
3 errors generated.


Original change's description:
> Roll libyuv from 1703 to 1707
> 
> Contains the following changes:
> 4ad3334 Pass float parameters via vector 2 float and "w" for scalar multiply. by Frank Barchard
> d868089 Fix building with clang targeting x86_32 mingw by Martin Storsjö
> 548ec65 Require clang 6 for AVX512 support by Frank Barchard
> c21af29 jpeg remove empty function declarations by Frank Barchard
> fdad629 Add a method to force the CPU flags by Jay Civelli
> 6ecd76a Make libyuv use the hermetic xcode toolchain. by Patrik Höglund
> 9d70f13 cpuid sandbox friendlier avoiding getenv() by Frank Barchard
> 83aa751 AVX512 VMBI version of ARGBToRGB24 by Frank Barchard
> 004954c cpu disables for AVX 512 and unittest show decimal by Frank Barchard
> 1d509f2 ARGBToRGB24_AVX2 version by Frank Barchard
> 3009890 NV21ToRGB24_AVX2 and SSSE3 by Frank Barchard
> 
> Change-Id: I90cbce98ba91ebe5eb477ad9df0640f5a1bb4994
> Reviewed-on: https://chromium-review.googlesource.com/980744
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Reviewed-by: Frank Barchard <fbarchard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546676}

TBR=jcivelli@chromium.org,fbarchard@chromium.org

Change-Id: I67f918f83ec1f23f23f4c9dfd6a06d47a88ae48c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/985872Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546770}

All we need to do is ensure that there's a leading '/' in the path, we
don't expect the path to exist necessarily, and we don't need to resolve
symlinks.  We just want to be able to search for directories by doing a
string search of the form "/foo/".  And since we don't use realpath
anymore, this should work with distributed compilation systems like icecc.

This will also avoid mis-classification of files in chromium checkouts
that are inside a directory with the same name as one of the so-called
"banned" directories, eg a checkout in /home/gen/chromium/.

BUG=583454

Change-Id: I01f6417eadf88f0e6d29624014573022e29093ff
Reviewed-on: https://chromium-review.googlesource.com/975041
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546769}

This patch adds PendingRequestInfo's nullptr check on
ResourceDispatcher::DidChangePriority() as we did for other
upstream methods, such as Cancel() and SetDefersLoading().

Bug: 819931
Change-Id: I6e1f7c87ef38209ce8b443bae108826cb28a801f
Reviewed-on: https://chromium-review.googlesource.com/981968Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546768}

Chrome/ never calls A11Y_NOTIFICATION_SHOW after refactoring, thus
ash::AccessibilityNotificationType is not needed for chrome/.

TBR=sky@chromium.org

Bug: 800270
Test: covered by tests and emulator tests
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic5b7b669074a5a00fe41dcbb814769358ae39f72
Reviewed-on: https://chromium-review.googlesource.com/982578
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546767}

This CL implements transition animation between collapsed state and
expanded state of UnifiedSystemTray.

As seen in the UX prototype, we support state change from touch gesture
and CollapseButton. In case of touch dragging, we should show
intermediate state between transition, depending on how much it's
dragged.

To support this, this CL extends UnifiedSystemTrayView::SetExpanded to
take double instead of bool, and make it render arbitrary intermediate
state. See the design doc for detail.

Video:
http://dr/file/d/1260aGQRNzgN5Y2qH5FhovT7nBbPhqoR8/view?usp=sharing

UX prototype: http://shortn/_EAeqJNHpAg
Design doc: go/cros-qs-restyling (See "Support animation" section)

TEST=manual
BUG=826999

Change-Id: Id010ad58b1fcbf77eac7c37b911fd0d164d7fe57
Reviewed-on: https://chromium-review.googlesource.com/981915Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546766}

This function isn't used.

Bug: 658997,402387
Change-Id: I01d751dfebaafd1580beaeb12ebcd124df132b26
Reviewed-on: https://chromium-review.googlesource.com/984919
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546765}

This logic existed pre-dice, and was not ported to Dice.
This is required to enable Dice by default in all tests.

Bug: 825173
Change-Id: If3e4c7a0aebbb735be45875342d66a5436ef5f35
Reviewed-on: https://chromium-review.googlesource.com/980172Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546764}

iOS version of https://chromium-review.googlesource.com/c/chromium/src/+/801051

Bug: 769471
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I9e4d6fc9aa675e705824d68e2b916096e97340fb
Reviewed-on: https://chromium-review.googlesource.com/984354Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546763}

https://chromium.googlesource.com/catapult.git/+log/191fda7cc6ae..9e3d4c4b70e0

$ git log 191fda7cc..9e3d4c4b7 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 dtu [pinpoint] Change messaging for perf try jobs.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ie39304535b817eefec8f0fc22c47b824e7e672f6
Reviewed-on: https://chromium-review.googlesource.com/985794Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546762}

This will be used to hide away ongoing fullscreen handwriting virtual keyboard work.

Bug: 826617
Change-Id: I3a67a98fd7de328e3d33aa9d7262ba4140b220ba
Reviewed-on: https://chromium-review.googlesource.com/983272Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Jianzhou Feng <jzfeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546761}

This is the content layer wiring of getStats() with the receiver
selector argument. A follow up CL will add blink layer wiring and expose
it in JavaScript.
https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm

(This CL is very similar to the RTCRtpSender.getStats() version:
https://chromium-review.googlesource.com/c/chromium/src/+/973608)

Bug: 680172
Change-Id: I2f0cb0e997602c01ad6b1a2523663811c2e0ebe3
Reviewed-on: https://chromium-review.googlesource.com/975963
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546760}

https://pdfium.googlesource.com/pdfium.git/+log/a17a0e219d5f..3b76ebd56054

$ git log a17a0e219..3b76ebd56 --date=short --no-merges --format='%ad %ae %s'
2018-03-29 dsinclair Fixup API check

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ief218c5ffb2b662bb101d028c80a0e6e6b5d8f45
Reviewed-on: https://chromium-review.googlesource.com/985651Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546759}

      level. Confirm that scale of Android app is changed as page zoom
      level is changed in Chrome settings. Note that Android side
      accepts scales from 85% to 150%.

Bug: 810473
Test: Open any Android app. Open Chrome settings and change page zoom
Change-Id: I5af0684f005cfe241c0ad3a7f529ab428f7580c5
Reviewed-on: https://chromium-review.googlesource.com/980073
Commit-Queue: Yuki Awano <yawano@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546758}

BUG=762641
TBR=afakhry@google.com

Change-Id: I722bb4de1e584041ac98c9ce71b490606d074285
Reviewed-on: https://chromium-review.googlesource.com/985535
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546757}

Blink scheduler code is transitioning to a new directory structure.
This patch moves a few files related to FrameScheduler, and rewrites
include paths in the affected files.

This patch introduces new directories: platform/scheduler/public and
platform/scheduler/main_thread. DEPS file is added to main_thread/
for moved tests.

Bug: 826203
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5894ccb0635922957aed6ada2a6e4e2e536d02e7
Reviewed-on: https://chromium-review.googlesource.com/983084
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546756}

No behavioral differences: a new struct (TrackedSession) is introduced
to represent what the tracker knows about a session, which is an
extended version of SyncedSession.

The set |tab_node_ids| is moved away from SyncedSession to the new
struct, because there's nothing that depends on it except the tracker
itself.

Somewhat unrelated, minor changes are introduced in the API as have
been suggested in code reviews.

Bug: 681921
Change-Id: Ife4c215b65dfbeb97d5c70fd1f984986b9938a8f
Reviewed-on: https://chromium-review.googlesource.com/983773
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546755}

Client (ClipboardInstance) of this version can handle a ClipData larger than 800K.

Android-side CL : ag/3763924
Doc : go/arc-image-cp

Bug: b:74877813
Test: cheets_ClipboardTest
Change-Id: I74dbd9e2e39cf5051b6f68cadef14ec5d769e897
Reviewed-on: https://chromium-review.googlesource.com/974669Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: Satoshi Niwa <niwa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546754}

This CL implements recommendations from a Desktop PWA UI review.
 - Use "Install <app>..." instead of "Add <app> to shelf..." for PWAs.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331947&signed_aid=9D-HKXE7gYd0wUpreYCSAg==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331948&signed_aid=cDTnW4abw74CAZfks6FXkw==&inline=1
 - Use "Create shortcut" instead of "Add to <shortcut container>" for non-PWAs.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331943&signed_aid=Ok3VbYPcM5cA0kp1mufUcQ==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331944&signed_aid=Jn3zF1Bjunr7NY6U5HZs-Q==&inline=1

In addition to these changes the confirmation dialog for these actions
have been updated for consistency:
 - For PWAs:
   Use "Install app?" instead of "Add to shelf?" for the title.
   Use "Install" instead of "Add" for the button.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331949&signed_aid=NBRq_H4GTrT_Nlj4uJZUgg==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331957&signed_aid=yEqown9Qn32Do3_UyXfbGw==&inline=1
 - For non-PWAs:
   Use "Create shortcut?" instead of "Add to shelf" for the title.
   Use "Create" instead of "Add" for the button.
   Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331945&signed_aid=vHvplIxwxZt1AbSCXNlRug==&inline=1
   After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=331958&signed_aid=y82Q7ebdDf31vnnHy_vqcg==&inline=1

Bug: 789817, 822305
Change-Id: Ib2fbe35f43b575a985af6c50094235dc7693a149
Reviewed-on: https://chromium-review.googlesource.com/984916
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546753}

This patch moves block related functions
 - EndOfBlock()
 - IsEndOfBlock()
 - IsStartOfBlock()
 - StartOfBlock()
to "EditingCommandsUtilities.cpp" from "VisubleUnits.cpp" because these
functions are used only in files in "editing/commands/" for improving code
health.

Change-Id: Idbf3ebc0c29d44c955fe18d5e4a09b1d38aecfef
Reviewed-on: https://chromium-review.googlesource.com/985340Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546752}

Now that all the blocker issues(see bug below) are fixed, we can reenable this
feature.

Bug: 653200
Change-Id: I42c6bc582c4b7e4af770e093e46bbf12357c7753
Reviewed-on: https://chromium-review.googlesource.com/963642
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546751}

CompositorFrameMetadata can arrive on the UI thread out of order:
Metadata is sent from compositor to UI in response to synchronous or
asynchronous draws. The synchronous draw replies is processed
immediately, even if there are replies to asynchronous draws pending. So
when there is a mix of sync and async draws, it's possible for metadata
to arrive out of order.

This has been a theoretical problem for a long time, but only became
real problem when FrameSwapMessageQueue was expecting metadata to be
ordered. The only practical fix is to simply drop out of order metadata
instead, which FrameSwapMessageQueue is designed to handle already.

Bug: 821706
Change-Id: I493862ba6d0838097f26e824359f03017eaa2a35
Reviewed-on: https://chromium-review.googlesource.com/985096Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546750}

Use ToCharacterData(node)->length() instead of Node::MaxCharacterOffset()
to avoid to use indirection call.

Because has the default implementation of Node::MaxCharacterOffset() = NOTREACEHD()
and all call sites call it for CharacterData.
Hence, it is better to deprecate to use Node::MaxCharacterOffset().

Bug: 825077
Signed-off-by: Yuhong Sha <yuhong.sha@samsung.com>
Change-Id: Ia7c44c0f92551295eb3e51cdd576ac172c2aaf25
Reviewed-on: https://chromium-review.googlesource.com/979894
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546749}

What CVC is doing with WebContentsObserver instance concerns
the action after navigation to a new contents. (whether it is
completed or render process is terminated). This CL handles
the task through a native, not Java WebContentsObserver.

There are 3 things involved for the task:
 - hidePopup / clear text selection (SelectionPopupController)
 - reset scroll (GestureListenerManager)
 - hide keyboard / (ImeAdapter)

Used GestureListenerManager to do all 3, just to avoid adding
numerous JNI calls. This is done by adding a new WebContentsObserver
so GLM can listen to the additional events in interest.

Bug: 598880
Change-Id: Ide527c0a594ed780e80522f733de6abd23ab3d6f
Reviewed-on: https://chromium-review.googlesource.com/972701
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546748}

This reference is not needed.
We can put the logic into DownloadManagerImpl.

BUG=803135

Change-Id: I7bdb0dfaa64d1860865566a67d8619fcd0f6bdaf
Reviewed-on: https://chromium-review.googlesource.com/985030Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546747}

MockObjectManager is currently not useful as the mocked methods are not
virtual.

BUG=chromium:812468
TEST=None

Change-Id: I3fa533299cda839b4f3602de88f6e76dbac5b24c
Reviewed-on: https://chromium-review.googlesource.com/982942Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546746}

This patch moves caret bounds related functions
 - AbsoluteCaretBoundsOf()
 -AbsoluteCaretRectOfPosition()
to "LocalCaretRect.cpp" from "VisubleUnits.cpp" to reduce size of
"VisubleUnits.cpp" for ease of maintenance.

Change-Id: Ie40d372bd78e7723feb7bf3e5ef73bcdb7d762df
Reviewed-on: https://chromium-review.googlesource.com/984758Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546745}

It's already used in a number of places in Blink. Blessing direct use of
the standard UMA histogram macros will also make it simpler to make
improvements to things like the macros for enumerations.

Bug: 742517
Change-Id: Ic7b83312e77918170c0dbabc92c1536fed673abc
Reviewed-on: https://chromium-review.googlesource.com/982946Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546744}

This CL fixes a null pointer crash when uninstalling an extension from
the app menu of a PWA window. The existing code expected the main UI
toolbar to be present.

Bug: 825554
Change-Id: I89353dd246168393747cca02f02444859b4457c6
Reviewed-on: https://chromium-review.googlesource.com/981839
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546743}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e367c2f4075..85a5ac7c6177

$ git log 4e367c2f4..85a5ac7c6 --date=short --no-merges --format='%ad %ae %s'
2018-03-28 ihf cbuildbot: mark caroline/kevin-arcnext important.
2018-03-26 jkop chromite: Increase VM Test timeout to 90 minutes.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:826755,chromium:818859


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8c9699eac4f21cb7c857f820d12011111218406d
Reviewed-on: https://chromium-review.googlesource.com/985650Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#546742}

This change fixes a crash when Native Filesystem Providers call the
Service::RequestMount() function via the providers_menu in the CrOS
Files App.

Bug: chromium:827023
Test: manually verified on eve
Change-Id: I25ba6fb33fe9c9ae1a360368c0d8bb45728fc7a1
Reviewed-on: https://chromium-review.googlesource.com/972421Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546741}

This patch moves the target |Unknown| because
there was a pushback in removal discussion:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/VllurNrBlL0/discussion

Until we can gather collect usage counter, postpone it.

Bug: 523952
Change-Id: I7844b37759b32120a2d542ce8ddb75e2c2230844
Reviewed-on: https://chromium-review.googlesource.com/983281Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546740}