GitLab

- Model is in binary glTF format with no inline shaders.
- Textures are composed by one base texture and three patches of minimal size.
- We also considered using WebP, but decoders are implemented only within blink.
- Monochrome APK size is increased by 40Kb.

BUG=644562
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2850893002
Cr-Original-Commit-Position: refs/heads/master@{#468806}
Committed: https://chromium.googlesource.com/chromium/src/+/c5582157f1ac2b92e412e5164c3fd49088fd7fff
Review-Url: https://codereview.chromium.org/2850893002
Cr-Commit-Position: refs/heads/master@{#469051}

BUG=701747,708192,710537

Review-Url: https://codereview.chromium.org/2833843005
Cr-Commit-Position: refs/heads/master@{#469050}

Add a basic set of tests that start up the SearchActivity, confirming
that it starts up the browser for URLs and shows the suggestions
container when something is typed in the omnibox.

BUG=708844

Review-Url: https://codereview.chromium.org/2855543005
Cr-Commit-Position: refs/heads/master@{#469049}

Reland of Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac (patchset #1 id:1 of https://codereview.chromium.org/2862583003/ )

Reason for revert:
...and relanding, because I'm trigger-happy and misread the bug report. There wasn't a problem with this reland, but with the previous one, which was already reverted.

Original issue's description:
> Revert of Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac (patchset #3 id:60001 of https://codereview.chromium.org/2858683003/ )
>
> Reason for revert:
> And reverting again, because MAYBE_ and PRE_ directives cannot be used together.
>
> Original issue's description:
> > Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac
> >
> > TBR=sky@chromium.org
> > BUG=717740
> >
> > Review-Url: https://codereview.chromium.org/2858683003
> > Cr-Original-Commit-Position: refs/heads/master@{#468963}
> > Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d0119f06c2304
> > Review-Url: https://codereview.chromium.org/2858683003
> > Cr-Commit-Position: refs/heads/master@{#469021}
> > Committed: https://chromium.googlesource.com/chromium/src/+/666f9f44c4e0aa571a167f7b9b9a8c15a6a0e964
>
> TBR=sky@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=717740
>
> Review-Url: https://codereview.chromium.org/2862583003
> Cr-Commit-Position: refs/heads/master@{#469040}
> Committed: https://chromium.googlesource.com/chromium/src/+/fe342d7b2c65097f714739bb6dabe33a1ec8b107

TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717740

Review-Url: https://codereview.chromium.org/2856223002
Cr-Commit-Position: refs/heads/master@{#469048}

I've forgot to scale the old offset before adding the offset adjustment :P
This CL fixes that bug and adds a test case to guard that pivot point remains
fixed after scaling.

BUG=714193

Review-Url: https://codereview.chromium.org/2857113002
Cr-Commit-Position: refs/heads/master@{#469047}

This change decouples preload matching from MemoryCache lookup. With this change,
preload matching is done for ResourceFetcher::prealods_.

This is the first step and part of the second step in the design document[1].

1: https://docs.google.com/document/d/1oq8ixPnaDxuAlKUTRQ3WoYHlJenVkzNU9xnkuZX_dWM/edit#

BUG=695939

Review-Url: https://codereview.chromium.org/2834733003
Cr-Commit-Position: refs/heads/master@{#469046}

E.g. CSWTCH.61 and CSWTCH.62 will now match as long as they are in the
same object file.

BUG=708865,717550

Review-Url: https://codereview.chromium.org/2857153002
Cr-Commit-Position: refs/heads/master@{#469045}

This is intended to make servicification a little simpler, since we won't
have to configure a secret global URLRequestContext used just to fetch PAC
scripts.

The system URLRequestContext will be updated in a similar manner in a
followup CL.

BUG=715697

Review-Url: https://codereview.chromium.org/2841163002
Cr-Commit-Position: refs/heads/master@{#469044}

Changed the script to use the logging module where possible and added a
--silent flag that hides gclient/ninja output. Also added stderr to
Ninja output so that users can check why a build failed.

Changed the branch restore function to use atexit so that the original
branch will be restored if ctrl-c is pressed while another rev is
checked out.

BUG=695182

Review-Url: https://codereview.chromium.org/2857073002
Cr-Commit-Position: refs/heads/master@{#469043}

Reland of https://codereview.chromium.org/2798953002 where the observer is disabled since it's still broken.

[PageLoadMetrics] Keep track of Ad Sizes on Pages

In order to help us understand the resource footprint that ads have on
webpages, we need to measure things like their network and cache utilizations.
This CL adds a PageLoadObserver that keeps track of frames with ads and
reports statistics on the number of ad frames found on the page, the size of
the ad frames, and the percentage that came from cache vs network.

As part of the work, the following additional changes were necessary:

1) Frame Tree ID and URL are added to extra request info
2) Add GetRenderFrameHostGetterForRequest to ResourceRequestInfo so that
   ChromeResourceDispatcherHostDelegate can get at the frame tree node id of
   the resource.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
BUG=708570,717892

TBR=bmcquade,clamy,jam,csharrison,isherman

Review-Url: https://codereview.chromium.org/2861473003
Cr-Commit-Position: refs/heads/master@{#469042}

No platform builds with USE_AURA and USE_OPENSSL_CERTS. This is a
remnant of some aborted attempts to switch all platforms to
USE_OPENSSL_CERTS.

BUG=671420

Review-Url: https://codereview.chromium.org/2859793003
Cr-Commit-Position: refs/heads/master@{#469041}

Revert of Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac (patchset #3 id:60001 of https://codereview.chromium.org/2858683003/ )

Reason for revert:
And reverting again, because MAYBE_ and PRE_ directives cannot be used together.

Original issue's description:
> Disable the flaky RestartTest.PRE_LocalStorageClearedOnExit on Mac
>
> TBR=sky@chromium.org
> BUG=717740
>
> Review-Url: https://codereview.chromium.org/2858683003
> Cr-Original-Commit-Position: refs/heads/master@{#468963}
> Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d0119f06c2304
> Review-Url: https://codereview.chromium.org/2858683003
> Cr-Commit-Position: refs/heads/master@{#469021}
> Committed: https://chromium.googlesource.com/chromium/src/+/666f9f44c4e0aa571a167f7b9b9a8c15a6a0e964

TBR=sky@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=717740

Review-Url: https://codereview.chromium.org/2862583003
Cr-Commit-Position: refs/heads/master@{#469040}

This CL separates the site settings protocol handler tests from the
site settings test. This is a step toward a code health todo in the
code.

(code health)
BUG=None

Review-Url: https://codereview.chromium.org/2855943004
Cr-Commit-Position: refs/heads/master@{#469039}

split between queuing delay and synchronous portion.
(there is already an end-to-end stat that covers both ops, and one for
 sync portion of open only).

Made the sync portion of open histogram split by cache_type like every
other SimpleCache statistic.

Also add synchronous portion metrics for Write/Close as both of these
seem to have opportunities for improvement, so it makes sense to measure them directly, at least short-term.

BUG=

Review-Url: https://codereview.chromium.org/2853263002
Cr-Commit-Position: refs/heads/master@{#469038}

|benchmark_sharding_map| is always non None, hence the branching to use
|bot_utils.GetDeviceAffinity| when it's None is now dead code.

BUG=713357
TBR=eyaich@chromium.org

Review-Url: https://codereview.chromium.org/2854413002
Cr-Commit-Position: refs/heads/master@{#469037}

BUG=

Review-Url: https://codereview.chromium.org/2856073002
Cr-Commit-Position: refs/heads/master@{#469036}

The proposal includes a request for a public (chromium.org) discussion
group, so we've started offline-dev@chromium.org.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal

BUG=NONE

Review-Url: https://codereview.chromium.org/2854253004
Cr-Commit-Position: refs/heads/master@{#469035}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/15b8a2e9d520..b77ce91e0576

$ git log 15b8a2e9d..b77ce91e0 --date=short --no-merges --format='%ad %ae %s'
2017-05-03 simonhatch Dashboard - Reduce bisect retries to 1.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I92a9304e26b6a6c4ca34c8d33def9e983935e698
Reviewed-on: https://chromium-review.googlesource.com/493780
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469034}

When a Tap selection is present, a second tap shows the pins, and
the Bar should keep showing.  However this seems to currently be
flaky.

This CL adds a check when a Tap is recognized to see if we're
already showing a Tap-selection.  We were incorrectly starting
a Tap sequence in response to this second tap but that's not
needed since we'll soon get a message for the Long-press gesture
when the pins show.

BUG=717942

Review-Url: https://codereview.chromium.org/2853393003
Cr-Commit-Position: refs/heads/master@{#469033}

Check that the position is correct when executing the GPU benchmark
Tap request if it isn't throw an exception.

BUG=683503

Review-Url: https://codereview.chromium.org/2838393002
Cr-Commit-Position: refs/heads/master@{#469032}

https://pdfium.googlesource.com/pdfium.git/+log/f45ade3a0af9..1e5a98afd195

$ git log f45ade3a0..1e5a98afd --date=short --no-merges --format='%ad %ae %s'
2017-05-03 npm Use enum class GifDecodeStatus instead of integers in fx_gif

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ief3b6967612c1f57d0d9070d73067204d6b752e2
Reviewed-on: https://chromium-review.googlesource.com/493874
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469031}

This CL convert all the ChromeActivityTestCaseBase direct children tests to
JUnit4. All TouchCommon methods (dragTo, dragStart, etc) are refactored
to directly calling TouchCommon. For more on JUnit4 migration, check
src/testing/android/docs/junit4.md

Previous landing CL: https://codereview.chromium.org/2831823003

BUG=640116

Review-Url: https://codereview.chromium.org/2858933002
Cr-Commit-Position: refs/heads/master@{#469030}

This treats URLs the same way they are treated in the omnibox text field:
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm?l=528&rcl=5bd9e2fd296b774e34d04cddfb09893525a79c04

BUG=712919

Review-Url: https://codereview.chromium.org/2854893002
Cr-Commit-Position: refs/heads/master@{#469029}

These methods are not used anymore.

BUG=667892

Review-Url: https://codereview.chromium.org/2853403002
Cr-Commit-Position: refs/heads/master@{#469028}

Review-Url: https://codereview.chromium.org/2854363003
Cr-Commit-Position: refs/heads/master@{#469027}

This CL forks login code which is most likely to change with the new UI. This
allows us to make breaking changes to the login screen without worrying about
the previous UI.

This adds an `isMd` boolean variable in the global scope that can be dynamically
queried if we need to make changes in a file and it is not trivial to fork it.
Otherwise, there are no code changes besides loading different assets.

BUG=717779
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2855883005
Cr-Commit-Position: refs/heads/master@{#469026}

The blocking pool is being deprecated in favor of TaskScheduler.

BUG=667892
R=steel@chromium.org

Review-Url: https://codereview.chromium.org/2773473002
Cr-Commit-Position: refs/heads/master@{#469025}

third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-frame-resource.html

This test is equivalent to the upstream version.

- third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-mixed-content-to-inscope.html
- third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-mixed-content-to-outscope.html

These tests are roughly equivalent to the upstream versions. Because the
upstream versions only differ in the inclusion of additional assertions,
the Chromium-specific versions can be safely removed.

BUG=688116
R=mek@chromium.org

Review-Url: https://codereview.chromium.org/2859653002
Cr-Commit-Position: refs/heads/master@{#469024}

BUG=none, follow-up of https://codereview.chromium.org/2854663002/.
TEST=aura_unittests

Review-Url: https://codereview.chromium.org/2858633005
Cr-Commit-Position: refs/heads/master@{#469023}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b4916264..5aa79437

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2860763002
Cr-Commit-Position: refs/heads/master@{#469022}

TBR=sky@chromium.org
BUG=717740

Review-Url: https://codereview.chromium.org/2858683003
Cr-Original-Commit-Position: refs/heads/master@{#468963}
Committed: https://chromium.googlesource.com/chromium/src/+/dd799306dbacf94b73b935d9870d0119f06c2304
Review-Url: https://codereview.chromium.org/2858683003
Cr-Commit-Position: refs/heads/master@{#469021}

Manually converted tests to use new Audit.

BUG=704967
TEST=
StereoPanner/stereopannernode-no-glitch.html
StereoPanner/stereopannernode-panning.html

Review-Url: https://codereview.chromium.org/2788793004
Cr-Commit-Position: refs/heads/master@{#469020}

This is the maximal amount of characters from the left and from the right
taken together, i.e. there is 120 on each side.

BUG=717619

Review-Url: https://codereview.chromium.org/2862503002
Cr-Commit-Position: refs/heads/master@{#469019}

The bindings are updated to include ES3 functions. However, the context that is created for GPU rasterization is still ES2 so this should have no effect. An ugly version string hack that was temporarily needed to restrict Skia to ES2 is removed as it is no longer necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

BUG=651829

Review-Url: https://codereview.chromium.org/2436813005
Cr-Commit-Position: refs/heads/master@{#469018}

This eliminates the chance of a diff coming up where the symbols do not
sum up to the entire section delta

Other misc changes here:
 * Improves the size summary messaging.
 * Kills nm subprocess upon exit (rather than letting process finish)
 * Allows linker maps to not have a Common Symbols section

BUG=714180

Review-Url: https://codereview.chromium.org/2858793002
Cr-Commit-Position: refs/heads/master@{#469017}

This check returns false for the first part of the loop and returns true for the second
one. We split this loop in two and remove this check.

Review-Url: https://codereview.chromium.org/2807933002
Cr-Commit-Position: refs/heads/master@{#469016}

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2853383003
Cr-Commit-Position: refs/heads/master@{#469015}

Move threat_details* to the safe_browsing component and
update build files and dependencies.

BUG=700351, 688629

Review-Url: https://codereview.chromium.org/2836103002
Cr-Commit-Position: refs/heads/master@{#469014}

There's a race condition that's causing a tab to finish
loading before onStartWithNative has successfully run.
It's not entirely clear where the race condition lies
because the startup pathway is complicated, so prevent
deferred startup from running until native has loaded.

BUG=711708

Review-Url: https://codereview.chromium.org/2855043002
Cr-Commit-Position: refs/heads/master@{#469013}

base::SharedMemory used to support synchronous transport of handles into other
processes using base::SharedMemory::ShareToProcess. This required
base::SharedMemoryHandle to also track whether the OS resource belonged to the
current process. ShareToProcess has been removed, so all the pid tracking is no
longer necessary.

BUG=716206
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
TBR=wfh@chromium.org

Review-Url: https://codereview.chromium.org/2849243002
Cr-Commit-Position: refs/heads/master@{#469012}