- 03 Nov, 2020 40 commits
-
-
Tim Song authored
BUG=1138137,1106937 Change-Id: If93f56067d670e1baa8e4e5fd639b2a4768df2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516389Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#823720}
-
dpapad authored
- Include webui_generated_resources.grd to Android and iOS builds (previously only included on Desktop). - Update shared_resources_data_source.cc and shared_resources_data_source_ios.mm accordingly. - Update various BUILD.gn file as needed. - Move all ui/webui/resources/js/cr/ui/ files from webui_resources.grd to webui_generated_resources.grd. Bug: 1132403 Change-Id: I7e92caf28f80ce31ce6e9009e63821037283e508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503814Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#823719}
-
Becca Hughes authored
This is a reland of 530c8fd2 The fix is to remove the include for media_session_service.mojom that has been deleted. Original change's description: > [Media Session] Convert interface from mojo to CPP > > Context: https://crrev.com/c/2485850 > > This converts the MSS interface to CPP since it does > not need to be mojo. > > BUG=1140215 > > Change-Id: I595bef21cddf755bc0fb423f87db9e620227d3e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503393 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823358} Bug: 1140215 Change-Id: I23a4043529e236174f44377402a8e1fbc5a23600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518085 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#823718}
-
Devlin Cronin authored
Use `= default` for move constructors and assignment operators. This cuts down a lot of bespoke code. Bug: None Change-Id: I818befbe8d70027f5d7b69da53ebc261028b113a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511331 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#823717}
-
yilkal authored
This is a reland of 27e795c1 Original change's description: > Reland "Adds parental handoff login screen in oobe." > > This is a reland of dca1afe8 > > This is an interesting failure point due to the difference between > official builds and non official builds. In official builds, the > Sync Consent screen is shown and it will not exit until we interact > with it. The waiters timeout waiting for the Parental Handoff Screen > to be shown. > > Original change's description: > > > Adds parental handoff login screen in oobe. > > > > The description and mock can be seen in the comments in the bug report. > > > > Bug: 1134567 > > Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618 > > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > > Reviewed-by: Aga Wronska <agawronska@chromium.org> > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > > Reviewed-by: Jesse Doherty <jwd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819158} > > Bug: 1134567 > Change-Id: Id4d8c15363579799da14a3f3ed0a285e61dde5d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489756 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820388} Bug: 1134567 Change-Id: Ibec5b7defb09229c1e5d13c930db793ba02eb40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499362 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#823716}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/74023424daa4..4735f01193b8 2020-11-03 rharrison@chromium.org Move diagnostic/printer.h into the public API 2020-11-03 bclayton@google.com formatter: Remove colon line prefix with no source 2020-11-03 bclayton@google.com diagnostic/printer: Print newline at end of tests 2020-11-03 bclayton@google.com Fix all warnings when building with CMake + clang 2020-11-03 rharrison@chromium.org Add tests for MinBufferBindingSize 2020-11-03 dsinclair@chromium.org Fixup lint errors. 2020-11-03 bclayton@google.com Add test for bad function attribute 2020-11-03 bclayton@google.com Have tint executable use the diagnostic printer 2020-11-02 bclayton@google.com Make Formatter a non-interface 2020-11-02 dsinclair@chromium.org [spirv-writer] Generate load in Unary Op generation. 2020-11-02 bclayton@google.com Implement diagnostic color printing 2020-11-02 bclayton@google.com Fix all doxygen warnings 2020-11-02 bclayton@google.com Remove Parser constructors that take a string 2020-11-02 dsinclair@chromium.org Make doxygen happy. 2020-11-02 bclayton@google.com Use the new diagnostics for wgsl the parser 2020-11-02 dneto@google.com spirv-reader: support scalar spec constants 2020-11-02 bclayton@google.com Add tint::diag namespace for diagnostics 2020-11-02 bclayton@google.com Produce end ranges for tokens and AST nodes 2020-11-02 bclayton@google.com Rm line() & column() from wsgl::Token & ast::Node 2020-11-02 bclayton@google.com Remove tint::Source(size_t, size_t) constructor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I3957366127fe28170940d35cc2e0cee0527e139c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823715}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ia8a7c82359c99a71affc476e4eba002ce73702ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518191 Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#823714}
-
minch authored
After crrev.com/c/693322, the clickable logic of TrayInfoLabel hasn't been used by any class. Bug: 1131543 Change-Id: I81e3234f7c6b88c1d2083986adb95a61746ffad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510730Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#823713}
-
Donn Denman authored
Adds a new CGI param for Related Searches to Contextual Search that contains experiment and processing information for offline logs quality analysis. This param is used for both the Resolve and Search requests. BUG=1144916 Change-Id: Ibc8b4ced4831f8c867be2185ed174b7306b248cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515225 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#823712}
-
Josh Nohle authored
Change-Id: I3ee3371c1f7ca450ba85d78896ddc641600ec97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518400 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#823711}
-
Anne Lim authored
The footer is shown only to signed-in users have more than one account, and who do not sync. Screenshot with feature enabled in light mode: https://screenshot.googleplex.com/ApVmkMVQakM6ai9 Screenshot with feature enabled in dark mode: https://screenshot.googleplex.com/BJB2jUuGoH3T5jM Bug: 1135847 Change-Id: Ia2e031a48920e44e66503fab62f26ed87b8e1d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496184 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#823710}
-
Alexander Timin authored
Add a flow event connecting the place where a new task is added to the execution queue and the event marking the execution of the said task. R=vmiura@chromium.org BUG=1142207 Change-Id: I53e21326a0c986da4c26805be544e27a11ec6395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495147 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823709}
-
Scott Lee authored
As found in https://crbug.com/1141606#c5, the symptom appeared on Windows-10-18363 bots only, but not on Windows-10-17134. Since 2020-10-21, fyi win builders run tests on Windows-10-17134 bots only, and it should be safe to enable resultdb on fyi builders. In the meanwhile, I will continue investigating into the slowness issue. R=chanli@chromium.org,gbeaty@chromium.org CC=nodir@chromium.org,bpastene@chromium.org Bug: 1141606 Change-Id: I48a8ca06724828cd887bc260be71716d8db2ffee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518111Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823708}
-
Joe Downing authored
I am working on some ETW stuff for Chrome Remote Desktop and I noticed that this parameter is unused and a default value of 16KB is always used. This isn't a big deal as the only caller appears to be its unit tests but it seemed like the value passed in should do something. The other approach would be to remove the param but adjusting the buffer size seems like a reasonable thing to expose (assuming the param is actually used). The issue in the previous CL was that the unittests requested a buffer size of 100MB but the max size is 1MB for realtime logging. The try-bots didn't detect the failure so I'll make sure this passes on the ASAN bots before submitting. This is an updated reland of: https://chromium-review.googlesource.com/c/chromium/src/+/2511290 Change-Id: I73bff2493f2ffcee6195faed7b4ab82d119259b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516886 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Joe Downing <joedow@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#823707}
-
Dominik Röttsches authored
Take into account swapping of underline and overline in vertical, when using text-underline-position "right" and "left". Add 3 WPT tests to ensure text-overline-offset is not applied to overline and that the underline on the correct side is offset in vertical. Bug: 1143600 Change-Id: Idd52a5d2d953fc486050ef20a1960ab51145521c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510829Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#823706}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604404061-a0e49f41ece3a518deb5950cf222a12f66659bab.profdata to chrome-linux-master-1604426269-c37b60c52a129039000efce9374c5d976d3c4e8a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I435ca8aa5d49ceaaf9198783b0c6392b830e08f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518073Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823705}
-
Nico Weber authored
https://chromium-review.googlesource.com/c/chromium/src/+/2510772 tried to force the arm_float_abi gn arg to softfp on Android. But since arm_float_abi was declared only in arm toolchains, it broke builds that declared the android_clang_arm toolchain but didn't actually instantiate it. To work around this, https://chromium-review.googlesource.com/c/chromium/src/+/2512899 made arm_float_abi available unconditionally, even in non-arm builds. Instead, make arm_float_abi a declare_arg only on non-android arm, and set it to a fixed value in arm.gni for android builds. I tested this in chromium and webrtc builds. No real behavior change, except that arm_float_abi is exposed as gn arg in fewer cases (which seems like a good thing). Bug: 1144188 Change-Id: I2260f2abb9bbb91ab8b87760014cf1a553264dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517423 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#823704}
-
David Dorwin authored
The default is changed from WARN to NONE. Bug: 1145025 Change-Id: Iab4cd336ebf44d2a71eabb199bf7f2cfcdebfc6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517006Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823703}
-
Daniel Cheng authored
This is likely due to https://crbug.com/838348, where browser-side state becomes desynced from the renderer-side state and causes the main frame to be incorrectly detached. Note that this doesn't fix the real problem and likely just pushes a possible crash slightly further into the future. Bug: 838348, 1143380 Change-Id: If334b7312ed57607dea8605d355b1124a8dd455e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518105 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#823702}
-
minch authored
Unified system tray had been launched long time ago. |use_unified_theme_| is always true now. Bug: 1131543 Change-Id: I38ceb731b02e774a8f8ee44577077cdeb5103f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508635 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#823701}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eb999bce4f0f..7d3f089e5811 2020-11-03 johnstiles@google.com Fix use-after-free error discovered by the fuzzer. 2020-11-03 vigneshv@google.com Reland "heif: Add AVIF type and AVIF sniffing" 2020-11-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 71d2e1d23d49 to 3bf9f4a2e65e (4 revisions) 2020-11-03 brianosman@google.com Disable "any" function workaround in standalone/non-GPU caps 2020-11-03 johnstiles@google.com Create test case for oss-fuzz:26942. 2020-11-03 michaelludwig@google.com Update GrAtlasTextOp::MaskType to enum class 2020-11-03 bsalomon@google.com GrRefCntedCallback has Make function. 2020-11-03 michaelludwig@google.com Improve coverage AA for thin quads 2020-11-03 egdaniel@google.com Add support for wrapped GrAttachments. 2020-11-03 robertphillips@google.com Minor cleanup of GrTriangulatingPathRenderer 2020-11-03 tdenniston@google.com [svg] Add feTurbulence filter (incomplete) 2020-11-03 bsalomon@google.com Add SkImage::MakeFromYUVATexturesCopyToExternal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:820987 Tbr: bsalomon@google.com Change-Id: I0918cf75801d4a1ae2cf73730f4d6493f7cd4e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518063Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823700}
-
Sophey Dong authored
Bug: 1135311 Change-Id: I5fa5d931a9eba2ff82bed1bda09dcb4723f35c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508198Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823699}
-
Mei Liang authored
This CL adds accessibility announcement for the undone closed tab action. This announcement is announced after user has pressed the undo button in the snackbar under GTS or the reopen button under the accessibility tab switcher. Skip-Translation-Screenshots-Check: True Bug: 526259 Change-Id: I18ef6ab8e606f27d6dab609a8a37757b4d20556e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518102 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#823698}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: Id3265adb0eb56ae651145b6ab7a643ba84d8a50a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516887Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#823697}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604404061-6e4b1d6492901c864984b20d97dc0cd527cfcccf.profdata to chrome-mac-master-1604426269-8f05fba2f9491fbe2e5ad2e4e4fb4bee6873c7ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I36e2826001e69a56fcb6cc08266467e8f5effd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823696}
-
Matt Wolenetz authored
BUG=1143546,1145278 R=sky@chromium.org,bbudge@chromium.org Change-Id: I23be33444805035442f858e84a72d0f05465e964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518268Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#823695}
-
Jamie Madill authored
Skia Gold requires tests to run on CI before registering golden images in the dashboard. This fixes odd behaviour we were seeing where only one golden image was visible on the UI despite accepting many of them. This adds the ANGLE restricted trace tests to 8 bots: - Win10 FYI x64 Release (Intel UHD 630) - Win10 FYI x64 Release (Intel HD 630) - Win10 FYI x64 Exp Release (Intel HD 630) - Win10 FYI x64 Release (NVIDIA) - Win10 FYI x64 Exp Release (NVIDIA) - Linux FYI Release (NVIDIA) - Linux FYI Release (Intel UHD 630) - Linux FYI Release (Intel HD 630) Once we move to the chromium.angle waterfall we can remove these tests entirely from GPU.FYI. Bug: angleproject:5297 Change-Id: Ic36932cc7aa5dbb922565517a3f7a64f6e694ac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517621Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#823694}
-
Joel Hockey authored
Make it clearer that it is the virtual path which is passed in, not the absolute path in the host. Change-Id: I2506387a06463c0a6635e3b0ecfb3a29455268b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515428Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823693}
-
Gabriel Charette authored
R=fdoray@chromium.org Change-Id: Ie210d0d4f63eecf35b53c0419393b4c6c3ca26a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504193Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#823692}
-
Caitlin Fischer authored
Bug: 1145159 Change-Id: Ie83ca14104ce98e1eb9655ce2ac3367e5a6905b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517381Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#823691}
-
Mark Schillaci authored
This CL updates the strings/content for aria-current nodes on Android. In the previous CL (https://crrev.com/c/2493660), we added a base string with a placeholder that was dynamically populated. This presents an issue with gendered languages and translations, as the "current" text would need to match the gender of the dynamically populated portion. To fix this, we instead make each string the full content, and removed the dynamic placeholder logic. AX-Relnotes: N/A Skip-Translation-Screenshots-Check: True Bug: 1093578 Change-Id: I11ef9ae570a632176bfe9819b852f584e8f0634d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511036Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#823690}
-
Michael Montvelishsky authored
Bug: 170082901 Change-Id: I84be6454a82eb394b67a26a1c2ac44ce9a01d7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518260 Auto-Submit: Michael Montvelishsky <mont@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#823689}
-
Egor Pasko authored
Reason: ntp.NewTabPageTest#testFocusFakebox failing on builder "Lollipop Tablet Tester". Tbr: twellington@chromium.org Bug: 1145195 Change-Id: I611995e08bfb2f540e0ee184f036b646d8d66b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517725Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823688}
-
Joel Hockey authored
Partial revert of crrev.com/c/2461372 where changes should have only applied to OS_LINUX and not OS_CHROMEOS. Bug: 1144979 Change-Id: I752783a181afa8c40e73e883b2906cfd5da1e7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515806Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823687}
-
Peter Wen authored
Error: util.build_utils.CalledProcessError: <exception str() failed> This is due string.decode turning stdout and stderr into unicode strings in python 2. Bug: None Change-Id: Id21da9a9126f31c851932a62a9fbf349a658ec7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511881Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823686}
-
Jamie Madill authored
This was most likely fixed along with several changes that went into fixing angle_end2end_tests on TSAN. Bug: chromium:1035461 Change-Id: I5de352a9f1d00226ccf5c00b220689082c475ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517643 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#823685}
-
dpapad authored
This reverts commit b70bf309. Reason for revert: Caused crbug.com/1145097 and crbug.com/1145103. The former is trivial to fix, while the latter requires changes to code that resides outside the Chromium repo. Original change's description: > NTP: Enable scrollbars to follow system's light/dark theme. > > Previously scrollbars always appeared light, even if a WebUI > page was otherwise respecting dark mode. The upcoming > FormControlsDarkMode feature allows webpages to specify whether > scrollbars should follow the system's theme, by specifying a new > <meta name="color-scheme"> tag. > > Launch Chrome with the following flags to experience dark scrollbars. > --enable-features=WebUIDarkMode,CSSColorSchemeUARendering \ > --force-dark-mode > > Bug: 1142291 > Change-Id: Iaaea8427a88bdf7cb53559e5fed35d8d59df5ef3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513686 > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Commit-Queue: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823279} TBR=dpapad@chromium.org,aee@chromium.org Change-Id: If6ec121d06e7ec1e38c3e814681379ddc0a0a7f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142291,1145097,1145103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518190Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#823684}
-
manukh authored
Adds a OmniboxTriggeredFeatureService, accessible through AutocompleteProviderClient, that registers features as they're triggered which are copied to the metrics logs once an omnibox session ends. Change-Id: I311fc20b185dd58b1acc6174321e47a38f794c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437743 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#823683}
-
Alex Turner authored
Use of base::Bind and base::Callback is deprecated in favor of the more explicit Once/Repeating versions. Despite being marked as fixed, a few directories have a few remaining uses that were missed in the conversion. This cl fixes those stragglers in the components/* directories that have been marked as fixed. The presubmit is also enabled for these directories to avoid any future regressions. Bug: 1141533, 1007674, 1007677, 1007712, 1007717, 1007739, 1007747 Change-Id: I3bf96c5e820168a01f5859ad2a5e181bb28b22d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505579Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#823682}
-
Omar Morsi authored
This CL introduces ARC key permissions manager delegate which observes changes that affect ARC usage allowance of corporate keys residing on a specific token. If an ArcKpmDelegate observes a change in the state of ARC usage allowance, it notifies all observers. ArcKpmDelegates are utilized by key permissions managers to keep key permissions updated in chaps. Bug: 1113115, 1127284 Change-Id: Ib7636c83f313904c7d5a23f91baca6bf43907344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479706 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Long Cheng <lgcheng@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823681}
-