- 27 Aug, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium a1c6c1a6. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" 5546163a "Temporarily send `Sec-Fetch-*` headers via non-secure transport." d3b97055 "Update simulateUserActivation to match webxr-test-api spec" 2d090a27 "[WPT/referrer-policy] Call getRequestURLs() for each subtest" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iecad6b387f7942ab92371625a9e80533e2f5e3e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772087Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690850}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7ad424d601e2..db16ee85fb52 git log 7ad424d601e2..db16ee85fb52 --date=short --no-merges --format='%ad %ae %s' 2019-08-27 malets@yandex-team.ru Wrap results.output_dir in os.path.realpath() in json_3_output_formatter.ResultsAsDict. Created with: gclient setdep -r src/third_party/catapult@db16ee85fb52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:996105 Change-Id: I07ee94eb281e13f5f30c2fb5c477a747f278e7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690849}
-
Thomas Guilbert authored
This CL allows the Renderer process to request a LearningTaskController from the Browser process. The MediaMetricsProvider is used as a bridge between the Renderer and the Browser process. It binds the incoming mojo request to a MojoLearningTaskControllerService. The service in turn forwards calls to a LTC owned by the appropriate BrowserContext's LearningSession. Bug: 994831 Change-Id: Ib2e3e35500da858688de0d49f3989968730b86ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764791Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#690848}
-
Erik Chen authored
Change-Id: I619dda7a91016698a4d3f0b5a3bbda00decf781f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772088 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#690847}
-
Piotr Bialecki authored
Minor refactor for too-long variable names, obsolete comment cleanup. Refactor XRPlaneSpace into XRObjectSpace that can be used by XRPlane and XRAnchor. Refactor allocating TransformationMatrix in XRPlane - it's not necessary to allocate it when it's being updated. Adjust the code to account for the fact that anchor objects can be created in an uninitialized state as the anchor creation API is promise-based and the objects will be surfaced to JS prior to RAF callback that will update them. Surface XRAnchor set from XRFrame (returns same result as XRSession). Both XRAnchor and XRPlane objects internally know their ID (it will be needed for anchor creation). Adjust anchor creation stubs to take XRRigidTransform - XRPose does not have an app-exposed constructor in JS. Bug: 992029 Change-Id: I8313f15b5943535f10da627191a231581a7758ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769697Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#690846}
-
Nick Burris authored
If we parse a TextFragmentAnchor but don't find a match, we should fallback to matching the element anchor, if there is one. Example: https://spaceplace.nasa.gov/blue-sky/en/#similar##targetText=notamatch Bug: 992522 Change-Id: Ie6dd2a4f5b35a612d563a3acb81392df756ce1d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746210 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690845}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f4081b4ef9b..73c58302fc9e Created with: gclient setdep -r src-internal@73c58302fc9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7c8f778c63dbd515361fe692a8d182735f57da62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773442Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690844}
-
Nico Weber authored
GN grew a string_replace() function we can use here. No behavior change. Bug: none Change-Id: Ic06e6aa40f4507047bc3cff143af84bc8a99c777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773538Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#690843}
-
gogerald authored
Before: https://drive.google.com/file/d/1A89i4BC32cSpzCuhW2jmhQR0OQKa73WO/view?usp=sharing https://drive.google.com/file/d/16jQU90GJZxdKXhG8Vhdzp4U1tELQtJ62/view?usp=sharing After: https://drive.google.com/file/d/17CHZtgW-ygZ7lFcHftGOkjBuWeuwu6Ds/view?usp=sharing https://drive.google.com/file/d/1X8T4OE9e4MlX0CmA7tXKWuc6s6LwbiYI/view?usp=sharing It visually aligns the first Tab in the Tabs carousel with the explore surface cards. It also makes the Tabs carousel use the entire device width when scroll is needed. Screenshots confirmed by UX designer. Bug: 996381 Change-Id: Ic9d65b5eac6f771140b44f0562e3e1e9452f3cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768865 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#690842}
-
liberato@chromium.org authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/0f36d36f4973..d7ba23c23434 $ git log 0f36d36f4..d7ba23c23 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 liberato Fail matroska parsing with an error rather than assert. Created with: roll-dep src/third_party/ffmpeg Bug: 996523 TBR: wolenetz@chromium.org Change-Id: I8f43d0aebfa23d5608333fa5446660cc7ab3bd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773342Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#690841}
-
Sophie Chang authored
This will record the last decision made during a navigation for each type and target. Bug: 969558 Change-Id: Ifdfebd7e349e491e52c30aa3190bc4e1d8f3436f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762982 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#690840}
-
Andrei Chulkov authored
The text is usually the most important part of the illustration dialogs. However, the image takes up most of the space in landscape or multi-window mode, making it impossible to read the text on many devices. This CL implements hiding the illustration in cases where there isn't enough vertical space to show it. Bug: 983445 Change-Id: I990d1beb2d89bedd9b0d135a8de614de471a1a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761601 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#690839}
-
Regan Hsu authored
Change-Id: I8065f48aefce80816914aa7b73f219a9e2eead6e Bug: 987659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773444Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#690838}
-
Felipe Cerqueira authored
Bug: 927957 Change-Id: Iea605992b365560bc44a1527251f04a981cce123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772546Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#690837}
-
chrome://bookmarksHector Carmona authored
Screenshots in bug. Bug: 910412 Change-Id: I89b3355c430a911f4f4fa7691c815846e3fd65e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761522 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#690836}
-
Lev Rumyantsev authored
Bug: None Test: None Change-Id: Ife43b9b735044d9eabde1ca5574d252c919f5691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768828Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Lev Rumyantsev <levarum@google.com> Cr-Commit-Position: refs/heads/master@{#690835}
-
Michael Thiessen authored
Simplifies tab restore by copying from NoTouchActivity, which has the same persistence model (currently) as WebappActivity. This also simplifies the stale directory cleanup to only clean up more recent sources of stale directories. This could lead stale directories to stick around when updating from very old versions of Chrome, but these directories should be small regardless. Also deletes some unused webApk UMA constants, and deletes the unused histogram generation code in NoTouchActivity for tab restore. Bug: 525785 Change-Id: I615542e2f28a147ecd5403b04b61b749f3e737ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769313 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#690834}
-
rbpotter authored
Based on https://chromium-review.googlesource.com/c/chromium/src/+/1744521 by dpapad@ Autogenerate Polymer 3 version of cr-icon-button, add closure target, and autogenerate and run its automated tests. Bug: 965770 Change-Id: I060066de84d419379b1cd248d3ea0fa43c2e100b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772371Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#690833}
-
Sigurdur Asgeirsson authored
This takes care of GraphImpl as well as BrowserChildProcessWatcher. Additional CLs upcoming for more of the same. Bug: 966840 Change-Id: I1b38f0f941722aeee7f615db5061ce58d0260578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771178 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#690832}
-
Joel Hockey authored
Bug: 998192 Change-Id: Ia123dfe2a2ba1fcad117de3aab540806b1d0d1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772940 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#690831}
-
Antonio Rivera authored
Currently there are two nearly-identical declarations/definitions of MonotonicClockNow: one in MediaPipelineBackendForMixer, and one in internal chromecast code. With this change, we can use the same function for both use cases to avoid repeated code. Test: cast_audio_backend_unittests pass Bug: b/139928913 Change-Id: Ibe2216b92a0a8f6529297c7ffe35220cad871046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771053Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Antonio Rivera <antoniori@google.com> Auto-Submit: Antonio Rivera <antoniori@google.com> Cr-Commit-Position: refs/heads/master@{#690830}
-
Bailey Berro authored
For guest users, don't show the extraneous horizontal separator. Bug: 986246 Change-Id: Ifa1fb57e260cf754c6eb398986175ce1bd4f9122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771051Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#690829}
-
Nico Weber authored
Bug: angleproject:3827 Change-Id: Ib8a743d77700db2a91e3f7b4a3bd9f81ebb28f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773184 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#690828}
-
Steven Bennetts authored
Bug: 853953 Change-Id: I25c0b40b23936d8c89790153f97d135780035026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769548 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690827}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/3de7170b31c5..6c73c33b7d8c $ git log 3de7170b3..6c73c33b7 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 renjietang No longer send SETTINGS in gQUIC. 2019-08-26 fayang gfe-relnote: In TLS client handshaker, call OnHandshakeComplete when handshake is finished. Protected by existing FLAGS_quic_supports_tls_handshake. 2019-08-26 bnc Remove VersionUsesQpack() TODO. 2019-08-26 zhongyi Always create and destroy a single client in the creation of the QuicClientTest to ensure persistent sockets for certificate verifiers are opened before testing. 2019-08-26 bnc gfe-relnote: Deprecate gfe2_reloadable_flag_quic_avoid_empty_frame_after_empty_headers. 2019-08-26 fkastenholz Save all data from received IETF Connection Close frames 2019-08-24 ianswett gfe-relnote: Do not enable version 99 unless gfe2_reloadable_flag_quic_use_parse_public_header is also enabled. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I71b64773eb6640f78dba6b43cf864070127998f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772294 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#690826}
-
Etienne Pierre-doray authored
This patch makes it a requirement for all task traits to specify their thread affinity on ChromeOs. Previously task traits that did not name a specific thread would implicitly run on the thread pool, which could be surprising. To make this more obvious, thread pool tasks must now use the base::ThreadPool() trait. Previous patch applied the checks on all platforms except ChromeOs which was failing: https://chromium-review.googlesource.com/c/chromium/src/+/1769080 This CL enables the check on ChromeOs: joelhockey@ fixed the chromeos build in https://chromium-review.googlesource.com/c/chromium/src/+/1767447 Bug: 968047 Change-Id: I18efe212b94fe35f55e446c76ce2c3f20cc259f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771976Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#690825}
-
Ken Rockot authored
Adds a BinderRegistry::AddInterface() override which accepts a PendingReceiver-based binder callback. This is to ease the ongoing mass transition of code over to newer Mojo typenames. Cleans up a bunch of one-off transitional helper functions that were added recently due to a lack of this support. Bug: 955171 Change-Id: Id55412a7e87e6ba0261f9710b40a8366d2c3226b TBR: tkent@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772056 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690824}
-
Clifford Cheng authored
The idle page test runs with and without MR extension, but there is no good way to distinguish them because they use the same name. Now, for the test with no MR extension, we use #no_media_router to identify it. Change-Id: Iac6bc9f1ab411e14c0d51129290c293394f8ded9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772569 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#690823}
-
Ian Kilpatrick authored
This is necessary for a followup patch: https://chromium-review.googlesource.com/c/chromium/src/+/1769158 But split out here for simplicity. This new flag will return true if a self-collapsing block has any adjoining object descendants (typically floats). Change-Id: I9e901aae9971a64d854a70672a5b26d5026d2bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772291Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#690822}
-
Stephen McGruer authored
Bug: 900581 Change-Id: Ia92d41788e13e7fb496b3e426d54622320f137cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769306Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#690821}
-
Steven Bennetts authored
The type is not used for communication with chrome over the network config api, it is associated with the chrome.send calls for third party vpns. Bug: 853953 Change-Id: I9c4217b2f3cd2cee482ad51c0f0c4edd66ba8326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769617 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#690820}
-
Mike Klein authored
It's coming through SkRefCnt.h incidentally today. Change-Id: If729712090749f323c176217add7ebec5bf4cf07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773401 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#690819}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 997713 Change-Id: I8431c2d6bf3df0d5731dc48b5870bae2604aef63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771936 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#690818}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 121 histograms that show frequent access in the past 90 days. These are the 70% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-02-23. Change-Id: Iad055af9ccafc95bff082623107faca6a5141202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769095 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#690817}
-
Staphany Park authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/ed2eef654373..6a3d632f40a1 git log ed2eef654373..6a3d632f40a1 --date=short --no-merges --format='%ad %ae %s' 2019-08-26 misterg@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@6a3d632f40a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC isamsonov@google.com,staphany@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: Ie0dacd9cdc4c122fa7089c946ed30803a65e0af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771590 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Staphany Park <staphany@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#690816}
-
Philip Rogers authored
Now that BlinkGenPropertyTrees has launched, there is no need to track OverscrollBehavior on cc::Layer because it is tracked on cc::ScrollNode. Bug: 994361 Change-Id: Ic87508ed0e67c7be47b87f9313df554be01c891b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773200 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#690815}
-
Alex Keng authored
The leak detector (enabled by --enable-leak-detection) complains because the SVG images created and owned by the UA style sheet are not free'ed at the end of the tests but it's expected because the UA style sheet is a singleton (DEFINE_STATIC_LOCAL) and the SVG images will never be free'ed while a renderer is alive. Since the leak detector is not interested in anything referenced from CSSDefaultStyleSheets [1], this CL addresses the leak by re-creating the default style sheet in CSSDefaultStyleSheets::PrepareForLeakDetection to clean up the SVG resources before the leak detection. This CL also sets flattenhtml=true for IDR_UASTYLE_THEME_CONTROLS_REFRESH_CSS, which was reverted by [2] due to the memory leak. (The reverted CL [3] will be re-landed in a separate CL) TestExpectations is also updated to re-enable password tests which was disabled due to the memory leak. [1] discussion on memory-dev: https://groups.google.com/a/chromium.org/d/topic/memory-dev/LwiD2RBqUpg/discussion [2] https://chromium-review.googlesource.com/c/chromium/src/+/1722789 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1716161 Bug: 988232 Change-Id: I2f289e90f7c16cfe23f501ddc19ea219be7c5bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772657 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#690814}
-
Xianzhu Wang authored
Previously though TransformationMatrix was marked as alignas(16) and the compiler generates machine instructions assuming the alignment, the alignment was not always ensured, e.g. when a TransformationMatrix field was in a GC object (which is allocated by Oilpan which doesn't support alignment at 16-bytes). The program would crash when misalignment happened (which could be random). We had to workaround that by using something like unique_ptr but that is fragile and hard to ensure. The alignment was added in [1] for x86_64 16-byte-aligned SSE2 instructions which were faster than the unaligned counterparts on older architectures. On modern architectures since Sandy Bridge (first CPU shipped in 2011), aligned and unaligned SSE2 instructions have the similar performance [2][3][4]. Now we remove alignas(16) from TransformationMatrix to avoid the alignment trouble. [1] https://chromium.googlesource.com/chromium/src/+/acbc19c46aace2f7980876d96422067f61eb3f01 [2] https://software.intel.com/sites/landingpage/IntrinsicsGuide/#techs=SSE2 (see Performance of _mm_load_pd, _mm_loadu_pd, mm_store_pd, mm_storeu_pd) [3] https://software.intel.com/en-us/forums/intel-isa-extensions/topic/752392 [4] https://www.agner.org/optimize/instruction_tables.pdf Bug: 993638 Change-Id: I24524a1dae259f69c2a47fb0ac97dc517047be03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752840Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#690813}
-
Becca Hughes authored
As per UI review, we should change the swipe to dismiss direction from vertical to horizontal. Therefore, swiping right should dismiss the controls. BUG=998125 Change-Id: I88998ec07b49b9ba5ad316647848a71167f5b8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773441Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#690812}
-
Lei Zhang authored
https://crrev.com/690041 added handling for out of bound indices in PDFiumPage::GetTextRunInfo(), but failed to consider a valid situation where all the text in a text run are whitespaces. In this case, GetTextRunInfo() needs to report the number of characters processed. Add a test case with just a whitespace to test this condition. Also update hello-world.in to have a {{streamlen}} macro and regenerate hello-world.pdf Bug: 997747 Change-Id: Id9e074080b19e4c642cf75fa6b72c5eb969197a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769842Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#690811}
-