GitLab

Use of the base namespace in Blink is not currently recommended. Fortunately
WTF::OwnPtr is a drop-in replacement here.

Review URL: https://codereview.chromium.org/1310743006

git-svn-id: svn://svn.chromium.org/blink/trunk@201802 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=pdr

Review URL: https://codereview.chromium.org/1316863011

git-svn-id: svn://svn.chromium.org/blink/trunk@201800 bbb929c8-8fbe-4397-9dbb-9b2b20218538

By storing parsed meta viewport, we can apply it without reload when emulating mobile device.

BUG=none

Review URL: https://codereview.chromium.org/1328553003

git-svn-id: svn://svn.chromium.org/blink/trunk@201799 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We were only testing the default value for align-items (stretch),
but not other values (like we do for justify-items).

Modified the test to check the non-stretch behavior too.

BUG=510061
TEST=fast/css-grid-layout/min-width-height-auto.html

Review URL: https://codereview.chromium.org/1310603008

git-svn-id: svn://svn.chromium.org/blink/trunk@201797 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For the reason described in the bug, using a Member for SVGPropertyTearOffBase::m_contextElement
causes a cycle. To break the cycle, this CL changes it to a raw pointer.
The raw pointer is safe because the context element is guaranteed to be kept alive
by a V8 wrapper of the SVG tear off object.

BUG=528275

Review URL: https://codereview.chromium.org/1330673002

git-svn-id: svn://svn.chromium.org/blink/trunk@201796 bbb929c8-8fbe-4397-9dbb-9b2b20218538

according to RFC 7230.

In this CL:
- We don't show messages for Fetch API.
- We don't actually update header checks.
Also, this CL is preparation for actually updating
header value checks to RFC 7230.

These issue is a merge from:
https://bugs.webkit.org/show_bug.cgi?id=128593.

BUG=455099

Review URL: https://codereview.chromium.org/1018903002

git-svn-id: svn://svn.chromium.org/blink/trunk@201795 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Allocate this object separately and not as a part of a LocalFrame. The
main motivation for this is to play better with its use of a
CancellableTaskFactory following r201780.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/1330653003

git-svn-id: svn://svn.chromium.org/blink/trunk@201794 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See https://groups.google.com/a/chromium.org/d/msg/blink-dev/S-P3N0kdkMM/EypTXImtAwAJ
for context.

R=akuegel@chromium.org, akuegel
TBR=jochen

BUG=431478

Review URL: https://codereview.chromium.org/1315323007 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201792 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add partitionsOutOfMemoryUsingXXX to know Blink memory usage from crash reports when PartitionAlloc hits OOM.

To avoid linker optimization, copied alias.cc and alias.h from //base/debug to WTF.

BUG=

Review URL: https://codereview.chromium.org/1315113006

git-svn-id: svn://svn.chromium.org/blink/trunk@201791 bbb929c8-8fbe-4397-9dbb-9b2b20218538

They failed and a suspected culprit was reverted,
but they passed before the revert landed,
and the change was relanded and now the tests are
failing again. Disabling and filing a bug.

BUG=528186
TBR=alexmos

Review URL: https://codereview.chromium.org/1321233004

git-svn-id: svn://svn.chromium.org/blink/trunk@201790 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Make classes and structures in web fast-allocated. (patchset #1 id:1 of https://codereview.chromium.org/1328773002/ )

Reason for revert:
Revert to see whether SitePerProcessBrowserTest.SurfaceHitTestTest flakiness is caused by this commit or not.


Original issue's description:
> Make classes and structures in web fast-allocated.
> 
> - Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
>   instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.
> 
> BUG=523249
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201771

TBR=haraken@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=523249

Review URL: https://codereview.chromium.org/1326693003

git-svn-id: svn://svn.chromium.org/blink/trunk@201789 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=528198
TBR=horo
NOTRY=true

Review URL: https://codereview.chromium.org/1307233007

git-svn-id: svn://svn.chromium.org/blink/trunk@201788 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a CancellableTaskFactory is used by an Oilpan heap object, the
closure that the factory works with/over, cannot embed a reference
back to that object by way of an off-heap Persistent<> (WTF::Closure
is not on the heap.) If it does, such a reference will keep the heap
object alive, without it ever being released. Memory leaks are very likely.

This is too easy a slip-up to make with the current CancellableTaskFactory
constructor, so rephrase the constructor so as to make leaks no longer (easily)
possible. For Oilpan heap objects baked into the closure, the persistent reference
now held will be weak.

At the same time, take the opportunity to have this object no longer be a part object,
but a separate (off-heap) allocation. This lets us drop the ad-hoc ASan unpoisoning
support that was previously needed if CancellableTaskFactory was a part object
of an Oilpan heap object. Less magic.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/1312843009

git-svn-id: svn://svn.chromium.org/blink/trunk@201787 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Just for consistency. This won't affect practical performance.

BUG=

Review URL: https://codereview.chromium.org/1317033008

git-svn-id: svn://svn.chromium.org/blink/trunk@201786 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves |VisibleSelection::ChangeObserver| out from |VisibleSelection|
class as |VisibleSelectionChangeObserver| as preparation of introducing
composed tree version of |VisibleSelection| since it doesn't depend on
DOM tree traversal and composed tree traversal.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1309413006

git-svn-id: svn://svn.chromium.org/blink/trunk@201785 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/1319123003

git-svn-id: svn://svn.chromium.org/blink/trunk@201784 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1329853003

git-svn-id: svn://svn.chromium.org/blink/trunk@201783 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1328593005

git-svn-id: svn://svn.chromium.org/blink/trunk@201782 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reland of OOPIF: Call setCoreFrame on remote-to-local swaps. (patchset #1 id:1 of https://codereview.chromium.org/1315543009/ )

Reason for revert:
Reland: The Android build went green one build before this revert.

Original issue's description:
> Revert of OOPIF: Call setCoreFrame on remote-to-local swaps. (patchset #4 id:60001 of https://codereview.chromium.org/1316863009/ )
> 
> Reason for revert:
> I suspect this change broke webkit_unit_tests on Nexus 4:
> All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/0
> All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/1
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/0
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/1
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForMinimumScale/0
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForWidthEqualsDeviceWidth/1
> All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedLayout/1
> 
> First failing build:
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37423
> 
> Blamelist:
> http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=201725:201728&mode=html
> http://test-results.appspot.com/revision_range?start=347178&end=347178
> 
> Original issue's description:
> > OOPIF: Call setCoreFrame on remote-to-local swaps.
> > 
> > This ensures that various initializion in setCoreFrame is triggered when
> > doing remote-to-local swaps.
> > 
> > BUG=525285
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201726
> 
> TBR=dcheng@chromium.org,alexmos@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=525285
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201756

TBR=dcheng@chromium.org,alexmos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=525285

Review URL: https://codereview.chromium.org/1304093005

git-svn-id: svn://svn.chromium.org/blink/trunk@201781 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Similar to https://codereview.chromium.org/1312353004/

We would like to be able to prioritize loading tasks, but in order to
do that we need to make sure loading tasks are posted to the right queue
to make sure tasks run in the expected order.  If this task is posted as
a timer, and loading tasks are prioritzed, it's possible
FrameHostMsg_DidStopLoading will be sent before the corresponding
FrameHostMsg_DidStartLoading ipc which causes various browser tests to
break.

Must be submitted after https://codereview.chromium.org/1303153005/

BUG=497761, 510398

Review URL: https://codereview.chromium.org/1305933007

git-svn-id: svn://svn.chromium.org/blink/trunk@201780 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Persistent handle introduced to SVGInterpolation in 201698 created the following cycle.

SVGInterporation =(Persistent)=>
SVGAnimatedProperty =(Member)=>
SVGElement =(Member)=>
ElementRareData =(Member)=>
ElementAnimations =(part of object)=>
CSSAnimations =(part of object)=>
CSSAnimationUpdate =(Member)=>
NewTransition =(Member)=>
InertEffect =(Member)=>
EffectModel =(RefPtr)=>
InterpolationEffect =(RefPtr)=>
InterpolationRecord =(RefPtr)=>
SVGInterpolation

This CL breaks the cycle by making SVGAnimatedProperty::m_contextElement a raw pointer.

BUG=

Review URL: https://codereview.chromium.org/1325433005

git-svn-id: svn://svn.chromium.org/blink/trunk@201779 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/1324843003

git-svn-id: svn://svn.chromium.org/blink/trunk@201778 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=201759

BUG=522797
TBR=falken@chromium.org

Review URL: https://codereview.chromium.org/1313103003 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201777 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Correct old bug numbers, which were assigned to fix flaky crashes
of WPT shadow-dom tests.  The crashes are gone now, and reassign
to regular WPT shadow-dom issue (505364).

NOTRY=true
TBR=tkent@chromium.org
BUG=505364

Review URL: https://codereview.chromium.org/1326123003

git-svn-id: svn://svn.chromium.org/blink/trunk@201776 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1315303010

git-svn-id: svn://svn.chromium.org/blink/trunk@201775 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently each call site is calling V8GCController:collectGarbage multiple times
to collect all V8 & Blink objects. We should have a helper method that does this.

BUG=

Review URL: https://codereview.chromium.org/1328653002

git-svn-id: svn://svn.chromium.org/blink/trunk@201774 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=528110,528120,528122
TBR=pdr
NOTRY=true

Review URL: https://codereview.chromium.org/1322373002

git-svn-id: svn://svn.chromium.org/blink/trunk@201773 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DeprecatedPaintLayer::physicalBoundingBox() returns the layer bounding box
in physical direction, translated to an ancestor layer's space. The caller
can either specify the ancestor layer or a pre-computed translation. Only one
of the parameter will be used.

This CL overloads the function to remove the extraneous argument at callers.

No behavioral change, no test added.

BUG=508383

Review URL: https://codereview.chromium.org/1315303009

git-svn-id: svn://svn.chromium.org/blink/trunk@201772 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION
  instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible.

BUG=523249

Review URL: https://codereview.chromium.org/1328773002

git-svn-id: svn://svn.chromium.org/blink/trunk@201771 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This plumbing doesn't go anywhere anymore.

R=jdduke@chromium.org

Review URL: https://codereview.chromium.org/1310583005

git-svn-id: svn://svn.chromium.org/blink/trunk@201770 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1314543009

git-svn-id: svn://svn.chromium.org/blink/trunk@201769 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1310713006

git-svn-id: svn://svn.chromium.org/blink/trunk@201768 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds base support of JQuery event listeners. Listeners which was installed by JQuery are shown in Event Listeners sidebar.
API for frameworks are provided. Developers can add own event listeners provider to global devtoolsFrameworkEventListeners array (it should be created if undefined). Provider functions should return two arrays:
1. Array with framework event listeners for current object in eventListeners field in format {type: {string}, useCapture: {boolean}, handler: (function()|Object)}.
2. Array with internal framework event handlers for current object in internalHandlers field - one function per each handler. This array is used for filtering out native internal event handlers.
BUG=61643
R=paulirish@chromium.org, pfeldman@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/1268353005 .

git-svn-id: svn://svn.chromium.org/blink/trunk@201767 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/1305343007

git-svn-id: svn://svn.chromium.org/blink/trunk@201766 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces template class |VisiblePositionTemplate| like
|PositionWithAffinityTemplate| as a preparation of introduce composed tree
version of |VisiblePosition|.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1330563005

git-svn-id: svn://svn.chromium.org/blink/trunk@201765 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=506468

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201676

Review URL: https://codereview.chromium.org/1327593003

git-svn-id: svn://svn.chromium.org/blink/trunk@201763 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's failing on Linux Leak. Probably r201736
https://codereview.chromium.org/1236913004 missed adding the
expectation.

Build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/13880
Leak log:
({"numberOfLiveActiveDOMObjects":[2,4],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,2]})

BUG=410974
TBR=tdresser
NOTRY=true

Review URL: https://codereview.chromium.org/1326083003

git-svn-id: svn://svn.chromium.org/blink/trunk@201762 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=386142

Review URL: https://codereview.chromium.org/1314903010

git-svn-id: svn://svn.chromium.org/blink/trunk@201761 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Longer term we should clean up initialize code as in crbug.com/519111.

BUG=527636
TEST=WorkerThreadTest.StartAndStopImmediately

Review URL: https://codereview.chromium.org/1325193002

git-svn-id: svn://svn.chromium.org/blink/trunk@201760 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some tests have slightly different results after r201644
https://codereview.chromium.org/1308033003, looks like
they were just missed when adding the Rebaselines in that
patch.

BUG=522797
TBR=jbroman
NOTRY=true

Review URL: https://codereview.chromium.org/1321233003

git-svn-id: svn://svn.chromium.org/blink/trunk@201759 bbb929c8-8fbe-4397-9dbb-9b2b20218538