GitLab

Bug: 1066467
Change-Id: I23114012b994684004a5553fea74f31795030bd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144841Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758419}

Migrate this test out of third_party/blink/web_tests/css3/masking/ and
into the WPT-specific directory, adding links to the relevant specs and
a test assertion describing its purpose.

Bug: 1063749
Change-Id: I207d3241ef7b13e13a3b25e5582109840bf217b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143819
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758418}

Bug: 1035647
Change-Id: Ifeaadb55c5865a041b2461db17baf7397340c673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142577
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758417}

This CL removes the hardcoded list of files in the updater's setup.
At runtime, the setup copies all files unpacked by the metainstaller, or
uses a build-generated dependency file to determine what files it needs
to install, if `updater --install` is run from the `out` directory of
the build.

The CL introduces a new command line argument `--install-from-out-dir`,
which is used in addition to other command line arguments of
`--install`.

This CL fixes the issue where --install could not find the
`uninstall.cmd` file when run from the `out` dir.

Bug:1069264,1054685

Change-Id: I03382b6d60fc71352a650e90b9abad6a85f085e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146082Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758416}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/607540bcad8c..16297237f8cc


Created with:
  gclient setdep -r src-internal@16297237f8cc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: nhiroki@google.com,reillyg@google.com
Change-Id: I2e7fa54ff227d5104892511d915ee86ad48490c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146514Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758415}

This reverts commit 77eb87e6.

Reason for revert: Relanding now that we have data from UMA

Original change's description:
> Revert "Overlay scrollbars work correctly without overflow"
>
> This reverts commit 2c6eb18b.
>
> Reason for revert: Reverting temporarily to confirm effect on metrics
>
> Original change's description:
> > Overlay scrollbars work correctly without overflow
> >
> > Overlay scrollbars - the type that fade in/out, not overflow: overlay -
> > should only ever be visible when the content is scrolling. Therefore, if
> > the content cannot scroll, we should never see an overlay scrollbar.
> > This is different from classic (i.e. non-overlay) scrollbars. An
> > overflow:scroll scroller requires showing a (disabled) scrollbar even
> > when there is no overflow. Today, when an overlay scrollbar is created
> > we check after-the-fact in UpdateAfterLayout whether there is overflow
> > and, if there isn't, we remove overlay scrollbars. This is how the above
> > mentioned behavior for |overflow:scroll| overlays is implemented.
> >
> > However, this doesn't account for different kinds of updates.
> > UpdateAfterStyleChange must also recompute scrollbar states and didn't
> > have this no-overflow removal logic. If content caused a style update
> > that didn't require a layout, an overlay scrollbar would be attached in
> > this case. In the attached bug, the scrollbar is visible because the
> > fade out (on the main thread) is controlled by a timer that causes
> > scrollbars to be disabled (which causes them not to paint). In addition
> > to incorrectly creating the scrollbar, UpdateAfterStyleChange does not
> > compute the scrollbar enabled state so it defaults to true. Without
> > being able to scroll, the fade out timer is never started.
> >
> > This CL fixes the issue by moving the overflow requirement for overlay
> > scrollbars into ComputeScrollbarExistence so that we account for it no
> > matter the point at which we recompute scrollbar existence. We also
> > refactor ComputeScrollbarExistence to make clear the distinction between
> > overflow dependent and independent computations.
> >
> > A considered alternative was to always create the scrollbar but ensure
> > its enabled state is correctly set. This would have unified the
> > lifetimes of overlay and non-overlay scrollbars. However, it requires we
> > prevent creating composited layers for scrollbars that are overlay but
> > have no overflow since the compositor fades all of a scroller's
> > scrollbars together so such scrollbars would become visible if the other
> > axis is scrollable. We couldn't use the enabled state for this because
> > it is flipped every time the scrollbars fade in/out so that would cause
> > layers to constanty be created/destroyed so we'd have to introduce more
> > complexity to compositing decisions.
> >
> > This change caused three tests to break (note: unit tests generally use
> > mock overlay scrollbars):
> >
> > RepaintScrollableAreaLayersInMainThreadScrolling:
> >
> >   A style change like this does not require invalidating paint on
> >   overlay scrollbars' compositing layers since the compositor can deal
> >   with resizes on its own.  However, this was causing an invalidation
> >   because of the bug fixed here: the style change adds a horizontal
> >   scrollbar and the layout removes it. Because it isn't composited, it
> >   causes the whole PaintLayer to be invalidated[1]. This causes the
> >   scrollbar layer to also need a repaint[2]. Since we no longer cause
> >   this creation and destruction of the horizontal scrollbar, we don't
> >   get this invalidation.
> >
> >   This test now resizes the overflow so that the vertical scrollbar
> >   needs to be disabled which does cause an invalidation.
> >
> > [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc?l=2845&rcl=33a9a3956034a765124f034a8f7d86f19c9c17e6
> > [2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc?l=2099&rcl=01e24ce806680bf99abf117e77d30d9566c72121
> >
> > TraverseNonCompositingDescendantsInPaintOrder:
> >
> >   The source of the failure here was that the |overflow:scroll| div no
> >   longer has overlay scrollbars after its style is updated (but before
> >   it does layout). When it performs PaintLayer::UpdateSelfPaintingLayer
> >   it will no longer be self painting[3]. Since it no longer has a self
> >   painting layer it will be added to the parent's visual overflow. This
> >   larger rect means that during overlap testing, the scroller's sibling
> >   (#stacked-child-of-composited-non-stacking-context) and its parent
> >   will overlap and so the sibling will require compositing. Finally,
> >   because it is now composited, it is now a paint invalidation container
> >   and so it won't be invalidated from the container element[5].
> >
> >   The fix here is to simply add overflow to the scrolling div so that it
> >   continues to cause a self painting layer in [3].
> >
> > [3] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_layer.cc?l=3054&rcl=fa18fef1b31a878fed89e2a543c3be0af2f57623
> > [4] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_box.cc?l=5780&rcl=0650ec2415a0f2583db48d11c6d8b6a31ff448c4
> > [5] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/object_paint_invalidator.cc?l=70&rcl=d9d7df43f1718c900afc470371b382c8dca085b6
> >
> > mock-scrollbars.html:
> >
> >   This was failing only on the legacy LayoutNG disabled bot so I didn't
> >   dig too deeply into it. The failure here was that the inner box would
> >   layout as if the parent had non-overlay scrollbars. I believe this is
> >   because the mock scrollbars were being enabled at load, after layout
> >   was already completed. I think this used to work because the scrollbar
> >   was being added and then removed which would cause a layout
> >   invalidation which no longer happens, thus we need to ensure mock
> >   scrollbars are enabled before we produce the first layout.
> >
> > Bug: 1039501
> > Change-Id: Ic68522a4fdba8ffaa2c5ef508736c9a94eac7682
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119933
> > Commit-Queue: David Bokan <bokan@chromium.org>
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#754808}
>
> TBR=wangxianzhu@chromium.org,bokan@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1039501
> Change-Id: Ifa1851da28d080686d7444db56ea660638f469d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140310
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Stephen Chenney <schenney@chromium.org>
> Commit-Queue: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#757192}

TBR=wangxianzhu@chromium.org,bokan@chromium.org,schenney@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1039501,1068351,1069574
Change-Id: I5c272b3a2f32bd2fab09bfaa8b0895ffc3f4261c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146451Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758414}

For security reasons, text fragments must only be activated when
navigated with a user gesture. However, browser initiated navigations
(e.g. user typing in the omnibox, bookmarks) don't have the user gesture
bit set despite being initiated by the user (see discussion in
https://crrev.com/c/2132673 for details). Because of this limitation,
text fragment code explicitly checked if the navigation was browser
initiated, assuming that such navigations are always user activated.

However, history navigations are a special case. They're intentionally
considered to be browser initiated, even if they originate from renderer
script (e.g. `history.back()`). This meant that our check above would
allow script to use the history API to activate a text fragment without
a user gesture.

This CL explicitly forbids activating a text fragment if the navigation
is of history type. This is a trivial change (in terms of UX) because a
history navigation will restore the scroll position to where the user
left off so the text fragment scroll is already clobbered. This change
prevents a transient scroll that will be undone.

Note: we had an explicit test for this case that failed to catch the
failure. The reason was that the test was checking that the fragment
wasn't activated by checking that the scroll offset after a navigation
is 0. However, the text fragment's scroll would be clobbered (assuming
by history scroll restoration) so this check would erroneously pass. We
fix it in this CL by using a scroll listener so that we can tell a
scroll occurred even if it is later restored.

Bug: 1042986
Change-Id: Ia0ad9a8adcda2250603e6a7dd2b386193be2a6e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135407Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nick Burris <nburris@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758413}

https://crrev.com/48614c8 added a DCHECK in Page so that we ensure all
code can access a ScrollbarTheme. This is because unit tests on Android
run without a platform theme engine. If a MockScrollbarTheme isn't
installed, any execution that requests a scrollbar theme will crash. A
scrollbar theme is essential to style and layout so this should always
be available.

However, this caused tests to break, revealing that some tests are
running without a mock theme. It's unclear why those tests are flakily
passing some runs and why the CL cleared the trybots in the first place;
the issue is 100% reproducible locally.

This CL fixes all blink unit tests to run with a mock theme. We default
a DummyPageHolder to use a MockOverlayScrollbar theme and manually
install it on other tests that don't use this class. A few tests create
multiple DummyPageHolders, these required a small fix to ensure the old
one is destructed before the new one is created so that we maintain
proper nesting of ScopedMockOverlayScrollbars.

One test in ImageDocumentTest required updated expectations as the test
now runs with overlay scrollbars, changing the required expected offset.

Bug: 1068595
Change-Id: I034c768e4b353dd0082ec5d568a0de073a28413b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141213
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758412}

This reverts commit e3f29527.

Reason for revert: Rolldep of internal changes failed

Original change's description:
> Uprev LibAssistant to 1.46s
> 
> The current LibAssistant branch (1.42c) is no longer maintained,
> and also does not contain the latest features.
> 
>    * This will only be landed after M83 branches
>    * This depends on the internal changes to land first
> 
> Note: 
> Bug: b/152777569
> Change-Id: Ic34b6ca3ba1d793c719ebb58ab9766e943fc5ec6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134617
> Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758408}

TBR=xiaohuic@chromium.org,wutao@chromium.org,jeroendh@google.com

Change-Id: I022550bcb93f4201a63aa2b28f64f6ccb32e5005
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/152777569
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146450Reviewed-by: Jeroen Dhollander <jeroendh@google.com>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#758411}

It is possible for a draw to succeed, but a frame to still not be
submitted. This can happen when nothing blocks the draw, but still
no frame was submitted because there was no damage. In such cases,
mark the frame as deliberately dropped, rather than a frame that
was aborted while waiting on the main-thread.

BUG=790761

Change-Id: I410151858f7f2dd48b066cfc0ec05c29aac2e6d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144422
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758410}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f63c870256d3..607540bcad8c


Created with:
  gclient setdep -r src-internal@607540bcad8c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: nhiroki@google.com,reillyg@google.com
Change-Id: I97eb54295428b91c0e1e02c9a5892ad525e8e22a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146271Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758409}

The current LibAssistant branch (1.42c) is no longer maintained,
and also does not contain the latest features.

   * This will only be landed after M83 branches
   * This depends on the internal changes to land first

Note: 
Bug: b/152777569
Change-Id: Ic34b6ca3ba1d793c719ebb58ab9766e943fc5ec6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134617
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758408}

https://swiftshader.googlesource.com/SwiftShader.git/+log/d37179337d95..9d2fd9c161ab

git log d37179337d95..9d2fd9c161ab --date=short --first-parent --format='%ad %ae %s'
2020-04-11 bclayton@google.com LLVMReactor: Replace deprecated CreateCall overload

Created with:
  gclient setdep -r src/third_party/swiftshader@9d2fd9c161ab

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I6f3b782dfb9c11022741566183e13160807c98da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146269Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758407}

CSS Filter should create a containing block for fixed and absolute
position except for the root[1]. Will-change: filter should do the
same[2].

[1] https://drafts.fxtf.org/filter-effects/#FilterProperty
[2] https://drafts.csswg.org/css-will-change/#will-change

Bug: 960953
Change-Id: I9de08e812ffd818bd907f078cbe31e918c19333c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136667Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758406}

The crash is because the vulkan device lost. Fix the problem by
always calling context_state_->MakeCurrent() in
SkiaOutputSurfaceImplOnGpu::MakeCurrent(), it will check vulkan
device lost by testing gr_context_->abandoned(), and if the device
is lost, we will skip the draw to avoid crash.

Bug: 1068161
Change-Id: I128df218958c0fb0d8f48e8533678f90ceab270b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146235
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758405}

Before this patch, an unowned function pointer would be invoked
asynchronously with a reference to the possibly freed reference to the
browser context, which could cause use after free in certain
circumstances.

This patch makes the browser context own the callback and binds the
function with a weak pointer, so freeing the browser context invalidates
the weak pointer, which cancels the callback execution.

After this patch, freeing the browser context aborts the asynchronous
callback that dereferences the browser context, so the use after free
is prevented.

Bug: 1065298
Change-Id: Id6de3099a55c4505e94a8a6d21fb25d6d2b34c6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144311Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758404}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9cfb35d0901..f63c870256d3


Created with:
  gclient setdep -r src-internal@f63c870256d3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: nhiroki@google.com,reillyg@google.com
Change-Id: I4b144c30e397e13f9fb8c591c865a9ca02174217
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146347Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758403}

https://webrtc.googlesource.com/src.git/+log/dc69fd2b80c9..adc4da30f420

git log dc69fd2b80c9..adc4da30f420 --date=short --first-parent --format='%ad %ae %s'
2020-04-11 marinaciocea@webrtc.org [InsertableStreams] Fix video receiver simulcast.

Created with:
  gclient setdep -r src/third_party/webrtc@adc4da30f420

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1065838
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I321b45438cf696e59b9522b27d948d1ea277875b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146348Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758402}

TBR=bling-p10-rolls@google.com

Change-Id: I6e23638ea9d5c9c21670a13f13b436bac27e8606
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144441Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758401}

https://webrtc.googlesource.com/src.git/+log/d37010c9b708..dc69fd2b80c9

git log d37010c9b708..dc69fd2b80c9 --date=short --first-parent --format='%ad %ae %s'
2020-04-11 marinaciocea@webrtc.org [InsertableStreams] Fix video sender simulcast.

Created with:
  gclient setdep -r src/third_party/webrtc@dc69fd2b80c9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1065838
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ia0344df076b95dd56399bf1c23040da1e9ee7dbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146344Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758400}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8fb658105806..30c590849d00

git log 8fb658105806..30c590849d00 --date=short --first-parent --format='%ad %ae %s'
2020-04-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@30c590849d00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Iba9afeb5ea5c93458f9ec97c7fb74ef311102eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146345Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758399}

TBR=antrim@chromium.org

Fixed: 949239
Change-Id: If390e8e653dff58b9c33d3bd871cdcf6d1ad67a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144181Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758398}

Remove the thread check in ClearRendererCacheOnNavigation. This should
always be called on the UI thread.

BUG=696822

Change-Id: I25f0059b43dd25bcabf3f52fa1c645bd5a211136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145699
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758397}

* Follow-up to https://crrev.com/c/2132384.
* Removes the string, the C++ side logic to string construction, the
  communication of the string to JS, and the handling of the string
  in JS.

Bug: 1015841
Change-Id: I5cb7b20f1309306910fd0923fcfdcedc1c1253c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139713Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Andrey Zaytsev <andzaytsev@google.com>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758396}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d4198aab5e3..e9cfb35d0901


Created with:
  gclient setdep -r src-internal@e9cfb35d0901

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: nhiroki@google.com,reillyg@google.com
Change-Id: Ie0218edc35ad3179583cf06504e11e63e67f16cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146341Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758395}

Test in
https://chromium-review.googlesource.com/c/chromium/src/+/2144276


Bug: 1065838
Change-Id: I8804f187dec8f889993c757fc8466faab032c107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142033
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758394}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I7c2d96c4816be73344b5f9d6bd66761e16d5fbc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146340Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758393}

https://webrtc.googlesource.com/src.git/+log/9d8cede79b05..d37010c9b708

git log 9d8cede79b05..d37010c9b708 --date=short --first-parent --format='%ad %ae %s'
2020-04-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 666362b2..318b9b3c (758256:758358)

Created with:
  gclient setdep -r src/third_party/webrtc@d37010c9b708

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I998196b211ac73f9078319fe692231ef60738c0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146313Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758392}

The timeout limit for finch is still 60 seconds. But the parameter
is updated accordingly to keep the same duration.


Bug:949839,1069938

Change-Id: I503c574ecd2bec076f11bb351717154ccc1b207d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146054Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758391}

https://chromium.googlesource.com/openscreen.git/+log/07e64e6eeffc..6812621f27e9

git log 07e64e6eeffc..6812621f27e9 --date=short --first-parent --format='%ad %ae %s'
2020-04-11 jophba@chromium.org Upgrade ARM64 bot configuration

Created with:
  gclient setdep -r src/third_party/openscreen/src@6812621f27e9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: Id5db5d3ea77b3bf5c6897c68aa170dd0afd5f61e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146338Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758390}

https://skia.googlesource.com/skia.git/+log/daf94c56bcb3..459ecee2cbdc

git log daf94c56bcb3..459ecee2cbdc --date=short --first-parent --format='%ad %ae %s'
2020-04-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps

Created with:
  gclient setdep -r src/third_party/skia@459ecee2cbdc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: csmartdalton@google.com
Change-Id: I5793cd915a6abedc56b0a12f6bd92354ad5ecd75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146336Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758389}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/868bd943887c..1d4198aab5e3


Created with:
  gclient setdep -r src-internal@1d4198aab5e3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1058152
Tbr: nhiroki@google.com,reillyg@google.com
Change-Id: I0c346e80bdd7cf58b5a6ecc8f05bc54c11b31dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146327Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758388}

This patch adds [Exposed=Window] IDL extended attribute to
the IDL interface definitions that are missing the extended
attribute.  The necessity of [Exposed] is determined by the
current behavior regardless of what each web spec specifies.

In a follow-up patch, the bindings generator will be fixed
so that it won't expose IDL interfaces unless [Exposed] is
specified.

Bug: 839389
Change-Id: Ib2cdb8801d1e3648c2e41d16617c41171fda0005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143173Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758387}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/8da8c788..a9439a50

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I446d54418dbda6e997ddb394e8c3e865b7a384ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143866Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758386}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b36549d189fb..8fb658105806

git log b36549d189fb..8fb658105806 --date=short --first-parent --format='%ad %ae %s'
2020-04-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@8fb658105806

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I23afe6a050dc7a6482b61614d0c7120115fe553e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146329Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758385}

https://dawn.googlesource.com/dawn.git/+log/8619cbe2379c..5b7292c8f8e2

git log 8619cbe2379c..5b7292c8f8e2 --date=short --first-parent --format='%ad %ae %s'
2020-04-11 zmo@chromium.org Fix more compilation warnings.

Created with:
  gclient setdep -r src/third_party/dawn@5b7292c8f8e2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1064305
Tbr: cwallez@google.com
Change-Id: I7e4cbdfbe5f52a3b3c494800e2c27a4198e0b03e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146322Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758384}

I was so confused as to why these tests had wrong expectations
compared to what output they gave locally. Then I finally
figured out that they were disabled in a totally different
file.

Bug: none
Change-Id: Ia418e732e27f944731670ca64ed0c881f97f15e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145753
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#758383}

Recent changes to pointer lock requests(https://crrev.com/c/2069199)
caused an error in logic which allowed requests made while not in focus
to be able to succeed. This meant that a request made while changing
focus would cause a strange state. I also added an earlier check for
focus so that we error out before reaching the browser.

Bug: 1068339
Change-Id: If706d2a693ca6a9aa2a8cf6c85ed622b429b97fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138501Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758382}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da1fe3609158..868bd943887c


Created with:
  gclient setdep -r src-internal@868bd943887c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1067290
Tbr: nhiroki@google.com,reillyg@google.com
Change-Id: I484ced4bf76cdfcf7a0d608012be7b3eac5fecea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146316Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758381}

Bug: 829414
Change-Id: Ib5d24dab8540513e1f5179c3c0914c4572395980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975305
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#758380}