GitLab

> Add ScopedStubEnterpriseInstallAttributes for tests to set test install attributes.
> 
> This change is motivated by the need to set the test install attributes before the browser policy connector is initialized for the first time. In particular, test class members may cause the policy connector to be initialized in their constructors, so we also need to set the install attributes in the constructor of a member.
> 
> BUG=243341
> 
> Review URL: https://codereview.chromium.org/247283007

TBR=stepco@chromium.org

Review URL: https://codereview.chromium.org/257763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266179 0039d316-1c4b-4281-b951-d872f2087c98

On LoginDatabase using platforms, a password entry found by a PSL match gets the signon realm and the origin overwritten to match the query password form. This way, when the credential is saved, it is saved for the new site.

On Gnome, the overwriting did not happen. This CL introduces this to match the LoginDatabase behaviour.

Also, on Gnome, PSL matching was used not only to get logins, but also to check for existing logins when adding and updating passwords. The latter two use cases should require exact matching (that's also what happens in LoginDatabase). This CL fixes that, and only keeps PSL matching for GetLogins.

BUG=364745
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/245563005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266177 0039d316-1c4b-4281-b951-d872f2087c98

Only relevant for the --enable-experimental-app-list-position flag.

AppListView now has a mode where it automatically keeps the bubble
centered on the screen's primary display, rather than a fixed position.

BUG=363928
TEST=Run with --enable-experimental-app-list-position. Open the app
list, press Ctrl+Shift+F3 to rotate. App list should remain centered.

Review URL: https://codereview.chromium.org/237533015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/234473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266175 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the code in DiscardableMemoryManager that was
hard-coded to use heap allocations with code that handle
instances that implement the
DiscardableMemoryManagerAllocation interface instead.

This allows us to use the manager class not only for
emulated discardable memory but any other type that
might need some level of userspace control. This also
removes the circular dependency between
DiscardableMemoryManager and DiscardableMemory classes.

BUG=327516
TEST=base_unittests --gtest_filter=DiscardableMemory*

Review URL: https://codereview.chromium.org/204733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266174 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org
BUG=354046
TEST=unit_tests

Review URL: https://codereview.chromium.org/250443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266173 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266170 0039d316-1c4b-4281-b951-d872f2087c98

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/257423007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266169 0039d316-1c4b-4281-b951-d872f2087c98

Gin Java Bridge requires some customization in JS values serialization:

 - 'undefined' values must be encoded, not skipped;

 - 'non-finite' doubles must be supported;

 - ArrayBuffers and ArrayBufferViews must be encoded differently.

BUG=355644
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/248903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266168 0039d316-1c4b-4281-b951-d872f2087c98

Mostly manual refactoring of ServiceWorkerRequestHandler into a base class and two derived classes, one for use when processing requests from a controllee document, and the other for use with request from a service worker context.

BUG=364247

Review URL: https://codereview.chromium.org/255413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266166 0039d316-1c4b-4281-b951-d872f2087c98

In ResourceScheduler::GetNumDelayableRequestsInFlight,
total_delayable_count has no relation to active_request_host,
so we do not need to compute it for each request.

The patch can boost BrowsingBench workload >5% performance.

BUG=347454

Review URL: https://codereview.chromium.org/180843016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266165 0039d316-1c4b-4281-b951-d872f2087c98

For example, to create an alarm event for SmokeDetector

function SmokeDetector() {
    this.defineEvents(['alarm']);
 };
base.augment(SmokeDetector, base.Events);

To fire an event
SmokeDetector.prototype.onCarbonMonoxideDetected = function () {
  var param = {} // optional parameters
  this.raiseEvent('alarm', param);
}

To listen to an event
var smokeDetector = new SmokeDetector();
smokeDetector.addEventListener('alarm',listenerObj.someCallback,listenerObj);

The code lives in (base.js), a module that contains JavaScript utility components and methods for the web app.

Review URL: https://codereview.chromium.org/245923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266164 0039d316-1c4b-4281-b951-d872f2087c98

RenderViewTest::LoadHTML assumed that issuing a load
of a data url, posting a task to quit the message loop
and then pumping the message loop until it quits was
sufficient to end up with a fully parsed page.

That very soon won't be true once we send data: urls
to the threaded parser, as the parser thread posts
back to the main thread and may post tasks after the
quit message.
https://codereview.chromium.org/210253003/

Instead I've added a FrameLoadWaiter class which
implements RenderViewObserver to listen for the
load event for the frame and only post the quit
task once the load event had come in.

BUG=308321

Review URL: https://codereview.chromium.org/257723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266163 0039d316-1c4b-4281-b951-d872f2087c98

Compilation error:

c:\b\build\slave\cr-win-rel-x64\build\src\mojo\services\view_manager\view_manager_connection.cc(199) : error C2723: 'mojo::services::view_manager::ViewManagerConnection::DeleteView' : 'override' specifier illegal on function definition

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/17746/steps/compile/logs/stdio


> Adds more to viewmanager
> 
> Specifically ability to delete nodes, create views and attach them.
> 
> BUG=365012
> TEST=covered by tests
> R=ben@chromium.org
> 
> Review URL: https://codereview.chromium.org/250633003

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/250733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266162 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365868
TEST=visual and unit test

Review URL: https://codereview.chromium.org/249723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266161 0039d316-1c4b-4281-b951-d872f2087c98

Avoid using external servers.

BUG=361658

Review URL: https://codereview.chromium.org/258623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266160 0039d316-1c4b-4281-b951-d872f2087c98

Specifically ability to delete nodes, create views and attach them.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/250633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266159 0039d316-1c4b-4281-b951-d872f2087c98

The only reason it is in content/public/ is so that content/shell can dump
history state for testing. Move back/forward list dumping to content/test/.

BUG=

Review URL: https://codereview.chromium.org/246163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266158 0039d316-1c4b-4281-b951-d872f2087c98

In order to reduce pain (hopefully to zero) for sheriffs and fellow developers
who prefer their trees green rather than red, let's make landing the change
at https://codereview.chromium.org/213783002/ as safe as possible.

Step 1: This CL. Extend DOMActivityLogger with new methods for logGetter,
logSetter, and logMethod, which have the same functionality as the current
log() method.
Step 2: https://codereview.chromium.org/213783002/ - The implementation change
in blink to switch from using log() to using logX.
Step 3: Cleanup -- remove old log method from chrome.

BUG=356890

Review URL: https://codereview.chromium.org/247953008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266157 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/255543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266156 0039d316-1c4b-4281-b951-d872f2087c98

Adds about ~5us per task on Nexus 4.

BUG=None

Review URL: https://codereview.chromium.org/254423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266155 0039d316-1c4b-4281-b951-d872f2087c98

Check switching between pods on login screen and add new test to check
wallpaper persistence across logout.

BUG=none

Review URL: https://codereview.chromium.org/219143004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261741
TBR=agable

Review URL: https://codereview.chromium.org/256733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266153 0039d316-1c4b-4281-b951-d872f2087c98

After discussion with ianh, we decided it wasn't helpful to add Unsupported to the rAc spec after all.

BUG=347832

Review URL: https://codereview.chromium.org/248333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266150 0039d316-1c4b-4281-b951-d872f2087c98

This is the first step in making Preferences the authoritative source for the user-selected DSE. In follow-up CLs, we will only persist a DSE choice when it is an explicit user choice.

BUG=365762
TBR=sky

Review URL: https://codereview.chromium.org/231863008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266149 0039d316-1c4b-4281-b951-d872f2087c98

Previously we convert SupportedCodecs (a uint32 bit mask indicating which
codec is supported) to ContainerCodecMap (a map from a container type to a set
of supported codecs in that container). Then we pass ContainerCodecMap to
KeySystems and store it there for easy look up.

This results in a lot of duplicate converting code. This CL stores
SupportedCodecs in KeySystmeInfo and KeySystems so that we don't need to convert
anything. Then when IsTypeSupported() is called, we find the bit masks for
queried container and codec types and compare it with the SupportedCodecs stored
in KeySystems.

BUG=362769
TEST=All existing tests pass.

Review URL: https://codereview.chromium.org/246033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266148 0039d316-1c4b-4281-b951-d872f2087c98

MojoShell crashed when it goes backgound then comes to front again.
It did hit an assertion in InitApplicationContext() that is expected
to be called oly once for each process.

This change ensures it to be called once at most.

TEST=none
BUG=none
R=abarth,beng

Review URL: https://codereview.chromium.org/249713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266147 0039d316-1c4b-4281-b951-d872f2087c98

This adds support for synchronously enabling/disabling tracing in
devtools agent, so we can support tracing-based timeline enabled
synchronously from the inspected renderer.

BUG=361045
R=pfeldman@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/243103008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266146 0039d316-1c4b-4281-b951-d872f2087c98

Corresponds to Blink change https://codereview.chromium.org/244923002/.
Used to study:
- how many send() calls are being made
- how much binary data sending functionality is used
- how many people are using ArrayBufferView version send()

BUG=128156, 359926
R=asvitkine@chromium.org, ricea@chromium.org, yhirano@chromium.org

Review URL: https://codereview.chromium.org/246573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266143 0039d316-1c4b-4281-b951-d872f2087c98

- Definition for SECURE_PROXY_CONNECTION is missing
- "connection" is redundant. Remove it from all description texts

BUG=none
R=asvitkine@chromium.org, yhirano@chromium.org

Review URL: https://codereview.chromium.org/244843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266138 0039d316-1c4b-4281-b951-d872f2087c98

The tests are skipped if those mojom.js files don't exist. This is a
temporary fix before isolated tests are enabled on Chromium waterfall.

TEST=None
BUG=351214
R=sky@chromium.org

Review URL: https://codereview.chromium.org/253413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266135 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366993
NOTRY=true

Review URL: https://codereview.chromium.org/256693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266131 0039d316-1c4b-4281-b951-d872f2087c98

 * Clean up the implementation
 * Accept FROM_HERE to improve tracability
 * Add another version that takes TaskRunner to relay.

BUG=347425
TEST=unit_tests --gtest_filter=DriveBackendCallbackHelperTest.*
R=peria@chromium.org

Review URL: https://codereview.chromium.org/259503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266127 0039d316-1c4b-4281-b951-d872f2087c98

This change is to improve AV sync for transcoding.

The algorithm is now changed to schedule for trancoding every 10ms.
And then trasncoding audio into 10 ms blocks and send to the network.
Video is then transcoded according to the audio timeline.

I have also added looping support.

Review URL: https://codereview.chromium.org/255473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266125 0039d316-1c4b-4281-b951-d872f2087c98

> Suppress uninitialized read that aren't suppressed due to the lack of symbols.
> 
> This is same as crbug.com/366905, but causing failure due to the lack of symbols.
> This suppression is too wide and should be reverted as soon as the symbol issue is solved.
> 
> BUG=366905
> TBR=zhaoqin@chromium.org, bruening@chromium.org
> 
> Review URL: https://codereview.chromium.org/250753002

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/250823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266124 0039d316-1c4b-4281-b951-d872f2087c98

With my previous 'cleanup', the candidate view becomes a CustomButton
and the 'PRESSED' button status indicates the highlighted. I thought
this is good enough, but hovering also changes the button state.

Using a button state is a bad idea, so this CL adds a boolean flag
for highlighted status.

BUG=365959
R=oshima@chromium.org
TEST=manually, ash_unittests

Review URL: https://codereview.chromium.org/258463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266123 0039d316-1c4b-4281-b951-d872f2087c98

Removed use of a WebRTC struct to hold the RTP-specific header values,
and only include those struct members needed by Cast in RtpCastHeader.
Also:

1. Cleaned up RtpParser, and fixed bugs relating to 8-->32 bit frame_id
   and reference_frame_id expansion.
2. Moved call to OnReceivedPayloadData() out of RtpParser::ParsePacket()
   and into RtpReceiver.
3. Massaged unit tests around RtpCastHeader changes.
4. Coding style violations fixed where code was touched.

Testing: All cast_unittests pass.  Also, manually casted from Chrome to cast_receiver_app to confirm everything works.

BUG=347391

Review URL: https://codereview.chromium.org/250363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266120 0039d316-1c4b-4281-b951-d872f2087c98

ChromeOS virtual keyboard depends on the virtual viewport to support overscrolling. Enabled it by default on ChromeOS and removed it as an experiment from about:flags. Also added the experiment to Android since we'll eventually want to enable it there too.

BUG=366670

Review URL: https://codereview.chromium.org/254393008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266119 0039d316-1c4b-4281-b951-d872f2087c98

Before this patch, the number of CPUs allowed to be used by ninja was hardcoded.
This patch tries to find the optimal number by querying the number of available
cpus in the system.

BUG=324806
NOTRY=true

Review URL: https://codereview.chromium.org/248673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266118 0039d316-1c4b-4281-b951-d872f2087c98

It is reported on Win 8.1 running on MS Surface Pro after connection to factory-reset Chromecast device.

BUG=366582

Review URL: https://codereview.chromium.org/250223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266117 0039d316-1c4b-4281-b951-d872f2087c98