- 06 Nov, 2020 40 commits
-
-
Etienne Bergeron authored
This reverts commit 8815502e. Reason for revert: The bug is fixed, this code is now useless Original change's description: > Add sanity checks to text properties bounds in RenderText > > This CL is adding sanity check to ensure no components in chrome are > using incorrectly the RenderText API. > > We recently observed a crash (crbug/1124118) that was caused by > setting a property outside of the text bounds. > > The RenderText API assume correct uses of these properties. With this > CL they will be reported as a crash reports. > > Bug: 1142020 > Change-Id: I58d19bbbfeca97ad8425706eb85a825105db9f21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518895 > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823866} TBR=msw@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142020 Change-Id: Id5ddc6f9967c267ad6fe6e9be38395d469ff868a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523331Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#824972}
-
Kyle Horimoto authored
This field will be used by Phone Hub to start discovering a remote device for an "out-of-band" connection using a pre-synced Bluetooth address. This CL also makes the fast_advertisement_service_uuid field optional for out-of-band connections. Bug: 1106937 Change-Id: I35845fbf6a4626bfd18fd1e9451f4a18fdaabf14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493427 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#824971}
-
Avi Drissman authored
Bug: 1145672, 1145792, 1142017 Change-Id: Idfb5ddc8f64a4f55814c5cc67d6852ca2cf3af3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520521 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#824970}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/973d145df865..16036cf206f1 2020-11-06 kainino@chromium.org Add WGPU_STRIDE_UNDEFINED and update bytesPerRow/rowsPerImage validation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I40c0baed49dd1d0314e9cbe6781df7aec1185df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824969}
-
Kartik Hegde authored
Add the CaptivePortal routine to the ServiceConnection. BUG=chromium:956783 TEST=1) chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* 2) unit_tests --gtest_filter=DeviceCommandRunRoutineJobTest* 3) Applied CaptivePortal changes and successfully ran the CaptivePortal routine on a DUT (verified using cros-health-tool diag --action=run_routine --routine=captive_portal). Change-Id: I8eb98621bdfde9efc53357ba05f04affce614139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477523Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#824968}
-
David Black authored
This will make our terminology consistent with UX terminology in the spec and should hopefully clear up some amiguity/confusion that may have arisen due to using the term "item" in a context not directly referring to a holding space model item. Bug: 1142572 Change-Id: I59adbeebbd83f95c1bf377c7941f8b149d6f4448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523059 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#824967}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia9fb19d396512f107316176662d08ac9e8f34289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523227Reviewed-by:
-
Ben Pastene authored
The doc includes a number of isolate links, but items in isolate expire after 90 days. So this updates these to a set of new isolate links. Hopefully by the time these new links expire, we'll be on RDB which will have a slightly different debugging flow. This also adds some tips on running the tests locally. Bug: None Change-Id: Ib6244f787d2a914b7c3a79aaba2a33b688d346c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522409Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#824965}
-
David Black authored
Previously finalization was not being handled. Bug: 1142572 Change-Id: I73b4ee49ab22a0326e877d71a0627fad046d8d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522682Reviewed-by:
-
cfredric authored
Bug: 1146217 Change-Id: I59fda9bb717fad0fe19dc557461b1ca763f436a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522895 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#824963}
-
Kyle Horimoto authored
Each Core object is meant to be used by a single client, so we will use one for Nearby Share and one for Phone Hub. Each Core instance uses the same underlying connectivity framework, so we instantiate a single OfflineServiceController and share it with all Cores. This CL also adds a service_id parameter to each mojom::NearbyConnections function so that we can decide which Core object to use to process each call. Bug: 1106937 Change-Id: Ibbf8378822862579b79321689dd00a61d204fb1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495878Reviewed-by:
-
Koji Ishii authored
|Paint()| supported block fragmentation in r824316 <crrev.com/c/2515429> by assuming |LayoutNGBlockFlowMixin| functions cannot support block fragmented objects, but support block fragmentation by making sure we traverse only fragment tree. This patch applies the same pattern to |FirstLineBoxBaseline| and |InlineBlockBaseline|. Because these functions in |LayoutBlock| traverses |LayoutObject| tree, existing tests hit the DCHECK when the fragment does not have a baseline but |LayoutObject| has children. This patch copies the logic from |LayoutBlock| without checking |LayoutObject| tree. Already common code between |LayoutBlock| and |LayoutBlockFlow| is extracted to share. Bug: 1061423 Change-Id: Id4b9430c8c9ede00212664e80f305d2bb06b6563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515933Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#824961}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e6cf66ee522..62efc005477d 2020-11-06 vapier@chromium.org pylint: upgrade to 2.6.0 2020-11-06 chrome-bot@chromium.org Update config settings by config-updater. 2020-11-05 vapier@chromium.org pylint: switch to standard wheels 2020-11-05 vapier@chromium.org pylint: stop forcing vpython interp 2020-11-05 morg@google.com Promote grunt-arc-r as critical in RVC PFQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I193c3c511a32ef3d6f3d0349ce6a4c4510b836cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523094Reviewed-by:
-
Andrew Grieve authored
This reverts commit 7f7b0e87. Reason for reland: Updated allow-list Original change's description: > Revert "Android: Check R8 output for references to missing symbols" > > This reverts commit 67f02bba. > > Reason for revert: The new check breaks the android build on perf waterfall, e.g.: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/240223 > > Original change's description: > > Android: Check R8 output for references to missing symbols > > > > javac prevents missing symbols via compiler errors, but they > > can still occur by including prebuilts with incomplete deps, > > or by using jar_excluded_patterns to remove a class that is > > actually used. > > > > Bug: 1142530 > > Change-Id: Idebb28c9e1133d9021d899c570e35a5ff16d5f14 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510236 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824739} > > TBR=agrieve@chromium.org,pkotwicz@chromium.org > > Change-Id: I20033723611ea07fcae98b7824402da89001dd8c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1142530 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523395 > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> > Cr-Commit-Position: refs/heads/master@{#824954} TBR=agrieve@chromium.org,pkotwicz@chromium.org,wenbinzhang@google.com NOTRY=true # Already went through CQ in different CL. Bug: 1142530 Change-Id: I52ccfacc28c38db741d08ba10d00bb133ca89004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523532 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#824959}
-
Sajjad Mirza authored
Bug: 1090653 Change-Id: Ie233b9d9c6433a5e62d3f83177319132c937107e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523356Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
-
Elizabeth Popova authored
Due to Focus/Keyboard Navigation Changes in Android P+ initial focus is no longer assigned which causes the keyboard not to be shown on Android P+. This behavior was fixed by: - triggering default focus programatically (no-op on pre Android P) - showing keyboard only after the focus is set Bug: 1144129 Change-Id: Ib7539ba307e62c7c00a66ae088e9ffe15a45a4df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510211Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/master@{#824957}
-
Mohsen Izadi authored
Generally, event handling code that fully handles an event moves the metrics object to `EventsMetricsManager` as it does not need it anymore. However, `EventsMetricsManager` currently saves a copy of the object to be sent to `CompositorFrameReporter` to be reported. It can instead move the object in which case `cc::EventMetrics` does not need to be copyable anymore. Some tests that take advantage of copyability of `cc::EventMetrics` need to be updated, too. Bug: 1054009 Change-Id: Iafdb1346ea96a1e962de4c61e962bc1a51066a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518916Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#824956}
-
Andrew Xu authored
This reverts commit 9e285c75. Reason for revert: The original CL does not cause the issue. So reland it. Original change's description: > Revert "[Multipaste] Speak a11y announcement when delete button is focused" > > This reverts commit a2c9272d. > > Reason for revert: suspect this cl causes build failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/21195 > > Original change's description: > > [Multipaste] Speak a11y announcement when delete button is focused > > > > This CL does two things: > > (1) Ignore the MenuItemView instance in accessibility events handling. > > Then we can customize accessibility behaviors of the multipaste menu > > in ClipboardHistoryItemView class. > > > > (2) When the delete button gets the pseudo focus, the accessibility > > side is notified. > > > > Bug: 1145773 > > Change-Id: Ibd73b04637b89cc8200ca2f74721a10a44e857c4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513502 > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: Andrew Xu <andrewxu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#824561} > > TBR=newcomer@chromium.org,andrewxu@chromium.org > > Change-Id: I999c30afd42fa4c703f506a536fd736bcbfb48df > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1146255 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523237 > Reviewed-by: Tina Wang <tinazwang@chromium.org> > Commit-Queue: Tina Wang <tinazwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824885} TBR=newcomer@chromium.org,andrewxu@chromium.org,tinazwang@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1146255 Change-Id: I66e9612bb47f5f3196d8f800e6221cb0a3a201fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523471Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#824955}
-
Wenbin Zhang authored
This reverts commit 67f02bba. Reason for revert: The new check breaks the android build on perf waterfall, e.g.: https://ci.chromium.org/p/chrome/builders/ci/android-builder-perf/240223 Original change's description: > Android: Check R8 output for references to missing symbols > > javac prevents missing symbols via compiler errors, but they > can still occur by including prebuilts with incomplete deps, > or by using jar_excluded_patterns to remove a class that is > actually used. > > Bug: 1142530 > Change-Id: Idebb28c9e1133d9021d899c570e35a5ff16d5f14 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510236 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824739} TBR=agrieve@chromium.org,pkotwicz@chromium.org Change-Id: I20033723611ea07fcae98b7824402da89001dd8c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1142530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523395Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#824954}
-
Michael Bai authored
Bug: 1145964 Change-Id: I7cf1fbb239ec0a97e69e4d6ea2e15015ecb5fd3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521972Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#824953}
-
Quinten Yearsley authored
This builder runs the tricium_simple recipe, which runs all simple legacy analyzers for chromium. In the future, adding or modifying simple legacy analyzers would involve a change to this recipe instead of a change to the tricium config. Bug: 1105239 Change-Id: I96e2846f57c859ac4d2ca142dbeb5ca69379bc8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521848Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#824952}
-
Xiaocheng Hu authored
Bug: 1146503 Change-Id: Ie02f82b1a55e76f9f51c2879ce3131bf6a7e2640 NoTry: True Tbr: vasilii@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523474Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#824951}
-
Clark DuVall authored
With isolated splits enabled, assets must be loaded from the context for the split they are present in. This means the split name must be specified when loading pak files and the extra_icu data file from isolated splits. This CL also enables test_dummy, extra_icu, and dev_ui DFMs with isolated splits. Bug: 1126301 Change-Id: I5257bef4e92dde4657c956d60463efa46731e534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518447Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824950}
-
Nick Diego Yamane authored
Restrict extended-drag extension to OS_CHROMEOS as it depends directly into some ash components, which are not included in cast product builds. R=oshima@chromium.org, spang@chromium.org Bug: 1099418, 1146150 Change-Id: I5269825917ce9343e438aaabb9b11f560187ac0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521694 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#824949}
-
Michael Thiessen authored
The test was removing an observer after finishing the Activity, leading to an NPE. Bug: 1146208 Change-Id: I59563b4d5c9c9501d1f3a3a64c1014f39fa0351f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522607 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#824948}
-
Nico Weber authored
The feature has been on on the tot bots for a while now and it's been on by default upstream for a while, and things seem to work. Since we just rolled in a clang with all the fixes, let's turn this on. Bug: 1127713 Change-Id: I56805d576bea5936d58c653da994dc738c2a79a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520013 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#824947}
-
manukh authored
Currently, bookmark suggestions are limited to title & URL matches. E.g the input 'planets jupiter' won't suggest a bookmark titled 'jupiter' in a directory 'planets'. This is the 3rd of 3 CLs implementing bookmark-paths which will allow inputs to match bookmark paths (without contributing to the bookmark suggestion's score). This CL updates the bookmark provider to: 1) Ask the underlying bookmark model for path matching when querying for bookmarks. 2) Include the path in the suggestion contents or description depending on feature params. Bug: 1129524 Change-Id: I0b0d5f57a03e1e7a7a09ca5ab6f7b60ad161ece5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441130 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#824946}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a2d6b31f66f5..4cb5c5e17289 2020-11-06 brianosman@google.com Revert "Rearrange SkSL pre-include modules to hide things" 2020-11-06 herb@google.com test for extents of SkTextBlob drawing 2020-11-06 ethannicholas@google.com Revert "Revert "Additional SkSL benches"" 2020-11-06 egdaniel@google.com Fix ST array storage for vulkan memory barriers. 2020-11-06 adlai@google.com Remove dead no-sorting GrDrawingManager code paths 2020-11-06 michaelludwig@google.com Revert "Draw image filters directly under non-axis-aligned transforms" 2020-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 1e494cae8d48 to 3dfaeeb00271 (13 revisions) 2020-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ad54c71632cc to 612ded0654a0 (4 revisions) 2020-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e1d559cf to a4f272b3 (432 revisions) 2020-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6564890116fd to 2b6b0f45ff05 (4 revisions) 2020-11-05 johnstiles@google.com Test that SkSTArray and SkTArray classes are compatible. 2020-11-05 brianosman@google.com Rearrange SkSL pre-include modules to hide things 2020-11-05 michaelludwig@google.com Draw image filters directly under non-axis-aligned transforms 2020-11-05 bsalomon@google.com Make ManagedBackendTexture fail on invalid GrBackendTexture 2020-11-05 ethannicholas@google.com Revert "Additional SkSL benches" 2020-11-05 nifong@google.com Add a method to search for the command that shades a pixel. 2020-11-05 mtklein@google.com allow overriding {target,host}_link = ... in GN 2020-11-05 johnstiles@google.com Add int-vector folding tests to VectorFolding. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I3133930434a66f453cbdaf0dfe8104b390d3cea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523229Reviewed-by:
-
jchen10 authored
MSAA8 is slow for WebGL contexts. Currently MacOS and ChromeOS also use MSAA4 on Intel. Bug: 1145793 Change-Id: I8f29889de165c18a99616a2c2bfb74bf0d110182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522615 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#824944}
-
yilkal authored
This cl informes LoginDisplayHost observers about view bounds changes in LoginDisplayHostWebUI. The corresponding implementation for LoginDisplayHostMojo has already been implemented. Bug: 1145668 Change-Id: Ibfae96eb43be77dbcf7c37ff8a5d14b0bc532365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519859Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#824943}
-
Przemek Pietrzkiewicz authored
Bug: 1146474, 1146480 Change-Id: I1262e7347769430f44b77fed1c0a9a261aa8a332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514879 Commit-Queue: Przemek Pietrzkiewicz <ppi@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824942}
-
Michael Thiessen authored
Updates imports in chrome/android/javatests/ to use the base/ CriteriaHelper Bug: 1134178 Change-Id: I698b59619a65c58dad0701f0f2f70c69abe99aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518894 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#824941}
-
adoneria authored
Uses a template to dynamically generate updater version_info.py. This is required to install correct updater version during testing. Also copy over the generated file to test package so that python can read it as a package and successfully import it. Bug: 1140211 Change-Id: I10da968690f47fccd35bddb6c5d9f77f89bbce83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510877Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#824940}
-
Bailey Berro authored
This change introduces the CpuUsageData and accompanying tests. Bug: 1128204 Change-Id: I401b4884be3cac434196da1ab35977c9e8866e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522055 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#824939}
-
Clark DuVall authored
It seems there is a bug in Android which will use a different ClassLoader for components declared in a split than is returned by Context.createContextForSplit().getClassLoader(). This fix attempts to force the ClassLoader to be the same using AppComponentFactory. Note that this fix only works on P+, but nearly all the reports have been from P+ (with most from Q+). If this stops the crash on those versions, we can see if another workaround can be found for O. One of the main places this is seen is when loading feature modules, since the implementation class is loaded with the ClassLoader from ContextUtils.getApplicationContext(). Another place I believe has the same root cause is when native code calls back into java. This also uses the ClassLoader from ContextUtils.getApplicationContext(), and can cause weird errors like globals not being set that were set in the other ClassLoader. crbug.com/1142614 has some of those. Bug: 1142589, 1142614, 1142588 Change-Id: Iddee0964ce057b0811833bdd0ca7c5da56fdefb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522511Reviewed-by:
-
Daniel Vogelheim authored
This uses - behind a flag - the trial implementation of TC39 "Dynamic Code Brand Checks" in crrev.com/c/2339618 to fix the handling of TrustedScript with the JavaScript Function constructor. Bug: 1096017, 1087743 Change-Id: I42f2f4295fdf3aab0b2e8c80ebf3d04373c17368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340905 Auto-Submit: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#824937}
-
minch authored
TrayPopupItemStyle is used to set some of the icon and label's colors of system tray, also the fontlist of the label. Remove it and get the colors from AshColorProvider instead. This is also better for necessary live update later. Bug: 1131543 Change-Id: Ia148fa60725017f471bd9730d2f0b23a2239d17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509000Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#824936}
-
Pavol Marko authored
The invalidation topics in certificate provisioning are public, not private. Also, fix CertProvisioningWorker accidentally invalidating the weak pointer it used to bind the OnShouldContinue callback. Add a unit test for that case (fails without the fix). Bug: 1146410 Change-Id: Ib3024d977de3de2a2b75de0c0b279dd0c8764883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523208 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#824935}
-
kylechar authored
conformance/textures/video/tex-2d-luminance-luminance-unsigned_byte.html is flaky on chromeos-amd64-generic-rel. Bug: 1145830 Change-Id: I93efd5497d75903efe0e19557c8981ef4f130121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522606 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#824934}
-
Xiaocheng Hu authored
Bug: 1146484 Change-Id: Ie30b17eb2b12c894fdf65bf51d2e1f836ef5c39d NoTry: True Tbr: jboulic@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523412Reviewed-by:
-
