GitLab

Add dedicated windowToViewport method to convert FloatRect from window coordinates to Viewport coordinates.

... to avoid rounding issue with fractional scale factor.
BUG=485650

Review URL: https://codereview.chromium.org/1603253003

Cr-Commit-Position: refs/heads/master@{#371762}

All other return values pass through
computeReplacedLogicalWidthRespectingMinMaxWidth, let this one do so
too.

Review URL: https://codereview.chromium.org/1637473002

Cr-Commit-Position: refs/heads/master@{#371761}

If we return nullptr trying to consume a compound, and all tokens have
been consumed, we don't recognize that as a parse failure if a valid
selector precedes the compound. Set m_failedParsing to true to notice
we have an invalid selector.

R=timloh@chromium.org
BUG=581257

Review URL: https://codereview.chromium.org/1634273003

Cr-Commit-Position: refs/heads/master@{#371760}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5c7b38de6fd5..537c7c6cb877

$ git log 5c7b38de6..537c7c6cb --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1640553003

Cr-Commit-Position: refs/heads/master@{#371759}

* <!DOCTYPE> should be shown differently.
  Old:    html    0xhhhhhhhh
  New:    DOCTYPE html  0xhhhhhhhh

* Processing Instructions should be shown differently.
  Old:    xml-stylesheet    0xhhhhhhhh
  New:    ?xml-stylesheet   0xhhhhhhhh

* Elements and documents show editability
  Old:    body    0xhhhhhhhh
  New:    body    0xhhhhhhhh (editable)

This CL has no behaivor changes in production.

Review URL: https://codereview.chromium.org/1639193002

Cr-Commit-Position: refs/heads/master@{#371758}

Change getDistributedNodes to getAssignedNodes to make the performance test run.
BUG=531990

Review URL: https://codereview.chromium.org/1630003004

Cr-Commit-Position: refs/heads/master@{#371757}

This CL adds metrics to measure the usage of features that require permissions
in Chrome when they are used in cross-origin iframes only. In particular we only
want to count an iframe if it doesn't have scripting access into the top level
document. A new UseCounter::countCrossOriginIframe function has been added which
will only count this type of usage.

Note that this intends to count cases when a site tries to use an API whether or
not the permission is granted by the user.

BUG=444744

Review URL: https://codereview.chromium.org/1578263006

Cr-Commit-Position: refs/heads/master@{#371756}

Cr-Commit-Position: refs/heads/master@{#371755}

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/1639833002

Cr-Commit-Position: refs/heads/master@{#371754}

Enable gl path rendering by default if it is supported by the
hardware.

Skia will use it when GPU rasterization MSAA codepath is used.

BUG=344330

Review URL: https://codereview.chromium.org/1626363002

Cr-Commit-Position: refs/heads/master@{#371753}

This will avoid new dependencies and helps with keeping track of the
refactoring.

R=pfeldman@chromium.org
BUG=
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1632273002

Cr-Commit-Position: refs/heads/master@{#371752}

This patch moves implementations of |SelectionAdjuster| into its own file.

This is a follow-up patch of http://crrev.com/1630903005, which introduces
|SelectionAdjuster| into "SelectionEditor.cpp" and "VisibleSelection.cpp".

BUG=n/a
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1640623002

Cr-Commit-Position: refs/heads/master@{#371751}

This CL is part of the net::IPAddressNumber migration[1].

IPEndpoint::address() currently returns a net::IPAddressNumber but we need it to return a net::IPAddress.

BUG=496258
TBR=scheib

[1] https://code.google.com/p/chromium/issues/detail?id=496258#c10

Review URL: https://codereview.chromium.org/1565303002

Cr-Commit-Position: refs/heads/master@{#371750}

https://chromium.googlesource.com/chromium/src/+/39de759a9

BUG=537077
TBR=noel@chromium.org

Review URL: https://codereview.chromium.org/1633403004 .

Cr-Commit-Position: refs/heads/master@{#371749}

The old EDK always initializes the new EDK as well, but it wasn't
shutting it down unless --use-new-edk was set. This was hitting
CHECKs to guard against double-initialization, because tests init
and shutdown the EDK multiple times in the same process.

This CL fixes that by always shutting the new EDK down as well.

Also we don't actually use g_io_thread_task_runner anymore so
I removed that.

TBRing since it's a pretty obvious fix IMHO and it's breaking
stuff on bots.

BUG=None
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/1642453002

Cr-Commit-Position: refs/heads/master@{#371748}

Spec is described here: http://w3c.github.io/webcomponents/spec/shadow/#dfn-scoped-flag
Only with UA's creation of certain events(abort, error, etc.), this scoped flag is set to true.
Note that any event created by users has scoped flag set to false by default.
R=hayato@chromium.org
BUG=531990, 575042

Review URL: https://codereview.chromium.org/1586563005

Cr-Commit-Position: refs/heads/master@{#371747}

Having this rule defined in mini_installer.gypi cause the following
warning:

warning: multiple rules generate mini_installer_exe_version.rc. builds
involving this target will not be correct

This is because this .gypi gets included both by mini_installer.gyp and
by mini_installer_syzygy.gypi. So these 2 targets declare
'mini_installer_exe_version.rc' as one of their output, and for some
reason the _syzygy one win and becomes the owner of this file.
This creates the following dependencies (from bottom to top):

syzygy/chrome.dll.pdb
  stamp
    obj/chrome/chrome_dll_syzygy.actions_rules_copies.stamp
      stamp
        obj/chrome/installer/mini_installer_syzygy.actions_depends.stamp
          mini_installer_syzygy_target_mini_installer_version_71edb9637c223314ee6152f2a3daf553
            mini_installer_exe_version.rc
              rc
              stamp
                obj/chrome/installer/mini_installer.mini_installer_exe_version.res
                obj/chrome/installer/mini_installer.actions_rules_copies.stamp
                  link_embed
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                  rc
                  cxx
                  cxx
                  cxx
                  cxx
                    mini_installer.exe
                      stamp
                        obj/build/chrome_official_builder_no_unittests.actions_depends.stamp
                          stamp
                            obj/build/chrome_official_builder.actions_depends.stamp
                              chrome_official_builder

Equivalent to (-> = "depends on"):

chrome_official_builder -> mini_installer.exe -> mini_installer_exe_version.rc -> mini_installer_syzygy -> chrome_dll_syzygy

Having this kind of dependency between mini_installer and the syzygy target cause some
important build failures on the official builder.

Defining this target in a new gyp file (instead of in a gypi file) fix this redefinition issue
(i.e. both targets still depends on it but they don't define it).

TBR=gab@chromium.org, grt@chromium.org
BUG=581525

Review URL: https://codereview.chromium.org/1633343002

Cr-Commit-Position: refs/heads/master@{#371746}

Currently the number of pages per bucket is limited to 2^16,
and this has caused a bunch of crash reports at partitionBucketFull().

This CL increase the limit to 2^24 instead of decreasing the limit of
|numSystemPagesPerSlotSpan| to 2^8 (It is statically guaranteed that |numSystemPagesPerSlotSpan|
does not exceed 2^8). As a result, this CL doesn't change sizeof(PartitionBucket).

BUG=87772

Review URL: https://codereview.chromium.org/1622553004

Cr-Commit-Position: refs/heads/master@{#371745}

Move some enum definitions from //ui/base/ime into a new target
//ui/base/ime:text_input_types. This is to fix a circular dep problem that
appears with //ui/ozone not being able to depend on //ui/platform_window.
It fixes a failing GN check and allows ozone implementations to include
//ui/platform_window correctly.

The new target only has header files with enum definitions. Two of the
files in the new target were not previously in any target. The GYP target
has type none because iOS builds fail when a library has no source files
in them.

BUG=361137

Review URL: https://codereview.chromium.org/1619423003

Cr-Commit-Position: refs/heads/master@{#371744}

Before this CL, we don't check required member field when 'null' is
passed as a dictionary. Add the checks.

BUG=580531

Review URL: https://codereview.chromium.org/1631333003

Cr-Commit-Position: refs/heads/master@{#371743}

Step 7 in

https://html.spec.whatwg.org/multipage/embedded-content.html#processing-model

BUG=578125

Review URL: https://codereview.chromium.org/1631303002

Cr-Commit-Position: refs/heads/master@{#371742}

https://chromium.googlesource.com/chromium/src/+/a9c81551f

BUG=570611
TBR=wkorman@chromium.org

Review URL: https://codereview.chromium.org/1641533002 .

Cr-Commit-Position: refs/heads/master@{#371741}

Classes outside of core/layout/ that need a reference to an InlineBox's
layoutObject must currently use the API-busting shim we've set up to
get a reference to a LineLayoutItem's underlying layoutObject.

Some references can simply be changed to lineLayoutItem() directly, where
the line layout API already provides access to the methods used.

There are no functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1629643002

Cr-Commit-Position: refs/heads/master@{#371740}

BUG=581131
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1634343002

Cr-Commit-Position: refs/heads/master@{#371739}

This is part of the ongoing refactoring to make clients use the line
layout API instead of poking at LayoutObjects directly.

No functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1624593003

Cr-Commit-Position: refs/heads/master@{#371738}

We weren't zeroing the allocated memory before filling
the buffer. Due to padding this means there could be
uninitialized bytes. Bad news. Fixed.

Should fix failures on memory bots:

https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20Browser%20%28DrMemory%20full%29%20%284%29/builds/7154

BUG=None
TBR=thestig@chromium.org,darin@chromium.org

Review URL: https://codereview.chromium.org/1641493002

Cr-Commit-Position: refs/heads/master@{#371737}

This adds a new AddServiceOverride method to ServiceRegistryImpl.
The purpose of this is to allow testing code to intercept remote
service connections and opaquely provide a mock implementation of
any service.

The new interface is also added to the ServiceRegistry's JS
bindings.

Review URL: https://codereview.chromium.org/1470153002

Cr-Commit-Position: refs/heads/master@{#371736}

Update the test resource to the golden file [1] and rebaseline the
test result.

[1] https://code.google.com/p/chromium/issues/detail?id=570150#c25

TBR=radu.velea@intel.com
BUG=537077,570150
NOTRY=true

Review URL: https://codereview.chromium.org/1638253002

Cr-Commit-Position: refs/heads/master@{#371735}

BUG=540864

Review URL: https://codereview.chromium.org/1638953002

Cr-Commit-Position: refs/heads/master@{#371734}

- ash::Shell::GetScreen()
- DisplayInfoProvider::GetActiveScreen()

Followup to https://codereview.chromium.org/1608733002/.

R=oshima@chromium.org, sky@chromium.org
BUG=558054

Review URL: https://codereview.chromium.org/1608053002

Cr-Commit-Position: refs/heads/master@{#371733}

https://chromium.googlesource.com/chromium/src/+/4f439fec8

BUG=579151
TBR=sigbjornf@opera.com

Review URL: https://codereview.chromium.org/1633403003 .

Cr-Commit-Position: refs/heads/master@{#371732}

There is no invalid value default, so the missing value default will
apply in that case too.
The 'Unknown' HTMLAreaElement::Shape enumeration value is no longer
needed, so remove it.

Also add support for the non-conforming <area shape> values:

 * 'circ'     (alias for 'circle')
 * 'polygon'  (alias for 'poly')
 * 'rectangle (alias for 'rect')

Because 'rect' (and hence 'rectangle') is the same as the missing
value default we don't need any explicit checks for these values.

https://html.spec.whatwg.org/multipage/embedded-content.html#attr-area-shape

BUG=578125

Review URL: https://codereview.chromium.org/1632133007

Cr-Commit-Position: refs/heads/master@{#371731}

https://chromium.googlesource.com/chromium/src/+/3e32a8e50

BUG=579365
TBR=samli@chromium.org

Review URL: https://codereview.chromium.org/1638243002 .

Cr-Commit-Position: refs/heads/master@{#371730}

https://chromium.googlesource.com/chromium/src/+/9dd810a16

BUG=516751
TBR=vmpstr@chromium.org

Review URL: https://codereview.chromium.org/1635423002 .

Cr-Commit-Position: refs/heads/master@{#371729}

Several android bots are failing v8.infinite_scrolling almost
consistently.

R=nednguyen,eakuefner,sullivan
BUG=579546
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:win_perf_bisect

Review URL: https://codereview.chromium.org/1638063002

Cr-Commit-Position: refs/heads/master@{#371728}

https://chromium.googlesource.com/chromium/src/+/5a4c04591

BUG=530095
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1637343002 .

Cr-Commit-Position: refs/heads/master@{#371727}

 - Stop passing the 'cr.webUIResponse' string from JS to C++ and again back to JS.
 - Restricting C++ response to JS to a single argument, since Promises
   can only be resolved with a single argument (this is also more consistent
   with Mojo-based communication).
 - Adding additional test cases.

BUG=580633

Review URL: https://codereview.chromium.org/1635673003

Cr-Commit-Position: refs/heads/master@{#371726}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e314e3752a98..5c7b38de6fd5

$ git log e314e3752..5c7b38de6 --date=short --no-merges --format='%ad %ae %s'

CQ_INCLUDE_TRYBOTS=
TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1635383002

Cr-Commit-Position: refs/heads/master@{#371725}

Revert of Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes (patchset #2 id:20001 of https://codereview.chromium.org/1626163002/ )

Reason for revert:
Broke compile:
../../ui/accelerated_widget_mac/display_link_mac.cc:94:69: error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull]
      CVDisplayLinkSetOutputCallback(display_link_, nullptr, nullptr);
                                                    ~~~~~~~         ^

Original issue's description:
> Speculative fix for ui::DisplayLinkMac::StopDisplayLink crashes
>
> The CVDisplayLink is tied to a ScopedTypeRef data member of DisplayLinkMac.
> However, there may be other references. Since there's no guarantee that
> ~DisplayLinkMac() will invoke the last CVDisplayLinkRelease(..) and clear
> the callback automatically, clear it explicitly in ~DisplayLinkMac.
>
> BUG=564780
>
> Committed: https://crrev.com/2286ddf0119516f7a93feaff4f8ce2edff8c4543
> Cr-Commit-Position: refs/heads/master@{#371648}

TBR=ccameron@chromium.org,tapted@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=564780

Review URL: https://codereview.chromium.org/1637313002

Cr-Commit-Position: refs/heads/master@{#371724}

https://chromium.googlesource.com/chromium/src/+/38858c577

BUG=568196
TBR=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/1641513002 .

Cr-Commit-Position: refs/heads/master@{#371723}