- 01 Dec, 2016 40 commits
-
-
mikhail.pozdnyakov authored
This patch is a part of 'AudioContext.getOutputTimestamp' method implementation [1] and it continues the changes introduced at [2]. The AudioRendererSink::RenderCallback::Render method has same semantics as AudioSourceCallback::OnMoreData. That caused other changes in the following interfaces: - AudioSyncReader::UpdatePendingBytes(uint32_t bytes, uint32_t frames_skipped) -> AudioSyncReader::PrepareNextData(base::TimeDelta delay, base::TimeTicks delay_timestamp, uint32_t frames_skipped) - AudioDeviceThread::Callback::Process(uint32_t pending_data) -> AudioDeviceThread::Callback::Process(int64_t pending_data, base::TimeTicks data_timestamp) - AudioDeviceThread is receiving a "packet" of two int64_t values BUG=619533 [1] https://codereview.chromium.org/2060833002/ [2] https://codereview.chromium.org/2101303004/ Initially committed at: https://crrev.com/06d9d80a203b9c329fc6d53fde44bae66645a389 Reverted at: https://crrev.com/2665e952502835c6c37d51153bfa180343635a41 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2517503003 Cr-Commit-Position: refs/heads/master@{#435597}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c43132b7..eb1b609e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2539423002 Cr-Commit-Position: refs/heads/master@{#435596}
-
yhirano authored
BUG=666227 Review-Url: https://codereview.chromium.org/2544603003 Cr-Commit-Position: refs/heads/master@{#435595}
-
yamaguchi authored
BUG=669055 TEST=manual test as noted in the bug CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2538403003 Cr-Commit-Position: refs/heads/master@{#435594}
-
torne authored
Various code was passing pointers to heap-allocated ScopedJavaGlobalRef objects in order to pass Java objects between threads. Having heap-allocated smart pointer types is very weird and not a desirable pattern. base::Bind handles rvalues correctly (they become owned by the callback) and so the nicer alternative is to simply pass temporary ScopedJavaGlobalRef parameters, which will automatically be deleted when the callback is deleted. The receiving function can take a const reference to JavaRef as its parameter type, which matches how direct function calls typically take Java object parameters and makes this look much more consistent. ScopedJavaGlobalRef is movable, so using std::mode is also an option, but all the cases in this CL simply construct temporaries. BUG=519562 Review-Url: https://codereview.chromium.org/2538463002 Cr-Commit-Position: refs/heads/master@{#435593}
-
yoichio authored
TextControlElement::{start,end}{Word,Sentence}() without VisiblePosition was introduced for Speedometor benchmark.(crrev.com/db6862d1) Since, editing is now pipeline friendly and hoisting have not caused regression, we need not have such optimization functions. This CL clean up code path. I will clean up the functions later. BUG=639528 Review-Url: https://codereview.chromium.org/2533213003 Cr-Commit-Position: refs/heads/master@{#435592} -
kbr authored
These were accidentally dropped during the port to the new harness a while back. BUG=352807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Review-Url: https://codereview.chromium.org/2547463002 Cr-Commit-Position: refs/heads/master@{#435591}
-
jbriance authored
Remove useless class and struct forward declarations, and add missing ones in android_webview header files. BUG=662195 Review-Url: https://codereview.chromium.org/2540163002 Cr-Commit-Position: refs/heads/master@{#435590}
-
kozyatinskiy authored
If line contains at least one breakpoint and more then one possible breakpoint location then text editor will show decorations for all breakpoints and possible breakpoint locations. BUG=chromium:566801 R=lushnikov@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2526013002 Cr-Commit-Position: refs/heads/master@{#435589}
-
tzik authored
ExecutionContext has its own task suspension through MainThreadTaskRunner. However, the suspension can be coarser, since it's used only when the page is suspended. Also, the custom suspension / resumption makes it hard to use finer grained TaskType. This CL moves the task suspension from ExecutionContext to WebFrameScheduler. Review-Url: https://codereview.chromium.org/2527143002 Cr-Commit-Position: refs/heads/master@{#435588}
-
tommyt authored
This changes the name and signature of the PaymentInstrument.getInstrumentMethodName method to: Set<String> getInstrumentMethodNames() This is to match the "enabledMethods" field in the PaymentAppOption dictionary in the Payment Apps specification, which is defined to be a sequence of strings. See: https://w3c.github.io/webpayments-payment-apps-api/#payment-app-options I also change the name of PaymentInstrument.getInstrumentDetails to "invokePayment" in order to convey better that this is where the payment method specific stuff happens. For a Web Based Payment App, this method is an appropriate point to launch the payment request event into the service worker. BUG=669876 Review-Url: https://codereview.chromium.org/2530793002 Cr-Commit-Position: refs/heads/master@{#435587} -
milko.leporis authored
As of LLVM r287681 there are no issues when using integrated as. BUG=None TEST=Build Chromium Linux for MIPS with integrated as Review-Url: https://codereview.chromium.org/2538493003 Cr-Commit-Position: refs/heads/master@{#435586}
-
kouhei authored
BUG=None Review-Url: https://codereview.chromium.org/2543933002 Cr-Commit-Position: refs/heads/master@{#435585}
-
battre authored
Setting the testing build time ensures that the test passes even if the system clock is incorrect when running the test. BUG=666821,668539 Review-Url: https://codereview.chromium.org/2546433002 Cr-Commit-Position: refs/heads/master@{#435584}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e08f5483..c43132b7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2546693002 Cr-Commit-Position: refs/heads/master@{#435583}
-
tapted authored
tools/grit used to add it, but it should move to chrome_grit_defines instead to avoid a ui dependency there. It's currently breaking WebRTC. It's currently used by chrome/app/theme/theme_resources.grd. (ui_resources.grd might need it later, but it doesn't right now). BUG=657244 TBR=scottmg@chromium.org, sky@chromium.org Review-Url: https://codereview.chromium.org/2535753007 Cr-Commit-Position: refs/heads/master@{#435582}
-
tkent authored
This CL has no behavior changes. NOTRY=true Review-Url: https://codereview.chromium.org/2546473004 Cr-Commit-Position: refs/heads/master@{#435581}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#435580} -
alemate authored
BUG=604119 TEST=none Review-Url: https://codereview.chromium.org/2530453002 Cr-Commit-Position: refs/heads/master@{#435579}
-
keishi authored
BUG= 591606 Review-Url: https://codereview.chromium.org/2540143002 Cr-Commit-Position: refs/heads/master@{#435578}
-
yhirano authored
Test mojo-loading feature with http/tests layout tests. BUG=669357 Review-Url: https://codereview.chromium.org/2505933002 Cr-Commit-Position: refs/heads/master@{#435577}
-
tsergeant authored
Grouped mode is currently in active development for MD History, but it is necessary to execute Javascript in Devtools to enable it. This adds an obscure keyboard shortcut to the page which enables grouped mode, simplifying debugging of this feature. BUG=589357 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2543593003 Cr-Commit-Position: refs/heads/master@{#435576}
-
tapted authored
The "Harmony" control style diverges sufficiently from AppKit controls such that we should no longer distinguish between "WebUI" and "AppKit" themes for native dialogs when selecting whether to use the toolkit-views or Cocoa version of a dialog. Also the toolkit-views theme currently breaks on Mac when not used in conjunction with --secondary-ui-md. --secondary-ui-md describes the outcome nicely, so collapse the "MacViewsNativeDialogs" and "MacViewsWebUIDialogs" feature flags into --secondary-ui-md. BUG=658105 Review-Url: https://codereview.chromium.org/2524213002 Cr-Commit-Position: refs/heads/master@{#435575}
-
jbriance authored
Remove useless class and struct forward declarations, and add missing ones in remoting header files. BUG=662195 Review-Url: https://codereview.chromium.org/2538183002 Cr-Commit-Position: refs/heads/master@{#435574}
-
yoav authored
This fixes an issue where a resource loader belonging to one ResourceFetcher was accidentally added as a blocking loader to another ResourceFetcher, by checking the loader is part of the already non-blocking loaders belonging to current ResourceFetcher. This also adds DCHECKs on a couple of methods removing loaders from hashmaps, to make sure we're not trying to remove a nullptr. BUG=666563 Review-Url: https://codereview.chromium.org/2537303003 Cr-Commit-Position: refs/heads/master@{#435573}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/582ccd4ab71b..852f85163d54 $ git log 582ccd4ab..852f85163 --date=short --no-merges --format='%ad %ae %s' 2016-11-30 eakuefner Revert of [Telemetry] Ensure that story display names are unique (patchset #4 id:60001 of https://codereview.chromium.org/2153513002/ ) 2016-11-30 eakuefner [Telemetry] Ensure that story display names are unique Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2541303002 Cr-Commit-Position: refs/heads/master@{#435572}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22c94457..e08f5483 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2540233004 Cr-Commit-Position: refs/heads/master@{#435571}
-
tkent authored
This CL has no behavior changes. NOTRY=true Review-Url: https://codereview.chromium.org/2538333003 Cr-Commit-Position: refs/heads/master@{#435570}
-
meade authored
This will allow easier testing of each property as we add support in CSS Typed OM, as we will not have to hand-write exhaustive tests for each property, and we will easily be able to add a new test that applies to every element easily if we need to later. The standard set of tests is: *single-valued properties* - Setting with a sequence of valid values throws - Calling append with a valid value throws *list-valued properties* - Setting with a sequence of valid values works - Setting with a sequence containing valid and invalid values throws - Append succeeds with a valid value - Appending a sequence of valid values succeeds - Append throws when given an invalid value - Append throws when given a sequence containing valid and invalid values - GetAll when the property is set to a list returns all the properties *common* - Can be set to each valid keyword (automatically adds initial, inherit and unset) - Can be set to each given valid instance of StyleValue - Setting to an invalid type throws (automatically adds null, undefined, true, false, 1, 'hello', {}, and a fake keyword) - Get returns the right KeywordValue when the property is set to each valid keyword - Get returns the right StyleValue when the property is set to .cssText of each given valid StyleValue - GetAll works when the property is set to a valid StyleValue instance - Delete removes the style from the element - GetProperties includes the name of the property when it is set to something I've added example tests for "bottom" and "animation-direction", as semi-random, convenient single-valued and list-valued properties. Note that since getting CSSKeyword from a StylePropertyMap is not yet fully supported, the new tests fail. BUG=545318 Review-Url: https://codereview.chromium.org/2529043002 Cr-Commit-Position: refs/heads/master@{#435569} -
bashi authored
A RuntimeException can be thrown when we call ActivityManager.getMemoryInfo() when the system is going to restart. To avoid immediate crash, handle these exceptions gracefully. BUG=668966 Review-Url: https://codereview.chromium.org/2545673002 Cr-Commit-Position: refs/heads/master@{#435568}
-
benwells authored
The new metrics record the action the user took after the disclosure was shown (ignored, clicked settings, or dismissed), as well as the time that the infobar was shown for. BUG=661011 Review-Url: https://codereview.chromium.org/2534363002 Cr-Commit-Position: refs/heads/master@{#435567}
-
hywu authored
Linux refuses to accept buffers that have sizes ualigned to CPU cache line, which can be 128 bytes on certain devices. This test inputs a frame that has unaligned size of U and V planes to catch such errors. BUG=664039 TEST=Run VEA unittest on Kevin. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/62f3a0edf9c5e19da3e59a6b2f5c402895b1805a Review-Url: https://codereview.chromium.org/2525563005 Cr-Original-Commit-Position: refs/heads/master@{#435179} Cr-Commit-Position: refs/heads/master@{#435566}
-
yukishiino authored
Revert of binding: Removes Document::wrap that must be equivalent to Node::wrap. (patchset #5 id:100001 of https://codereview.chromium.org/2525313004/ ) Reason for revert: CHECK(!frame->document()->containsWrapper()); in WindowProxy::updateDocumentProperty() is causing crashes at several places. Original issue's description: > binding: Removes Document::wrap that must be equivalent to Node::wrap. > > Removes unnecessary Document::wrap and associateWithWrapper. > The special code in these functions were made in order to keep > WindowProxy::m_document updated and consistent with toV8(document). > But we no longer rely on the hack, and we can remove the dead code. > > BUG= > > Committed: https://crrev.com/87dc599743f71d33466ac56a8db5a53c5f6ce46c > Cr-Commit-Position: refs/heads/master@{#435226} TBR=haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669968 Review-Url: https://codereview.chromium.org/2538403002 Cr-Commit-Position: refs/heads/master@{#435565}
-
meade authored
BUG=542537 Review-Url: https://codereview.chromium.org/2541783002 Cr-Commit-Position: refs/heads/master@{#435564}
-
meade authored
Replace entire passage taken from a particular news article with more neutral dummy text (used http://www.cipsum.com to generate random buzzword text). BUG=542537 Review-Url: https://codereview.chromium.org/2541773002 Cr-Commit-Position: refs/heads/master@{#435563}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/f447deea6289..71b762f2aca1 $ git log f447deea6..71b762f2a --date=short --no-merges --format='%ad %ae %s' 2016-11-30 borenet [nobuildbot] CT bots Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@google.com Review-Url: https://codereview.chromium.org/2540423002 Cr-Commit-Position: refs/heads/master@{#435562}
-
renjieliu authored
BUG= Review-Url: https://codereview.chromium.org/2539333002 Cr-Commit-Position: refs/heads/master@{#435561}
-
meade authored
BUG=542537 Review-Url: https://codereview.chromium.org/2540013003 Cr-Commit-Position: refs/heads/master@{#435560}
-
napper authored
Made CSS white-space property use IndependentInherit, which is part of the process of making property inheritance faster. This change adds 1 bit to the size of ComputedStyle but significantly reduces the time for a recalc for independent-only changes involving whitespace. Tested using: third_party/WebKit/LayoutTests/fast/css/invalidation/independent-inheritance-fast-path.html BUG=622138 Review-Url: https://codereview.chromium.org/2538983002 Cr-Commit-Position: refs/heads/master@{#435559}
-
dominickn authored
BUG=None Review-Url: https://codereview.chromium.org/2542063002 Cr-Commit-Position: refs/heads/master@{#435558}
-