- 08 Jun, 2020 40 commits
-
-
Jeffrey Cohen authored
This also adds the screenshot to the view. https://hsv.googleplex.com/5993630915362816 Test classes for the view and mediator are also added. Bug: 1034733 Change-Id: Iaadf3e32d87c31bf453c049b416fa2cd7bf6445f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211050 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#776167}
-
Andrew Grieve authored
Cronet is the only project that requires a lower minSdkVersion. To continue supporting building of their targets, this change enabled proguard on all of their apks in order to have all files desugared at the proper minApiVersion. This change should speed up compiles somewhat, as it removes the need to generate main-dex-lists for legacy multidex purposes. Bug: 1091919 Change-Id: Ifd8089bbf4965b55a13dea11464ccda979fd5028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233581Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#776166}
-
Tom Anderson authored
BUG=1055026,1090915 R=dpranke CC=goanuj Change-Id: I7009f67268fa5d35e9d41fca593248c36f6ef631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232837 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#776165}
-
Denis Kuznetsov authored
This CL adds 'inline-suffix' slot that allows to have suffix element within undelined space of cr-input. It also renames existing 'prefix' slot to 'inline-prefix' for consistency. Bug: 856310 Change-Id: If371576fd69006a1c20d9ab5406ea6d2becdd88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198994Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776164}
-
Joshua Pawlicki authored
Bug: 1088779 Change-Id: I01b5ec432f7aa17955375f637a387c779c45fc06 Fixed: 1088779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236013 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#776163}
-
Kartik Hegde authored
Add a routine to test whether a DNS resolution can be completed successfully. BUG=chromium:956783 TEST=unit_tests --gtest_filter=DnsResolutionRoutineTest.* Change-Id: I70f15771569e03068e10e8213c55f7656e4a49f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159897 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#776162}
-
Anastasia Helfinstein authored
Because the options in a combo box are not in the automation tree, we will handle combo boxes by simulating arrow keys. This behavior will be changed when the underlying data is available. AX-Relnotes: n/a. Bug: 996401 Change-Id: Ice9003de483a4d9cdb7edd32f97f8024ec8b477b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231660 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#776161}
-
Alison Maher authored
As a result of http://crrev.com/c/2079192, the PreferredColorScheme is stored and accessed through WebSettings instead of WebThemeEngine. With this change, SVGImage no longer can retrieve the correct PreferredColorScheme needed to respond to the prefers-color-scheme media query as it had before. To fix this, pass the PreferredColorScheme from Settings to SVGImage via SVGImage::DataChange(). Bug: 1090464,1090660 Change-Id: I0aacd08930fad21f55c9dfa8dd1b8f747912237d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230909 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#776160}
-
James Cook authored
This reverts commit e8e3c1af. Reason for revert: This was a mistake. We aren't ready to launch everywhere (see comment about field trial below). There's a JSON file we can likely use to get the test waterfalls to exercise the feature. I'm following up with the Finch team to make sure the file can be used for first-run client-side trials, but for now I'm going to revert this. Original change's description: > chromeos: Enable feature SplitSettingsSync by default > > This is the "V1" feature. It: > - Creates a new "Sync your settings" section in Chrome OS settings > - Moves app, wallpaper and Wi-Fi sync to OS settings > - Provides a separate toggle for OS preferences, distinct from browser > preferences > - Makes the OS ModelTypes run in sync transport mode, controlled by a > master pref for the OS sync feature > - Updates the OOBE sync consent screen > > NOTE: The feature is rolling out via a client-side Finch trial, so the > actual state will vary. See config in > chrome/browser/chromeos/sync/split_settings_sync_field_trial.cc > > Bug: 1013466 > Change-Id: Ie84b193cd7c298387245f1c32f868b04731fb0e9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210623 > Auto-Submit: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775785} TBR=jamescook@chromium.org,xiyuan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013466 Change-Id: Ib3e22c79ce90f8bbfdb6ba2acd4d5e311681eb4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236216 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#776159}
-
Eugene But authored
This CL records the following user actions: - MobilePullGestureReload (existing action recorded on Android) - MobilePullGestureCloseTab (new action; iOS-only) - MobilePullGestureNewTab (new action; iOS-only) Bug: 1083433 Change-Id: I0bc7c3b0b70adec65e89708ad125d90c7534c13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229615Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#776158}
-
Daniel Nicoara authored
Whenever we create a RenderViewHost, update it's Blink properties and enable the scrollbar. The scrollbar is disabled by default on Chromecast since Cast Apps are not supposed to be scrollable. Webviews don't have such limitations so enable scrollbars for Webviews only. BUG=b/158124105 TEST=Manually on device with a scrollable page. Change-Id: I0e7c8971760977568afa2a6a3eede6b28a8dd6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231589Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#776157}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00a96f2c994c..fee069880d16 2020-06-08 johnstiles@google.com Reland "Move JavaInputStreamAdaptor into third_party and add a LICENSE file." 2020-06-08 johnstiles@google.com Define sample(null) as returning the inputColor unchanged. 2020-06-08 fmalita@chromium.org Reland "[skrive] Initial parser plumbing" 2020-06-08 bungeman@google.com Use "und" in place of HB_LANGUAGE_INVALID. 2020-06-08 herb@google.com simplify GrTextContext 2020-06-08 fmalita@chromium.org Revert "[skrive] Initial parser plumbing" 2020-06-08 johnstiles@google.com Update GrAARectEffect to use a child FP. 2020-06-08 reed@google.com inline Cluster::run() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I5907047496a3d6c68b7e75e4853c0629707f283c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776156}
-
Fredrik Söderqvist authored
Previously this would be happening via the call to RemoveClient(), which ended up calling RemoveClientFromCache() on the LayoutObject associated with the <filter>. Bug: 1091568 Change-Id: I473321962dd5855e228403ad6bcba96ea6f825ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235078Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#776155}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/675551d57710..cab169a237ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xidachen@google.com,dimich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1059002 Tbr: xidachen@google.com,dimich@google.com Change-Id: Ic8ae4d3c71275d45a42342d055cc0a3d974c1e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235963Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776154}
-
Akihiro Ota authored
This change does the following: 1. Adds an interactive tutorial polymer component 2. Adds a lesson polymer component 3. Adds html files used to define the test areas for interactive lessons. 4. Ports over some content from the existing tutorial into the new one. 5. Connects the interactive tutorial to the ChromeVox panel. 6. Wait to send commands to the panel until the panel has loaded. Connecting the tutorial to the panel was increasing the panel load time, which was causing us to fail panel-related tests. 7. Compiles ChromeVox using ES_NEXT rule to support async panel command behavior; errors were fired when trying to compile using ES6. Bug: 1075752 AX-Relnotes: N/A Change-Id: I7589a1d81185cba93242a1e419da4bd466351f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194345 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776153}
-
Brian Sheedy authored
This reverts commit 7e159a10. Reason for revert: No longer necessary. Original change's description: > Disable GPU Watchdog on CrOS tests > > Temporarily disables the GPU watchdog on GPU Telemetry tests on CrOS. > It is suspected that the watchdog is causing general test flakiness > on CrOS, so it is being disabled for ~1 day to see if there's any > noticeable impact on flakiness. > > Bug: 1090071 > Change-Id: I13936e94798bcd71e024bf761246ed330ec5444c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229436 > Auto-Submit: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774932} TBR=kbr@chromium.org,bsheedy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1090071 Change-Id: I155137da44a3e479d474a1fd87b53f1e9bedc195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236017Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776152}
-
Harald Alvestrand authored
and rebase changed tests. This reverts commit 328f27b7. Reason for revert: Change has now landed Original change's description: > Disable tests for landing a WebRTC name change > > Bug: webrtc:8787 > Change-Id: I5a166726bf236e088426734456f2d503e3c6875e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232554 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775594} TBR=hta@chromium.org,hbos@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:8787 Change-Id: Ic074a1b1231f90363bf6af7a581c8044bef947c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235041Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#776151}
-
Tao Bai authored
- Add the callback invoked after the observers. - Flush the pending change in pref. This will let WebView consistently see the persisted metrics after restart. Bug: 1076549 Change-Id: I9ab7a228bfd0431ead9545c37a07905c1a41ec8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226067 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776150}
-
Joe DeBlasio authored
This CL bumps the histograms for Safety Tips until after M87. Safety Tips is currently targeting M86, so that is hopefully the last bump we'll need to do. Fixed: 1089806, 1089471, 1089805, 1089477, 1089475, 1089473, 1089474, 1089472, 1089470, 1089469, 1089468, 1089467 Change-Id: I036f674d5a4ecc532b6aca0058ee672fbc3cd02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236042 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#776149}
-
Gang Wu authored
Because strict mode violation issue fixed, we can enable the test now. Bug: 1076643 Change-Id: I2a4283aef68767fedc850fa2a538ccf2eaaa5042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233921Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776148}
-
Jian Li authored
Bug: 1044139 Change-Id: Ic482b9590c14bfac490666d65a198e5f7c537a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231539Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#776147}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4fa4342740a8..1557a1c16778 2020-06-08 jacktfranklin@chromium.org Components dev server 2020-06-08 changhaohan@chromium.org Remove behavior of merging Computed pane in the Elements Tab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1073899 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I736c7cee49d699f5617473f8a33574465c4d3298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776146}
-
Sujie Zhu authored
When nickname management is disabled, nothing changes. When nickname management is enabled, given that expired & invalid nickname error message spaces are both reserved, we config larger margins among the inputs so that the inputs&text&buttons are evenly distributed in the dialog: 1. Margins between inputs are set to 26px in total by setting the cr-input-error-display to block. 2. Margin between saved-to-this-device and nickname input is 26px. Achieve by using the nickname input's error message spaces. 3. Margin between saved-to-this-device and button is the same 26px in total. Override Button's padding-top to 0, and set the label's margin-bottom to 26px We also update the character count's font-size and padding-inline-start (8px) to move the character count closer to the input field. Bug: 1082013 Change-Id: I5fb16eaeb0c9feb3b323ecc26a60c7e06d175d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229724 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#776145}
-
Andrew Grieve authored
Bug: 1091919 Change-Id: I4a072f99dda5ef238d8507f5a5d5dc36c60843bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235972Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#776144}
-
Gang Wu authored
1. Use existing FileProviderHelper instead implement new one. 2. Update ContextMenuTest#testCopyImage, use Clipboard API to get clipboard data, instead get clipboard data by itself. Change-Id: Ide10a4ac1e89f02329e64b32574b1a76d44c34a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231846Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776143}
-
Ionel Popescu authored
This CL fixes an issue where the slider track value part is not following the thumb when border or padding is applied. The issue was that when computing the thumb position in ThemePainterDefault::PaintSliderTrack we were not considering its offset. There was also and issue for RTL where the coordinates were not properly adjusted. Added range-appearance-border-padding.html to validate the change. Bug: 1088049 Change-Id: Ib9b0543adba763eefaa64ea5004e9c2c17c98ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233826Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776142}
-
Rainhard Findling authored
* Use the safetyCheckChromeCleanerChild instead of the privacySettingsRedesign flag. Bug: 1087263 Change-Id: I177ddd0724f3beb75d16534eee42996c2ac6acb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235756Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#776141}
-
Simon Pelchat authored
The litepages server will soon start blocking requests that don't have a GWS ID from one of the explicitly allowed GWS IDs. GWS ID -1 will be a special GWS ID used for prober requests and integration tests and will always be allowed by the server. Bug: 1092538 Change-Id: I0ef8e8c034847a944c5dbd750df78911f0f3da6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236046 Commit-Queue: rajendrant <rajendrant@chromium.org> Auto-Submit: Simon Pelchat <spelchat@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#776140}
-
Aaron Colwell authored
This is the first of 2 changes to rename components/blacklist to components/blocklist. This contains all the class/method/member/variable renaming. There should be no functional differences here. This patch will be followed by another patch that renames the directory/files and updates the necessary build system rules. The vast majority of the changes here are simply replacing an 'a' with an 'o'. - Replaced blacklist references with blocklist in components/blacklist - Replaced whitelist references with allowlist in components/blacklist - Updated all code that depends on components/blacklist to use new names and updated the names of any callers that may have been influenced by the original names. - Filed bugs and left TODOs for code that interacts with backend services that may depend on the old name. - Replaced some empty method bodies with '= default;' and added default member assignments to make ClangTidy happy. These should not cause any behavior changes. Bug: 1092096 Change-Id: I8a1a7d7bb51c619f05476086755509c94e05f995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234793Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#776139}
-
Yulun Wu authored
Bug: 1091050 Change-Id: Ie7f4320f2234f223851dfcaae71a14babbe88efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230776Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776138}
-
Sergei Datsenko authored
Allow target to pass with `-fsanitize=null`. Bug: b/155090459 Change-Id: I597d937b239bde9a4f4fc690aca8fe56867d69ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230410Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#776137}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8c3125c64f32c14d7f4fa12f576bf1d7ec62d195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236015Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776136}
-
Lucas Gadani authored
This allows portals to support XFO sameorigin policies. Bug: 1083329 Change-Id: I922fd762ed643c1381706145aa3a017254456ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216537 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776135}
-
Alison Maher authored
We are currently setting the root background-color in forced colors mode inside the UA stylesheet. Instead, set the forced background-color directly at the viewport level (similar to dark mode). This is based on feedback from https://chromium-review.googlesource.com/c/chromium/src/+/2211124. Bug: 970285 Change-Id: I3b3280ab7816b40833e87f92fe6147d5882bc039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227809 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#776134}
-
Yue Zhang authored
http://crrev.com/c/2227890 spotted that the TabModelSelectorTabObserver can be leaked across sessions during theme change, and tried to fix this by removing the observer when tab is detached. However, there are still crashes with similar stack, and the suspect is that there are still leaked observers. This CL adds a band-aid fix to the problem for M84 experiment. Bug: 1087826 Change-Id: I34c149e0651e30b08a19872c6332d70c4028fd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236098Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#776133}
-
Kurt Horimoto authored
Bug: none Change-Id: I8d09e50b107d41fbfd616a2af5e35d2a8b1a29a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233820 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#776132}
-
Dominic Mazzoni authored
This test is a follow-up to this patch: http://crrev.com/c/2226300 It ensures that if the server request uses a different language than the language passed with the original request, the annotation still succeeds. Also adds a log to make it more clear if we were ever to hit this case in the future. Previously it was a silent failure. AX-relnotes: N/A Bug: 1090234, 1070505 Change-Id: I6c728a859bfa4c9a182ea4dd446b3b54c1836014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233482Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776131}
-
Sujie Zhu authored
Add WithNickname suffix to Autofill.StoredCreditCardCount.Local and Autofill.StoredCreditCardCount.Server.Masked to get what percentage of cards has nickname. Bug: 1082013 Change-Id: I979209fe5681f43fd9e89c00537c7df788e83b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232835Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#776130}
-
Anna Malova authored
Bug: 1085115 Change-Id: I0c720e23190fa7482ff08a03c579416719267fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230474Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#776129}
-
Matt Menke authored
A bunch of tests check cases where alt service info should not be added. All of these tests send an alt service frame that advertises QUIC without actually enabling QUIC, so even if the logic they're trying to test doesn't work, no alt service info would be added, as QUIC is disabled. Fixed: 1092521 Change-Id: I46f7f26780b48bb5796f85349b91077cee8e2b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236018 Commit-Queue: Matt Menke <mmenke@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776128}
-