- 01 Feb, 2019 40 commits
-
-
Dana Fried authored
Currently, Chrome offers to update plugins that are blocked because they are outdated. In Dec 2020, there will be no way to update, as plugins will be end-of-life. When the user tries to load an outdated plugin now, they get a status message that offers to run the outdated version or upgrade the plugin. This patch changes the message seen when a plugin is blocked and cannot be updated - it only offers to run the plugin as-is (no upgrade option). Bug: 918427 Change-Id: If6019fc9492575d7c2e9efbec7c3d665f1db47ac Reviewed-on: https://chromium-review.googlesource.com/c/1448794 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#628421}
-
Nicolas authored
This will let the Internet Explorer BHO use the same prefs as Chrome. Caveat: since cache.dat is only updated at startup, it won't update correctly if BrowserSwitcher is enabled by Cloud policy, or if BrowserSwitcher *becomes* enabled while Chrome is open. Bug: 909878 Change-Id: I1f5fe1d436d752eeb327d0bf9c0c4096ab62fce7 Reviewed-on: https://chromium-review.googlesource.com/c/1432478Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#628420}
-
dpapad authored
Replace i18n-values with $i18n{} mechanism. Also remove unnecessary tabs.css and widgets.css dependencies. Bug: 677338 Change-Id: I99b9b570e00bbc2b0bd0ff1179b086bd6bd8e270 Reviewed-on: https://chromium-review.googlesource.com/c/1450307Reviewed-by:Joshua Bell <jsbell@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#628419}
-
Ahmed Fakhry authored
BUG=906698 TEST=Manually, on nocturne, make sure going into docked mode causes the video to stop playing. Change-Id: I9381c9688a4529db9684e6de5f88e2a935b8dce6 Reviewed-on: https://chromium-review.googlesource.com/c/1407504Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#628418}
-
Philip Rogers authored
This patch removes a CaptureScreenshotTest.CaptureScreenshotArea subtest that was testing screenshots extending beyond the frame. This does not affect the devtools screenshot feature which resizes the frame to be large enough. There could be non-chrome users of the devtools api that depend on this behavior but I think there are not. For example, on a page such as https://pr.gg/fixedtall.html, capturing pixels outside the frame would mean the blue fixed div would be in the middle of the screenshot. Bug: 922706 Change-Id: I8ed1e143bffd08de6e0f2b6ec6d76da93ab1e797 Reviewed-on: https://chromium-review.googlesource.com/c/1435836Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#628417}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ab56670af981..a34d7766c56a git log ab56670af981..a34d7766c56a --date=short --no-merges --format='%ad %ae %s' 2019-02-01 nisse@webrtc.org Move RtpSenderAudioTest to its own file 2019-02-01 mbonadei@webrtc.org [clang-tidy] Apply performance-move-const-arg fixes. 2019-02-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ecc3b419..6893a4aa (628213:628317) 2019-02-01 nisse@webrtc.org Delete sequence number save and restore in ChannelSend. 2019-02-01 mbonadei@webrtc.org Fix RTCStatsReport::ConstIterator move constructor. 2019-02-01 eladalon@webrtc.org Improve CPU utilization when encoding VP8 with a single temporal layer Created with: gclient setdep -r src/third_party/webrtc@a34d7766c56a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia708a6669e2a247e7ea9c2382d28f62268b8ba25 Reviewed-on: https://chromium-review.googlesource.com/c/1449787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628416}
-
David Bertoni authored
We are currently collecting stats for the old and new analysis functions. Keeping the percentage of visible pixels required will allow us to keep comparing these numbers. Bug: 805600 Change-Id: I5d7e9c800c2e6f7bab5f92b081624b796b18b4f3 Reviewed-on: https://chromium-review.googlesource.com/c/1448791Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#628415}
-
François Beaufort authored
This CL makes sure a play/pause button is always displayed in a Picture-in-Picture window if a Media Session action such as play or pause has been set by the website. Clicking this button will also trigger the action handler if set. Change-Id: Ic06f2dfc18318593b0d7b85deaef7e8ff24626d4 Bug: 926163 Reviewed-on: https://chromium-review.googlesource.com/c/1437074 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#628414}
-
Raul Tambre authored
IntToString has been deprecated in favour of NumberToString. Using NumberToString also fixes a few 64-bit truncation warnings. Bug: 879657 Change-Id: Icd305fbc7ee005df63271a74412eb6dffad19712 Reviewed-on: https://chromium-review.googlesource.com/c/1448463 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628413}
-
Matt Menke authored
This parameter was recently added to the SSL socket pools, which are going away. This CL adds it to the TransportClientSocketPool, which is replacing them. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: I804bf4558e4e9f57dbb014a7f0e5ff102e1f677d Reviewed-on: https://chromium-review.googlesource.com/c/1446248Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#628412}
-
David Tseng authored
Bug: b:123382801 Change-Id: Ic4527aff9042c32606de942b09c5e5bb1d663f93 Reviewed-on: https://chromium-review.googlesource.com/c/1443935Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#628411}
-
Vadym Doroshenko authored
Manual fallbacks are needed for forms that have <input type=password> but for some reasons not considered as valid password forms (for example because there is autocomplete attributes for credit card fields). The manual fallback flow is the following: 1.A form with <input type=password> is found 2.Filling information is sent to the renderer, if this form is not considered as valid password form, automatic filling shouldn't happen, only fallbacks on password field are available. 3.When the user is typing in any password element, the manual manual fallback for saving is shown. 4.If the user submits form that is not considered as valid password form, not automatic prompt is shown. This CL contains: 1.FormParser is updated to ensure that all <input type=password> are taken for manual fallbacks (before that credit card fields or readonly fields might be missing). 2.Implemented not to fill, if parsing result is only for fallback 3.PasswordManager::ProvisionallySaveForm is updated to ensure that no save fallback is shown, if parsing was unsuccessful (because nothing to save) 4.Renaming PasswordForm::only_for_fallback_saving to only_for_fallback (because it's also used for filling now). Bug: 831123, 925191 Change-Id: If6d4f8d2f139b1530eaffc7c6eb74efdc9842d49 Reviewed-on: https://chromium-review.googlesource.com/c/1446153Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#628410}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cf9383ed325c..91d469aae063 git log cf9383ed325c..91d469aae063 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 syoussefi@chromium.org Initial support for compiler AST validation 2019-02-01 jmadill@chromium.org Roll glslang. 2019-02-01 ckulakowski@opera.com Fix for linking of non-component angle_unittests 2019-02-01 jmadill@chromium.org Inline ValidateBindTexture. Created with: gclient setdep -r src/third_party/angle@91d469aae063 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:926235,chromium:927650 TBR=cwallez@chromium.org Change-Id: I07f7ddfada83e3ab1a0a3e8478ef07d7e8b26089 Reviewed-on: https://chromium-review.googlesource.com/c/1450157Reviewed-by:
-
Joshua Pawlicki authored
Bug: 833687 Change-Id: I7581877bfda2a5f8ffeb1134814ec0b784c9def0 Reviewed-on: https://chromium-review.googlesource.com/c/1450305 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#628408}
-
Joey Arhar authored
Bug: 607240 Change-Id: I2595c44cdb80a9abc9098bd66fb38145b697a6d0 Reviewed-on: https://chromium-review.googlesource.com/c/1447231 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#628407}
-
Stephen McGruer authored
Previously the content-side support for reduced motion for a frame was static and would not react to changes in the system settings until you created a new frame. This CL listens for notifications and recomputes the webkit preferences when that happens (which then causes the new prefers-reduced-motion value to be calculated). This CL also introduces a caching mechanism for the system setting, to avoid potentially expensive recomputation. Test: Tested manually on MacOS and Windows devices. Bug: 722548 Change-Id: I6be0822cc40a697a4373fbf53888d2219e5890f2 Reviewed-on: https://chromium-review.googlesource.com/c/1418498 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
-
Brian Osman authored
When skcms was spun out from Skia, we ended up with two structs for transfer function. They're both POD, and memory-layout is identical, but field naming is different. We've migrated most APIs to use the skcms types - this finishes that work in Chrome. Change-Id: I148c60518776cac950bae5edab34be58d25b3555 Reviewed-on: https://chromium-review.googlesource.com/c/1434175Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#628405}
-
Kevin Ellis authored
Change-Id: If273cdaee2a84cbe961962c1b5ab47e595dbec4b Reviewed-on: https://chromium-review.googlesource.com/c/1450038Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#628404}
-
Kenneth Russell authored
conformance2/vertex_arrays/vertex-array-object.html is currently flaky on all GPUs with ANGLE's OpenGL backend. Bug: 920265 Change-Id: Iedded0bf7b36a0046edc19ccfc6dbd216f47a82a Tbr: ynovikov@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1450258Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#628403}
-
Vlad Tsyrklevich authored
Now that https://crrev.com/627865 has landed, increase the amount of memory GWP-ASan uses to get back to consuming approximately ~40k per process. Bug: 896019 Change-Id: Iac888c38f32078e21cf4295bdd756b67f48d68c0 Reviewed-on: https://chromium-review.googlesource.com/c/1448793 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#628402}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/453b7c85c8fd..37861ac10602 git log 453b7c85c8fd..37861ac10602 --date=short --no-merges --format='%ad %ae %s' 2019-02-01 afdx@google.com Merge blocks in reducer (#2353) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@37861ac10602 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I608d7d135d7dfc740044624602ed81e4b1701649 Reviewed-on: https://chromium-review.googlesource.com/c/1449782Reviewed-by:
-
Ovidio Henriquez authored
This change updates ChosenObjectView to properly distinguish user and policy objects. The policy objects will state that it is controlled by the administrator and the delete icon will be disabled. UI Screenshot: https://drive.google.com/open?id=1U_6xFpGALEZDPXD7Ic5yHjRsAKpghOHy Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w Bug: 854329 Change-Id: Ic9c1166221e223983eb674521a037651fabab82f Reviewed-on: https://chromium-review.googlesource.com/c/1383400 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#628400}
-
Weidong Guo authored
When button is focused, accessible name will be annouced without explicitly notifying accessibility event. So remove usages of NotifyAccessibilityEvent(). Bug: 916421 Change-Id: I4188030b3790b8c61b78e2c198bedf31b98e2c8e Reviewed-on: https://chromium-review.googlesource.com/c/1449003Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#628399}
-
dpapad authored
chrome://quota-internals seems to attempt to localize its contents even though there don't seem to exist any translations for its content. Bug: 677338 Change-Id: I5236f0be9cbe8c1473b2cece43c450ff81065ee7 Reviewed-on: https://chromium-review.googlesource.com/c/1449164Reviewed-by:
-
Dale Curtis authored
FindIt says the context loss fixes for SurfaceLayer made this test flaky. This is a speculative fix since I was unable to repro on Linux and don't have my mac today. BUG=none R=liberato Change-Id: Id11aa6b4eb7159b45236deab686f929114b6f1a6 Reviewed-on: https://chromium-review.googlesource.com/c/1448407 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#628397}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/af7426e2..b2d43541 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f687e8776ce31812f2f78edf0403a74e422f5ba Reviewed-on: https://chromium-review.googlesource.com/c/1450041Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#628396}
-
Carlos IL authored
This reverts commit 4555b491. Reason for revert: SBER will no longer be included in Unity. Original change's description: > Removed extended reporting checkbox if unified consent is enabled. > > This CL removes the checkbox for certificate reporting from SSL > interstitials, and for SBER from safe browsing interstitials if unified > consent is enabled. > > Bug: 861747 > Change-Id: I751c31cd70e7ba2a1e6358586652b5ae0b0ae18e > Reviewed-on: https://chromium-review.googlesource.com/1189058 > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Thomas Tangl <tangltom@chromium.org> > Reviewed-by: Jialiu Lin <jialiul@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Commit-Queue: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587893} TBR=meacer@chromium.org,changwan@chromium.org,jialiul@chromium.org,carlosil@chromium.org,tangltom@chromium.org Bug: 861747 Change-Id: Ibf0f74e5166545872d2550ef7169ff6c14e56f8b Reviewed-on: https://chromium-review.googlesource.com/c/1448815 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#628395}
-
Nate Fischer authored
WebView only supports in-process NetworkService mode, which requires enabling another Feature. This fixes our CTS FYI bot's configuration. R=bpastene@chromium.org Test: None Change-Id: I4e70390de319e1aecca23d98cc2a6827e472764f Reviewed-on: https://chromium-review.googlesource.com/c/1450045Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#628394}
-
Yi Gu authored
This test is flaky mostly on debug build and occasionally on release build. Bug: 927462 Change-Id: I4174882127170b4abcf141cb8eb49533503d2d38 Reviewed-on: https://chromium-review.googlesource.com/c/1448676 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#628393}
-
Orin Jaworski authored
This is a code-health CL that effectively does nothing but restructure an AutocompleteMatch method for cleaner use at the call-site. Bug: 893183 Change-Id: Ia8c23ad57ee3951ed74fd9a8f56548be60e1f588 Reviewed-on: https://chromium-review.googlesource.com/c/1449312Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#628392}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/387002d1535d..da18f31f960f git log 387002d1535d..da18f31f960f --date=short --no-merges --format='%ad %ae %s' 2019-02-01 achuith@chromium.org chromite: Update moblab docs. 2019-02-01 nednguyen@google.com portage_util: remove usages of cros_build_lib.Die Created with: gclient setdep -r src/third_party/chromite@da18f31f960f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7fd2c24834b5a1e08ad1a3110b84833f9b42d94e Reviewed-on: https://chromium-review.googlesource.com/c/1449779Reviewed-by:
-
Mohsen Izadi authored
For viz service to run as a standalone process in multi-process mash, it should be configured to provide interface binders for drm mojo interfaces as it is where drm resides. Viz host should also be updated to bind those interfaces on the viz service. BUG=912218 Change-Id: I915df5cc01f62e10f432f108f74a9640fdfe1f60 Reviewed-on: https://chromium-review.googlesource.com/c/1425977 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#628390}
-
Eric Lawrence authored
The Trickuri URL display testing tool was designed to augment the URL Display Guidelines documentation to enable testing against the guidelines. Add a link to the tool to the guidelines doc. Change-Id: Ia1e0742ef24a729cc3ef14f2bf6a75bfe4df6779 Reviewed-on: https://chromium-review.googlesource.com/c/1448731 Auto-Submit: Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#628389}
-
Mike Klein authored
** Sheriffs, this is a bug fix that affects most curve drawing. ** ** I've got thousands of diffs here, and probably missed a few. ** ** If we could find a way to roll forward through any breakages ** ** rather than revert this CL, I'd be very appreciative. It's ** ** going on a month now trying to get this in. ** DAA and its ilk have fundamental problems dealing with overlapping coverage. While we think about how to solve them (and if they can be solved at all), turn it off. It took me a while to find one, but fast/borders/borderRadiusDashed01.html is the smoking gun. Bug: chromium:913223, skia:6886 Change-Id: I42b6b1cec464a40017ee4e8e4f9c663bb13a11e6 Reviewed-on: https://chromium-review.googlesource.com/c/1412462 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#628388}
-
James Cook authored
Events with a location like 10.2,10.2 were truncated to 10,10 during deserialization. Bug: 924279 Test: added to events_unittests Change-Id: Ic9a408507122958ffa4f598288e5e922369532f5 Reviewed-on: https://chromium-review.googlesource.com/c/1444251Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Eric Karl authored
During teardown of GPU channels, several GLContextVirtuals may be made current and released in a row. This change makes two tweaks to avoid excessive calls to Release/MakeCurrent which were leading to hangs on ARM: - When we call ReleaseCurrent on GLContextVirtual, only release the real GL context if: a) We are releasing a real surface (need to release to clean up surface). b) We are the last virtual owner of the GL context (we need to release before final destruction of real context). - When we call SetCurrent(nullptr) on GLContext, only clear the surface / GL API if we are the real context. During normal operation GLContextVirtual always calls through the real context in ReleaseCurrent. During destruction, both will be called. Change-Id: I1db94a38943ba8df41d656b7302b026f8a885ded Reviewed-on: https://chromium-review.googlesource.com/c/1437704Reviewed-by:Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#628386}
-
ssid authored
The mojo message handlers are always grouped together as tasks posted by "Notify" function. To identify the root cause, add a trace event using the heap profiler tag. This only adds event to simple watcher, which seems most common. BUG=927206 Change-Id: Id17c1d6ad396c994242a5a2ab92ed1ff0df42d48 Reviewed-on: https://chromium-review.googlesource.com/c/1437727 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#628385}
-
Ian Clelland authored
This is a reland of ee0a6c8d Original change's description: > Create a virtual test suite for FeaturePolicyForSandbox > > Adds test expectations (marked with bugs) for the tests which are > currently identified as failing. > > Bug: 812381 > Change-Id: I768074cbb4dfb8447b8b809915732e2f7ce8e06c > Reviewed-on: https://chromium-review.googlesource.com/c/1440266 > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Commit-Queue: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628053} New features: - Added expectations for the flakes identified by findit - Added additional expectations for flakes which match the other test suites in /http/tests/navigation and /http/tests/security Bug: 812381 Change-Id: I5848b116fbc894f87a4d5ffbcbb86ebc3cf360fb Reviewed-on: https://chromium-review.googlesource.com/c/1450036Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#628384}
-
Klaus Weidner authored
This folder is intended to contain a minimal set of small files needed to run automated tests. Currently this is just the cube-sea texture. For larger files, the intent is to use a local media folder for ad-hoc testing, or in the future use cloud storage via DEPS indirection. To save space, the image file is recompressed from the original PNG to WEBP using https://squoosh.app/ . (WebP format, effort 6, quality 75.) Bug: 923149 Change-Id: I18a89ab103a5670b49489bfe102e4a20a59a4138 Reviewed-on: https://chromium-review.googlesource.com/c/1448336Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#628383}
-
Stephen Martinis authored
Removes //infra/config/branch/cq.cfg. This has been replaced with //infra/config/global/commit-queue.cfg. Also updates presubmit checks to point to the new file. Bug: 926596 Change-Id: Iaff905119bb89bfad718a0e1376d9566777c4dc6 Reviewed-on: https://chromium-review.googlesource.com/c/1444702 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#628382}
-
