GitLab

ConfigureServiceForProfile was only used for WiFi as Shill didn't support other types before https://gerrit.chromium.org/gerrit/63651.

This change is helpful for Ethernet EAP policy as well, because Shill will automatically select the EthernetEAP service if the network type is EthernetEAP.

BUG=265592, 217524
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/22689003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216988 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=TRUE
TBR=akuegel@chromium.org
BUG=269006

Review URL: https://chromiumcodereview.appspot.com/22838003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216987 0039d316-1c4b-4281-b951-d872f2087c98

Currently the omnibox assumes that all matches that score at least
1200 must be inlineable / able to be shown in the omnibox.  This
is a sizable constraint on every omnibox provider.

This change creates a field trial for a new behavior: have the omnibox
providers score matches however they want, then have the omnibox
itself reorder matches as necessary to put an inlineable result first.

This change does three main things:
* this change adds a field to AutocompleteMatch to indicate whether
a match is allowed to be a legal default match.  (there's a distinction
between inline_autocomplete_offset and allowed_to_be_default_match
-- see earlier discussion on this changelist; that's why this change
adds that new field.)
  - this change also has to set the field appropriately in every provider.
* this change makes AutocompleteResult do the reordering as necessary
  (when the field trial is enabled)
* when the field trial is enabled, this change bypasses the code in
Shortcuts, HistoryQuick, and SearchProvider that enforce the constraint
relevance >= 1200 implies inlineable, thereby allowing those
providers to deliver more accurate relevance scores.
* this change revises and adds tests as necessary.

In addition to the pile of tests, I have tested it interactively to
verify that it improves the ordering of matches in the
settings on my personal profile where I hoped it would.

BUG=252531
R=hfung@chromium.org, msw@chromium.org, pkasting@chromium.org

Review URL: https://codereview.chromium.org/18878007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=271431
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/22819002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216985 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216984 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=155922:155924&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/22801002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216983 0039d316-1c4b-4281-b951-d872f2087c98

Functions in file_manager_util.cc were poorly named and/or documented.
Also simplify OpenFileWithFileBrowserHandler (was ExecuteExtensionHandler).

BUG==270469
TEST=none

Review URL: https://chromiumcodereview.appspot.com/22789002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216982 0039d316-1c4b-4281-b951-d872f2087c98

This allows us to remove all PlatformFileHandle related code
in Blink core.

(Blink side patch: https://codereview.chromium.org/22645008/)

BUG=267341

Review URL: https://chromiumcodereview.appspot.com/22738002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216981 0039d316-1c4b-4281-b951-d872f2087c98

This experimental feature is hidden behind the experimental-location-features flag and was never fully developed and has very little usage. Please refer to the bug for more details.

BUG=134075

Review URL: https://chromiumcodereview.appspot.com/22674006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216980 0039d316-1c4b-4281-b951-d872f2087c98

On some devices, "reboot" is not synchronous, so the Reboot()
call and its internal waits were finishing before the device had even
started rebooting.

BUG=265425

Review URL: https://chromiumcodereview.appspot.com/22587004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216979 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/22834002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216978 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216976 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216975 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/22401006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270046
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/22685003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216973 0039d316-1c4b-4281-b951-d872f2087c98

Refactoring change.
This field has similar name to a field that I'm going to add.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216972 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 216856 (broke Blink perf canaries).

TBR=qyearsley@chormium.org

Review URL: https://codereview.chromium.org/22432007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216971 0039d316-1c4b-4281-b951-d872f2087c98

This enables GpuVideoDecoder reinitialization on config change for CrOS ARM
as well, following its enablement on x86.

BUG=151045,233608
TEST=HTML5, Flash, YT, MSE playback
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22691003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216970 0039d316-1c4b-4281-b951-d872f2087c98

This adds a resolution switch sequence, initiated by the driver sending us
a V4L2_EVENT_RESOLUTION_CHANGED event. After receiving it, we finish
processing existing output buffers and replace them with a new set for
the new format, provided by MFC. Input buffers are kept intact in order
to be able to continue decoding them after the switch.

Also, separately, perform a dummy STREAMOFF-STREAMON cycle on Flush().
This fixes freezes in MSE player between stream chunks, as the player
triggers a Flush() at end of chunk, but no Reset(). MFC requires reset
to continue after flush.

BUG=177422, 238488
TEST=regular playback, unittests, resolution switch streams, MSE tests
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22590009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216969 0039d316-1c4b-4281-b951-d872f2087c98

The leak was introduced at http://crrev.com/216673 and supressed at http://crrev.com/216711

BUG=270742,240165
TBR=glider
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/22782002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216968 0039d316-1c4b-4281-b951-d872f2087c98

The chrome-si/initializers stat has improved by 2.86%

TBR=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/22814002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216967 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216963 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=155914:155921&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/22679004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216962 0039d316-1c4b-4281-b951-d872f2087c98

This has been done by:
 - patching third_party/protobuf with the upstream diff for r423:426 and r428 (427 has already been cherrypicked)
 - manually applying the rejected hunks in the following files:
      src/google/protobuf/wire_format.cc
      src/google/protobuf/wire_format_lite.h
      src/google/protobuf/unknown_field_set.cc
      src/google/protobuf/descriptor.pb.h
      src/google/protobuf/extension_set.cc
      src/google/protobuf/wire_format_lite.cc
      src/google/protobuf/descriptor.pb.cc
      src/google/protobuf/wire_format.h
      src/google/protobuf/compiler/plugin.pb.h
      src/google/protobuf/compiler/cpp/cpp_helpers.h
      src/google/protobuf/compiler/cpp/cpp_file.cc
      vsprojects/lite-test.vcproj.rej
      vsprojects/libprotobuf-lite.vcproj.rej
      vsprojects/libprotobuf.vcproj.rej
      vsprojects/tests.vcproj.rej
      vsprojects/extract_includes.bat.rej
 - adding the new cc/h files to protobuf.gyp and disabling MSVC warning C4291
 - rebuilding descriptor.pb.{cc,h} using the upstream protoc r425
 - fixing compilation (replaced WireFormat with WireFormatLite where applicable)
 - cherry-picking the upstream r505
 - applying patch from https://code.google.com/p/protobuf/issues/detail?id=539

To reduce the changelist size, some of the test files were excluded.
They will be committed separately: https://codereview.chromium.org/21231003

BUG=259808
TBR=agl@chromium.org, pliard@google.com

Review URL: https://codereview.chromium.org/21208003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216961 0039d316-1c4b-4281-b951-d872f2087c98

-o2
Processed 54 files (out of 520 files) in 01:03:52s
Result : 27015 => 24420 bytes (2595 bytes : 9 %)

TBR=jamescook@chromium.org
BUG=271299

Review URL: https://codereview.chromium.org/22786002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216958 0039d316-1c4b-4281-b951-d872f2087c98

- Introduce file_tasks::TaskInfo
- Change CrackTaskId() to use TaskInfo and rename it to ParseTaskId().
- Change ExecuteFileTask() to use TaskInfo
- Move MoveDriveAppTaskId() to file_tasks.h/cc
- Add unit tests for MakeTaskId(), MakeDriveAppTaskId(), and ParseTaskId().

BUG=270435
TEST=none
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22292014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216956 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org,thestig@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22386003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216955 0039d316-1c4b-4281-b951-d872f2087c98

On Mac, the app list is not warmed up when Chrome starts. If it is not
shown, its model will not be updated with the changes due to app
install. If shown, the app is not shown at all if it is still
installing, and it will not be highlighted if shown after install
completes.

This CL Exposes a CreateForProfile function to the AppListService, which
allows an app list to be created but not shown.

BUG=267814
TEST=From a profile that has not used the app launcher (it can have
apps), install an app from the web store. Launch the app launcher.
During install, it should show install progress. After install, it
should have the item highlighted (whether first shown before or after
install completes).
TBR=xiyuan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22730003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=268987
TEST=covered by test.

Review URL: https://chromiumcodereview.appspot.com/22394003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216953 0039d316-1c4b-4281-b951-d872f2087c98

This histogram has been replaced by FileBrowser.ViewingFileType.
In fact, this histogram is marked <obsolete> in
tools/metrics/histograms/histograms.xml

BUG=189103
TEST=none
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/22629012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216952 0039d316-1c4b-4281-b951-d872f2087c98

BUG=270306
TEST=With app shortcuts enabled on Mac, right-click a v2 platform app in
the OSX App Launcher. "Create Shortcuts" should not present.

Review URL: https://chromiumcodereview.appspot.com/22398007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216951 0039d316-1c4b-4281-b951-d872f2087c98

The new menu button assets do not have a border. This moves the menu
popup closer to the meat of the icon.

BUG=269210
TEST=Visual - menu location should match the screenshot at
http://crbug.com/269210#c4

R=benwells@chromium.org

Review URL: https://codereview.chromium.org/22642007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216950 0039d316-1c4b-4281-b951-d872f2087c98

Follow up to https://codereview.chromium.org/20234002/ - the old
representation is no longer set so remove use of it.

TBR=boliu@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/22778004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216949 0039d316-1c4b-4281-b951-d872f2087c98

Add unittests for net::BalsaFrame, net::BalsaBuffer and net::BalsaHeaders.
This CL does not change any behavior.

R=rch@chromium.org
BUG=267354

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216572

Review URL: https://chromiumcodereview.appspot.com/22573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216948 0039d316-1c4b-4281-b951-d872f2087c98

This patch relands crrev.com/216860 with the fix for the first run tests.

To test this new feature one can do the following:

On chrome, open the "Import Bookmarks and Settings..." dialog, you can do this
by three ways, one is to navigate to chrome://settings/importData, another is
to open chrome://settings (either through wrench menu or navigating to it through
omnibox) and then under the Users category click on "Import Bookmarks..." button
to open the dialog. The third way to open this dialog
is Wrench->Bookmarks->Import Bookmarks and Settings...".

Once the dialog is opened, open the "From" combobox and select
"Bookmarks HTML File" item. That should show only the "Favorites/Bookmarks"
checkbox checked and enabled and present a "Choose file" button in the place
where "Import" button was. Click on that new button and select your bookmarks
html file, once you do that the import process should start, and if you file is
ok, chrome should import and present you with a success message.

BUG=80685
TBR=dbeam@chromium.org, isherman@chromium.org, cpu@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22560003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216947 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216946 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=155911:155913&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/22498004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216945 0039d316-1c4b-4281-b951-d872f2087c98

Run through sanitize-png-files.sh -o2

Diffstat:
100/../app_list_tools_hover.png   | Bin 635 -> 155 bytes
100/../app_list_tools_normal.png  | Bin 156 -> 160 bytes
100/../app_list_tools_pressed.png | Bin 516 -> 150 bytes
200/../app_list_tools_hover.png   | Bin 1144 -> 243 bytes
200/../app_list_tools_normal.png  | Bin 277 -> 247 bytes
200/../app_list_tools_pressed.png | Bin 966 -> 219 bytes

BUG=269210
TEST=Visual
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/22254008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216944 0039d316-1c4b-4281-b951-d872f2087c98

The test times out most of the times on Blink/linux_aura, sometimes on other bots.

BUG=270948
TBR=shishir@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22481006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216943 0039d316-1c4b-4281-b951-d872f2087c98

BUG=265753
TEST=content_unittests
R=jam@chromium.org,jamesr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22410007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216942 0039d316-1c4b-4281-b951-d872f2087c98