GitLab

After I landed https://codereview.chromium.org/985663002/ I noticed that there is some problems in ServiceWorker DevTools protocol.

1. ServiceWorkerHandler::ContextObserver can't get the state of ServiceWorkerVersion correctly.
 ServiceWorkerHandler::ContextObserver is using GetLiveVersion in OnVersionUpdated().
 But when OnVersionUpdated() is called the live versions may already be deleted.
 This is because OnVersionUpdated() is called via ObserverListThreadSafe<ServiceWorkerContextObserver> in ServiceWorkerContextCore.
 So I change ServiceWorkerContextObserver::OnRunningStateChanged() and ServiceWorkerContextObserver::OnVersionStateChanged() to pass the new state and introduce OnNewLiveRegistration() and OnNewLiveVersion().

2. We have to distinguish the ServiceWorkerRegistrations which are deleted from the storage.
 We shuold show the registrations which are already deleted from the storage but are still exist in the memory.
 This could happen when ServiceWorkerRegistration.unregister() has been called but there are still some controlled pages.
 So I will add isDeleted flag to ServiceWorkerRegistration DevTool's protocol. (https://codereview.chromium.org/996363002/)
 And we can stop using workerRegistrationDeleted event.

3. Stop using {active/waiting/installing}_version properties of ServiceWorkerRegistration in DevTools protocols.
 We send the all ServiceWorkerVersion infromation with workerVersionUpdated event and it has "state" properties.
 So we don't need {active/waiting/installing}_version properties of ServiceWorkerRegistration.

This change depends on https://codereview.chromium.org/996363002/.

BUG=466871

Review URL: https://codereview.chromium.org/998173002

Cr-Commit-Position: refs/heads/master@{#321277}

When an app is being uninstalled and the "confirm removal" dialog is
closed, the focus controller selects the most recently used window to
return focus to. However, the MruWindowTracker doesn't take into
consideration the app list container, and hence the app list window is
not on the MRU window list. Focus is then returned to something else (if
you have other windows open) which causes the dismissal of the App list.

R=oshima@chromium.org,skuhne@chromium.org
BUG=467877

Review URL: https://codereview.chromium.org/1011283004

Cr-Commit-Position: refs/heads/master@{#321276}

The App Info dialog was getting a nullptr on apps with the 'fileSystem'
permission in Guest Mode (notably, the Get Help app). Added null checks
to work around the problem.

BUG=457346

Review URL: https://codereview.chromium.org/994283003

Cr-Commit-Position: refs/heads/master@{#321275}

BUG=467797

Review URL: https://codereview.chromium.org/1017913003

Cr-Commit-Position: refs/heads/master@{#321274}

The problem was that the height of the header (where the extension name and icon are shown) was not being taken into account by the animation of the options overlay.

BUG=468024

Review URL: https://codereview.chromium.org/1012233002

Cr-Commit-Position: refs/heads/master@{#321273}

The reset command takes upwards of 3 minutes on KK, this runs
the set usb 1 command so that it will set charging to on while it
is resetting.

BUG=

Review URL: https://codereview.chromium.org/1012383006

Cr-Commit-Position: refs/heads/master@{#321272}

Make STLDeleteValues do like STLDeleteElements and increment the
iterator before deleting the value. This protects against modifications
to the container that may invalidate the current iterator.

STLDeleteContainerPairSecondPointers already provides this ability.

Review URL: https://codereview.chromium.org/1020673002

Cr-Commit-Position: refs/heads/master@{#321271}

No changes aside from package/imports.

BUG=428882

Review URL: https://codereview.chromium.org/1017783004

Cr-Commit-Position: refs/heads/master@{#321270}

This change adds functions to return the content line height and the answer line height.  It also makes the answer line height the large font.

(Separated out from CL 795933009).

BUG=455418

Review URL: https://codereview.chromium.org/1017323003

Cr-Commit-Position: refs/heads/master@{#321269}

BUG=
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1019653002

Cr-Commit-Position: refs/heads/master@{#321268}

This operation requires accessing the filesystem on OS X and linux and could be slow.

BUG=466437

Review URL: https://codereview.chromium.org/1018953005

Cr-Commit-Position: refs/heads/master@{#321267}

Review URL: https://codereview.chromium.org/1022473003

Cr-Commit-Position: refs/heads/master@{#321266}

This avoids a crash in debug builds on Linux.

BUG=454893
TEST=Change IsErrorDueToBadClock() to always return true, launch a debug
build, visit a bad SSL site, and click "Update date and time". Observe
no crash.

Review URL: https://codereview.chromium.org/1002013008

Cr-Commit-Position: refs/heads/master@{#321265}

This picks up various bug fixes, but no new functionality.

TBR=scottmg@chromium.org
BUG=430215
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1016083003

Cr-Commit-Position: refs/heads/master@{#321264}

BUG=429053

Review URL: https://codereview.chromium.org/1000483002

Cr-Commit-Position: refs/heads/master@{#321263}

This CL adds support for third-party VPNs to the network details dialog:
* The title contains both the VPN provider name and the network name.
* Fields not applicable to third-party VPNs are hidden.
* A new field showing the provider name is added.
* The "Configure" button triggers the VPN provider's configuration UI.

BUG=460428
TEST=Manual

Review URL: https://codereview.chromium.org/1006553002

Cr-Commit-Position: refs/heads/master@{#321262}

R=brucedawson@chromium.org
BUG=440500

Review URL: https://codereview.chromium.org/943893003

Cr-Commit-Position: refs/heads/master@{#321261}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/24e06d5..8dc58ed

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1019673002

Cr-Commit-Position: refs/heads/master@{#321260}

Revert of [Android] Make failure to find tombstones nonfatal. (patchset #2 id:20001 of https://codereview.chromium.org/1002293004/)

Reason for revert:
Looks like this is causing flaky failures on the CQ.

Original issue's description:
> [Android] Make failure to find tombstones nonfatal.
>
> BUG=467918
>
> Committed: https://crrev.com/724e0baba29a167e97c119335eff476fa4437269
> Cr-Commit-Position: refs/heads/master@{#321219}

TBR=klundberg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467918

Review URL: https://codereview.chromium.org/1004803008

Cr-Commit-Position: refs/heads/master@{#321259}

The GpuDataManager should be initialized before SetRunRendererInProcess to ensure
the gpu features/blacklists are correctly set for renderer.

BUG=468150

Review URL: https://codereview.chromium.org/1015633003

Cr-Commit-Position: refs/heads/master@{#321258}

R=asvitkine@chromium.org
BUG=463209

Review URL: https://codereview.chromium.org/1011093004

Cr-Commit-Position: refs/heads/master@{#321257}

This is the GYP counterpart of the GN changes in
https://codereview.chromium.org/1008603002/.

R=mtklein@google.com,petarj@mips.com,reed@google.com
BUG=none

Review URL: https://codereview.chromium.org/1010773007

Cr-Commit-Position: refs/heads/master@{#321256}

BUG=468151
TEST=manual
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/1012413002

Cr-Commit-Position: refs/heads/master@{#321255}

This is admitting defeat by site isolation, for now. It's better than crashing.
It will be properly fixed when permission checks are moved into the browser.

BUG=454917
R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1018163002

Cr-Commit-Position: refs/heads/master@{#321254}

Also fixes webapp top controls flashing issue which sprang back after this change.

BUG=430635,463957

Review URL: https://codereview.chromium.org/986963002

Cr-Commit-Position: refs/heads/master@{#321253}

This is a retry patch to add ServiceWorkerDispatcherTest and not to modify
the test from the original patch[1]. Main difference from the original
patch is directly to make ThreadSafeSender mockable instead of introducing
an interlayer (ie. ServiceWorkerMessageSender in [1]).

[1] https://codereview.chromium.org/1011643002/

BUG=452403
TEST=content_unittests --gtest_filter=ServiceWorkerDispatcherTest.*

Review URL: https://codereview.chromium.org/1017013002

Cr-Commit-Position: refs/heads/master@{#321252}

AppKit resizes content views when the window resizes by calling
[NSView setFrameSize:], but does not take into account
[NSWindow contentRectForFrameRect:]. We intercept the former and call the
latter. This is similar to the method used by FullSizeContentView.

This CL also adds NativeWidgetMacFramelessNSWindow which overrides
contentRect <-> frameRect conversion.

The frameless NSWindow is used in app windows by overriding
NativeWidgetMac. This is similar to AppWindowDesktopNativeWidgetAuraWin
which provides a specialized WindowTreeHost. BrowserFrameMac (another
NativeWidgetMac subclass) will do the same to draw custom themed frames.

BUG=459877

Review URL: https://codereview.chromium.org/987323002

Cr-Commit-Position: refs/heads/master@{#321251}

Remove pipelining and blocking the pipeline in different stages. The
underlying issue it was trying to workaround is fixed in Android, and it
involves a lot of complexity and was a source of bugs.

Also remove special handling when viewport is empty, as this is handled
correctly now.

Add back the IsEmpty corner case workaround by passing some frame
metadata with ChildFrame.

BUG=

Review URL: https://codereview.chromium.org/1001643004

Cr-Commit-Position: refs/heads/master@{#321250}

Right now the order is somewhat arbitrary. Instead, look at the types of
a field's ancestors to determine the order.

BUG=465587

Review URL: https://codereview.chromium.org/1012093004

Cr-Commit-Position: refs/heads/master@{#321249}

Currently, ChromeConstrainedWindowViewsClient::GetEmbedderWebContents
returns the embedder WebContents of the GuestView if the initiator
WebContents is in a GuestView. However, with OOP PDF, a mime handler
view can be embedded in a webview that is embedded in an app window; in
this case, the webview WebContents is returned instead of the app window
WebContents. This CL changes GetEmbedderWebContents to return the
outermost embedder WebContents.

BUG=457672

Review URL: https://codereview.chromium.org/1012373002

Cr-Commit-Position: refs/heads/master@{#321248}

This is a minimalistic way to display large icons on local NTP for testing.
The code looks for the "largeIconUrl" data, which only becomes available
beyind flag. If not found then use thumbnail as before; otherwise large icons.
New NTP styles are not implemented in this CL.

BUG=467712

Review URL: https://codereview.chromium.org/1013173003

Cr-Commit-Position: refs/heads/master@{#321247}

This is to track force-alt-protocols command line flag usage to be able to
decide whether it should be kept.

BUG=452514

Review URL: https://codereview.chromium.org/1016873002

Cr-Commit-Position: refs/heads/master@{#321246}

BUG=467216

Review URL: https://codereview.chromium.org/1020683002

Cr-Commit-Position: refs/heads/master@{#321245}

LargeIconUrlParser is the parser for the path portion of the (upcoming)
chrome-search://large-icon end point. This CL adds the code, but only
the unit test is active.

BUG=467712

Review URL: https://codereview.chromium.org/1014853004

Cr-Commit-Position: refs/heads/master@{#321244}

Summary of changes available at:
https://chromium.googlesource.com/angle/angle/+log/d4475816b6..a17e77febd

TBR=geofflang@chromium.org
BUG=344767
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1020523003

Cr-Commit-Position: refs/heads/master@{#321243}

BUG=462748

Review URL: https://codereview.chromium.org/1019663002

Cr-Commit-Position: refs/heads/master@{#321242}

In particular, these two bugs both affect how HistoryQuick provider
suggestions are scored.  One has a tendency to prevent typed visits
to URL from actually being counted as typed visits.  The other has
a tendency to make URLs with multiple visits be suggested more
aggressively than I intended.

BUG=369989

Review URL: https://codereview.chromium.org/1009973005

Cr-Commit-Position: refs/heads/master@{#321241}

BUG=465765

Review URL: https://codereview.chromium.org/1004803007

Cr-Commit-Position: refs/heads/master@{#321240}

BUG=

Review URL: https://codereview.chromium.org/1023493002

Cr-Commit-Position: refs/heads/master@{#321239}

This CL maps the third-party VPN provider extension ID (which is
stored in shill's |Provider.Host| field) to an ONC property.

BUG=460428
TEST=Extended unit tests and API test

Review URL: https://codereview.chromium.org/1019033002

Cr-Commit-Position: refs/heads/master@{#321238}