GitLab

Bug: 1076617
Change-Id: I5d818d4db60fad9e4cdc8e862d82a5bff6372560
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505583
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821978}

Currently Cronet disables 0-RTT features for all POST requests, as they
are not considered idempotent. But for Youtube /videoplayback request,
we are POSTing client abr state information. We want to create an
option in Cronet UrlRequestParams to specify enabling 0-RTT when
creating idempotent requests.

This cl only makes it available for iOS. Enabling 0-RTT for idempotent
request  in Android interface will be implemented in the next cl,
since it requires a different env.

Change-Id: Id2f1aa1fd89c654d6a374cb70566c6c72e18233e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497468Reviewed-by: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Yu Su <yuyansu@google.com>
Cr-Commit-Position: refs/heads/master@{#821977}

Currently the post-layout translation is taken into account for both
focused and unfocused states. This should only be applied when focused
because that's the only time the url bar is translated post-layout.

Bug: 1135898
Change-Id: Ie805e6d638c0c9c86e08c1ca6e5dfc8d08451aac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458888
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821976}

As blink::mojom::ResourceType is deprecated[1], this CL removes
|type| from WebRequestInfoInitParams and WebRequestInfo. Instead,
they use |web_request_type| converted using
ToWebRequestResourceType().

[1] https://crbug.com/960143

Bug: 1059639
Change-Id: I1d06f264c78ec3f3da171ab7899b1e225768f891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426064
Commit-Queue: Julie Kim <jkim@igalia.com>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821975}

When the --enable-search-prefetch-service flag is passed into Chrome,
various conditions should be modified to be easier to test behavior
locally.

Change-Id: Ic78f795c923f9fd6c4a5c178c3517980db0077dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505742Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821974}

Most of the code was already written assuming not in content namespace,
so just remove it.

Change-Id: I7b637c8b372da83ce16be85eac0a238f15b6568b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479882Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821973}

Value changes (either previously or in its new value in text field
changed) events were never used to process output for content
editables nor text areas.  Doing so will at least be more costly if
not cause unwanted output.

Fixed: 1143161, 1143157
AX-Relnotes: n/a

R=dmazzoni@chromium.org, nektar@chromium.org

Change-Id: I3e7414b9df3853d6e86409db7bc398fb8a8f80d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506469Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821972}

navigation/post-frames-goback1.html expects to call a function when
it navigates back from resources/go-back.html.
However, if we enable same-site backward/forward cache, we don't
handle onload event and the function isn't called again.

This CL fixed the test to work as expected.

Bug: 1136383
Change-Id: Ibfac773230fcadd52cbeacfa399c4b55425afb8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503911Reviewed-by: Fergal Daly <fergal@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821971}

This patch extracts the ambient view ids from assistant view ids and
adds DCHECK in test for better debugging.

Bug: b/171901133
Test: Add DCHECK
Change-Id: I4ba1d4d37c543773fa18f10168d4906ca53c56d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506398Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821970}

This reverts commit 1c5d9e6d.

Reason for revert: appears to be causing flake. Reverting to check.

Original change's description:
> Add activation-related trace events
>
> Adds trace events to HTMLPortalElement::activate,
> RFHI::OnPortalActivated and PortalHost::OnPortalActivate.
> In order to correlate the flow events, a trace id
> is plumbed through activation flow.
>
> Bug: 1137916
> Change-Id: I8841dff33bfeaf91adc58722311672db8aa59210
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439016
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
> Reviewed-by: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821749}

TBR=vollick@chromium.org,dcheng@chromium.org,altimin@chromium.org,adithyas@chromium.org,lfg@chromium.org,arthursonzogni@chromium.org

Change-Id: Ibaffedf5a48ad74f55ab54003dd2fa22e9123338
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1137916
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506559Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821969}

base::Bind, base::Callback and base::Closure are deprecated and should
be replaced with the more explicit base::Bind{Once,Repeating},
base::{Once,Repeating}Callback and base::{Once,Repeating}Closure.

This cl converts most uses, but ClientReportPhishingRequestCallback is
left for a follow-up cl. This is due to non-trivial required test
changes. The follow-up should also remove the directory from the legacy
exception list in PRESUBMIT.py.

Bug: 1141564
Change-Id: I89504921c1a590872d1883e0173c238ca587b204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493044Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821968}

Currently, system time is used in WaylandTest.
However, it turns out that, in order to fix other test
(key repeating tests), we need precise control of timing.
This CL switches the timer as its preparation.
The actual fix of key repeating tests will follow.

Note that key repeating tests are not working as intended,
and even with this CL they are not fixed yet.
However, they pass now at least, and this CL should not make
regressions which could cause of blocking CQ/CI.

Bug: 1141473
Test: Ran ozone_unittests locally.
Change-Id: Ifdc2768561e373c9170385a1aee43dae424c7b2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503996Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821967}

This CL implements GetCertificates, GenerateKey, ImportCertificate and
RemoveCertificate extension APIs for Lacros.

Most of the CL is generic plumbing.

One decision in this CL is to pass certificates as byte arrays between
Lacros to Ash. Another approach would have been to use
network.mojom.X509Certificate. This structure just serializes the leaf
certificate, along with any intermediates. This would risk Mojo errors
whenever the net::X509Certificate parser changes. Instead this CL uses
byte strings in the mojom interface. Ash parses and serializes
net::X509Certificates, and Lacros passes the byte strings directly to
the extension. Note the enterprise.platformKeys API does not take or
return intermediate certificates, so the mojom interface only sends the
leaf.

Another decision in this CL is to use a string param |named_curve| in
KeystoreECDSAParams. platform_keys_service_nss.cc only supports one
curve: P-256. However, all the plumbing in both lacros and ash assumes
that there's a string parameter to the GenerateKey() plumbing. It would
be possible to parse and error check in Lacros, send as an enum, and
then convert the enum in ash back into a string. This adds plumbing for
no perceivable benefit since platform_keys_service_nss also performs the
same parsing and error checking.

This CL adds basic integration tests that confirm that the IPC is
working appropriately. Additional work is necessary to flush out the
full integration testing surface.

Change-Id: Ia91f20ca2adc6e04ca14509b8e1a8185aeb98d69
Bug: 1127505
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488755Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Auto-Submit: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821966}

Code was previously removed, but apparently the flag-metadata entry
should be removed too, otherwise it'll keep nagging. :)

Fixed: 1143336
Change-Id: I90d0efca147a9221dfc05f132cd696c4457a43dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505947Reviewed-by: Siyu An <siyua@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#821965}

First step on the way of getting non-affine transforms into canvas2D.
Right now this is a no-op. Trying to keep the CLs small.

CanvasRenderingContext2DState now stores a TransformationMatrix, which
is a generic 4x4 matrix instead of an AffineTransform, which is one of
those 2x3s used to encode 2D rotation/skew and a translation in the 3rd
column. For operations that require an affine transform, there's an
explicit GetAffineTransform method that constructs one.

Also, CanvasRenderingContext2DState->Transform() has become
CanvasRenderingContext2DState->GetTransform() on juanmihd@s sage advice,
which is the bulk of this change.

Bug: 1140535
Change-Id: I5630e48747dcfc7b7b27f25f1dc1a7cdd8860408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490821Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821964}

Change-Id: I518b2781541cfa169cdb1b6c4b5dea729c0a796b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493087
Auto-Submit: Nate Chapin <japhet@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821963}

Tabs.Suggestions.NumSuggestionsChanged(GroupingSuggestion|ClosingSuggestion)
are still needed and are expiring soon. They need to be extended.

Bug: 1140252
Change-Id: I3a7c044ab2e3418c1864d0d92bf438ca8a71d3e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486564Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821962}

This CL changes WebAudioSourceProviderImpl::ProvideInput to verify that
the number of channels in the given AudioBus matches the number
expected. If not, it simply outputs silence. This may be the case due
to a race condition during configuration change, and audio output should
resume afterwards.

Bug: 991984
Change-Id: Icb62d2798a35186f396e62ca543bb014a26a9348
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505878
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821961}

In some cases when attempting to pair a Bluetooth keyboard during OOBE,
the keyboard will appear in the devices list in the system tray with a
"Connecting..." message before the user has clicked on it. But the code
entry dialog will never appear and the keyboard will never connect.

This issue is tied to the fact that the HIDDetectionScreen is observing
Bluetooth device changes in the background and attempting to connect
to devices, yet is unable to display the code entry dialog because it
is hidden. This blocks the pairing flow through the system tray on
other OOBE screens.

Fixed: b:168247012
Change-Id: I4a45bb661e5fb4ac4c591bb21bee9b0e1abbe398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488913Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Michael Hansen <hansenmichael@google.com>
Cr-Commit-Position: refs/heads/master@{#821960}

CFM devices submit feedback via the feedbackPrivate API. This results in
feedback reports getting uploaded without auth tokens because the uploader
can only generate tokens for the primary account. CFM devices must instead
generate a token with the device's account in order to attribute the
feedback report to the robot account associated with the device.

BUG=b:169404690
TEST='Submitted feedback report locally on CFM device with and without
      remora requisition'

Change-Id: Id9ea219edb21c965f76ea4ad35fb9b2f7fec03c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490145
Commit-Queue: Chris Buquicchio <cbuquicchio@google.com>
Reviewed-by: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821959}

The affeced_by_forced_colors property flag is no longer needed. This
CL removes this flag.

Bug: 970285
Change-Id: I57601e958ce332e2436a48a188ef3a6d15680a30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393524
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821958}

This CL whitelists the
|ash::prefs::kAssistantNumSessionsWhereOnboardingShown| pref in autotest
API for test usage in http://crrev.com/c/2481627.

Misc:
Return an error message instead when the value type does not match the
expectation to provide more debugging info.

BUG=1135381
TEST=unittested

Change-Id: If353ccce2c0e61637bc968ef3ec311b6d9009fbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462249
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821957}

https://skia.googlesource.com/skia.git/+log/e25c30034a63..018f5f6dccd6

2020-10-28 herb@google.com add comments about the use of different subrun types
2020-10-28 johnstiles@google.com Mark IRNode leaf classes as final.
2020-10-28 brianosman@google.com SPIRV: Stop mutating (shared) interface blocks for no reason

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jcgregorio@google.com
Change-Id: I0d62f93427150f37edae63d6038c968077e6375f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506374Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821956}

This reverts commit 5a02abb3.

Reason for revert: The issue was resolved.

Original change's description:
> input-implicit-length-limit.html times out on Mac and Linux debug
>
> Observed after https://chromium-review.googlesource.com/c/chromium/src/+/2462900
>
> NOTRY=TRUE
>
> Tbr: tkent
> Change-Id: I1cfe9edba0dd717fa4fbb88c3a43b712a6f00d3e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503518
> Commit-Queue: Dominik Röttsches <drott@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821673}

TBR=tkent@chromium.org,drott@chromium.org

Bug: 1143185
Change-Id: I9182d40934a58c411e85833dba0d002fc586a16c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505401Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821955}

This extends the expiry date of the Feature / Permissions Policy histograms by one year, and aligns them all to expire on the same date.

Change-Id: I598d89eadaddc80e84762bf5af59f3d421a19256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503781Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821954}

Change-Id: I64fec3921c044141e70827a2c2cf4ce4cf1e645f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506463Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Deep Roy <dproy@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821953}

https://pdfium.googlesource.com/pdfium.git/+log/c7ea56a3ebb3..2d61ff8f6c11

2020-10-28 tsepez@chromium.org Tolerate empty local in JS_DateParse().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1142688
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Icb8020fa71ae09e66d3a77ea334e1a5633ffc3c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506413Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#821952}

The method isn't defined, just declared. Remove the declaration.

Change-Id: Ic83c827fe37f39a34802b16f39251e422a48e989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505442
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821951}

This simple cl corrects button name reference. "actionButton" is
not defined.

Bug: 1140742
Change-Id: Ib3d3a298620e66b3d29d450afb0054fdf3297444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506170
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821950}

This is a reland of 39fc8ffd, but now
with the new code path under a disabled feature flag to make it easier
to evolve, test and fix the code.

Original change's description:
> [PM] Add service worker clients to the graph.
>
> This is lifted from Pat's change at
> https://chromium-review.googlesource.com/c/chromium/src/+/2355089
>
> Bug: 993029, 1088353, 1121069
> Change-Id: Ibdc91c07a235be347cbe1704f0fe5e77cff73470
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490221
> Reviewed-by: Patrick Monette <pmonette@chromium.org>
> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820771}

Bug: 993029
Bug: 1143281
Change-Id: Ie889c8e7a9375a1bdf91f899cf77723eec8303b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505929Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821949}

Add FileManagerBrowserTest test Option files_swa, which can be used to
test the files app web contents area contained by the SWA.

We should add an initial test to show that the SWA loads (and renders)
in a follow-up patch.

Bug: 1113981
Change-Id: I57f002afb3ae2b1aae0ae11e366992acb5b65448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501168Reviewed-by: Alex Danilo <adanilo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821948}

The expand_owners.ExpandHistogramsOWNERS function call takes 5 sec and
it's unnecessary for most of the case. This helps reduce the PRESUBMIT
runtime by at least 5 sec.

Bug: 1142714
Change-Id: I5c56cbb9904a861fc7e0954e360cb692fb26edaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505463
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821947}

It will be needed until the NaCl code is deleted, according to the
schedule in https://blog.chromium.org/2020/08/changes-to-chrome-app-support-timeline.html

Bug: 1138018

Change-Id: I78de7eb6498931728766d24804cceb80882ccb82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505681Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Anthony LaForge <laforge@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Anthony LaForge <laforge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821946}

This CL changes the logic of |TabModel#isActiveModel| function to be
consistent with |TabModel#setActive| function. By this CL, tab model
instances returns whether the model is active regarding to mActive
variable that set by setActive method.

Bug: 1126532
Change-Id: I0f8fee345987b35832a9589a278fab0d0846364f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495182
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821945}

Bug: 1141691
Change-Id: I380faba21b1d4fb914e7c49b3c5db02ce37765e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493785
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821944}

AX-Relnotes: n/a
Bug: 1139823
Change-Id: I8e2d0737018692de0a1d4b49c22deaa0fc605cfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502968Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821943}

In CL:2432805, we added a ScopedObserver on
AXPlatformNodeTextRangeProviderWin::TextRangeProvider. However, that
appears to cause a crash and we decided to go back to a simple observer
instead.

The crash was caused by the difference in lifetime of the AXTreeManager
and the AXPlatformNodeTextRangeProviderWin. In some cases, the
AXTreeManager can get deleted before the TextRangeEndpoints does, so
when the destructor of the ScopedObserver calls
ScopedObserver::RemoveAll on an already deleted AXTreeManager, it
crashes.

Bug: N/A
Change-Id: I24291b6609d9f1102f94e177d1751b14e005425b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505774Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#821942}

Completing the implementation of navigator.share() for Windows by
hooking in the relevant components and updating the corresponding tests.

Originally committed as part of https://crrev.com/c/2443757, but
reverted due to test issues. Patchset 1 is a cherry pick of this
original change (reduced to the files relevant to this portion) for
easy comparison.

Bug: 1035527
Change-Id: Ic83fa002601cce5e6c03eee9ec214f7c4c209096
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505603Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#821941}

This CL renames |TabModel#IsCurrentModel| to |TabModel#isActiveModel|
to be consistent with |TabModel#setActive| method.

Note: This CL is only a clean up and does not change code behaviour.

Bug: 1126532
Change-Id: Idc25b6d200d378ec66b567079e5d3582afb0e949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485215Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821940}

The SMS Receiver API check for cross-origin embedding is correct in the
renderer process but not in the browser process. The renderer checks
the origins of the entire ancestor chain of frames, whereas in the
browser it only checked the main frame. This CL changes the check in
the browser to match that of the renderer.

It also moves the check into the service class itself so that the
service contains its own security checks.

Bug: 1139938
Change-Id: I211b5ffad36bd5c385028f1acb4a4e677c7153ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485540Reviewed-by: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821939}