GitLab

https://pdfium.googlesource.com/pdfium.git/+log/cb8a4ddc2277..b67698386664


git log cb8a4ddc2277..b67698386664 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 asweintraub@google.com Fix for a bug where no valid codepoints are recognized in certain PDFs.


Created with:
  gclient setdep -r src/third_party/pdfium@b67698386664

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:909762
TBR=dsinclair@chromium.org

Change-Id: Ib6b3b5038a133df9fcfc404253a3de0e5756b205
Reviewed-on: https://chromium-review.googlesource.com/c/1352868Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611851}

Change-Id: I6fe3dd94a248914cd3f86339f7a152fdda3886d0
Reviewed-on: https://chromium-review.googlesource.com/c/1353033Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611850}

The design of FCP++ have several containers that store the node ids of objects.
In case the size of them will grow unlimitedly, we set a cap for these
containers.

The original implementation uses a counter to count the number of nodes. As a
better approach, we can use the sum of the sizes of the containers for the
same purpose.

The original implementation uses "recorded_node_count_ > kTextNodeNumberLimit"
as a condition. The condition was still checked each time after the condition
has been met. As A better approach, we can have "is_recording_" flag to
indicate whether the container still accepts new entries.

Bug: 869924
Change-Id: Ifc03e5f782e16bab65f6f024d9f73974051ca421
Reviewed-on: https://chromium-review.googlesource.com/c/1349477
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611849}

This ensures that all metrics for a page will be sampled in/out
together and is important for things like Blink.UseCounter that is
a multi-output per page and capturing different outputs on different
pages can be misleading.  All or nothing, per-page.

Design Doc:
https://docs.google.com/document/d/19UKLg7JJSmcS59V7TPnC6w8Smt22xeB12x-lvASVR0s/edit?usp=sharing

Bug: 766909
Change-Id: Ib025b31b85e343d0b8ffec1d190395c1a8bd573d
Reviewed-on: https://chromium-review.googlesource.com/c/1343060
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611848}

This CL renames SnapshotGeneratorDelegate protocol methods to be
unique to SnapshotGenerator.

Bug: 904992
Change-Id: I6357931f782a7d533a74a0b438751b4d5a78aab4
Reviewed-on: https://chromium-review.googlesource.com/c/1345128
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611847}

Refactor the permissions parsing in the chrome.permissions API in order
to separate out requested permissions into different fields, including
required permissions, optional permissions, and permissions that were
not specified in the manifest.

Add more robust testing for the permissions parsing code.

This CL is prework for subsequently adding support for requesting
withheld content script permissions through the permissions API. There
should be no behavior change as a result of this CL.

Bug: 889654
Change-Id: I22c1e057ccb259b4fcff4051923fc9c1128c8213
Reviewed-on: https://chromium-review.googlesource.com/c/1347310
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611846}

TBR=dgozman@chromium.org

Bug: chromium:595206
Change-Id: I95ed4bb30e36b4e2dd7a76713e849fbefe7f932c
Reviewed-on: https://chromium-review.googlesource.com/c/1354232Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611845}

This reverts commit 995f8099.

Reason for revert: Breaks browser tests on continues builders (consistent failures) See crbug.com/908787

Original change's description:
> Make SaveCardBubble browsertest use the sync state
> 
> The browsertests used to rely on the save manager being hardcoded to
> upload to Google if the observer_for_testing was set. This makes it
> impossible to test that the logic for showing the upload prompt works
> properly.
> 
> BUG=906630, 859761
> 
> Change-Id: Id7352a869388aac4ff36e1284750e22ac68c91b3
> Reviewed-on: https://chromium-review.googlesource.com/c/1348335
> Commit-Queue: Florian Uunk <feuunk@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610866}

TBR=vasilii@chromium.org,sebsg@chromium.org,feuunk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 906630, 859761
Change-Id: I145d2b56295af6014b6a94c44beb38b1bf6b9e01
Reviewed-on: https://chromium-review.googlesource.com/c/1352680Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611844}

Needed for testing so that we can reliably trigger in cases where we
normally would have needed to show the HTTPS Previews Notification
Infobar first.

Bug: 908491
Change-Id: I83c3ca2bf41de24e5926128804ab523f77608e18
Reviewed-on: https://chromium-review.googlesource.com/c/1352975
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611843}

Adding a UMA counter for file:///*.svgz file loads in order
to ensure we aren't deprecating support for something widely
used in Chrome.

Bug: 857117
Change-Id: I74e40df6c9aebd33197c2a5cfaf1af83bb84ea51
Reviewed-on: https://chromium-review.googlesource.com/c/1338302Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611842}

This CL migrates the pageInfo coordinator from BVC
to BrowserCoordinator.

Bug: 905524
Change-Id: I56ed15b3bb13ce07db3da97de8e66ff020f032f2
Reviewed-on: https://chromium-review.googlesource.com/c/1338162
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611841}

Disabled SVG shapes [1][2][3] should not be possible to hit since they
are considered "not rendered".

[1] https://svgwg.org/svg2-draft/shapes.html#RectElement
[2] https://svgwg.org/svg2-draft/shapes.html#CircleElement
[3] https://svgwg.org/svg2-draft/shapes.html#EllipseElement

Bug: 896641
Change-Id: I5fe530722a4d60ecd416cd68f06a7555bb6a520f
Reviewed-on: https://chromium-review.googlesource.com/c/1353983Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#611840}

There should be no behaviour change.

Change-Id: I32389eb3b05a6935e320fa3d871d27c3eead2c73
Reviewed-on: https://chromium-review.googlesource.com/c/1353948Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611839}

This is a reland of 66794d00

In this reland we revert changes to RenderThreadImpl and mus to make
LayerTreeFrameSink creation asynchronous again.

Then in RenderWidget we must remember that a warmup is underway, we do
so with a bool and a WeakPtrFactory. If it is aborted, we reset the bool
and invalidate the WeakPtrFactory.

If a request for a frame sink beats the warmup completing, we save
the callback and run that instead of saving the frame sink on
RenderWidget when the warmup completes.

This ignores some weird weird corner cases like where warmup is
aborted then we start another warmup or unfreeze the widget or something
and will just make redundant requests. Since these are so rare they
are not worth adding complexity for.

Original change's description:
> Start gpu channel and compositor mojo pipe collection eagerly
>
> When a RenderWidget is frozen, its compositor is stopped. However when
> the main frame is being navigated, we want to start requesting mojo
> pipes for the gpu and display compositor immediately so that it can
> happen in parallel with the navigation loading.
>
> Previously, we just always did this when creating a RenderWidget, and
> left them active when freezing the RenderWidget. After 678f025f
> however, we don't, and this causes time-to-first-pixels regressions
> on navigation.
>
> So we add a WarmupCompositor() method to RenderWidget, and call this
> from RenderFrameImpl::CreateFrame() when it makes the provisional
> frame, and the WebFrameWidget, since we expect to make use of the
> main frame RenderWidget shortly.
>
> Then, if RenderFrameImpl::FrameDetached() occurs, due to the
> navigation failing, we will AbortWarmupCompositor() to drop the
> mojo pipes instead of holding onto them indefinitely.
>
> This recovers the loading regressions introduced, while also not
> allocating mojo channels for frozen RenderWidgets indefinitely.
>
> In order to do this reasonably, we drop the "callback" from the
> request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that
> it always returns something immediately. This way RenderWidget
> does not need to worry about having a task run to collect the
> new frame sink, and ordering with tasks from the compositor to
> collect it.
>
> R=piman@chromium.org
>
> Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0
> Bug: 905191
> Reviewed-on: https://chromium-review.googlesource.com/c/1341073
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610909}

Bug: 905191
Change-Id: I6cb65e08a832a969156b96bece0f2e12eccd5b60
Reviewed-on: https://chromium-review.googlesource.com/c/1351938
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611838}

This relands commit 01dd4ead.

Breakage was due to in-flight conflict with 39536eb8
Fix is just to update a few more function names that were added in
that change.

Original change's description:
> Make BrowserWithTestWindowTests work with single process Mash
>
> The InputDeviceClient needs to only be created once, so remove it
> from AuraTestSuiteSetup. Otherwise, in BrowserWithTestWindowTest,
> it gets created twice: during test suite setup, and as part of
> OzonePlatform (due to AshTestHelper/ash::Shell).
>
> Many tests still need one though, especially those that create a
> WebContents, so add it to RenderViewHostTestEnabler, which should
> take care of all RenderViewHostTestHarness tests or tests that create
> the enabler manually.
>
> Also update a few other tests to either create their own
> RenderViewHostTestEnabler or InputDeviceClient as appropriate.
>
> Also the InputDeviceManager can be a true singleton now (not thread-
> singleton).

TBR=sky@chromium.org

Change-Id: I4eb8579404ab6c10fb9d6ac9ac8c8c6e7a9baa57
Reviewed-on: https://chromium-review.googlesource.com/c/1352969
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611837}

https://chromium.googlesource.com/angle/angle.git/+log/83b2f0e8a2e0..c4e0a1e511fc


git log 83b2f0e8a2e0..c4e0a1e511fc --date=short --no-merges --format='%ad %ae %s'
2018-11-28 timvp@google.com Revert "Enhance ANGLE for Android Developer Options"


Created with:
  gclient setdep -r src/third_party/angle@c4e0a1e511fc

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Ida5377f5b10a097c6a943dbc0f2f1c9d6495d513
Reviewed-on: https://chromium-review.googlesource.com/c/1352863Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611836}

For now we don't have any bug about this. I found the issue when I was
experimenting some code change, e.g. using uncached display item client
for some display items.

Change-Id: I83b5be0618d45f8be10627f33b04509d238d18c8
Reviewed-on: https://chromium-review.googlesource.com/c/1342457Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611835}

When we want to paint the whole document, we should ignore the viewport
clip, thus should use infinite cull rect for all direct scrolling
contents of the main frame.

Bug: 792577
Change-Id: I46fcfd5a2e30b9d60c2c211a6b063b5789bd9ade
Reviewed-on: https://chromium-review.googlesource.com/c/1347433Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611834}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I4db49f716e36e362b36b059579a4c5a75eb8730c
Reviewed-on: https://chromium-review.googlesource.com/c/1352767Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#611833}

In the GuestView implementation, we inadvertently call methods and
invoke property getters and setters that user code can control.

To avoid method calls to user code, we introduce safe_methods.js
which provides references to the untainted methods.

To avoid invoking user controlled getters and setters, we prevent our
internal objects from inheriting from Object.prototype or we explicitly
access own properties.

Bug: 701034, 803668, 892886
Change-Id: Ie615d6f796793313ed2db6089e259573ad25a90d
Reviewed-on: https://chromium-review.googlesource.com/c/1302698
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611832}

Promoting an element with a clipping ancestor leads to a broken UX for
users and so we should detect and prevent this case. The break occurs
when the user hides the URL bar. Unless the page explicitly resizes the
clipping element (which is difficult for us to detect), the clip will be
smaller than the viewport and so it will block out the bottom region of
the scroller. To the user, this appears as an inability to scroll to the
bottom of the content.

We already prevent promoting an element if it has a scrolling ancestor.
This CL simply generalizes that check to check for clipping and masking
(since scrollers will necessarily have an overflow clip). The exception
here is the LayoutView (i.e. viewport). The viewport always has an
overflow clip but we use the frame's bounds to clip (which accounts for
the URL bar) so in that case we simply check for scrollability.

Bug: 903273
Change-Id: I44b21a619052bcf6e4c08fa6369814f31bfb35cf
Reviewed-on: https://chromium-review.googlesource.com/c/1351563
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611831}

This creates a new session with the system compositor (Scenic) and uses
it to create the vulkan surface resources. This is necessary in order to
support vulkan surfaces from the GPU process, since the browser Scenic
session will not be accessible there.

In order for this to work, we need to be able to run platform code when a
gpu::VulkanSurface is destroyed. To accomplish this, this adds a
destruction callback to gpu::VulkanSurface which cleans up the Scenic
resources associated with the surface.

Bug: 861853
Test: run_content_shell --ozone-platform=scenic --disable-gpu --enable-vulkan

Change-Id: If08c25746ba73569afae63040a7f6551861eeaad
Reviewed-on: https://chromium-review.googlesource.com/c/1343238
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611830}

Underlying data structures don't handle more than 4GB frames to process so
stick with using an unsigned value to avoid 64 bit truncation errors.

BUG=879657
TBR=haraken@chromium.org

Change-Id: I353a187cde9885b3642d1d2aaa4019afce40867e
Reviewed-on: https://chromium-review.googlesource.com/c/1354124Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611829}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/7cb43009d543..bbf63435c37a


git log 7cb43009d543..bbf63435c37a --date=short --no-merges --format='%ad %ae %s'
2018-11-28 johnkslang@users.noreply.github.com Merge pull request #84 from grorg/whlsl
2018-11-26 johnkslang@users.noreply.github.com Merge pull request #83 from dgkoch/SPV_EXT_fragment_invocation_density


Created with:
  gclient setdep -r src/third_party/spirv-headers/src@bbf63435c37a

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ief7d43f768b17d8c5edbe70dbace7ddad1023656
Reviewed-on: https://chromium-review.googlesource.com/c/1354178Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611828}

The token binding feature was removed in crrev.com/584532 (M70) - this
is overdue for being removed.

Bug: 875046
Change-Id: I121028692ba02602c54077401dc15eb176c8e67b
Reviewed-on: https://chromium-review.googlesource.com/c/1351712Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611827}

Bug: 906214
Change-Id: Iad3053bf54046f3c0c7a59001164dac75d449582
Reviewed-on: https://chromium-review.googlesource.com/c/1352357Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611826}

Will be used in a followup CL to simplify making examples for a new
layout manager without having to duplicate a bunch of code.

Change-Id: I3a37dc1656f70015170434c9da80ccbc20c1db88
Reviewed-on: https://chromium-review.googlesource.com/c/1351968Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611825}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: Id60e6bc512e2e9d1b12088b7131fd2a74ebedc9d
Reviewed-on: https://chromium-review.googlesource.com/c/1353881Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#611824}

But not its CI bot (a la every other CI/CQ pair)

R=dpranke, jbudorick

Change-Id: Ieae0c25ca1841fa21e59fe942ef5f04354ed2297
Reviewed-on: https://chromium-review.googlesource.com/c/1352610Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611823}

https://skia.googlesource.com/skia.git/+log/6616efbdebd2..8061053b73e2


git log 6616efbdebd2..8061053b73e2 --date=short --no-merges --format='%ad %ae %s'
2018-11-28 borenet@google.com [infra] Flutter bot should sync to origin/skia-master
2018-11-28 reed@google.com add bench for computing convexity
2018-11-28 fmalita@chromium.org [skottie] Add a custom property manager util class
2018-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 83b2f0e8a2e0..c4e0a1e511fc (1 commits)
2018-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 67c93d206431..3b003a51bc9a (1 commits)
2018-11-28 reed@google.com Force clients to specify font when requesting strikecache


Created with:
  gclient setdep -r src/third_party/skia@8061053b73e2

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: Id88a0d085dbe59de4ec85f2af90a67a5e5a45f23
Reviewed-on: https://chromium-review.googlesource.com/c/1352867Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611822}

Replaced the usage of ProfileOAuth2TokenService and SigninManager by
identity API calls.

This CL adds a new function to the identity_test_utils.h set to set
the auth error of a given account with a refresh token.

Bug: 903859
Change-Id: I29e1ae3bee6ba7f69404f5f2bb7152fa0db9101d
Reviewed-on: https://chromium-review.googlesource.com/c/1352250Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#611821}

Adds categories useful for debugging Android traces.

Change-Id: I75cc0ed406f3e3b40fd21106c1e54f7c5a4b0897
Reviewed-on: https://chromium-review.googlesource.com/c/1352229Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611820}

TaskQueueImpl::SweepCancelledTasks doesn't have to know about
SequenceManager.

R=skyostil@chromium.org,alexclarke@chromium.org

Change-Id: Ifad12c6fe652a323b776066a49aeb6e11f14e515
Reviewed-on: https://chromium-review.googlesource.com/c/1349265Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611819}

Bug: 882586
Change-Id: Id18e17c72aa3646a52a074e536fafa5cf789d85c
Reviewed-on: https://chromium-review.googlesource.com/c/1343246Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611818}

This is a re-land of [1] that has been fixed to not trigger
the Clang crash when coverage instrumentation is enabled.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1346305

---------------- original commit message ----------------------
This is a small cleanup of the TraceEvent class performed
which is part of a larget bug allowing cleaning up and
reducing the generated machine code for TRACE_EVENTXXX()
macro calls (see related bug).

A first CL to perform this refactor was submitted as [1], but
later reverted because it made some tests fail mysteriously
(see http://crbug.com/899813). So the original CL was split into
several independent ones.

A first CL was submitted as [2], which actually fixed some
potential dangling pointer issues that were created from the
Initialize() and MoveFrom() methods.

This second CL removes this methods by making TraceEvent a
proper C++11 movable type, which should prevent (or at least
make it more difficult) introducing invalid states for its
instances. The goal is to see if this introduces new unexpected
test failures (which would indicate that there are still invalid
instance states used in the code base).

The third CL is [3] and re-introduces the TraceArguments helper
class on top of this one.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1318919
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1340308
[3] https://chromium-review.googlesource.com/c/chromium/src/+/1318919
------------------ end of original commit message ------------

BUG=898794
R=primiano@chromium.org,oysteine@chromium.org,alexilin@chromium.org,chiniforooshan@chromium.org

Change-Id: Icb332f91dd9724a2acae9cb1f99a580541e6cc42
Reviewed-on: https://chromium-review.googlesource.com/c/1353929Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611817}

* Remove callers to SetArcAlwaysStartForTesting(true)
* Change the remaining SetArcAlwaysStartForTesting(false) to
  SetArcAlwaysStartWithoutPlayStoreForTesting()

TEST=out/Cleanup/unit_tests --gtest_filter=ChromeLauncherController*: \
     Arc*:NoteTakingHelperTest*
BUG=b:69960761
R=khmel@chromium.org, yusukes@chromium.org

Change-Id: I0bbb0774c005db62c346fcfd40f57d897ec86877
Reviewed-on: https://chromium-review.googlesource.com/c/1352495
Commit-Queue: Victor Hsieh <victorhsieh@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611816}

Previously when starting subprocesses test launcher would clone
some namespace dirs, but not all of them. Update test launcher to use
fdio_ns_export_root() to get namespace of the current process so the
child process can get complete namespace clone, except for /data that
needs to be overridden.

Change-Id: I0e49aa12a4a98e036acdf6549252478e6c771936
Reviewed-on: https://chromium-review.googlesource.com/c/1351888
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611815}

SafeCast a sequence to int in bindings.
Add explicit cast in heap_page.h

BUG=879657

Change-Id: I1c6cf9b1748b84795ed81d903e3e19684bd6d0e3
Reviewed-on: https://chromium-review.googlesource.com/c/1354062Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611814}

This reverts commit 5fd55b4b.

Reason for revert: I am fairly certain this is causing static initializer check failures on the official builder, because it changes BookmarkItem to be a non-POD type, and there are static BookmarkItem constants in the build: https://crbug.com/909828 

Original change's description:
> Navi: Localize Google Apps strings.
> 
> Bug: 894499
> Change-Id: I698b51eac47cdb7af63e4bb2ace338f87c5e7493
> Reviewed-on: https://chromium-review.googlesource.com/c/1351779
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Commit-Queue: Hector Carmona <hcarmona@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611759}

TBR=hcarmona@chromium.org,scottchen@chromium.org

Change-Id: I72aff79d75c2c578c509bf4525d120c0e402cc17
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894499
Reviewed-on: https://chromium-review.googlesource.com/c/1352682Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#611813}

Bug: 462296
Change-Id: I14fade7b9324f869192c4131d2d41d282278d85a
Reviewed-on: https://chromium-review.googlesource.com/c/1352536Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611812}