- 23 Aug, 2018 40 commits
-
-
Karan Bhatia authored
The enum value RulesetMatcher::kLoadErrorRulesetVerification is ambiguous and doesn't clarify the failure reason. Rename it to RulesetMatcher::kLoadErrorChecksumMismatch. BUG=None Change-Id: I451221e9a5a67181ecfc599563ff7a3e7f5d72f2 Reviewed-on: https://chromium-review.googlesource.com/1187371 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585647}
-
Tom Anderson authored
BUG=876586 R=sky Change-Id: I97d58a1fcb333781dfa2bceb4c3363b5c914e5df Reviewed-on: https://chromium-review.googlesource.com/1187197Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#585646}
-
Gang Wu authored
Remove old storage implementation for both Java and C++. Bug: 828935 Change-Id: Ib6144e206b513272510763559337dc6aa16e06b6 Reviewed-on: https://chromium-review.googlesource.com/1185794Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585645}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9c9316dc. With Chromium commits locally applied on WPT: 2160c22c "Modify source path for wpt test of Accept-CH" 3152c6f7 "[UserTiming] Correct measure where start is undefined" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23214 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I6143d70f2e62f0ee1517e5c493ad253d05efd80b Reviewed-on: https://chromium-review.googlesource.com/1187269 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585644}
-
Robert Ogden authored
Wires the Java bridge into the ToolbarModel to trigger the Omnibox Previews badge. Also includes a small pre-s13n hack to enable the Previews UI to be displayed when a HTTPS Lite Page Preview is shown. Bug: 871839 Change-Id: Ia279cd6793c4517d02534a3d16029809c16b34f1 Reviewed-on: https://chromium-review.googlesource.com/1180372 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#585643}
-
Ned Nguyen authored
Bug: 828467 Change-Id: I26fea5488c36d930ef84990da3354ccc64c17aa5 Reviewed-on: https://chromium-review.googlesource.com/1187075Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#585642}
-
Eric Orth authored
ResolveHostParameters::allow_cached_response is a direct replacement for RequestInfo::allow_cached_response. Defaulting to true, it controls whether or not a result can come from the host cache. ResolveHostParameters::source allows specifying a source (system vs async resolver) for a request. This is a replacement for setting the HOST_RESOLVER_SYSTEM_ONLY flag or directly using the async resolver classes. Just adding to C++ net/ API for now. Mojo version in next CL. Bug: 846423 Change-Id: Ie945745f595302ae745ffdab355ae1b13a993c4a Reviewed-on: https://chromium-review.googlesource.com/1185216 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#585641}
-
Clark DuVall authored
This adds a new method to NetworkContext to write the cached data. Verified this worked by adding logging in URLLoaderClientImpl::OnReceiveCachedMetadata to make sure we were getting metadata. Previously, this would always have 0 size with network service enabled. Bug: 876836 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I359e8cf594ff8e4435872c7dae018b1ff9d3c044 Reviewed-on: https://chromium-review.googlesource.com/1185907 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#585640}
-
Martin Kreichgauer authored
We previously disabled the MakeCredential operation for Touch ID if AuthenticatorAttachment was set to kAny in order to avoid having the fingerprint dialog compete with external authenticators. Since MakeCredential now always triggers the transport selection UI, we can now undo this limitation if the UI is active. Bug: 873710 Change-Id: I68ad9f0e7d5c3bdeda84652f893dc5df2743254f Reviewed-on: https://chromium-review.googlesource.com/1180541 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
-
sczs authored
Bug: 876874 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iad9f153fff3c1e1d8dae8c5bcd2f1326b6360475 Reviewed-on: https://chromium-review.googlesource.com/1187329 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585638}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d06cc78ec8cc..b16da6a2a9e5 git log d06cc78ec8cc..b16da6a2a9e5 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 jbudorick@chromium.org bot_update: set the push URL to the actual remote, not the cache. Created with: gclient setdep -r src/third_party/depot_tools@b16da6a2a9e5 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:876734 TBR=agable@chromium.org Change-Id: I7d5b4dfb8628ec0797ca7b94af4bf0da3c4f3659 Reviewed-on: https://chromium-review.googlesource.com/1187421Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585637}
-
rbpotter authored
Some PrintSettings enum values - PAGE_RANGE, SELECTION_ONLY, and HEADERS_AND_FOOTERS - were incorrectly being recorded as always off in recent versions of Chrome. This is because these values are set to default/dummy values in the print ticket, since the preview generation process is responsible for applying them. Save the most recent preview request ticket, and use this to record metrics for preview generation parameters when the print request is received. Also, stop recording EXTERNAL_PDF_PREVIEW. This event is now also captured by the OPEN_IN_MAC_PREVIEW bucket for the UserAction histogram, and fits better with that histogram than with PrintSettings. Bug: None Change-Id: Ie83ce1017aef101dba899024ebdb5cb242f9e622 Reviewed-on: https://chromium-review.googlesource.com/1186081 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585636}
-
Morten Stenshorne authored
There's no need for NGOutOfFlowLayoutPart to compute borders on its own, since the algorithm has already done that. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7c1bf51d05208c1e1d6a573b32a03ba35b5742f8 Reviewed-on: https://chromium-review.googlesource.com/1184718Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#585635}
-
Steve Anton authored
This change implements the RTCIceTransport.gather() method and associated methods/events: getLocalCandidates(), gatheringState, ongatheringstatechange, and onicecandidate. The state property is also partially implemented so that the RTCIceTransport can be stopped and garbage collected. Bug: 864871 Change-Id: I7056764789d92dc93038a7a2279a15c850b4d299 Reviewed-on: https://chromium-review.googlesource.com/1153845 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585634}
-
Mao Huang authored
Original CL: - https://codereview.chromium.org/1577883002 Add run-time CHECK to smoke-test allocator overrides As part of the refactoring work on the allocator, it emerged that it would be nice to have a test that ensures that we don't accidentally break things along the way and not detected that. This CL adds a runtime CHECK() that verifies that: - On Windows (non-component build) the shim layer has been initialized. Concretely this checks that chrome called the shimmed _heap_init() method and not the one from libcmt. - On Linux desktop, the malloc symbols are being overridden by tcmalloc (only when USE_TCMALLOC is defined). The rationale of this test is: if _heap_init was shimmed there are very good chances that malloc (& friends) were shimmed as well. Likewise on Linux for mallopt() <-> malloc(). BUG=564618 Committed: https://crrev.com/be9d6fce01061afde845fd7aa2335e5757d6a421 Cr-Commit-Position: refs/heads/master@{#369007} BUG=724399,b:70905156 Change-Id: I047ac19bb71346fbf601825d335bd97729b9f688 Reviewed-on: https://chromium-review.googlesource.com/1130793 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585633}
-
James Cook authored
Chrome creates a second InputMethodChromeOS when a remote mojo app opens. This sets a new IMEInputContextHandler on IMEBridge, but does not trigger an "engine switch". Make sure the dictation code looks up the current IMEInputContextHandler each time it tries to inject text. Bug: 876448 Test: added to interactive_ui_tests Change-Id: I100a62920ffb397ec823a4bcddb1adf94ec5f6a3 Reviewed-on: https://chromium-review.googlesource.com/1187135 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585632}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I390595bac216edba8e7e1c710f94084c540b52c0 Reviewed-on: https://chromium-review.googlesource.com/1187395Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#585631}
-
Andrey Lushnikov authored
This patch adds permission management over DevTools protocol: - Browser.grantPermissions to grant permissions to origin - Browser.resetPermissions to reset devtools permissions to defaults Testing overview: - content_shell's devtools manager delegate is updated to resolve the default browser context. This way functionality can be tested in layout_tests - a new browser-grant-permissions.js test is added to test added methods - geolocation test is rewritten to use protocol instead of PermissionsUtil layout_test hook to verify that protocol permissions work with geolocation overrides. BUG=631464 R=dgozman Change-Id: I6d9451339c319781c47c7db9db02c9cd08115c26 Reviewed-on: https://chromium-review.googlesource.com/1185877 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#585630}
-
Lei Zhang authored
mojo::CreateReadOnlySharedMemoryRegion() just got added. Change-Id: Ic247f391e041d9d7f401d73c34b3f005bb000347 Reviewed-on: https://chromium-review.googlesource.com/1187238 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#585629}
-
Devlin Cronin authored
s/h2/h3 Bug: None Change-Id: Ie874f5592b8244a58d0d41659b7b5a94f632a5b3 Reviewed-on: https://chromium-review.googlesource.com/1186924Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585628}
-
Daniel Rubery authored
It looks like aw_web_ui_controller_factory.cc was getting it's dependency on GURL through components/safe_browsing/web_ui/safe_browsing_ui.h. This CL makes the dependency direct, so the Safe Browsing UI can change its dependencies without breaking android_webview. (For an example of a broken build from changing the Safe Browsing UI, see crrev/c/1187008/1) Change-Id: I5d94b567d473caf7655c1447fbc8ccd416d6b5b6 Reviewed-on: https://chromium-review.googlesource.com/1187186Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#585627}
-
Scott Violet authored
This does not change the namespace, only the directory. That will happen next. BUG=876924 TEST=covered by tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iff71c6372b21ea13dfa9c35d44f06073a2ba3c77 Reviewed-on: https://chromium-review.googlesource.com/1186040Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585626}
-
Kurt Horimoto authored
This can be used to remove ChromeBroadcastObservers from the FullscreenController's broadcaster before deallocation. This CL also updates LocationBarCoordinator and PrimaryToolbarCoordinator to track their started state so that the start and stop logic is only performed once. This prevents the coordinators from attempting to remove itself as a FullscreenControllerObserver multiple times. Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I491ac5891586c342152aa96bf51d4a6b6d847b1a Reviewed-on: https://chromium-review.googlesource.com/1176874 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#585625}
-
bsheedy authored
Adds an automated test to cover the manual test of entering the VR Browser on a native page via an NFC scan. Bug: 862155 Change-Id: I1a4779a94996389b77cf15aea07f151152a16cda Reviewed-on: https://chromium-review.googlesource.com/1187196Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585624}
-
Gabriel Marin authored
Moves the macro defines for enabling doubly-linked free lists and for disabling huge allocations in tcmalloc to the build file. This makes it easier to uprev tcmalloc from gperftools where these features are implemeneted, but not enabled by default. BUG=724399,b:70905156 Change-Id: Ie84407583227baeddeef6bcf5eb9a825dbc6ddd2 Reviewed-on: https://chromium-review.googlesource.com/1187381 Commit-Queue: Gabriel Marin <gmx@chromium.org> Reviewed-by:
-
Sahel Sharify authored
TBR=tdresser@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836996 Change-Id: Iceb8ee0ba3b67f2f222e7ec4f382814e846d5b5d Reviewed-on: https://chromium-review.googlesource.com/1187513 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585622}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5a571a1d27ef..790b2751b515 git log 5a571a1d27ef..790b2751b515 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 chrome-bot@chromium.org Update config settings by config-updater. 2018-08-23 dgarrett@google.com workspace_stages: Use overlay_type for workspace uprevs. 2018-08-23 dgarrett@google.com commands: cros_mark_as_stable overlay-type support. 2018-08-23 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@790b2751b515 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I50130c6ea7abc549f6afd88ab20f58a93045f455 Reviewed-on: https://chromium-review.googlesource.com/1187123Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585621}
-
Mathias Carlen authored
R=gogerald@chromium.org Bug: 806868 Change-Id: I6d682514509fbb773cef90f35f63201277dce91a Reviewed-on: https://chromium-review.googlesource.com/1186417 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#585620}
-
Scott Little authored
Failing test: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-003v.html TBR=atotic@chromium.org Bug: 877183 Change-Id: If695ba1ac593ab265b72a9f0f09ec6ed987231ad Reviewed-on: https://chromium-review.googlesource.com/1187376Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Not sure if this was ever used - the CL that added it didn't make use of it, and nothing currently uses it. Change-Id: I9be36d1e36b088790c155ff95147357df10829f4 Reviewed-on: https://chromium-review.googlesource.com/1186550Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#585618}
-
Mohsen Izadi authored
These fields are not used on other platforms; so there is no need to send them: - |max_page_scale_factor|; - |root_layer_size|; - |root_overflow_y_hidden|. Note that |min_page_scale_factor| is used on Mac. BUG=859969 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I27d23f9b32e93805ab204b44a0999fb0c72e585f Reviewed-on: https://chromium-review.googlesource.com/1158856Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
- kEmbedFlagEmbedderInterceptsEvents is not yet supported for ServerRemoveViewHost embedding. Change it to a DCHECK. - Use AppListEventTargeter for mash card like in classic ash. Bug: 812434 Change-Id: Ie2a952b6e60b66c4f87855fc85313505d0586a2b Reviewed-on: https://chromium-review.googlesource.com/1187185Reviewed-by:
-
Vikas Soni authored
This is a reland of dd9f811b with a bug fix for Bug: 875121 Original change's description: > Add support for reporting EGL Timestamps via > presentation feedback. > > This CL adds support for reporting egl_composite_interval and > presentation_time via the presentation feedabck. > GLSurfacePresentationHelper uses the new interface > EGLTImestampClient to query the egl timestamp info. > > Bug: 790761 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I7e1f3200bba41bf3252b8acedc68393eeeb76df5 > Reviewed-on: https://chromium-review.googlesource.com/1106600 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583360} Bug: 790761 Change-Id: I498cde154a1926b61b683ad27f984d9552385146 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1185441 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#585615}
-
Reilly Grant authored
Somehow these changes didn't make into the last patchset uploaded for r581994 and so I have recreated them here. Change-Id: I54cf951d46ad12c23433996dee790ce25047c8a5 Reviewed-on: https://chromium-review.googlesource.com/1187020Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#585614}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a7fb87b3a3d1..7a1ed44d248a git log a7fb87b3a3d1..7a1ed44d248a --date=short --no-merges --format='%ad %ae %s' 2018-08-23 chiniforooshan@chromium.org Telemetry: fix a rendering benchmark failure Created with: gclient setdep -r src/third_party/catapult@7a1ed44d248a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877056 TBR=sullivan@chromium.org Change-Id: Ie77f89090cb2e0537baf011a3351c19f89e8c575 Reviewed-on: https://chromium-review.googlesource.com/1187341Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585613}
-
Sahel Sharify authored
This reverts commit 2e954351. Reason for revert: "fast/frames/crash-frameset-CSS-content-property.html" is flaky example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/171496 Original change's description: > Fix fast/frames/crash-frameset-CSS-content-property.html > > This test switches a <frameset> to a <body>. For framesets, LayoutView::CalculateScrollbarModes > forces the user scrollable bit to be false. So, we need to make sure to call > LayoutView::SetNeedsPaintPropertyUpdate when the LayoutView's child changes to/from a frameset. > > > Bug: 875287 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I5ae0a7673ae8e325242465633749ffcd76ca705f > Reviewed-on: https://chromium-review.googlesource.com/1186181 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585493} TBR=pdr@chromium.org,chaopeng@chromium.org Change-Id: Ibbfd46388eedd04af20242e4c87413880b9d9718 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875287, 877210 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1187283Reviewed-by:
-
Scott Little authored
This reverts commit be51aadb. Reason for revert: Looks like this caused a test to start flaking, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/12367 Original change's description: > Consistent touchpad pinch behaviour for app windows and webviews > > Currently, app windows (possibly containing webviews): > 1) suppress all pinch events which also suppresses the > synthetic wheel event, but not touchscreen touch events, and > 2) allow "smart zoom" on Mac which can change the page scale even > though other means of changing the page scale are suppressed. > > As a result of (1), if we have, say, google maps in a webview, a > user can pinch zoom with a touchscreen, but not with a touchpad. > > We now suppress gesture events to app windows based on whether they > cause a scale change. So now touchscreen and touchpad pinching are > consistent since the page has access to the events so that it may > implement custom pinch zoom behaviour, but unhandled events still > do not result in a scale change for the app window. Also, smart > zoom is suppressed to be consistent with other touchpad pinching. > > Bug: 725970, 874132 > Change-Id: I03dd2048002d69dc7c8a822fc727140c67d64706 > Reviewed-on: https://chromium-review.googlesource.com/1174933 > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585489} TBR=benwells@chromium.org,ekaramad@chromium.org,wjmaclean@chromium.org,mcnee@chromium.org Change-Id: I3a717517c60bbe22bbb3b93c64bea107ef191a5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725970, 874132 Reviewed-on: https://chromium-review.googlesource.com/1187167Reviewed-by:
-
Sahel Sharify authored
Failure example: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/9598 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873045 Change-Id: I97f130469c20017f4fb4d336845bf89195729b1e Reviewed-on: https://chromium-review.googlesource.com/1187126Reviewed-by:
-
Michael Thiessen authored
More unused test threading code... Change-Id: I142035ceaa8b7f3126f5c375b12c0356d2d6eb40 Reviewed-on: https://chromium-review.googlesource.com/1186552Reviewed-by:
-
Scott Little authored
This CL makes the Data Reduction Proxy bypass logic get applied to a response that has the Data Reduction Proxy Via header even if the response didn't seem to come from a configured Data Reduction Proxy. This same workaround was previously present in Chrome, but removed in https://chromium-review.googlesource.com/c/chromium/src/+/1040827. This CL re-adds it since it turns out it's still necessary in some cases, see the bug for more details. Bug: 876776 Change-Id: I0bb9a4f8018c9f21c056f169fb934bc08d37f139 Reviewed-on: https://chromium-review.googlesource.com/1186123Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
