- 02 Jul, 2018 40 commits
-
-
Vadym Doroshenko authored
Checkboxes are not part of calculation of form signature. So despite the same signature it might be different number of fields. For example when the site adds or removes checkboxes dynamically. This CL removes assumption that initially observed form and server predictions have the same number of fields. Unique_renderer_ids are used for field identification. Bug: 831123, 853149 Change-Id: Ibb6551e702cf073562dea1c4be47c5421143f713 Reviewed-on: https://chromium-review.googlesource.com/1118258 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571919}
-
Theresa authored
This reverts commit 36fc4d87. Reason for revert: caused crbug.com/859423 and crbug.com/859421 BUG=859421,859423,835412 Original change's description: > Modern] Update toolbar button animation for NTP > > Fade out the toolbar buttons rather than scrolling them off when the NTP > is scrolled. > > BUG=835412 > > Change-Id: I9c273aaa83f3546c9e04f9a7140c39796f09af9c > Reviewed-on: https://chromium-review.googlesource.com/1120442 > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571530} TBR=twellington@chromium.org,mdjones@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 835412 Change-Id: I98b3f2d9b561eff9f80b798abb3965065ecf6002 Reviewed-on: https://chromium-review.googlesource.com/1122877Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#571918}
-
Emily Hanley authored
Bug: 757933 Change-Id: Ica1832c5f95d0cb0d3d034d318ff58c9e5a4ac70 Reviewed-on: https://chromium-review.googlesource.com/1106549Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#571917}
-
Alexander Timin authored
Bind input-related mojo interface to the input task runner and add a feature to assign the highest priority to it. BUG=857099 R=alexclarke@chromium.org,yutak@chromium.org,haraken@chromium.org,rkaplow@chromium.org CC=eseckler@chromium.org,hajimehoshi@chromium.org Change-Id: I19f3e08bcc6af626dba298f31570102ddaffc4ac Reviewed-on: https://chromium-review.googlesource.com/1117188Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571916}
-
khmel@google.com authored
RequestAccountInfo -> OnAccountInfoReady is implmented as truly async calls. It seems that it is possible the case when instance is removed after making a request and this leads to crash (however it is pretty rare case). TEST=N/A BUG=801947 Change-Id: I0ae3f7a250e0796d2174ea5252e33db84f949592 Reviewed-on: https://chromium-review.googlesource.com/1120777Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#571915}
-
Ovidio Henriquez authored
This change splits the runtime enabled flag for WebUSBOnDedicatedAndSharedWorkers into WebUSBOnDedicatedWorkers and WebUSBOnSharedWorkers to facilitate the independent development of the features. Bug: 837414 Change-Id: Icb9237a42a1f0b27391f602db7b3f395d53dcd6d Reviewed-on: https://chromium-review.googlesource.com/1098031 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#571914}
-
Sky Malice authored
Bug: 714018 Change-Id: Icf820390ed7ae7dd66219d9473dedae3e90e382a Reviewed-on: https://chromium-review.googlesource.com/1117569 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#571913}
-
Alexandr Ilin authored
This reverts commit 65c948ac. Reason for revert: The cause of flakiness was fixed in https://crrev.com/c/1092851. Original change's description: > Disable Flaky ForegroundedOrClosedTest.SingleTab test > > ForegroundedOrClosedTest.SingleTab has started to flake on ChromeOS. This > disables the test until the cause can be found. > > TEST=ForegroundedOrClosedTest.SingleTab > TBR=fdoray@chromium.org > > Bug: 839886 > Change-Id: I650bc975a9e4795218eb205a628d3c604f7fcdcf > Reviewed-on: https://chromium-review.googlesource.com/1044533 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556112} TBR=fdoray@chromium.org,jonross@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 839886 Change-Id: I946125acee4ec518f25d6c1992ff3b3ecf9f6b0e Reviewed-on: https://chromium-review.googlesource.com/1122797Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571912}
-
edchin authored
Previously, the close all button in regular tabs panel in tab grid would close both the regular tabs and incognito tabs. This was the behavior in the stack view. This CL makes it only close the visible panel, as that makes more sense. Bug: 845496 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I730f7c102baaf96e983543baa42d277414339b90 Reviewed-on: https://chromium-review.googlesource.com/1120680Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571911}
-
Koji Ishii authored
By manual review of build 7420. All rebaselined differences are 1px kerning differences, height of LayoutBR, or different way to split text runs. TBR=atotic@chromium.org Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I02103c7ccd3f02e5fc6fc1cefec57b8233381c4c Reviewed-on: https://chromium-review.googlesource.com/1122033Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571910}
-
Mitsuru Oshima authored
This reverts commit 6488ecd7. Reason for revert: the leak was identified in crbug.com/859262, and same leak happened after this revert. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28109 Original change's description: > Revert "Propagate flip layout proprety of the popups" > > This reverts commit fbe272fb. > > Reason for revert: exo_unittests are flaky on Linux ASan: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29?limit=200 > > Original change's description: > > Propagate flip layout proprety of the popups > > > > BUG=788782 > > TEST=manully tested with gtk3-demo > > > > Change-Id: I4a381b9350675d4e5407b378fbe07ae9de64fe8a > > Reviewed-on: https://chromium-review.googlesource.com/1108558 > > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: David Reveman <reveman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#569893} > > TBR=reveman@chromium.org,oshima@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 788782 > Change-Id: Iae9444d706ff01f37787781955bfbbb8dff63c01 > Reviewed-on: https://chromium-review.googlesource.com/1115918 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570586} TBR=dgozman@chromium.org,reveman@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 788782 Change-Id: Ibb60d892830e070683ac1d8190144d50fa8d876a Reviewed-on: https://chromium-review.googlesource.com/1122876Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#571909}
-
Guido Urdaneta authored
This tries to address a crash that occurs when MSM::PostRequestToUI runs as a posted task using a raw pointer to a request as argument. It is possible that the request had been cancelled when the posted task runs and the raw pointer is invalid. This CL also adds thread checking to all methods that access |requests_|. Bug: 847490 Change-Id: I1607a2f2637e58b88270100bc691d5263ab91fff Reviewed-on: https://chromium-review.googlesource.com/1122406 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#571908}
-
Hongchan Choi authored
This is a follow-up CL of https://chromium-review.googlesource.com/c/chromium/src/+/1115516. TBR=rtoy@ Bug: 856215 Change-Id: Ib2836d831968795eac6a95eae6148469af69d15d Reviewed-on: https://chromium-review.googlesource.com/1121209Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#571907}
-
Bailey Berro authored
This change implements the logic to check whether a mount was originally mounted with ChromAD Kerberos, and if so passes the user's username and workgroup when attempting to remount. Bug: chromium:757625 Change-Id: I3f1d4261d118f11cb410c7c44a8150423c99fbf9 Reviewed-on: https://chromium-review.googlesource.com/1098115 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#571906}
-
Jacob Dufault authored
The back button did not work, but escape did. Unify these two exit paths so they do not diverge, and also fix closing via back button. Bug: 859130 Change-Id: I96286ea69fb9d230ed82e589030a9e1a747c5150 Reviewed-on: https://chromium-review.googlesource.com/1120868Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#571905}
-
Fredrik Söderquist authored
Check Document::hidden() in LayoutObject::WillRenderImage, thus pausing animations on pages that are not visible. To resume animations, we may need to explicitly resume the timeline, so a hook is added in Page::SetVisibilityState to allow calling StartAnimation() on the relevant SVGImages. Update: Added RunPendingTasks() to test to make sure the later code is actually waiting for a proper animation frame. Tbr: chrishtr@chromium.org Bug: 856082 Change-Id: I457fc0b92576edf7d70933373d12d49d52a0b912 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1122413Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#571904}
-
Thomas Tangl authored
The condition of whether a user changed their profile avatar explicitly is changed. Bug: 853363 Change-Id: I1e9bc3928b74f3dbb613521b492561455a7b104b Reviewed-on: https://chromium-review.googlesource.com/1120065Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#571903}
-
Alexandr Ilin authored
This reverts commit 7476d68c. Reason for revert: The cause of test flakiness was fixed in https://crrev.com/c/1092851. Original change's description: > Disable flaking ChromeLauncherControllerWithArcTest.ArcAppPinPolicy > > ChromeLauncherControllerWithArcTest.ArcAppPinPolicy is flaking currently. > Disabling as the team who owns the root cause is OOO. > > TEST=ChromeLauncherControllerWithArcTest.ArcAppPinPolicy > TBR=skuhne@chromium.org > > Bug: 839916 > Change-Id: I86209df361ab53cb84225363c39b1c83db197a2f > Reviewed-on: https://chromium-review.googlesource.com/1044655 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556125} TBR=skuhne@chromium.org,jonross@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 839916 Change-Id: I36936a7a97b04857a20d892a636f6aac98bc04b2 Reviewed-on: https://chromium-review.googlesource.com/1122796Reviewed-by:
-
Oscar Johansson authored
When building using Jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kStartPadding and kEndPadding in chrome/browser/ui/views/download/download_item_view.cc and chrome/browser/ui/views/download/download_shelf_view.cc. This commit solves the issue by moving the variables from the namespace to the class. It also moves other variables in the same namespace, to keep the files locally consistent. Bug: 773275 Change-Id: I8d23ae9999fe404d253a3a189e6d17d81786939d Reviewed-on: https://chromium-review.googlesource.com/1107063Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571901}
-
Gauthier Ambard authored
This CL moves the Open In toolbar out of ios/web and removes completely the toolbars in CRWWebControllerContainerView. Instead the open in toolbar is directly added to CRWWebControllerContainerView. As the Toolbar cannot be positioned with autolayout directly, the toolbar is using a dummy view with its height constrained to the bottom toolbar height. When the height change, the toolbar is re-positioned. Bug: 833177 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic4d757f259bc60799de05f325a1f1d6c8c697215 Reviewed-on: https://chromium-review.googlesource.com/1112002 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#571900}
-
nednguyen authored
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I32a057c4bb0b9c443b4518d36acf6e2fd6a73b3f NOTRY=true # test covered by PRESUBMIT Change-Id: I32a057c4bb0b9c443b4518d36acf6e2fd6a73b3f Reviewed-on: https://chromium-review.googlesource.com/1122487Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571899}
-
Leonard Grey authored
- exit early from SetText when possible - replace some uses of CalculatePreferredSize with GetPreferredSize, and update preferred size when text changes Bug: 712268 Change-Id: Iaf9440b75aa94ec09b67f207bc9f98e4ab0d9301 Reviewed-on: https://chromium-review.googlesource.com/1119209Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#571898}
-
Oscar Johansson authored
When building using jumbo unnamed namespaces gets merged and variables with the same name conflict. This happens for the variables kFooterBackgroundColor and kSeparatorColor in ui/views/autofill/autofill_popup_view_native_views.cc and ui/views/passwords/password_generation_popup_view_views.cc. This commit solves the issue by renaming the constants to something more file specific. It also renames other variables in the same namespace, so the naming is locally consistent. Bug: 773275 Change-Id: I3f71efeaa29eccdbe646e7c2fb512f218c2f010a Reviewed-on: https://chromium-review.googlesource.com/1118260Reviewed-by:
-
Marc Treib authored
The strings in there were referenced in only two places: 1) ForeignSessionHandler (which powers chrome://history/syncedTabs) sent them to JS, but the JS side never used them. 2) about_sync_util.cc (which powers chrome://sync-internals) used them, but nothing else on chrome://sync-internals is localized, so it's better to just inline non-localized strings there. Bug: none Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ide4a2efe563f57c9d0afaa51722dece0dac50d7e Reviewed-on: https://chromium-review.googlesource.com/1118233Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#571896}
-
Boris Sazonov authored
This CL modifies the main Settings screen to hide 'Account' section header when personalized sign-in promo is shown. Bug: 814728 Change-Id: I994c2b0731e9c74bc4599c3f2893989ce112c378 Reviewed-on: https://chromium-review.googlesource.com/1122618Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7687ad58b24b..5c71e74331bd git log 7687ad58b24b..5c71e74331bd --date=short --no-merges --format='%ad %ae %s' 2018-07-02 aleloi@webrtc.org Add AGC1-compliant fake recording device. 2018-07-02 aleloi@webrtc.org Add more ApmDataDumper dumps to AGC. Created with: gclient setdep -r src/third_party/webrtc@5c71e74331bd The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I77cde3e4ac2b36201c2a6ede165618b1d36ac5ff Reviewed-on: https://chromium-review.googlesource.com/1122577Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571894}
-
Emily Hanley authored
Failures in this revert https://chromium-review.googlesource.com/c/chromium/src/+/1120125 were for failing mac, but the everything was succeeding, we were failing when trying to right out not valid json as perf results. I have added logic in line 447 of process_perf_results.py to catch these errors in the future. Note this was also an issue in the old recipe, it just shows one step as failed instead of the entire suite. Bug: 713357,854162, 859073, 858995 Change-Id: I37c8f8fe3d7973962a17bbd64b758c7c98517799 Reviewed-on: https://chromium-review.googlesource.com/1122478Reviewed-by:
-
Mark Cogan authored
This CL adds a leightweight construct for managing groups of property animators. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I875abe271a1eadc36e7d012e8c03117b12ac3f8c Reviewed-on: https://chromium-review.googlesource.com/1118261 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571892}
-
Lutz Justen authored
Handle setWindowBounds for FakeArcSupport (just do nothing). It fails there if mash is enabled. Bug: 859503 Change-Id: Icb99100691de2dfed753b1afbd935c0be10117eb Reviewed-on: https://chromium-review.googlesource.com/1122620Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#571891}
-
Vasilii Sukhanov authored
Password drop-down used to show "Generate password" as a fallback. The feature was never launched. Instead user may right-click a password field and select "Generate password" from the context menu. It's available on stable. Bug: 739343 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ide9bc9ed132e687cc81288de84b2b8f88d60c9ec Reviewed-on: https://chromium-review.googlesource.com/1112242Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#571890}
-
Adam Rice authored
Add [ Failure Timeout ] expectations for virtual/outofblink-cors/http/tests/fetch/workers/thorough/redirect-loop-base-https-other-https.html with site_per_process and all variants. Bug: 854630 Change-Id: I204009be0538ebe8c0651cfbcd90e098ffb32dc3 Reviewed-on: https://chromium-review.googlesource.com/1122144 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#571889}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e9d405363cbf..b56a7a2a1a62 git log e9d405363cbf..b56a7a2a1a62 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 hjd@google.com Merge "Added Track Canvas Context" 2018-06-29 michaschwab@google.com Added Track Canvas Context Created with: gclient setdep -r src/third_party/perfetto@b56a7a2a1a62 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I0f48acd9a52896cd9dc4f6e6329d636a0503c99c Reviewed-on: https://chromium-review.googlesource.com/1122377 Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571888}
-
Daniel Bratell authored
If EnclosingIntRect() is called on an IntRect it is first converted to a FloatRect or DoubleRect since that is what EnclosingIntRect() is used for. Then you (hopefully) get the originally IntRect back. This strange conversion wasn't obvious in the code because the type of the IntRect was hidden by an |auto|. It was discovered in jumbo builds because the compiler had access to both DoubleRect and FloatRect and didn't know which one to use. Bug: 843606 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1ca799cc27da02e1c6615bf403bc190fec1d5cde Reviewed-on: https://chromium-review.googlesource.com/1122219Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#571887}
-
Leonard Grey authored
This reduces layout time per tick while resizing (with text in the security chip) from 56ms to 16 ms in a local release build. It seems fine visually, and all tests pass, so... Bug: 850128 Change-Id: I13b3441a174958c15c9d72bf4462c47819de0040 Reviewed-on: https://chromium-review.googlesource.com/1119210Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
Javier Fernandez authored
The spec considers flexible tracks as content-sized if the grid has an indefinite size. We were using FreeSpace to determine this case as part of the IsIntrinsicSizedGridArea, which is incorrect since that function returns a different value before, during and after running the tracks sizing algorithm. We use the IsIntrinsicSizedGridArea function to detect cyclic sizing dependencies in grid items, so that such items can participate in baseline alignment. Hence, using the FreeSpace function lead to inconsistent behavior in some cases, like the one described in the bug this CL tries to fix. Bug: 859374 Change-Id: Ifa90cdad6703c3b5e55a7230f85bc4ef63bf32d3 Reviewed-on: https://chromium-review.googlesource.com/1122217 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#571885}
-
Alexandr Ilin authored
Some clients would like to get a unique shared memory region ID without having a mapping to this region. There is no reason to not expose this method that is already implemented in the PlatformSharedMemoryRegion. Bug: 854594 Change-Id: I7e7de1b6c35748c382a1bf99974c53a0472e9b73 Reviewed-on: https://chromium-review.googlesource.com/1117190Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571884}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/34f0d7e2e45f..3836c556c4c6 git log 34f0d7e2e45f..3836c556c4c6 --date=short --no-merges --format='%ad %ae %s' 2018-07-02 pasko@chromium.org androidStartupMetric: Allow multiple FCP events Created with: gclient setdep -r src/third_party/catapult@3836c556c4c6 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760498 TBR=sullivan@chromium.org Change-Id: I10d9051ea1022d1a0b1cf64eddf04cd9cbc79113 Reviewed-on: https://chromium-review.googlesource.com/1122436Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571883}
-
Bailey Berro authored
This change adds authentication parameters to SmbProviderClient::Remount so ChromAD Kerberos shares can be remounted by passing in a user's username and workgroup. Bug: chromium:757625 Change-Id: I201a100526cbf1f29188e2b9b7e797c60b929620 Reviewed-on: https://chromium-review.googlesource.com/1098079 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
-
Oscar Johansson authored
When building using Jumbo namespaces with the same name gets merged and functions with the same name conflict. This happens for the function NetLogEntryCreationCallback in: net/disk_cache/net_log_parameters.h net/disk_cache/memory/mem_entry_impl.cc This commit solves the issue by renaming the function in net/disk_cache/net_log_parameters. Also renames CreateNetLogEntryCreationCallback to keep names consistent. Bug: 772146 Change-Id: Ice0a53054dbf2ded14728d48a7fd7b33bfe0d5a5 Reviewed-on: https://chromium-review.googlesource.com/1120180Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#571881}
-
Oscar Johansson authored
When building using Jumbo namespace aliases with the same name may end up in the same unit, causing a conflict at compilation. This happens for base::File and disk_cache::File in: net/disk_cache/simple/simple_index_file.cc net/disk_cache/simple/simple_synchronous_entry.cc This commit removes "using base::File" and instead call the namespace by its full name. Bug: 772146 Change-Id: I7385edf04bc23d519ee8800bc4941807a85340ad Reviewed-on: https://chromium-review.googlesource.com/1120252Reviewed-by:
-
