- 01 Jun, 2016 40 commits
-
-
erg authored
After 532d3841, we need to also check for MOUSE_MOVED, not just POINTER_MOVED. BUG=603369 Review-Url: https://codereview.chromium.org/2027283002 Cr-Commit-Position: refs/heads/master@{#397219}
-
mahmadi authored
BUG=563722 Review-Url: https://codereview.chromium.org/2032453003 Cr-Commit-Position: refs/heads/master@{#397218}
-
wangxianzhu authored
BUG=604144,396825,607185,587094,155836,602933 TBR=wkorman@chromium.org Review-Url: https://codereview.chromium.org/2025243002 Cr-Commit-Position: refs/heads/master@{#397217}
-
stip authored
BUG=525873, 606066 Review-Url: https://codereview.chromium.org/2027873002 Cr-Commit-Position: refs/heads/master@{#397216}
-
gab authored
Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Review-Url: https://codereview.chromium.org/2031693002 Cr-Commit-Position: refs/heads/master@{#397215}
-
jamescook authored
Calls to set shelf state should go through Shelf, not ShelfLayoutManager. * Move all calls to SetAutoHideBehavior() and SetAlignment() to Shelf instead of ShelfLayoutManager. * Add Shelf::GetVisibilityState() and Shelf::GetAutoHideState() and prefer using them to accessing ShelfLayoutManager directly. * Remove ShelfLayoutManager::GetAutoHideBehavior(). * Rename variables mis-named "shelf" to shelf_widget, shelf_layout_manager, etc. so they match their actual types. No functional changes. BUG=615502 TEST=ash_unittests Review-Url: https://codereview.chromium.org/2017413002 Cr-Commit-Position: refs/heads/master@{#397214}
-
gab authored
Change automated with clang-tidy (details @ https://crbug.com/612843#c13) BUG=612843 Review-Url: https://codereview.chromium.org/2023353002 Cr-Commit-Position: refs/heads/master@{#397213}
-
oshima authored
BUG=616556 TBR=esprehn@chromium.org Review-Url: https://codereview.chromium.org/2028203002 Cr-Commit-Position: refs/heads/master@{#397212}
-
nektar authored
There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility. For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic. BUG=615904 R=dmazzoni@chromium.org Review-Url: https://codereview.chromium.org/2021953002 Cr-Commit-Position: refs/heads/master@{#397211}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/d501ee220 BUG=613118 TBR=eae@chromium.org Review URL: https://codereview.chromium.org/2026403002 . Cr-Commit-Position: refs/heads/master@{#397210}
-
yuweih authored
This finishes up the refactorization of the JNI interface. Scheduled tasks inside a session will not be lingering after the session ends. BUG=526336 Committed: https://crrev.com/800991e54ced74fc425843070a1941827af5b787 Cr-Commit-Position: refs/heads/master@{#396036} Review-Url: https://codereview.chromium.org/2007403002 Cr-Commit-Position: refs/heads/master@{#397209}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e1916b6e9756..77276cd20e4e $ git log e1916b6e9..77276cd20 --date=short --no-merges --format='%ad %ae %s' TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2025103004 Cr-Commit-Position: refs/heads/master@{#397208}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/4a603fc591dc..edc743a57657 $ git log 4a603fc59..edc743a57 --date=short --no-merges --format='%ad %ae %s' 2016-06-01 bsalomon Add SkPathPriv::IsSimpleClosedRect 2016-06-01 jvanverth Add offset to memory allocations CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=herb@google.com Review-Url: https://codereview.chromium.org/2029683002 Cr-Commit-Position: refs/heads/master@{#397207}
-
sadrul authored
We can no longer expect a single cycle of message-loop iteration to paint a widget, since painting is now driven by BeginFrameSource. So update the tests to wait for the painting to happen first. These tests create desktop-widgets, which we do not support in mus, so disable the tests in mus. BUG=596039 Review-Url: https://codereview.chromium.org/2032573002 Cr-Commit-Position: refs/heads/master@{#397206}
-
xunjieli authored
This CL logs BIDIRECTIONL_STREAM_ALIVE before we start any stream request. This makes sure that HTTP_STREAM_REQUEST is nested inside BIDIRECTIONL_STREAM_ALIVE begin and end events. BUG=516342 Review-Url: https://codereview.chromium.org/2016863002 Cr-Commit-Position: refs/heads/master@{#397205}
-
pcc authored
tcmalloc defines malloc and free as wrappers (or aliases) for tc_malloc and tc_free, so we can test tcmalloc by using malloc and free directly instead of tc_malloc and tc_free. This fixes the test in component builds, where tc_malloc and tc_free are defined in a separate DSO with hidden visibility (due to https://codereview.chromium.org/2019183002/), and so will not be visible to tests. Some compilers (e.g. clang) will specifically recognize and optimize away calls to malloc and free, which would break these tests, as they are testing specific behavior of the allocator. Address this by marking the wrappers for malloc and free as NOINLINE. BUG= TBR=primiano@chromium.org Review-Url: https://codereview.chromium.org/2028183002 Cr-Commit-Position: refs/heads/master@{#397204}
-
amaralp authored
Added a Setting to tell Blink whether or not to always show the context menu on a long press. BUG=616060 Review-Url: https://codereview.chromium.org/2024323002 Cr-Commit-Position: refs/heads/master@{#397203}
-
fs authored
Use isSpecified() to query for existance in setStandardAttributes. This avoids triggering unnecessary attribute synchronizations. While here, drop the "double precondition" checking since the only caller of this function checks this already. BUG=235256 Review-Url: https://codereview.chromium.org/2026343002 Cr-Commit-Position: refs/heads/master@{#397202}
-
jaydasika authored
Since the transform tree tracks whether there is a curretly running transform animation, it can be used to determine whether the local transform in transform tree node should be overwritten at commit time BUG=609208 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2027073002 Cr-Commit-Position: refs/heads/master@{#397201}
-
jmadill authored
Also should fix it on Mac, but untested. BUG=616449 TBR=piman@chromium.org, sievers@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2027753003 Cr-Commit-Position: refs/heads/master@{#397200}
-
erikchen authored
Added tests for antialiasing, alpha channel, and Chromium image. BUG=607130 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2023153002 Cr-Commit-Position: refs/heads/master@{#397199}
-
krb authored
Use the new multi-line elision in RenderText to manage/display a dictionary definition answer-in-suggest, which can span multiple lines. BUG=591803 Review-Url: https://codereview.chromium.org/2009673005 Cr-Commit-Position: refs/heads/master@{#397198}
-
xhwang authored
This is required to run the browser_tests on swarming. BUG=614745,582622 TEST=This fixes failing browser_tests. Review-Url: https://codereview.chromium.org/2028133002 Cr-Commit-Position: refs/heads/master@{#397197}
-
mikecase authored
BUG= Review-Url: https://codereview.chromium.org/2024033003 Cr-Commit-Position: refs/heads/master@{#397196}
-
fsamuel authored
BUG=611802 TBR=tsepez@chromium.org, piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2027223002 Cr-Commit-Position: refs/heads/master@{#397195}
-
sunxd authored
The lcd text is only updated at commit time. We should compute whether or not to use_lcd_text on demand rather than updating it every frame. BUG=581842 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2026033002 Cr-Commit-Position: refs/heads/master@{#397194}
-
fsamuel authored
BUG=611802 TBR=ben@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2027203002 Cr-Commit-Position: refs/heads/master@{#397193}
-
jbroman authored
While here, also fix a bug in which the rectangle in which the filter is assumed to be visible was also mapped through the filter, and update unit tests accordingly. BUG=600821 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2015343002 Cr-Commit-Position: refs/heads/master@{#397192}
-
hta authored
This CL adds a layout test that getSettings actually returns frame rate. This required wiring up support for letting the fake video source in blink_test_runner call its callbacks. BUG=543997 Review-Url: https://codereview.chromium.org/2023203002 Cr-Commit-Position: refs/heads/master@{#397191}
-
pkotwicz authored
BUG=616509 R=dfalcantara Review-Url: https://codereview.chromium.org/2024293005 Cr-Commit-Position: refs/heads/master@{#397190}
-
brucedawson authored
When DEPOT_TOOLS_WIN_TOOLCHAIN=0 it is assumed that the developer has a local install of Visual Studio, and therefore the CRT DLLs don't need to be copied to the output directory in order to run binaries. However, when creating packages for running elsewhere (isolates or the mini_installer) those DLLs are needed. In order to avoid special cases elsewhere this change copies them to the output directories when 'gn gen' or 'gn args' runs. This change also makes the newly copied files writable so that they can easily be deleted. For backwards compatibility it also makes the files writable before deleting them. This avoids a problem with pgort140.dll which can end up read-only and thus impossible to copy over or delete without first removing the read-only flag. This change also removes the need for create_installer_archive.py to copy CRT DLLs, which should avoid bugs with over-copying of these DLLs. This change also updates that script to say that ucrtbase*.dll is required. BUG=611934,585556, 610336 Review-Url: https://codereview.chromium.org/2021353003 Cr-Commit-Position: refs/heads/master@{#397189}
-
xunjieli authored
This CL attempts to fix the flakiness observed on DrMemory bots by running the current message loop until idle after resuming the sequence socket data. R=mef@chromium.org BUG=604611 Review-Url: https://codereview.chromium.org/2011183002 Cr-Commit-Position: refs/heads/master@{#397188}
-
thestig authored
BUG=540847 Review-Url: https://codereview.chromium.org/2027883002 Cr-Commit-Position: refs/heads/master@{#397187}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cc555cc2..e7978efc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2024293004 Cr-Commit-Position: refs/heads/master@{#397186}
-
eae authored
Restore the LayoutUnit::epsilon tolerance in LineWidth::fitsOnLine calls to avoid unnecessary breaks at element boundaries due to precision loss. R=szager@chromium.org BUG=613118 TEST=fast/text/sub-pixel/button-span-wrap.html Review-Url: https://codereview.chromium.org/2026073002 Cr-Commit-Position: refs/heads/master@{#397185}
-
skyostil authored
Allow headless clients to provide custom protocol handlers. This lets the clients override how URL requests are fulfilled for different schemes types. Design doc: https://docs.google.com/document/d/1m4CCZGJWOJdHY5MVwQqY3sT-5kBoz7NqmGvIb6-l3fM/edit#bookmark=id.5bqp8w95liri BUG=546953 Review-Url: https://codereview.chromium.org/2024973002 Cr-Commit-Position: refs/heads/master@{#397184}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/e3fa811657ec..4a603fc591dc $ git log e3fa81165..4a603fc59 --date=short --no-merges --format='%ad %ae %s' 2016-06-01 msarett Revert of Create SkColorSpaceXform to handle color conversions (patchset #10 id:260001 of https://codereview.chromium.org/1952063002/ ) 2016-06-01 kulshin Implement support for rendering color emoji on Windows 2016-06-01 msarett Create SkColorSpaceXform to handle color conversions 2016-06-01 scroggo Make SkPngCodec decode progressively. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=herb@google.com Review-Url: https://codereview.chromium.org/2029023003 Cr-Commit-Position: refs/heads/master@{#397183}
-
mcasas authored
ImageCapture mojo command servicing in the Browser needs to jump several threads (UI --> IO --> Device(s)). On ToT, each possible error condition in this chain is treated more or less individually, which is ugly, (especially as I'm adding capability retrieval/settings in // CLs). This CL proposes ScopedResultCallback, which is a move-only type wrapping a Mojo |callback_| _and_ an associated |error_callback_|, which is a callback provided to signal to Blink-side that something went wrong. Using and passing this callback along the callstack allows for: - removing the boolean return value - not having to run the callback by hand: If and when the methods/functions receiving this ScopedCallback don't Run() it nor pass it explicitly, it would be tantamount to "rejecting" it. For reference, the callstack follows a sequence: ImageCaptureImpl --> VideoCaptureManager --> VideoCaptureDevice (implementation). BUG=518807 Review-Url: https://codereview.chromium.org/2005753006 Cr-Commit-Position: refs/heads/master@{#397182}
-
qyearsley authored
Review-Url: https://codereview.chromium.org/2007273003 Cr-Commit-Position: refs/heads/master@{#397181}
-
ajuma authored
This fixes a DCHECK during TileManagerPerfTests. LTHI::ResetTreesForTesting destroys the pending tree, so if it doesn't also destroy the pending tree duration timer, the next call to CreatePendingTree will fail the DCHECK that the timer doesn't already exist. BUG=607818 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2027803003 Cr-Commit-Position: refs/heads/master@{#397180}
-