- 14 May, 2020 19 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/07d68fbc..e31b0cbe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I13c4fc9d05c4b440fab166ed1b4198f1d44c82bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199500Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768568}
-
Karandeep Bhatia authored
As of now, an updateEnabledRulesets call can race with an initial ruleset load in response to OnExtensionLoaded, and cause a DCHECK in RulesetManager::AddRuleset (Since we assume that there is no existing ruleset for an extension as part of the initial ruleset load flow). Resolve this by ensuring that we queue any updateEnabledRulesets call to happen only after the initial ruleset load is complete. This is similar to what we do for updateDynamicRules call. BUG=754526 Change-Id: Iefebebb35a3e62ae6f9e35ef7a657d5c72c8306d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199175 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768567}
-
Zentaro Kavanagh authored
- Identifies new CrOS keyboards that provide a custom top row layout mapping via sysfs - Performs mapping as described by supplied mapping using scan codes - Include new keyboards in existing tests - Omit new keyboards from the tests that verify the old behavior that F-Keys get translated to Action keys - Add tests to verify that the F keys are never remapped on new keyboards - Add tests to verify that Action keys are mapped to FKeys based on scan codes when search is pressed - Add tests to verify that Action keys are not mapped when search is not pressed BUG=1076241 TEST=unitests Change-Id: I490b97a008153cafaecce7ad9eeb265e6cbff992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135541 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#768566}
-
Vincent Boisselle authored
Bug: 1082469 Change-Id: I6f6c82d2d0f0fa4173d2b8d7ae0242b7bcc51773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199912 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#768565}
-
Collin Baker authored
Bug: 1069869 Change-Id: I3a538ec9a69b54ecbbd21d94066133b4f9309ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199857 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#768564}
-
Karandeep Bhatia authored
This CL completes the implementation of the updateEnabledRulesets extension function by persisting the set of enabled static rulesets to prefs. This ensures that the setting is persisted across extension loads and sessions. Note that this setting is cleared on extension update. BUG=754526 Change-Id: I2e87d658f97abb33fb69355c16c6c7587f37a5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191731 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dcfb2338586c..be72c44ec3d8 git log dcfb2338586c..be72c44ec3d8 --date=short --first-parent --format='%ad %ae %s' 2020-05-13 mtklein@google.com S20 vk? 2020-05-13 mtklein@google.com Revert "Add an implementation and log2 variants for Wang's formula" 2020-05-13 egdaniel@google.com Reland "Reland "Add api on GrContext to update the data of GrBackendTextures."" 2020-05-13 senorblanco@chromium.org Make staging manager lists private to GrGpu. 2020-05-13 egdaniel@google.com Pass externally synchronizaed flag to vulkan memory allocator. 2020-05-13 csmartdalton@google.com Add an implementation and log2 variants for Wang's formula Created with: gclient setdep -r src/third_party/skia@be72c44ec3d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jlavrova@google.com Change-Id: I6f2d015d5ac2e67bfcbc5dff08bad45a27ff687e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#768562}
-
John Delaney authored
Adds a button to the internals page which sends all pending reports immediately. This button simply sends all reports for now. A more complicated UI was considered, which would allow individual rows to be selected and sent. However, this requires changes to the ConversionStorage interface, and the existing interface can be extended if this functionality is desirable. This change also restructures communication between ConversionManagerImpl and ConversionReporterImpl to be callback based. This is done to allow binding the HandleSentReport callback to a BarrierClosure which holds the WebUI callback. This allows the WebUI to update once all reports have finished sending. Bug: 1057240 Change-Id: If82773b01b9df98d6d1f52cf35aee8fd6bdcf751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2192436 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#768561}
-
Olya Kalitova authored
Checks for UserPluginVmAllowed user policy stored in PluginVmAllowed pref in order to allow Plugin VM only if corresponding user policy is set to true. Test: unit_tests --gtest_filter="*PluginVm*" Bug: 1081744 Change-Id: Id4e6eadc651a9dc2d30b7f137759bcdacae5ab5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198782 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768560}
-
Jose Magana authored
Follow adapted version of: crbug/1051776 as migration plan: Step 1: (This CL) - add .gitignore entry for new path - add entry to src/DEPS for HelpApp - point references to app to the new entry Step 2: (CL internal: https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/2967280) - remove entry for app in src-internal/DEPS Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: Iea0ccd46670f91824fc4c95ceb630c4bc7af791f Bug: 1080474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182702 Commit-Queue: Jose Magana <jomag@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#768559}
-
Toni Barzic authored
The dialog is shown when a zero state suggestion app list search result is removed, and asks the user to confirm the suggestion removal. It's positioned relative to the SearchBoxView, but was not properly getting updated on the app list/search box bounds changes. It was using ContentsView::SearchBoxUpdateObserver to detect search box bounds updates, but that did not work reliably (and did not handle app list contents animations at all, nor bounds updates due to app list view state changes). This CL removes this observer interface and lets search results page view handle the dialog positioning, and hides the dialog when the app list page changes away from search results page. Introduces SearchResultPageAnchoredDialog to encapsulate * the dialog widget positioning relative to the search box bounds (in app list contents view coordinates) * coordinate conversions between the app list contents view (in app list window coordinates) and the dialog widget (screen coordinates) * detecting the dialog widget closure * detecting app list window bounds changes Note that the helper observes the app list window bounds changes to detect when the app list view bounds changes that do not require contents view layout (and do not cause app list contents view bounds change) - the removal dialog has to be re-positioned in this case as well (its bounds are in the screen coordinates). An example of this update is when the virtual keyboard gets hidden/shown and app list view is shown. BUG=942653 Change-Id: I1b12f6b518d952a6a0f492ab73c4d6afb24f1bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198357 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#768558}
-
Yan, Shaobo authored
This patch adds the missing API in WEBGL_video_texture spec, renames VideoElementTargetVideoTexture to shareVideoImageWEBGL, and corrects the success logic in shareVideoImageWEBGL. Bug: 776222 Change-Id: I17f2839dcef9c63346348c6d155e4eb6eb877760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194795 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#768557}
-
gogerald authored
Screen record: https://drive.google.com/file/d/18vdtOt5pgAOLyaDH5BKRgcYcJ3uRX6tL/view?usp=sharing Bug: 1081538 Change-Id: I96b96524b574f8ffeb20aea93e31a5724a1f114e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199691 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#768556}
-
Xianzhu Wang authored
The flag is separated from cc::Layer::contents_opaque() for LCD text. By default it has the same value as contents_opaque(), but when contents_opaque() is false, blink can set contents_opaque_for_text() to true if all texts will be painted on opaque background, e.g. <div style="overflow: hidden; background: white; border-radius: 10px"> TEXT </div> This reduces 30%~40% non-LCD-text pixels for contents not opaque reason (except background is not opaque), and 6%~7% overall non-LCD-text pixels: https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-ChromiumPerf-4900/html/index.html https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-ChromiumPerf-4901/html/index.html Bug: 642885 Change-Id: I5566e7111ba711c4e50f9a03a0fb0500462f92b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163035 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#768555}
-
Callistus authored
Carbon specs: https://carbon.googleplex.com/cros-ux/pages/show-off/app-structure#3e13a03d-5684-488c-b935-4129aedd6a68 Demo: https://screencast.googleplex.com/cast/NTE1NzAyMzQ5Njc5ODIwOHxjY2U4OGY5Ni1iYw Bug: b/154777087 Change-Id: Ibd79be825751334be65025155d0a1b17a807dbeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198058Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Megan Jablonski authored
Bug: 1082193 Change-Id: Ie9b3aa6b93214b720972ef9e9d46827d9cff1025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198653 Commit-Queue: Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#768553}
-
Sergey Ulanov authored
fuchsia.camera3 API provides camera application to clients, which are expected to rotate the image when presenting it on the screen. Updated VideoCaptureDeviceFuchsia to watch camera orientation and apply corresponding transformation to the video frames. Bug: 866669 Change-Id: I05ea0a3d4a59975ae0ed111c949b434fb6482b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189619 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#768552}
-
Pavol Marko authored
This introduces x509_certificate_model::ProcessRawSubjectPublicKeyInfo which takes a DER-encoded X.509 SubjectPublicKeyInfo as input, and returns a string intended for displaying the public key represented by it. It will be used in the UI code for the Chrome OS built-in certificate provisioning feature. When a certificate provisioning process is in progress, only a key pair is on the device and not a certificate (yet). This function will be used to display the public key of the key pair on the UI. Bug: 1045895, 1081396 Change-Id: I8428dec1a03ac1fdc3edffdaeeda304be0cdb9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036053 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#768551}
-
Erik Chen authored
Bug: 1077348, 1080466 Change-Id: I1d27c2e041960b99345148a1668431c780f18b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200070 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
- 13 May, 2020 21 commits
-
-
Yoav Weiss authored
As a followup to [1], this CL ensures that on-by-default Client Hints don't get removed from cross-origin redirects. It similarly makes sure that legacy hints that don't abide to FeaturePolicy get a free pass on the removal in that case. Finally, it makes sure that UA-Mobile's FeaturePolicy's default value is "all". [1] https://chromium-review.googlesource.com/c/chromium/src/+/2178572 Bug: 911952, 1082072 Change-Id: I1f329a3c24397a287a1cbc333cd0976bb16d640a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199107 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#768549}
-
Olivier Li authored
After we previously run as an inconclusive beta trial by itself we grouped it with the HistoryService ThreadPool trial to try and coax a larger impact from the ThreadPool migration. This meant groups ran with either both services on the ThreadPool, none or only HistoryService (status quo). 28 day aggregation trial in beta showed no likely negative impact. Crashes seemed slightly elevated in the group when running both the HistoryService and the ProfileSyncService on the ThreadPool but closer examination suggests this is simply noise since all top-crashers are the same. Bug: 1014464 Change-Id: I3a1604413fcf1f4b5350c3b9161251f46a449865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198932 Commit-Queue: Oliver Li <olivierli@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768548}
-
Anatoliy Potapchuk authored
In Web App kiosk mode, even though web apps are enabled, system web apps are not. We should explicitly disable them here. Bug: 1061068 Change-Id: Iea6f6f439d11c408ba3c9a48d4987f5cdcad0da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199280 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#768547}
-
Karandeep Bhatia authored
Introduce getEnabledRulesets extension function which returns the IDs for the set of enabled static rulesets. BUG=754526 Change-Id: Ie7647c718b96953a7ba2fbb0e2322443b9a18fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189692 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
1. PageInfoController uses the now componentized PermissionParamsListBuilder. 2. A PermissionParamsListBuilderDelegate is created for WebLayer and passed into PageInfoController. Bug: 1052375 Change-Id: I71b1d61e60c755887b5ae767d4a945aa4eec8d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185070 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#768545}
-
David Bertoni authored
for flakiness. The UnlimitedStorageForLocalButNotSync was disabled long ago for flakiness. This test passed 3000 iterations on the bots with no flakes. Bug: 227296 Change-Id: I24da0f1718658348dafb866c2eb6e7770400f843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196959Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#768544}
-
Darwin Huang authored
Rename OSExchangeDataProviderAuraX11 to OSExchangeDataProviderX11. AuraX11 classes were named as "AuraX11" for historical reasons, but X11 no longer requires Aura, so X11 is a more concise name. No intended logic changes. Only names and comments should have changed. Change-Id: I444466032621a65d4e176f3278e5b0bb6f7dad30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197867 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#768543}
-
Yulun Wu authored
App list folders should expand from the folder's origin.The bounds for the folder should be 8 dip from the edge of the screen and should not be limited by the app list container bounds. Bug: 1018305 Change-Id: I3597dbe96c697f5c268ddd9cc5157c62f7600f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197422 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#768542}
-
Karandeep Bhatia authored
Introduce the updateEnabledRulesets extension function which allows extensions to update the set of enabled static rulesets. This is a partial implementation and the set of enabled rulesets still needs to be persisted to prefs so that it is sticky across extension loads. BUG=754526 Change-Id: I5b8e76ef4cc5a3c1049131109057e4f20efc8d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186989 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
-
Alex Gough authored
See linked bug for rationale. This does not change functionality. Bug: 1065087 Change-Id: Id6e938b64594cc029f716270cfbb0435b9efacd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198373Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#768540}
-
Olya Kalitova authored
Introduces and adds UserPluginVmAllowed policy, that controls whether Plugin VM is allowed for a user. Policy handling will be added in the follow up CL. Will co-exist with the current PluginVmAllowed device policy. Test: browser_tests --gtest_filter="PolicyPref*" Bug: 1081744 Change-Id: Ic3f794d340215a69ba0ad6814326d1ddfff0bf73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199057 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
-
John Williams authored
The change allows a Presentation API to control a 1UA mode presentation. Bug: 1069126 Change-Id: I943293d884c77319f865273105cf93f0c6727ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186109 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#768538}
-
Wei-Yin Chen (陳威尹) authored
This reverts commit e87e4072. Reason for revert: compilation failure. See https://ci.chromium.org/p/chrome/builders/ci/arm64-builder-rel/21384. Original change's description: > [Offline indicator v2] Add metrics > > Bug: 1068727 > Change-Id: I5470452fcdfd5d9b7310e65802ef2867326fb27a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191376 > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/master@{#768507} TBR=bcwhite@chromium.org,twellington@chromium.org,sinansahin@google.com Change-Id: I04a42405e1803ca808e7465589d31dc8940fa9f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1068727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199988Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#768537}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8355052cad11..0a227c84a559 git log 8355052cad11..0a227c84a559 --date=short --first-parent --format='%ad %ae %s' 2020-05-13 paolosev@microsoft.com Make DWARFSymbolServer build on Windows Created with: gclient setdep -r src/third_party/devtools-frontend/src@0a227c84a559 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id1678c6de07662c77f04eb712f6b8a99e62840d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199661Reviewed-by:
-
Dominic Schulz authored
We don't need to check if a URL is "HTTP" and then also check that it's not "chrome://" Bug: 1044855 Change-Id: Idf843951668d88de831dfe28a4f567f0b9717893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2185832Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Dominic Schulz <dominicschulz@google.com> Cr-Commit-Position: refs/heads/master@{#768535}
-
Tibor Goldschwendt authored
Logs - NewTabPage.Promos.LinkClicked - NewTabPage.Promos.RequestLatency2 - NewTabPage.Promos.RequestLatency2.Failure - NewTabPage.Promos.RequestLatency2.SuccessWithoutPromo - NewTabPage.Promos.RequestLatency2.SuccessWithPromo - NewTabPage.Promos.ShownTime on chrome://new-tab-page and extends and updates ownership of the metrics. Fixed: 1072874 Change-Id: Id22a10e4e376d987607a5795ffdd42631d0120cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197997 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#768534}
-
Dana Fried authored
external/wpt/pointerevents/pointerevent_capture_mouse.html is failing in blink_web_tests on WebKit Linux Leak Bug: 998948 Change-Id: I32248d6cf9183605a4fd5b5ebaf959af6179a75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200007 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#768533}
-
Erik Chen authored
Setting the switch will cause ash-chrome to launch the lacros-chrome binary from the given path rather than from component updater. Bug: 1077348 Change-Id: I50f5a1be84c31df434b37997007112e7c1296767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200078 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Alex Gough authored
This should not change behaviour. TEST=Manual browser_tests.exe --gtest_filter=EdgeImporter* Bug: 1065087 Change-Id: Ia67cd29625ff34575682da57a45ab68bd3104d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196838 Auto-Submit: Alex Gough <ajgo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#768531}
-
Muyao Xu authored
appParams is encoded in the presentation URL by the sender SDK in JSON format, and is passed to Cast MRP as a string. Bug: b/153748066, 1074358 Change-Id: I3e62baa4ebad7b73e026e3ac73a5db38c9425e63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166132 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#768530}
-
Anatoliy Potapchuk authored
We want the spoken feedback user to be notified about what what happens when the user presses the "change position" button on the floating menu. Bug: 1061068 Change-Id: Ib1c6a70f7d94825ee057e1d7fa2406b569a84564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199262 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
-
