- 16 Apr, 2018 40 commits
-
-
Eric Karl authored
After discussion with mariakhomenko@, we decided to leave this feature enabled despite some expected regressions. This change will allow us to disable this feature via Finch if any unexpected results appear as this rolls to stable. Bug: 825589 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I46506aa8807e1c10f0833e414253d1df11cf1382 Reviewed-on: https://chromium-review.googlesource.com/1014285Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#551095}
-
Anita Woodruff authored
- Previously when displaying and getting notifications the promise resolver was always converted to callbacks, for the legacy IPC code which needed to store these callbacks in a map. - Mojo renders a callback map unnecessary, so this patch refactors the code to avoid the conversion when the Mojo pathway is taken. Bug: 796991 Change-Id: I216730c06fdb42a3c2c9fe21708252cb652e8b6b Reviewed-on: https://chromium-review.googlesource.com/1011422 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#551094}
-
Justin Novosad authored
This reverts commit 613f5543. Reason for revert: Breaks fast/webgl/canvas-toDataURL-premul-overflow.html on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/43191 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/17758 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20(dbg)/11632 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.10/45887 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11/31889 https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.12%20(retina)/328 Original change's description: > Reland "Use new Skia GPU read/write pixel code paths" > > This reverts commit 56044665. > > Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData. > > Original change's description: > > Revert "Use new Skia GPU read/write pixel code paths" > > > > This reverts commit f17c70fe. > > > > Reason for revert: > > > > It looks like this change: > > > > slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne (crbug.com/825594) > > > > slowed down getImageData and putImageData for the HTML5 Canvas across the board (crbug.com/825585) > > > > Bug: 825594 > > Bug: 825585 > > > > Original change's description: > > > Use new Skia GPU read/write pixel code paths > > > > > > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992 > > > Reviewed-on: https://chromium-review.googlesource.com/973267 > > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#544777} > > > > TBR=bsalomon@chromium.org,robertphillips@google.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565 > > Reviewed-on: https://chromium-review.googlesource.com/980292 > > Reviewed-by: Robert Phillips <robertphillips@google.com> > > Commit-Queue: Robert Phillips <robertphillips@google.com> > > Cr-Commit-Position: refs/heads/master@{#545787} > > TBR=bsalomon@chromium.org,robertphillips@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 825594, 825585 > Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093 > Reviewed-on: https://chromium-review.googlesource.com/1014140 > Reviewed-by: Brian Salomon <bsalomon@chromium.org> > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551022} TBR=bsalomon@chromium.org,robertphillips@google.com Change-Id: I0dd6db48f1c55d869de88e2fbca963c2c0cde0ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825594, 825585 Reviewed-on: https://chromium-review.googlesource.com/1012796Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551093}
-
Sidney San Martín authored
This crashes consistently on 10.12 when draggingFrame isn't set. Bug: 826632 Change-Id: I9b1aec6804c0f5205cd2a471787cc296d943ff91 Reviewed-on: https://chromium-review.googlesource.com/1014361Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551092}
-
James Cook authored
This is part of moving ash out-of-process for mustash. * Introduce FirstRunHelper mojo interface * Make ash::FirstRunHelper object owned by ash::Shell * Add explicit create/close widget methods because object is now persistent * Add system tray test API to check if bubble is open Next step is to move the widget creation into chrome. Bug: 756057 Test: ash_unittests, browser_tests Change-Id: Ie3994bd36b6dfeecd1c685773c5ce8e19394052e Reviewed-on: https://chromium-review.googlesource.com/998181 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551091}
-
Peng Huang authored
Bug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia388f02926202777ac9c7461715947ed97e2082b Reviewed-on: https://chromium-review.googlesource.com/1011675Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551090}
-
rbpotter authored
Chrome OS local destinations need to be set up before they can be selected. Add the logic to request setup from the handler and select the destination only when configuration is complete. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iccfacad27bac15182abbfeb47f4ec9f274b46fa6 Reviewed-on: https://chromium-review.googlesource.com/1012191 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551089}
-
Steven Bennetts authored
Bug: None Change-Id: I93b4d00f99cf355c41365de52e5288219d47258a Reviewed-on: https://chromium-review.googlesource.com/1014292Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#551088}
-
Antoine Labour authored
They are only created in ResourceProviderTest, not used in production. Also remove ScopedWriteLockGpuMemoryBuffer and helper functions in LayerTreeResourceProvider. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8ddd10fe5c0f86f994dbfeb966200154304d8432 Reviewed-on: https://chromium-review.googlesource.com/1011558 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#551087}
-
khmel@google.com authored
This prevents crash when user tries to download pdf document from Play Store ToS. Test: Manually Bug: b:64117707 Change-Id: I965a760b0bdef2c1167a8007822ed7c9a2b353c6 Reviewed-on: https://chromium-review.googlesource.com/1009111 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#551086}
-
Jiaquan He authored
This commit is a preflight CL for app list search migration. It passes into every search result a pointer to the model updater, so that changes to search results can be synced to Ash. Bug: 733662 Change-Id: I6ff93636248e48ed0d012da512e440b8511a9d22 Reviewed-on: https://chromium-review.googlesource.com/999295 Commit-Queue: Jiaquan He <hejq@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Charlie Harrison authored
This CL changes the test to: - Use the default timer to push load state updates, which should deflake the test. This is accomplished using a WebContentsDelegate. - Tests the actual LoadState, not just the host. The test was currently flaking due to the update + ACK refactor which wasn't compatible with the test. Bug: 830991 Change-Id: I4d788e7a7388617af39f0981bd84fc7d1da6a87c Reviewed-on: https://chromium-review.googlesource.com/1009287Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#551084}
-
Greg Thompson authored
This CL provides an OsStackTraceGetterInterface implementation for Google Test that uses Chromium's base::debug. This allows Google Test to emit stack traces to make debugging test failures a bit easier. As a result, failures that once looked like the following will now include stack traces: [ RUN ] UpgradeDetectorImplTest.TestPeriodChanges unknown file: error: Uninteresting mock function call - returning directly. Function call: OnUpgradeRecommended() [ FAILED ] UpgradeDetectorImplTest.TestPeriodChanges (3 ms) BUG=none R=dpranke@chromium.org Change-Id: I992d807cc654104d0bad461fda8cb82c86e6e9f8 Reviewed-on: https://chromium-review.googlesource.com/1009947 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#551083}
-
Manuel Rego Casasnovas authored
This reverts commit 092113c3. Reason for revert: It's causing big performance regressions on CSS Grid Layout perftests. BUG=832078 Original change's description: > [css-grid] Initialize OverrideContainingBlock size for grid items > > This patch removes the grid logic from > LayoutBox::ContainingBlockLogicalWidth|HeightForContent(). > Instead it initializes the OverrideContainingBlock size to zero > in LayoutGrid::UpdateBlockLayout(). > > For grid items we don't want to use the grid container size > (which would be the regular containing block size), > so we want to use the overridden value. > And while we don't have such value, it's better we use zero > (so percentages are not resolved against the wrong thing). > > This change is covered by existent tests. > > Change-Id: If6a96abe7148203a2cdb9ffb2b9dd487239f7aae > Reviewed-on: https://chromium-review.googlesource.com/989734 > Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Sergio Villar <svillar@igalia.com> > Cr-Commit-Position: refs/heads/master@{#549461} TBR=jfernandez@igalia.com,rego@igalia.com,svillar@igalia.com,ikilpatrick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I17fb8ebc78e88c0c91c5802862402ea3689385d9 Reviewed-on: https://chromium-review.googlesource.com/1014120Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#551082}
-
Ria Jiang authored
Bug: 833234 Change-Id: I814fc6c736f2fb89cbe32a336fd32a97ac4f4f28 Reviewed-on: https://chromium-review.googlesource.com/1014353Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#551081}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4de5d3e6. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15652 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I5b07544cec805ab34c86f3f690c7581b0fa52189 Reviewed-on: https://chromium-review.googlesource.com/1012867 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551080}
-
Toni Barzic authored
Removes the following events: systemPrivate.onVolumeChanged systemPrivate.onBrightnessChanged systemPrivate.onScreenUnlocked systemPrivate.onWokeUp None of them seem to be used. Additionally, code that dispatches all listed events except systemPrivate.onVolumeChanged has been unreachable for some time. Bug:658006 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I104873a45b3274a7105215dd906881065a962527 Reviewed-on: https://chromium-review.googlesource.com/967421Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#551079}
-
Khushal authored
When using an unaccelerated canvas with a compositor using Gpu raster, each canvas update is rasterized to a bitmap pushed into a paint recording. This bitmap is uploaded and cached by cc's GpuImageDecodeCache. Since the canvas is frequently updated, it is common for the Gpu cache to use and keep the discardable texture memory to capacity. Avoid the above situation by actively deleting canvas snapshots in the Gpu cache. PaintImages from a canvas instance use a stable PaintImage::Id and update the PaintImage::ContentId when an updated snapshot is created. This patch ensures that the Gpu cache keeps the max 2 ContentId entries for the same PaintImage::Id (pending and active tree), effectively ensuring we only have the last 2 canvas snapshots. Note that BitmapImage, for encoded images in blink, also uses an updated ContentId as more data is fetched for an image. This change will also ensure that we evict previous partially decoded frames for the same image. For play:media:soundcloud test case on my linux machine, this reduced cc's cache size from 236M to 30M. R=enne@chromium.org, ericrk@chromium.org Bug: 814219 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I888155ae5504ece6ab73981f320515478d87917d Reviewed-on: https://chromium-review.googlesource.com/987194 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#551078}
-
Erik Chen authored
Change-Id: I3fad62b20d8cde691625d56d24639551bc00483b Reviewed-on: https://chromium-review.googlesource.com/1014362Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551077}
-
Parastoo Geranmayeh authored
Problem: On the last run to determine heuristics we do not consider the overall server type detections, and we only rely on field types detected by heuristics. Since the ultimate filling decisions are based on the overall detection, we need to use overall type detection. As in section identification this can sometimes cause an incorrect output. Exp: In the cabelas.com payment section, the heuristics detect card holder name as the address name, whereas the overall type is detected correctly. The sections are thus wrong. Solution: Update the form from the cache, before determining the heuristics for the last time. Test added. Bug: 831739 Change-Id: Ifdecfa442a21d38b53169c8dafc981ca5447629b Reviewed-on: https://chromium-review.googlesource.com/1012980Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#551076}
-
https://skia.googlesource.com/skia.git/+log/43f6d4516b03..ffbe93296838 $ git log 43f6d4516..ffbe93296 --date=short --no-merges --format='%ad %ae %s' 2018-04-16 liyuqian Revert "Cumulate deltas even if they're out of the clip" 2018-04-15 csmartdalton ccpr: Normalize the cubic inflection function instead of its roots 2018-04-05 herb Remove all notion of transport from the API - V2. 2018-04-16 robertphillips Unblacklist fixed tests on DDL3 bots 2018-04-16 mtklein skcms→019d877 add a basic profiling mode to src/Transform.c 2018-04-16 bsalomon Make TestCase class in GrShapeTest heap allocate its GrShapes 2018-04-16 borenet Revert "[infra] Run recipes through Kitchen" 2018-04-16 borenet [infra] Run recipes through Kitchen 2018-04-16 angle-skia-autoroll Roll third_party/externals/angle2/ 152152618..76b2c3852 (1 commit) 2018-04-15 rmistry Increase android compile timeout 2018-04-15 reed show flatness vectors in sample 2018-04-15 update-skps Update SKP version 2018-04-14 egdaniel Revert "Delete getRenderTargetHandle call on SkSurface." 2018-04-13 liyuqian Cumulate deltas even if they're out of the clip 2018-04-14 rmistry Reland "Whitespace change" 2018-04-14 angle-skia-autoroll Roll third_party/externals/angle2/ 983c429fa..152152618 (7 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Icf073f40e8ddc00173b172b00dfa33b679032a8f Reviewed-on: https://chromium-review.googlesource.com/1014186 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551075}
-
Bailey Berro authored
This change applies the migration of crrev.com/c/976394 to the addSmbShareDialog. Bug: 818279 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic40afe345c38d4e776afb15f7e0fdb761f6906c0 Reviewed-on: https://chromium-review.googlesource.com/1003632Reviewed-by:
-
Andrew Grieve authored
Addressing review comments from TBR'ed: dd5d5a01 Change-Id: Ic181c0da49f82031bf842ce69a05d14144dd92f8 Reviewed-on: https://chromium-review.googlesource.com/1014293Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#551073}
-
Lei Zhang authored
That is what all the callers want to pass in. Change-Id: Ib4d815fed86e9a5d2be88aba1b958405d3ba881c Reviewed-on: https://chromium-review.googlesource.com/1013285Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#551072}
-
Jandro Alderman authored
It is currently possible to trigger a segfault using GetContentRenderingTimeoutFrom() if other's timeout is nullptr. R=samans@chromium.org Change-Id: I455ef5e45357efb048199549d3d8f7313c37bc33 Reviewed-on: https://chromium-review.googlesource.com/1010702Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Jandro Alderman <aalderman@chromium.org> Cr-Commit-Position: refs/heads/master@{#551071}
-
Asanka Herath authored
This change adds a .gitattributes file at net/data/fuzzer_data to treat everything below that as binary files. Doing so prevents Git from trying to fix line endindgs for these files. The files in question are fuzzer seed corpuses. R=mmenke@chromium.org Change-Id: Ic9ad25cbe194137672e7542000190a27654f7dd5 Reviewed-on: https://chromium-review.googlesource.com/1007764Reviewed-by:
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb18-08.html BUG=412078 TBR=jschuh@chromium.org NOTRY=true Change-Id: Iffe4499aeadaf27f5bbbe41c6453cb6c926f90a0 Reviewed-on: https://chromium-review.googlesource.com/1013154 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#551069}
-
James Hawkins authored
R=hansberry@chromium.org, tbarzic@chromium.org Bug: none Test: none Change-Id: I95ff12bf273e961ee5451d0be1d6a3ec1c2034ea Reviewed-on: https://chromium-review.googlesource.com/1013050 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#551068}
-
Antonio Gomes authored
CL migrates CustomizationWallpaperDownloader away from URLFetcher et al to use SimplerURLLoader (network services). In the associated browsertests** it also simplifies the implementation a lot by making use of EmbeddedTestServer rather than the URLFetcher and FakeURLFetcherFactory machinery. **customization_wallpaper_downloader_browsertest.cc BUG=773295 TEST=CustomizationWallpaperDownloaderBrowserTest.* Change-Id: I881ccb8749377a0043f15edfe20c223c57c5ea51 Reviewed-on: https://chromium-review.googlesource.com/1012877Reviewed-by:
-
Peter Boström authored
Optimizes a significant number of .png files and cuts ~3.6M in total. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I53a951a6410839c3b21f7155f22e2fedb3fb963f Reviewed-on: https://chromium-review.googlesource.com/1012263Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#551066}
-
John Chen authored
While handling Target.detachedFromTarget events, check that the target_id exists in frame_to_target_map_ before using the target. Change-Id: I84d41913bdc2df02338f725eef2b0a513c0c5d4d Reviewed-on: https://chromium-review.googlesource.com/1013613 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#551065}
-
David Valleau authored
This change checks the interfaces on a detected USB printer to see if any of them support ipp-over-usb. A new flag has been added to the Printer class to indicate whether or not it does. Once the printer has been detected, in the event that we don't have a PPD for it and it supports ipp-over-usb then we set it up as an ipp everywhere printer. R=justincarlson@chromium.org, skau@chromium.org Bug: 768606 Change-Id: I38214e0ce4f8ecee262ae94ac548cd79626f8a82 Reviewed-on: https://chromium-review.googlesource.com/842691 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#551064}
-
Ryan Sleevi authored
SSLConfigServiceManager was moved into //components/ssl_config to support iOS, but the only configuration is based on LocalState prefs, which are neither set nor glued up to any device management policies. This can all be uplifted back into //chrome. On the //chrome side, the switches and prefs are unified back into the general //chrome switches and prefs files, rather than being dedicated. On the //ios side, all of the Profile-specific SSLConfig is removed, and instead a default SSLConfig is used. BUG=831193 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I64908cdd17612ad2938f6bf0a3a5477dcec13122 Reviewed-on: https://chromium-review.googlesource.com/1004919Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Michael Thiessen authored
Treat standalones as supporting everything, but when we try to enter browsing mode, exit VR, dropping to the 2D-in-VR path. Bug: 803202 Change-Id: I3b4e38b530257179f6351e542951ac0eebb956bd Reviewed-on: https://chromium-review.googlesource.com/1012922Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#551062}
-
bsheedy authored
Adds support for clicking on most VR browser native UI such as the URL bar, back button, and overflow menu. Currently does not support clicking on any of the 2D fallback UI or the VR keyboard. Bug: 826841 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I05fa5ce4aea06441652cfe8372b4f3d54edb0596 Reviewed-on: https://chromium-review.googlesource.com/1003894Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#551061}
-
Joy Ming authored
Currently the only way to get to the Downloads-related settings is by navigating through Chrome Settings. This CL adds a button into the downloads home top toolbar that allows the user to go directly to the Downloads-related settings. Screenshots: https://drive.google.com/file/d/1KDZJF8XoKpaBjj7jNZmgiHubEokGqHc6/view https://drive.google.com/file/d/1pV2M05Kpqh-xa3XcerZYDHHLbgW6rwqB/view https://drive.google.com/file/d/1mb6jOUZbPYVWvy2z5vATY4BrA6-a2LH6/view https://drive.google.com/file/d/1sBKowuMVTkY62dalrRGEDHX-DP6Tt3ky/view Bug: 792775 Change-Id: Ib92393fd30a231597bbda9a1d2c610fc46718cda Reviewed-on: https://chromium-review.googlesource.com/998827Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#551060}
-
Emily Hanley authored
Bug:779631 Change-Id: Ie71d9a22ab7dd0bead3e6fcb1347ce435dbededb NOTRY=true # CQ flake Change-Id: Ie71d9a22ab7dd0bead3e6fcb1347ce435dbededb Reviewed-on: https://chromium-review.googlesource.com/1011635 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#551059}
-
dpapad authored
Latest compiler version does not include Chrome's externs by default. They need to be explicitly included. Change log: https://github.com/google/closure-compiler/compare/8fc82299c45b0a33f19834222acda4850fd77bc0...5cae9b78a16a2655627733b66d1c686d5f547925 chrome.js: 7ef3422e1e87480d560247d75fee181b4cac24d9 chrome_extensions.js: 3a0b0052782af3f0bd3a5fe10bb568cdd769db4e -> 03c824e85e7b77bde4e7449ed3727608b05b2acc polymer-1.0.js: 55e962227e676cd30f81439573771326933aae54 -> 8f3b8c9354813ae0e2f186bf2f504cf3f3182a66 BUG=831004 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0db559ee9a198dadd3b23e57b835cc6b985540a9 Reviewed-on: https://chromium-review.googlesource.com/1006182Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#551058}
-
Derek Cheng authored
Race condition introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/724724 The crash is caused by a race condition, where the the renderer attempted to register another PresentationController to PresentationServiceImpl while there is still a (soon-to-be invalid) one already. When we moved the PresentationController implementation from PresentationDispatcher to blink::PresentationController, we are now creating/destoying the PresentationController across navigation (instead of having it long-lived in the PresentationDispatcher / RenderFrameImpl). The fix is to close all message pipes / Reset() in PresentationServiceImpl when a Mojo connection error is detected. This way, the PresentationServiceImpl will be in a clean state when the renderer connects to it again. This also fixes PresentationReceiver's behavior of obtaining a connection to PresentationService and immediately dropping it after calling SetReceiver(), which would let to Reset() getting called with this patch. To merge back to 66 (if possible) and 67. Bug: 832176 Change-Id: Ic7cd2601a107024143936fa9e1ae197505e4cf64 Reviewed-on: https://chromium-review.googlesource.com/1011289Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#551057}
-
Mitsuru Oshima authored
added UpdateImmersiveMode() which updates the immersive mode with the latest status and use it everywhere. This fixes the issue with activation. BUG=832765 TEST=covered by unit test. Change-Id: If1842e523d601dfba40973f5bf62459a7f7f86a6 Reviewed-on: https://chromium-review.googlesource.com/1012993 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#551056}
-
