- 26 Sep, 2014 40 commits
-
-
sammc authored
BUG=406487,416665 Review URL: https://codereview.chromium.org/603243004 Cr-Commit-Position: refs/heads/master@{#296931}
-
hjd authored
To pick up the asset fix at https://android-review.googlesource.com/#/c/108196/. BUG=391488 Review URL: https://codereview.chromium.org/603683008 Cr-Commit-Position: refs/heads/master@{#296930}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b71ff8c..5ce3b1a TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/608743002 Cr-Commit-Position: refs/heads/master@{#296929}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#296928}
-
vkuzkokov authored
Issue 387067 can be resolved by having port forwarding socket dependent on all other references to AndroidDeviceManager::Device. This requires for lifetime of AWS to be manageable in the first place. BUG=387067 Review URL: https://codereview.chromium.org/449883002 Cr-Commit-Position: refs/heads/master@{#296927}
-
mek authored
TBR=erikwright Review URL: https://codereview.chromium.org/607683002 Cr-Commit-Position: refs/heads/master@{#296926}
-
wuchengli authored
BUG=350197,402182 TEST=Run vainfo and VEA unittest on various Intel platforms. Review URL: https://codereview.chromium.org/603153002 Cr-Commit-Position: refs/heads/master@{#296925}
-
hjd authored
Chrome may access the CommandLine from Java in-between 'load' and 'initialize' which currently causes an crash since JNI is not ready until after initialize but the CommandLine is switched over to native after load (we moved the CommandLine switch to after load to fix a problem in the Webview). This fixes the problem for Chrome by moving the CommandLine switch back to after initialize but provides a method to cause the switch to happen early so the WebView problem can be fixed to. BUG=417053,331424 Review URL: https://codereview.chromium.org/598363003 Cr-Commit-Position: refs/heads/master@{#296924}
-
lliabraa authored
This value is always defined, but only true on iphonesimulator. BUG=417785 Review URL: https://codereview.chromium.org/595793004 Cr-Commit-Position: refs/heads/master@{#296923}
-
rsorokin authored
BUG=365354 Review URL: https://codereview.chromium.org/494633003 Cr-Commit-Position: refs/heads/master@{#296922}
-
dgozman authored
BUG=398049 Review URL: https://codereview.chromium.org/577923002 Cr-Commit-Position: refs/heads/master@{#296921}
-
kaliamoorthi authored
This CL adds a mechanism which can be used to make the python test server exit. BUG=417684 Review URL: https://codereview.chromium.org/607823002 Cr-Commit-Position: refs/heads/master@{#296920}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b7332a5..b71ff8c TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/604263002 Cr-Commit-Position: refs/heads/master@{#296919}
-
mcasas authored
Since @SuppressWarnings("deprecated") doesn't work for import statements, the only option is to use the fully qualified class path in every reference. To be sure, two deprecation warnings still remain, namely in the use of public abstract class VideoCapture implements android.hardware.Camera.PreviewCallback { That somehow is not covered by the suppression. TBR=qinmin@chromium.org BUG=398669 Review URL: https://codereview.chromium.org/605183002 Cr-Commit-Position: refs/heads/master@{#296918}
-
phoglund authored
This makes the test described in http://goo.gl/umvzMt run on Mac. It relies on Soundflower to loop audio from output to input so that rec picks up the right audio. The new gs resource files have been added to their respective buckets. Note: this patch doesn't enable the tests. I need to configure the bots first with sox and soundflower before I do that. BUG=418034 Review URL: https://codereview.chromium.org/611433002 Cr-Commit-Position: refs/heads/master@{#296917}
-
skyostil authored
Disable forwarding tasks to the Blink scheduler to avoid some regressions which it has introduced. BUG=391005,415758,415478,412714,416362,416827,417608 TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/609483002 Cr-Commit-Position: refs/heads/master@{#296916}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/2710d7a..b7332a5 TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/610563002 Cr-Commit-Position: refs/heads/master@{#296915}
-
achuith authored
BUG=416803 TEST=manual Review URL: https://codereview.chromium.org/593103002 Cr-Commit-Position: refs/heads/master@{#296914}
-
rob authored
settings in the content settings bubble. The reload infobar is no longer displayed when the media stream content settings change. Instead, a small hint is displayed in the bubble when it is re-opened after changing a media stream setting. This hint is always displayed when the camera/microphone permission changes. When the media device preference changes, the hint is only displayed if there was at least one active media capture. Also added a bunch of tests for the media menu because they had no test coverage. BUG=405522 TEST=ContentSettingBubbleModelTest.*Media* Review URL: https://codereview.chromium.org/588153003 Cr-Commit-Position: refs/heads/master@{#296913}
-
fdegans authored
This is a temporary workaround to make the bot green. Currently it fails with: Usage: lint-test-expectations [options] lint-test-expectations: error: no such option: --target TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=338338 Review URL: https://codereview.chromium.org/607803003 Cr-Commit-Position: refs/heads/master@{#296912}
-
hirono authored
Files.app: Always do fallback guessing mime type from file extensions when obtaining empty metadata from the backend. BUG=417978 TEST=Open files by using externalfile: scheme that runs the related code path. Review URL: https://codereview.chromium.org/603373002 Cr-Commit-Position: refs/heads/master@{#296911}
-
shreeram.k authored
According to specs img tag should have xml-role as img. BUG=417230 Review URL: https://codereview.chromium.org/592353004 Cr-Commit-Position: refs/heads/master@{#296910}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/4551312..2710d7a TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/605153002 Cr-Commit-Position: refs/heads/master@{#296909}
-
shreeram.k authored
Article tag and aria role article are not exposed with correct IA2 Role. Correct IA2 role for article is ROLE_SYSTEM_DOCUMENT. BUG=281890 Review URL: https://codereview.chromium.org/602353003 Cr-Commit-Position: refs/heads/master@{#296908}
-
nkostylev authored
Since primary user profile is loaded synchronously its session will always show up first. Once all users profiles have been loaded we'll switch to the session of the user that was active before crash has happened. BUG=409226 Review URL: https://codereview.chromium.org/594163002 Cr-Commit-Position: refs/heads/master@{#296907}
-
Per authored
TBR=viettrungluu@chromium.org BUG=418019 Review URL: https://codereview.chromium.org/609743002 Cr-Commit-Position: refs/heads/master@{#296906}
-
mtomasz authored
This patch moves the icon from the header to media controls. TEST=Tested manually. BUG=415426 Review URL: https://codereview.chromium.org/603273006 Cr-Commit-Position: refs/heads/master@{#296905}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/17c2127..4551312 TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/603393002 Cr-Commit-Position: refs/heads/master@{#296904}
-
perkj authored
Revert of Start building ui_base_unittests targets. (patchset #1 id:1 of https://codereview.chromium.org/600833002/) Reason for revert: Breaks Android waterfall. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Original issue's description: > Start building ui_base_unittests targets. > > This is in preparation for updating the buildbot code. First we need to > make sure we build those targets, otherwise buildbot will fail. > > BUG=331829,373148,299841,103304 > TEST=None > R=sky@chromium.org,maruel@chromium.org > > Committed: https://crrev.com/430fc906824927713d5a318afb50654e95b699b0 > Cr-Commit-Position: refs/heads/master@{#296877} TBR=cjhopman@chromium.org,sky@chromium.org,maruel@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=331829,373148,299841,103304 Review URL: https://codereview.chromium.org/603413002 Cr-Commit-Position: refs/heads/master@{#296903}
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#296902}
-
hirono authored
Previously drive paths are used to obtain 'externalfile:' URL and the URL is converted back to the drive path. The CL uses FileSystemURL instead of drive paths so that the app can generate external file URLs for other than drive files, and enables external file URLs for MTP and FSP volumes. BUG=367027 TEST=manually Review URL: https://codereview.chromium.org/589473002 Cr-Commit-Position: refs/heads/master@{#296901}
-
jamesr authored
This adds a few header-only targets which are useful for explicitly tracking our dependencies and propagating configs. R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/599283003 Cr-Commit-Position: refs/heads/master@{#296900}
-
eakuefner authored
The Page class was being declared in page/page.py which was creating problems for several module-level functions handling pages which were being declared (CL to follow). This CL kills page.py and moves the associated logic into page/__init__.py, in line with e.g. value/. R=dtu,nednguyen,chrishenry Review URL: https://codereview.chromium.org/556453003 Cr-Commit-Position: refs/heads/master@{#296899}
-
anand.ratn authored
Cleaning up weak_ptr_factory destruction order in "src/chrome/browser/ui" module. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Review URL: https://codereview.chromium.org/603383003 Cr-Commit-Position: refs/heads/master@{#296898}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/4a81f0d..17c2127 TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/607003002 Cr-Commit-Position: refs/heads/master@{#296897}
-
shreeram.k authored
main tag or aria role main is not exposed with correct IA2 role. The correct IA2 role for main is ROLE_SYSTEM_GROUPING BUG=417654 Review URL: https://codereview.chromium.org/601173002 Cr-Commit-Position: refs/heads/master@{#296896}
-
stanisc authored
Moving device_info* and local_device_info_provider.h to components/sync_driver and updating namespaces for the related classes from browsing_sync to sync_driver. Most of the changes are mechanical - trivial changes of header files and namespaces. There are just few less trivial changes: 1) I've removed GetClientName from DeviceInfo because it depended on content/public. Instead I've inlined GetClientName code (which is rather trivial) in two places where it was used, including supervised_user_registration_utility.cc. That required me to update DEPS file for supervised_user. There isn't anything new in reality - these dependencies already existed indirectly. 2) Added two extra parameters to DeviceInfoDataTypeController to avoid having direct dependencies on the browser. TBR=pkasting@chromium.org,yoz@chromium.org BUG=396136 Review URL: https://codereview.chromium.org/597423002 Cr-Commit-Position: refs/heads/master@{#296895}
-
anujk.sharma authored
This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Review URL: https://codereview.chromium.org/603893002 Cr-Commit-Position: refs/heads/master@{#296894}
-
ager authored
Revert of Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #1 id:1 of https://codereview.chromium.org/609713002/) Reason for revert: That revert was apparrently a really bad idea. Now all the bots are failing. Reverting the revert and hoping that will bring us back to one failing bot. Original issue's description: > Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #2 id:20001 of https://codereview.chromium.org/603563002/) > > Reason for revert: > Makes the webkit_lint step fail on android bots: > > @@@BUILD_STEP webkit_lint@@@ > > /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release > Usage: lint-test-expectations [options] > > lint-test-expectations: error: no such option: --target > < /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release > ERROR: process exited with code 2 > @@@STEP_FAILURE@@@ > > Original issue's description: > > Do not call run_webkit_tests.py in android buildbot scripts. > > > > Replace its usage by lint-test-expectations and run-webkit-tests, both > > scripts found in third_party/WebKit/Tools/Scripts. > > > > BUG=338338 > > TEST=None > > R=dpranke@chromium.org,cmp@chromium.org > > > > Committed: https://crrev.com/9c330bf94b161a4a19b1bcccb33b169843b4fd10 > > Cr-Commit-Position: refs/heads/master@{#296883} > > TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=338338 > > Committed: https://crrev.com/ce392c3ccf021a094e21ffa3ca3babeb313b4821 > Cr-Commit-Position: refs/heads/master@{#296892} TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=338338 Review URL: https://codereview.chromium.org/598083006 Cr-Commit-Position: refs/heads/master@{#296893}
-
ager authored
Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #2 id:20001 of https://codereview.chromium.org/603563002/) Reason for revert: Makes the webkit_lint step fail on android bots: @@@BUILD_STEP webkit_lint@@@ > /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release Usage: lint-test-expectations [options] lint-test-expectations: error: no such option: --target < /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release ERROR: process exited with code 2 @@@STEP_FAILURE@@@ Original issue's description: > Do not call run_webkit_tests.py in android buildbot scripts. > > Replace its usage by lint-test-expectations and run-webkit-tests, both > scripts found in third_party/WebKit/Tools/Scripts. > > BUG=338338 > TEST=None > R=dpranke@chromium.org,cmp@chromium.org > > Committed: https://crrev.com/9c330bf94b161a4a19b1bcccb33b169843b4fd10 > Cr-Commit-Position: refs/heads/master@{#296883} TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=338338 Review URL: https://codereview.chromium.org/609713002 Cr-Commit-Position: refs/heads/master@{#296892}
-