GitLab

A small refactoring. After the cl, the touchpad/keyboard is only
enabled/disabled when needed.

Bug: None
Change-Id: I1d247f48f8e65cb5345153cfca78efd321ea0280
Reviewed-on: https://chromium-review.googlesource.com/c/1344146
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610948}

This reverts commit 900ffcbd.

Reason for revert: Roll introduced significant netstack regression (though things were already flaky before that).

Original change's description:
> Roll Fuchsia SDK from ea00f9dcafd5 to 469421287ef1
>
>
> The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
>
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
>
>
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
> TBR=cr-fuchsia+bot@chromium.org
>
> Change-Id: Ifab9496a837c590c6ca525402d0c24eed4aa0f9c
> Reviewed-on: https://chromium-review.googlesource.com/c/1347081
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#610293}

Bug: 908125
Change-Id: I168b641b747a5f909ef8dd0296bffb9fe898a5a0
Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Reviewed-on: https://chromium-review.googlesource.com/c/1351454
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610947}

I recently added a few exports to chrome_elf.dll and I forgot to
update the arm64 .def file.

Change-Id: I977f61cd330d0059a652c639fdeb0b5506c40320
Reviewed-on: https://chromium-review.googlesource.com/c/1348857
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610946}

This CL encapsulates code that are related with overtime checking into
Timer class. This helps make the code cleaner and safer.

Bug: 228585
Change-Id: Id2d018b90a6976e39504914dd3f354a276b5601d
Reviewed-on: https://chromium-review.googlesource.com/c/1349714
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610945}

Bug: 903424
Test: steps in bug
Change-Id: I4ed9116d663da6da3c413dfd59efe2b7f83ba9a2
Reviewed-on: https://chromium-review.googlesource.com/c/1336057
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610944}

After a TWA client app is uninstalled or has its data cleared we show a
dialog that leads to Chrome site settings for the corresponding origin.
When there are multiple origins associated with the app, we go instead
to the "All sites" settings screen, where only the relevant origins are
displayed.

This is an alternative for the notification. For now, both solutions
are kept.

Change-Id: I4f970f7820812d6be7a7efba5996aedd0832d399
Reviewed-on: https://chromium-review.googlesource.com/c/1338106
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610943}

Bug: None
Change-Id: Ic2a6e5cddc397f03e4cad5b6e93132812cd27f3e
Reviewed-on: https://chromium-review.googlesource.com/c/1351493Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610942}

Replace "text-shadow" with "filter: drop-shadow()". This lets us remove
the manual title truncation and use "text-overflow: ellipsis" instead.

Also increase the title container height to 24px in order to allow for
larger font sizes.

Screencast: https://screencast.googleplex.com/cast/NDgyOTcwNjE2MzU4NTAyNHwyOTk3MzhjZi1iNw

Bug: 894000
Change-Id: Ibe46ea6ed269615fb6bf59044ccccce10fd91721
Reviewed-on: https://chromium-review.googlesource.com/c/1337431
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610941}

Bug: 907673
Change-Id: I5c355e2cba9398b919e6a14d6fb817332c43a0d2
Reviewed-on: https://chromium-review.googlesource.com/c/1351284Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610940}

We no longer use gyp, and this confuses people, see thread
"[chromium-dev] how to resolve this problems", the reply from Nov 24 2018.

Setting checkout_nacl to false in .gclient still stops running this hook.
OS=android in GYP_DEFINES used to skip this step too; this is no longer the
case.

Bug: none
Change-Id: Ic59c21150dff04580cf76c141a43713df58eb555
Reviewed-on: https://chromium-review.googlesource.com/c/1350200Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610939}

This reverts commit 27bd2d6f.

Reason for revert: Broke this bot:
https://logs.chromium.org/logs/chrome/bb/internal.client.clank/arm-builder/18748/+/recipes/steps/compile/0/stdout

Original change's description:
> Cronet: Simplify Android GN logic for srcjars by not using them
> 
> No need to zip up the generated source just to unzip it again :P
> 
> Bug: 908479
> Change-Id: Iac6982eb4b436a7e33c53b79f239fe2954fa4f11
> Reviewed-on: https://chromium-review.googlesource.com/c/1349871
> Commit-Queue: agrieve <agrieve@chromium.org>
> Reviewed-by: Paul Jensen <pauljensen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610889}

TBR=pauljensen@chromium.org,agrieve@chromium.org

Change-Id: I9daab0436aa1ff7605f427ab815adff711c0d59d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 908479
Reviewed-on: https://chromium-review.googlesource.com/c/1351575Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610938}

Changes Url to URL and adds an -IsURLNewTabPage helper.

Change-Id: If80a6e41d9b2d74ed5449550b49de1cb670bed07
Reviewed-on: https://chromium-review.googlesource.com/c/1350191Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610937}

This should allow us to determine which resolvers are not being properly
resolved or detached.

Bug: 873980
Change-Id: I44ead90aaf8b963b7380ba70c56c73ae2b7ad7d1
Reviewed-on: https://chromium-review.googlesource.com/c/1344822Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610936}

Additionally fixed extra WebStateObserver::TitleWasSet calls.

This makes session restoration behavior similar for both legacy
and slim navigation managers.

Bug: 877671
Change-Id: I2c0265914ed1a6738335efd031f752db9c0a295f
Reviewed-on: https://chromium-review.googlesource.com/c/1347316Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610935}

TBR=inferno@chromium.org,metzman@chromium.org

Bug: 539572
Change-Id: I600b9d777607f7b9be9e8e8065d3d2be029e138f
Reviewed-on: https://chromium-review.googlesource.com/c/1351280Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610934}

Bug: 904459
Change-Id: I2eee7eb9d0aa8ef432782d43f55e3c3f073a7b1f
Reviewed-on: https://chromium-review.googlesource.com/c/1347269Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Nik Bhagat <nikunjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610933}

Bug: internal b/117862002
Change-Id: Iae3c3ddd762bb8358e8a7b5bef68d5ba12743a67
Reviewed-on: https://chromium-review.googlesource.com/c/1318814Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610932}

This is follow up for
https://chromium.googlesource.com/chromium/src/+/7267171a528f001a5d097ea147544acb145f13e9

Bug: 867725
Change-Id: I1b8a59394acaadc4b741e7874592b090992185a5
Reviewed-on: https://chromium-review.googlesource.com/c/1350425Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610931}

This reverts commit 108147df.

Reason for revert:
FindIt suggests a 74% chance that this is the cause of the following issues:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/26833

Original change's description:
> Inherit the navigation initiator when navigating instead of the parent/opener
> 
> Spec PR: https://github.com/w3c/webappsec-csp/pull/358
> 
> Bug: 905301, 894228, 836148
> Change-Id: I43ada2266d42d1cd56dbe3c6dd89d115e878a83a
> Reviewed-on: https://chromium-review.googlesource.com/c/1314633
> Commit-Queue: Andy Paicu <andypaicu@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610850}

TBR=mkwst@chromium.org,andypaicu@chromium.org

Change-Id: If3ccf72cf8a4285926429f2855f32c1b0c606c5b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905301, 894228, 836148
Reviewed-on: https://chromium-review.googlesource.com/c/1351285Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610930}

This reverts commit 20b501c3.

Reason for revert:
FindIt believe with 74% confidence that it's the cause of these failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9835

Original change's description:
> Reland "v8binding: Do not hold a cross origin ScriptState in IDL callback function"
> 
> This is a reland of 756bea38
> 
> Original change's description:
> > v8binding: Do not hold a cross origin ScriptState in IDL callback function
> > 
> > Make IDL callback function not hold a ScriptState of its
> > creation context when it's cross origin from the incumbent
> > realm.
> > 
> > Not holding a cross origin ScriptState, there is much
> > less risk to access a cross origin context.
> > 
> > IDL callback interface will follow the same approach in
> > a separate patch.
> > 
> > Bug: 892755, 886588, 904218
> > Change-Id: Ie55b436fcc5f66f4ee053ef08ad98ea68fb3a2d6
> > Reviewed-on: https://chromium-review.googlesource.com/c/1314023
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#609662}
> 
> Bug: 892755, 886588, 904218
> Change-Id: I78ca7050e659cdb533ae09dab792bc699d2b48bf
> Reviewed-on: https://chromium-review.googlesource.com/c/1343881
> Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610820}

TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org

Change-Id: I21faed593e8bdaae31c86a11413b18d31ab38c45
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 892755, 886588, 904218
Reviewed-on: https://chromium-review.googlesource.com/c/1351424Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610929}

Per discussion w/ PMs, moving forward we'd like to use finch as a kill
switch for these rather than to enable them. This will prevent the user
from seeing nothing while they wait for their first flag sync.

Bug: b:119886923
Change-Id: Ic93d082f7c46eba4814750588fd89fa47328a67e
Reviewed-on: https://chromium-review.googlesource.com/c/1347619Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#610928}

Bug: b/77916222
Test: locally build and run on eve
Change-Id: If98c7ea10e1778626563587f58c0773351e8e485
Reviewed-on: https://chromium-review.googlesource.com/c/1341081Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Yue Li <updowndota@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610927}

Change-Id: Ia75e5ed83f814b6b6af3f4a87a03302a4e7f6dce
Reviewed-on: https://chromium-review.googlesource.com/c/1351072Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610926}

This is a cleanup CL. There is no functional changes.

R=oysteine@chromium.org

Change-Id: I4e8cdd9f401bb554987c8fb10edecc64b65f1bab
Reviewed-on: https://chromium-review.googlesource.com/c/1348852
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610925}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/89124cf9..344c43de

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0bc32d5f5676f71c62cc391ab9a78f371e187c4b
Reviewed-on: https://chromium-review.googlesource.com/c/1351269Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610924}

This is a reland of 36f90a0e

Original change's description:
> Use cast http connection in libassistant.
>
> Bug: b:118193766
> Test: Manual
>
> Change-Id: Ia0cd58e42761b35b9f7281344266505074d59936
> Reviewed-on: https://chromium-review.googlesource.com/c/1321956
> Commit-Queue: Yilei Li <yileili@google.com>
> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#607318}

Bug: b:118193766
Change-Id: Ice6e98bea5c1d97f538d7de98c4c799dc72788ae
Reviewed-on: https://chromium-review.googlesource.com/c/1337292Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yilei Li <yileili@google.com>
Cr-Commit-Position: refs/heads/master@{#610923}

These aren't causing failures today, but would with future changes I'm making.

* Be consistent about the root window passed to EventGenerator and the
  coordinate system used for points passed to EventGenerator.
* For WindowSelector close button tests, the window bounds have been transformed
  and potentially converted to containing rects.  To make sure mouse events
  properly hit the close button, click 5 pixels in from the right edge instead
  of 1.
* Fix copy-and-paste errors.

Bug: none
Change-Id: Ic8d36c32b1c6fe5569c02e86ab1f9c90d65ac78e
Reviewed-on: https://chromium-review.googlesource.com/c/1347583Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610922}

Fixes uses of Object::Set, Get, ToObject and GetPropertyNames in
content/renderer/pepper/ppb_var_deprecated_impl.cc.

Bug: v8:7283, v8:7286, v8:7279, v8:8238
Change-Id: I54b420f7173b23d241508ad697c0410c8ae45da6
Reviewed-on: https://chromium-review.googlesource.com/c/1349332Reviewed-by: Bill Budge <bbudge@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610921}

Build on PosInSet and SetSize functions in ax_node.cc to handle
invalid or erroneous assignment. SetSize should not allow decreasing
assignments, while PosInSet should not allow decreasing nor duplicate
assignments among nodes in the same container.

Change-Id: I07b0e9c493439aca9ef50ecfe3c3f5bbf7a7ce7a
Reviewed-on: https://chromium-review.googlesource.com/c/1343374
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610920}

TextClassifier provides methods for text classification via the ARC
container, one of these methods is classifyText(), this method expects
(among other params) a text to classify which needs to be non-empty.

This CL ensures that the provided text string is not empty before
passing it to the container, we already had a check in place but is
likely that converting the string could have messed with it.

Bug: b/119794258
Test: Build.
Change-Id: I155295c283e1f774f152483c8f5f009ded70baa3
Reviewed-on: https://chromium-review.googlesource.com/c/1344196
Commit-Queue: David Jacobo <djacobo@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610919}

Bug: 907660
Change-Id: Ic0b3916328d92a4989be0a9e3b2553986ab4f830
Reviewed-on: https://chromium-review.googlesource.com/c/1347618Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610918}

This CL fixes:
Consolidates TestShellObserver in window selector controller unittest and
TestOverviewObserver in window_selector_unittest. Removed two overlapping
tests.

Remove a TODO about bouncing a window, since a toast shows anyways.

Remove a enum for the header layout which is not needed anymore
because the header always fades in at the final location now. Previously
there was this enum to differentiate when the header animated with
the window, or when there was color on header which had to be slided
in.

Test: none
Bug: none
Change-Id: I7578b2809fda56b8f783875eef12f12ae6e57dd1
Reviewed-on: https://chromium-review.googlesource.com/c/1345536Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610917}

see: https://cs.chromium.org/chromium/src/base/metrics/user_metrics.cc?l=33

 TRACE_EVENT_INSTANT1("ui", "UserEvent", TRACE_EVENT_SCOPE_GLOBAL, "action", action);

R=oysteine@chromium.org

Bug: 867931
Change-Id: I27b80317c4fccc1bb27958a5c3d0439fd6d760c6
Reviewed-on: https://chromium-review.googlesource.com/c/1350193Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610916}

Simplify the browser tests by not checking for when the
experiment is disabled.

Also, add DCHECKs to the cc file to ensure that the
navigation predictor mojo binding object is
created only if the field trial is enabled.

Change-Id: I24189c75994e73a1f30d1a7aecc6d7bdaf4e8857
Bug: 903945
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1349873Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610915}

This CL changes browser process asynchronous hit testing so that if
the InputTargetClient returns a FrameSinkId for a RenderWidgetHostView
that has no children, it stops doing any further asynchronous queries
and accepts that as the current target.

It does not take into account whether the point being hit test is over
any of the descendant views, should any exist.

Test: SitePerProcessHitTestBrowserTest.*
Bug: 847604
Change-Id: Ic70a26c19a7e06cef86d2b5b0b91227589e14755
Reviewed-on: https://chromium-review.googlesource.com/c/1342771Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610914}

This change causes the cros-disks mount operation to be called with the
'nosymfollow' mount option if the FsNosymfollow Chrome flag is enabled.

R=stevenjb@chromium.org

Bug: 867807
Change-Id: I394a8c536b77146a0f2fe15c5fafda985f9a44a4
Reviewed-on: https://chromium-review.googlesource.com/c/1344933Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Micah Morton <mortonm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610913}

BUG=907517

Change-Id: I0d0d73d43ad7af5e2b3cf2091bc45fe782334347
Reviewed-on: https://chromium-review.googlesource.com/c/1349591Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#610912}

Bug: 907179
Change-Id: I1f66d659690027191a5c2d0d21f09abb2f2d82d0
Reviewed-on: https://chromium-review.googlesource.com/c/1347575Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#610911}

Bug: 907196
Change-Id: I760dc43fc5fd31aec1addc020190a568596b3109
Reviewed-on: https://chromium-review.googlesource.com/c/1344649Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610910}

When a RenderWidget is frozen, its compositor is stopped. However when
the main frame is being navigated, we want to start requesting mojo
pipes for the gpu and display compositor immediately so that it can
happen in parallel with the navigation loading.

Previously, we just always did this when creating a RenderWidget, and
left them active when freezing the RenderWidget. After 678f025f
however, we don't, and this causes time-to-first-pixels regressions
on navigation.

So we add a WarmupCompositor() method to RenderWidget, and call this
from RenderFrameImpl::CreateFrame() when it makes the provisional
frame, and the WebFrameWidget, since we expect to make use of the
main frame RenderWidget shortly.

Then, if RenderFrameImpl::FrameDetached() occurs, due to the
navigation failing, we will AbortWarmupCompositor() to drop the
mojo pipes instead of holding onto them indefinitely.

This recovers the loading regressions introduced, while also not
allocating mojo channels for frozen RenderWidgets indefinitely.

In order to do this reasonably, we drop the "callback" from the
request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that
it always returns something immediately. This way RenderWidget
does not need to worry about having a task run to collect the
new frame sink, and ordering with tasks from the compositor to
collect it.

R=piman@chromium.org

Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0
Bug: 905191
Reviewed-on: https://chromium-review.googlesource.com/c/1341073
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610909}