- 09 Aug, 2019 39 commits
-
-
Ben Pastene authored
It's reaching the 1hr timeout in some shards: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/14512 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/14509 Bug: 865455, 992200 Change-Id: If55fae6dc0151358d8e4b81b7d69261c2e45decb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745589Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ben Pastene (OOO on the 9th) <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#685445}
-
Scott Haseley authored
This CL implements the first part of the scheduler API prototype: 1) Adds IDL and classes for Task, TaskQueue, and Scheduler. 2) Adds window.scheduler instance tied to the Document's lifetime. 3) Implements basic postTask() related functionality: - Scheduler.postTask() - Scheduler.taskQueue() - TaskQueue.postTask() - TaskQueue.priority - Task.priority - Task.status - Task.cancel 4) Adds web_tests for the functionality in (3). For additional context, see the explainer (https://github.com/WICG/main-thread-scheduling/blob/master/PrioritizedPostTask.md) and the API proposal/design doc (https://docs.google.com/document/d/1xU7HyNsEsbXhTgt0ZnXDbeSXm5-m5FzkLJAT6LTizEI/edit?usp=sharing). Bug: 979017 Change-Id: If49c4cbdc042c80f28797ad94876d3cde8f9411f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703091 Commit-Queue: Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#685444}
-
dpapad authored
Currently no |data| attribute is exposed from such targets, which results in a very messy situation, forcing all |data| to be added in chrome/test/BUILD.gn instead of chrome/test/data/webui/BUILD.gn, even though the |data| is generated by |deps| in chrome/test/data/webui/BUILD.gn. Example CL showcasing the issue http://crrev.com/r/1742832. Eventually a lot of current |data| entries in chrome/test/BUILD.gn should be moved as appropriate, for example entries like "//third_party/accessibility-audit/axs_testing.js", "//third_party/chaijs/chai.js", "//third_party/mocha/mocha.js", should only be used by pulled in via js2gtest() targets. Bug: None Change-Id: I4d9cdd1b03f6a3459d0c2e582eee97ca26e09a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745500 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#685443}
-
DongJun Kim authored
This patch is for replacing Platform::Current()->GetURLLoaderMockFactory() calls with TestingPlatformSupport's GetURLLoaderMockFactory() under "third_party/blink/renderer/core/" Bug: 751425 Change-Id: Ifd944b5a5ce743f281aa42b2ef92d917fcdeeeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567711 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#685442}
-
Honglin Yu authored
In the previous CL: https://codereview.chromium.org/2747673002, "RefCountedThreadSafe" has been used again but the comments were not updated and misleading. And RefCountedThreadSafe does not have virtual functions now. BUG=None Test=no test Change-Id: I5d9a31a2d0f3d62af8772813db4d34e7f725773d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742257Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Honglin Yu <honglinyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#685441}
-
Gayane Petrosyan authored
- aria-label, aria-pressed, role="button" should all be on the same element. This will avoid vocalizing 'group' and will have a correct order of strings, e.g. label, selected, toggle button - always have aria-pressed and default to false, so that buttons are always considered toggle buttons, otherwise it will be just a button before selection and toggle button after the selection. Bug: 992059 Change-Id: I16de081e5f3b65b5ea13a25e54234a48dc6f602c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745047Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#685440}
-
Jared Saul authored
Was fully launched in M75 (non-iOS) and M76 (iOS) and is already set to ENABLED_BY_DEFAULT. Change-Id: I3db6d2ca7256b91d7d924560c89c3df5245da148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745551Reviewed-by:
Anne Lim <annelim@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#685439}
-
cjamcl@google.com authored
Also changed the limited run to use PWA, since just rendering that category results in errors w/o the changes in this patch. Bug: 962618 Change-Id: I79a83d16f65f04931cdeb376bd88a92eba545e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745287Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#685438}
-
David Staessens authored
This CL adds a test to the video_decode_accelerator_tests to test video decoder initialization. Correct initialization behavior is already verified by other testcases, but it's a good idea to have an explicit 'initialization' testcase. TEST=ran new VD tests on eve BUG=988929 Change-Id: I91a6093153d6fe618a7dff478a864d2726b6f1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736933 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#685437}
-
Chris Harrelson authored
If a LayoutUnit's size is equal to the maximum, then it returns true for HasFraction. Rather than slow down that method (which is used in non-debug code), add in defensive code to avoid a DCHECK false-positive. Bug: 988101 Change-Id: I48ab19a70d13f4c4aa537a3caae64a550342b676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745775Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#685436}
-
tby authored
Our app ranking experiments are changing in M78 and so this CL renames a flag to represent what we're doing. Once some legacy code is cleaned up, the EnableZeroStateAppsRanker flag will also be removed. Bug: 989350 Change-Id: Ia555a00accb10d97f75403784364d610047ffe02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732655Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#685435}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/287bff32f45e..5e4af85c4796 git log 287bff32f45e..5e4af85c4796 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9230e75a..6fb8f3c6 (685264:685365) Created with: gclient setdep -r src/third_party/webrtc@5e4af85c4796 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iaadb1e1d1dbc0d0c2f9fde0470c858c5f632f7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745518Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685434}
-
Theresa authored
The Espresso matcher previously used caused the test to pass on KitKat but fail on newer versions of Android. Update the inRoot matcher to more generically find any view not in the main activity DecorView. BUG=990135 Change-Id: Ief50297d5e203dbee7506897f2684b10ae1a070e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743031 Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#685433}
-
Aaron Gable authored
This is a reland of 89a993e4 The original was reverted because other bots were still trying to trigger this one, and were therefore failing. This reland should be safe after crrev.com/c/1743046 lands. Original change's description: > Remove linux-blink-heap-unified-gc builder > > The feature has been enabled chrome-wide, and no longer > needs a dedicated testing config. > > TBR: jbudorick > Bug: 990730 > Change-Id: I2ad03431104cf69367e3ec72f2fbdfac1e5d436e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736003 > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Aaron Gable <agable@chromium.org> > Auto-Submit: Aaron Gable <agable@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684510} Bug: 990730 Change-Id: If1ada1656ad408951966a954a4abb8b6d29979b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743027Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#685432}
-
Josh Nohle authored
Adds metrics to track the execution times of async function calls during the CryptAuth v2 Enrollment flow. These values will be used for tuning timeout values. Bug: 899080, 933656 Change-Id: I8f4f1b47c7bfe45785b903d8d34f2ec2fa4b9b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742833Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685431}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e9fabf59160b..42e1bba480d1 git log e9fabf59160b..42e1bba480d1 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 enga@chromium.org Revert "Fix dynamic buffer offset issues on D3D12 backend" 2019-08-08 rharrison@chromium.org Rolling 5 dependencies Created with: gclient setdep -r src/third_party/dawn@42e1bba480d1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I9084c58068e28aba9c08121cf31c92087610ede7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745786Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685430}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ecc1e12f780d..0d0f321a86b9 git log ecc1e12f780d..0d0f321a86b9 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 evanhernandez@chromium.org cros_branch: Bump source branch version. Created with: gclient setdep -r src/third_party/chromite@0d0f321a86b9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I50a363b5bac445c5f6e0c0b086bfc09bee361017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745515Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685429}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b2c5a94b1c7a..4d557e3df433 git log b2c5a94b1c7a..4d557e3df433 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 robertphillips@google.com Revert "Fix exactify for explicit resource allocation" 2019-08-08 robertphillips@google.com Fix exactify for explicit resource allocation 2019-08-08 bsalomon@google.com fix skip-rectangle-texture-support in GrGLGpu::onWrapBackendTextureAsRenderTarget 2019-08-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-08 mtklein@google.com expand thread_local blacklist to all ARMv7 iOS 2019-08-08 nifong@google.com Make mskp job name parse correctly 2019-08-08 herb@google.com Allow SkMakeSpan to correctly handle the distinction between 2019-08-08 bsalomon@google.com Rework how backend-specific formats are retrieved from GrBackendFormat. 2019-08-08 halcanary@google.com experimental/editor: scroll on delete if necessary 2019-08-08 mtklein@google.com Reland "thread-local caches?" 2019-08-08 halcanary@google.com SkQP: Docker compile helper script respects SKQP_OUTPUT_DIR 2019-08-08 mtklein@google.com Revert "thread-local caches?" 2019-08-08 mtklein@google.com thread-local caches? 2019-08-08 egdaniel@google.com Remove use of GrColorType on GrCaps::getRenderTargetSampleCount. 2019-08-08 scroggo@google.com SkCodec: don't assume frameRect is valid 2019-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 415bb0cdb057..7424fe8b79c3 (7 commits) 2019-08-08 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps 2019-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3aec8a3be749..75efa7bb97a4 (2 commits) 2019-08-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2d05439f..2cf71a3e (449 commits) 2019-08-08 halcanary@google.com experimental/editor: mouse drag select, modifierkeys cleanup. 2019-08-08 egdaniel@google.com Remove AMD workaround for new command buffer on pipeline changes. 2019-08-07 bungeman@google.com Add Symbol encoding when renaming a font. 2019-08-07 halcanary@google.com SkQP: make_apk_list.py include pie-cts-dev branch 2019-08-07 bsalomon@google.com Modify GrGLTexture/RenderTarget and related functions to not take 2019-08-07 michaelludwig@google.com Simplify luminance shader 2019-08-07 jvanverth@google.com Remove invalid entry in RELEASE_NOTES Created with: gclient setdep -r src/third_party/skia@4d557e3df433 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: chromium:b/138674523,chromium:b/138674523,chromium:None,chromium:None,chromium:None Change-Id: Ia2da55ca04d5543fbb3d9c6444942eb9de9587e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745517Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685428}
-
John Lee authored
Bug: 965770 Change-Id: I39320b103719db85f6ad10dfcb0564c69d8b0514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745612Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#685427}
-
Dominic Farolino authored
This CL adds a histogram to count the number of prefetch requests that get redirected vs the number of prefetch requests in general. The goal is to collect some data to see how often prefetch redirects happen in the wild, since for privacy reasons, we're interested in changing the redirect mode of prefetch requests to ether kFollow or kManual. Bug: 988956 Change-Id: I30ca86dad106fbd35351f3e609a9d60ee01aad31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743237Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#685426}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1692cd34cc0..fd8f7d66cc6f Created with: gclient setdep -r src-internal@fd8f7d66cc6f The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: If62bd0f78d75bff89b84a6cead5dc33e06197c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745592Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685425}
-
Giovanni Ortuño Urquidi authored
Mojo JS Lite Bindings were recently renamed to align with the new C++ names. This CL changes usage of the old names with the new ones. See bug for more details. Bug: 968369 Change-Id: I83dd8b8a3275c06da10d6552fdce01b032f0692d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722138Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#685424}
-
Maggie Chen authored
Set the crash key to true in DeliberatelyTerminateToRecoverFromHang if OnWatchdogTimeout() is called for the first time after power resume. Bug: 949839 Change-Id: I15a734d5c8e0e641dfb3cc10c640c32edc7b0ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745611Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#685423}
-
Oksana Zhuravlova authored
This change adds BrowserInterfaceBroker support for binders with context (in this case shared and dedicated workers), as well as plumbing for shared and dedicated workers. It also converts FileSystemManager client in blink to use BrowserInterfaceBroker for all contexts (should be safe because shared workers don't use this interface). DedicatedWorkerHost now has its own header since it is used by browser_interface_binders.cc Bug: 985112 Change-Id: If412b07948a0ae7831ec109ae876b0b62ffc1125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721936Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#685422}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b8ec98fe171b..c9ba782a6fd4 git log b8ec98fe171b..c9ba782a6fd4 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 syoussefi@chromium.org Vulkan: Support atomic counter array of arrays 2019-08-08 ynovikov@chromium.org Suppress functional.fbo.*.repeated_clear.* dEQP tests on Win NVIDIA Vulkan Created with: gclient setdep -r src/third_party/angle@c9ba782a6fd4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: None Change-Id: I5d3cc3807a80138fe009e69df5f2733642fed10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744970Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685421}
-
Julie Jeongeun Kim authored
This CL converts AppBannerManager in the browser process, AppBannerManagerTest, and AppBannerController and BeforeInstallPromptEvent in blink to new Mojo types. Bug: 955171, 978694 Change-Id: Ic1dd9957fcfa800ad19d1c05c965fa1a52687277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732113Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#685420}
-
Fergus Dall authored
Currently we do this if we know we're not online and we need a major update, but if we fail after that check nothing is displayed to the user. This could happen if, for example, their network connection was dropped during the update. Change this to show the same dialogue on any install failure, since we expect most failures to be caused by network issues. Change-Id: I55541ceb3674cceb406fe357cb78b19ab29933e0 Bug: 990227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743440Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#685419}
-
Vikas Soni authored
Move MockCodecBufferWaitCoordinator in a separate file. This will be helpful in refactoring current media code to merge SurfaceOwner and TextureOwner which will requires reorganising and moving some files and unittests to different locations/directories. Bug: 989344 Change-Id: Ie25bad59174de86b5b4c623c9f94a365becdccce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744640Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#685418}
-
Yue Li authored
Don't show Assistant UI when the opt-in window is showing. Instead, bounce the opt-in window. Bug: b/131432454 Test: Manual Test Change-Id: I2d723be27709b5795cc1157e90b61cd9c96e97eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742300 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#685417}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5472a5a44c1c..30604c6c8ec1 git log 5472a5a44c1c..30604c6c8ec1 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 simonhatch@chromium.org Dashboard - Remove start_try_job and GuessStoryFilter Created with: gclient setdep -r src/third_party/catapult@30604c6c8ec1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:992110 Change-Id: I06487295fcc5a378fc40b8ad3a48d2491bce4585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685416}
-
Alexey Baskakov authored
Unify InstallFinalizer::CanReparentWindow for bookmark apps and web apps. Bug: 973288 Change-Id: Ia68c0ad708a793b6b236a47a4012947d111ab5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743686Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#685415}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/65b41192b9a7..64c217c797c4 git log 65b41192b9a7..64c217c797c4 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 treehugger-gerrit@google.com Merge "gen_amalgamated: Check that amalgmated code is identical across platforms" Created with: gclient setdep -r src/third_party/perfetto@64c217c797c4 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic62122eeb9ddb39fdbb557d96c4de69706b48031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745514Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685414}
-
Darren Tucker authored
CI/try builders migrated: - UBSan Release - UBSan vptr Release - UBSanVptr Linux / linux_chromium_ubsan_rel_ng Bug: 950413 Change-Id: Ia0164c34ac130a63e2534130e674cbdb59213479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743296Reviewed-by:
Ben Pastene (OOO on the 9th) <bpastene@chromium.org> Commit-Queue: Darren Tucker <dtucker@chromium.org> Cr-Commit-Position: refs/heads/master@{#685413}
-
James Cook authored
UX wants the icon back in OS Settings. This is a partial revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1709783 Screenshot: http://screen/ygVfqu1eVb7 Note that this is currently the device account icon. A follow-up CL will change the Chrome C++ code to send the primary GAIA account icon, which could be different. Bug: 990528 Test: added to browser_tests Change-Id: I983846c517763d64e5cf2830deb9334865d7a17a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745590 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#685412}
-
Kenichi Ishibashi authored
We won't maintain on-the-main-thread script fetch anymore. Bug: 967272 Change-Id: I4731b5f8988da1a959ea74971c6f68f766275e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745666 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#685411}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Icbfb599fb8e6336035ab0fae673923e67176f2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745591Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685410}
-
Danyao Wang authored
Finch config CL: https://critique.corp.google.com/#review/262012910 Bug: 991381 Change-Id: Ie2da3a72a7f00c0f9de194b57d03cc7373ecd58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740506 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Danyao Wang <danyao@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#685409}
-
Aaron Colwell authored
This combines the origin and URL checks to remove some duplicate and unnecessary checks. This will also make it easier to update the URL checks to handle non-standard URLs in a follow-up CL. - Inlines CanCommitURL() at the beginning and end of CanCommitOrigin() and removes redundant checks. - Rename CanCommitOrigin() to CanCommitOriginAndUrl() - Move kDisableWebSecurity check to the top of the function so it skips URL checks as well. This is the only functional change. Bug: 991607 Change-Id: Id8b9f52b594994c1a4c1c38a709ba3e4c0daffc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742836 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#685408}
-
yuanzhi authored
Bug: TEST-851 Change-Id: I7646f3902793811b81ad2a6c4b3807603536c603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737726Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Yuan Zhi <yuanzhi@google.com> Cr-Commit-Position: refs/heads/master@{#685407}
-
- 08 Aug, 2019 1 commit
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium cb6e9a3c. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: pwnall@chromium.org, jsbell@chromium.org: external/wpt/cookie-store NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0f6fd9c6c14d4975c0c616bbd8886d9b37ae3c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745266Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685406}
-