- 08 Jun, 2020 40 commits
-
-
Pavel Yatsuk authored
This reverts commit ce14e58b. Reason for revert: The CL causes failures on Cronet KitKat builders https://ci.chromium.org/p/chromium/builders/ci/android-cronet-kitkat-arm-rel The error code is INSTALL_FAILED_OLDER_SDK https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878029920810653312/+/steps/cronet_smoketests_missing_native_library_instrumentation_apk_on_Android_device_Nexus_5/0/stdout Original change's description: > Android: Increase default_min_sdk_version 19 -> 21 > > Cronet is the only project that requires a lower minSdkVersion. To > continue supporting building of their targets, this change enabled > proguard on all of their apks in order to have all files desugared at > the proper minApiVersion. > > This change should speed up compiles somewhat, as it removes the need to > generate main-dex-lists for legacy multidex purposes. > > Bug: 1091919 > Change-Id: Ifd8089bbf4965b55a13dea11464ccda979fd5028 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233581 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776166} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: Id4b92d5549d13de9684f542ce646993c3833795f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1091919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236715Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#776237}
-
Zach Trudo authored
The messages defined in record.proto will need to be available to the server and the future daemon. Moving to the appropriate location. Also - reporting_messaging_layer is far too long for a namespace. Renamed to simply reporting. :-D Bug: chromium:1078512 Change-Id: Idd14c07e548e0b937c2a64b4ff4a4ae771e6cc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235991 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#776236}
-
Brian Sheedy authored
Updates the expectations for WebGL2 shaderoperation tests on Windows Intel machines: 1. Applies the skip to both UHD 630 and HD 630 machines - previously it only applied to UHD 630 machines. 2. Removes the d3d11 tag, as this can apparently also happen when not using d3d11. TBR=ynovikov@chromium.org Bug: 1085222 Change-Id: Ifde543f4bc069a4d5116a9656dc39326fa973ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236456Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#776235}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 624f611c. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" 101c532f "[css-lists] Fix list image gradient with dynamic zoom" a8a28083 "[Security][Coop] Browsing context switch reporting WPT" ba95aee6 "Move where we set the root forced background-color" 9703ac7b "Portals: XFO sameorigin now traverses the portal hierarchy." 45e0194e "Revert "Disable tests for landing a WebRTC name change" and rebase changed tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I76f36c72383bf2ac0dc062ad9289bb2f167eed13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236334Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776234}
-
Eric Roman authored
Bug: 1089015 Change-Id: Ic68dc830c40deda61544ae772d22e1d10662e87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231094Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#776233}
-
David Black authored
Previously, the unittest could attempt to advance the mock clock by a negative amount which is disallowed by the framework. Bug: 1092026 Change-Id: I47ce0ecc69b4391cff08154138c001bf7062f69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236214Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#776232}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fee069880d16..7b1355e5093a 2020-06-08 johnstiles@google.com Revert "Reland "Move JavaInputStreamAdaptor into third_party and add a LICENSE file."" 2020-06-08 adlai@google.com Clean up SkShaper_coretext.cpp & SkCGBase.h 2020-06-08 jlavrova@google.com Dealing with another crash when some fonts are unresolved 2020-06-08 johnstiles@google.com Update Gr(Circle|Ellipse)Effect to use a child FP. 2020-06-08 herb@google.com move painter to GrRenderTargetContext from TextTarget If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I4802653157bfb065da6958f56340584006f9eda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236376Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#776231}
-
Dmitry Titov authored
TBR=altimin@chromium.org Bug: 1090223 Change-Id: I5a0641d62d9bddb0b9b060bcf426fa45dc2bf637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236050 Commit-Queue: Dmitry Titov <dimich@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#776230}
-
Mehran Mahmoudi authored
This CL implements the integration needed for paint previews to show on a cold start. This feature is guarded behind an experimental flag that is only intended for the Canary/Dev channels. PTAL at the design doc for more context: http://go/fdt-tab-integration Bug: 1064011 Change-Id: I91bd682f32eccb8e22b27ec026f04079fd6fc250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231179Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#776229}
-
Andy Paicu authored
https://testtracker.googleplex.com/testplans/details/33023?revision=10 The link above describes the currently existing manual tests related to the permission prompts. As part of the review process, I've implemented the tests from section 1.3. Bug: 1063164 Change-Id: I30b1268fe010ee450afe440ac610cdc6fa3b9fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218169 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#776228}
-
Will Harris authored
This is a critical stability metric. Also add second owner. BUG=1053151 Change-Id: Id365c7b882542d5be37b57e53c5fbc25d8e54149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236063Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#776227}
-
Jonah Chin authored
This change introduces GetRasterSkImage() for use when an image's pixels are needed in CPU memory for raster. The goal is to remove GetSkImage() from PaintImage since, when texture backed, this API will incur the cost of a GPU to CPU readback. GetRasterSkImage() makes it clear that this readback may happen. Follow up changes will work on converting the remaining callers of GetSkImage() to other APIs. For details about this overall PaintImage effort, see crbug.com/1023259 This is being done as part of the OOPR-Canvas2D project. For more info about that project see the tracking bug here: crbug.com/1018894 Bug: 1031050 Change-Id: Iae075b4c5d936ac7c6f3db578e6ef5c47b99ffd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226922Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#776226}
-
Mikel Astiz authored
It's rarely inspected and after having deleted the Directory-based logic the remaining codepaths are either dead, very unlikely or covered by other UMA metrics. Change-Id: I3b266263a1c974738b6c1647115ca845733c825a Bug: 1089547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231123Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#776225}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I81353282f2c9e22d324b7a6a783ab569c36d765b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236240Reviewed-by:
-
Sergey Ulanov authored
Tests started flaking around the 0.20200605.1.1 roll due to a pkgsvr issue. TBR=wez@chromium.org Bug: 1092054 Change-Id: I09f7c9c16c7d2f44324af5383f3131d37a3ddccb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235839 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#776223}
-
Adam Langley authored
This is a test-only, non-semantic change that renames a parameter in the attestation tests to better reflect what it's used for in reality. (This is cut out of enterprint-attestation support to reduce diff noise.) Change-Id: If9cea22bc88085e7318c61c8ee40bfd358f67d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236229 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#776222}
-
Victor Hugo Vianna Silva authored
This CL is simply the analogous of crrev.com/c/2218055 for password exceptions. This means it changes the signature of this helper function to: a) make it easier to write tests in a multi-store scenario; b) allow the deduplication functionality to be introduced without breaking the existing tests. Besides that, the CL fixes a comment typo in validatePasswordList() and also exposes chrome.passwordsPrivate.removeExceptions() API in the PasswordManagerProxy, so it can later be used at PasswordsSection when exceptions are deduplicated. TBR=fhorschig@chromium.org Bug: 1049141 Change-Id: I3a501283c964904b981a6e2463336f4f147816bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2234755 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#776221}
-
Elly Fong-Jones authored
Specifically, change it from BubbleDialogDelegateView* to BubbleDialogDelegate*, to allow subclasses of PageActionIconView to not subclass BubbleDialogDelegateView*. This is a prelude to splitting LocationBarBubbleDelegateView into a LocationBarBubbleDelegate class (which is not a View, and will subclass BubbleDialogDelegate, not BubbleDialogDelegateView) and the existing class. Bug: 1075649 Change-Id: Iee1ac0d45c2c98bce6b460910d1af3e2990bad86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232742Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#776220}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/355e6449e7fd..dcb5c85b51e1 2020-06-08 vadimsh@chromium.org [lucicfg] Update to 1.15.0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic798b0ad91a01ca7fa08cca577837b681923c744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236317Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1e53576f0a3f..3ae59d04d192 2020-06-08 jophba@chromium.org Improve ReceiverSession test coverage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Iebe2f7546db18bcd190f3f67dcda7d2530325210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236373Reviewed-by:
-
Andrew Grieve authored
lld's partitions logic requires -fdata-sections, -ffunction-sections, and --gc-sections. For debug non-component builds, --gc-sections was missing. Bug: 1055945 Change-Id: Iac21d90f4158cae1c392c37f9fd4e5d8be9d5f0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233690 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#776217}
-
Tommy Li authored
Currently, there's all three methods: 1. SetSelection 2. SetSelectedLine 3. SetSelectedLineState SetSelection calls both SetSelectedLine and SetSelectedLineState. That has worked well so far, but this will cause a problem for section headers. The problem is: SetSelectedLine is what updates the textbox inline autocomplete. With Headers, we may need to update the inline autocomplete when the line state changes (from header to match), rather than when the line number changes. Philosophically, I think this is also a good change, because in the omnibox code, there should be one, and preferably only one, obvious way to do something. This CL is not intended to change any user facing behavior but it does change some of the logic of what happens in some circumstances or in what order. So it's possible that some unanticipated changes may arise. If so, they will be addressed in subsequent CLs. I'll fix the actual inline autocomplete behavior for headers in a followup CL. Bug: 1078183, 1052522 Change-Id: I3c086de080acf03eeaba72a6ac358408ca3462f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227453 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#776216}
-
edchin authored
This CL removes current uses of the drag and drop flag since they have been in stable use for several years now. This drag and drop flag will be used to continue adding drag and drop features in M85. Bug: 1087844 Change-Id: I6b4b48ca3d95ede89cd51b76c0e24acad4fddcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233723Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#776215}
-
Ian Barkley-Yeung authored
The NOTREACHED() fires during OOBE flow. Bug hasn't made progress in several months, and this is blocking other people's ability to use the DCHECK system. BUG=chromium:1039800 Change-Id: I4a5c471b33459ebb2132059af4caecfba877813e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231860Reviewed-by:
-
Patrick Noland authored
This change also makes the call to TrackerFactory null-safe to fix a crash when opening the menu too soon upon startup. Bug: 1088360 Change-Id: I12d881d22576381f9bef6b042873361db1b0d578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236049Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#776213}
-
Samuel Huang authored
This CL enables pretty print of .info files, and regenerates upstream .info files. In particular, file lists now contain one item per line, making diff easier. TBR=hypan@google.com,bialpio@chromium.org Bug: 1074446 Change-Id: I52b7fbcbd2ca3a0937e9fdbed54d95fb281d333f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235989 Commit-Queue: Samuel Huang <huangs@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#776212}
-
Dave Tapuska authored
FrameInputHandler is renamed FrameWidgetInputHandler to indicate that it actually is an interface on the Widget class that exposes a Frame interface. The implementations still remain on the content side for now but the input is sent to the focused widget. This simplifies setup of the FrameInputHandler because it used to be associated with the Frame but really it is associated with the FrameWidget. The useless content::mojom::Widget interface still exists in some capacity and will be removed in a followup CL. It just got to big to do it with this CL. BUG=1073560 Change-Id: Iec117ebce57f3202cfc8352b5aa13285075840e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230912 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#776211}
-
Roman Sorokin authored
* Extend expire date * Switch to timeticks * Extend ownership to rsorokin@ Fixed: 975285 Change-Id: I08c9c5550fb11f2980ac13b1be1570af0ebae0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231043 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Jared Saul authored
Bug: 1088600, 1088622, 1088623, 1088631 Change-Id: Ib490c244168de493bd9e50851a6a75f713b3bc7d Fixed: 1088600, 1088622, 1088623, 1088631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229367 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#776209}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iaed491c7994b741e1ca88b938d003d0b5d80988d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236219Reviewed-by:
-
Alexis Savery authored
Add UMA histogram "Platform.StatefulWritesDaily" to track the KiB written to the stateful partition each day. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2227044 Bug: chromium:1063105 Test: ran validate_format.py Change-Id: Ib7f4f4eb70f6e0cbe6701930220712a45d04a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225288Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Alexis Savery <asavery@chromium.org> Cr-Commit-Position: refs/heads/master@{#776207}
-
Peter Wen authored
Follow-up to: https://crrev.com/c/2235463 Now that WebRTC is migrated to using invoker.lint_suppressions_file, we no longer have a need for this global build override variable. Also clarify that lint_suppressions_dep is specifically for generating this custom file. Bug: 1082743 Change-Id: Id6fd199aed8ad0007b192f022ccc9c152a058dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235943 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
Fixed: 1092614 Change-Id: I5deb29ce23ec0625e85eac185dbacbeb96b85cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236460 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#776205}
-
Yulun Wu authored
Bug: 1091050 Change-Id: I830c2c3d024a3d3c8030a3083d69d791c90c2d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236225Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#776204}
-
Denis Kuznetsov authored
TBR=rsorokin@chromium.org Bug: 1082670 Change-Id: I52aa684837c8328156505af273e536427c8dba62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236472Reviewed-by:
-
Tom Anderson authored
This is a reland of d1bd3ffb Original change's description: > Enable Snap package for official builds > > BUG=1055026,1090915 > R=dpranke > CC=goanuj > > Change-Id: I7009f67268fa5d35e9d41fca593248c36f6ef631 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232837 > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776165} TBR=dpranke Bug: 1055026, 1090915 Change-Id: I80fd77b927b9a832b779bdb09b843016a9c3a93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236069Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#776202}
-
Nektarios Paisios authored
In AXObject, there are a lot of methods that traverse the accessibility tree. However, there is a lot of confusion as to which methods work on unignored nodes, which on ignored nodes that are included in tree, and which on nodes that are totally excluded from the tree. This confusion is the cause behind a bug in AXPosition, whereby the wrong method was called, unignored AXObject::NextInPreOrder(), instead of the ignored version AXObject::NextInTreeObject. This bug was fixed in https://crrev.com/c/2220035/ This patch renames all the tree traversal methods to give them more explicit names. In the process one more bug, having the same cause, was discovered in AXPosition (see ax_Position_test:PreviousPositionAfterARIAHiddenShouldNotSkipARIAHidden). This patch also harmonizes somewhat the method names between Blink and those used on the browser. For example, took the opportunity to introduce UnignoredChildCount() and UnignoredChildAt(index) methods which are especially useful in tests. AX-Relnotes: n/a. Bug: 1082814 R=dmazzoni@chromium.org Change-Id: I6c092dda12406ea7fb0ce9c2ade0410470f28125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205399 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#776201}
-
Xing Liu authored
The prompt status pref for download later dialog is similar to the prompt status used in the download location dialog. The checkbox and the setting UX spec is the same as well. Bug: 1078454 Change-Id: Ibaea0c63782b8fb4e33fc1336c862a015c9d219a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236213Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#776200}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1557a1c16778..60bf7bf3310f 2020-06-08 patrick.brosset@microsoft.com DevTools: E2E test covering going from perf to sources 2020-06-08 kahinds@microsoft.com Fix Network request initiator tooltip If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069404,chromium:1079076 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2a8ebbc4341d761e90145bd8cdf0725304397198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236375Reviewed-by:
-
Siye Liu authored
Some IMEs and Windows OS dictation will either insert zero-length text or delete existing composition text to commit active composition. Therefore, we should allow IMEs to cancel composition by committing zero length text. Bug: 1091069 Change-Id: I99cb213dc2ba1965abfa88ccf6858b89bd7e82df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233234 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#776198}
-
