- 18 Sep, 2018 40 commits
-
-
Bence Béky authored
This reverts commit 130902aa, reviewed at https://crrev.com/c/1073192, and also adds a comment that the expectation of DhcpPacFileFetcher::Fetch is violated. Bug: 882996 Change-Id: I127d582dd0fa4a68942c2a005bd543ad8efbd161 Reviewed-on: https://chromium-review.googlesource.com/1230442 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592057}
-
Peter Kasting authored
This also does a few other things, e.g. SkPath -> gfx::Path, cleaning up pre-refresh stuff in tab_unittest.cc, etc. Bug: none Change-Id: I880b950d0432a463c8f2a79c776a5e563d99a07e Reviewed-on: https://chromium-review.googlesource.com/1229368Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#592056}
-
Jan Krcal authored
This CL fixes a minor omission from a previous patch. It has minor impact on recording the metric Sync.ModelTypeOrphanMetadata but since this metric is out only for 5 days so far, this CL does not rename it. While adding a new test, this CL also simplifies one existing test. Bug: 1219615 Change-Id: Ie8af1da1d2bac49f087584350df59c1b8ce917e8 Reviewed-on: https://chromium-review.googlesource.com/1230030 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592055}
-
Stephen McGruer authored
Bug: 834314 Change-Id: Ib4fc26eea22bf8a84e2810dbf20f05e552f1fe18 Reviewed-on: https://chromium-review.googlesource.com/1228940Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#592054}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc38544e3562..2b7150b9323e git log cc38544e3562..2b7150b9323e --date=short --no-merges --format='%ad %ae %s' 2018-09-18 wangge@google.com Add utility functions for running the swarming task. 2018-09-18 perezju@chromium.org [soundwave] Refactor request and chrome_perf_auth out of api handler Created with: gclient setdep -r src/third_party/catapult@2b7150b9323e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863390,chromium:879526 TBR=sullivan@chromium.org Change-Id: Ibac8decd7c07093a2ea8cf415ebc4e2eb3283903 Reviewed-on: https://chromium-review.googlesource.com/1230637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592053}
-
Tarun Bansal authored
The experiment is already enabled for 50% Canary and Dev channel. Bug: 871795 Change-Id: Ida2f4cfb6a1f5a1b4d3b06bb688891b76fff8e61 Reviewed-on: https://chromium-review.googlesource.com/1226550Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#592052}
-
danakj authored
RenderWidgets sometimes have a LayerTreeView created for them by the time Init() is run, sometimes they do not, and sometimes they never create one. This subtle indirect state is used to determine if the RenderWidget should use a compositor thread input task runner or not. We make this explicit instead of depending on ordering. Further, we note that the initialization of WebPagePopupImpl has boolean return values which can never be false, and tests null cases which do not occur, so we remove those return values and branches. Analysis #0: RenderViewImpl-attached RenderWidget. 1. RenderViewImpl::Initialize() makes a WebViewImpl, which does create a LayerTreeView from its constructor. 2. Then RenderViewImpl::Initialize() calls RenderWidget::Init(). This means RenderWidget::Init() does see a compositor present here. Analysis #1: Popups. 1. WebPagePopupImpl is created from WebViewImpl::OpenPagePopup(). It does RenderViewImpl::CreatePopup(), which makes the WebPagePopupImpl, via RenderWidget::CreateForPopup(). 2. CreateForPopup() also calls RenderWidget::Init(). 3. Then the stack unwinds to WebViewImpl which calls Initialize() on WebPagePopupImpl, which creates the LayerTreeView in RenderWidget. This means the RenderWidget::Init() call happens before the LayerTreeView exists, and there is no compositor present yet. Analysis #2: CreateForFrame() when |local_root| has a parent (making a non-main-Frame RenderWidget) 1. RenderFrameImpl will call RenderWidget::CreateForFrame(). 2. RenderWidget::CreateForFrame() will call WebFrameWidget::Create() which makes a WebViewFrameWidget or WebFrameWidgetImpl. When there is a parent to the |local_root|, a WebFrameWidgetImpl is created. 3. A WebFrameWidgetImpl does not make a compositor in its constructor, but does later in its Initialize() method. The Initialize() call comes from WebFrameWidgetbase::BindLocalRoot() that is called from WebFrameWidget::Create() before returning to RenderWidget. This means RenderWidget::Init() does see a compositor present here. Analysis #3: CreateForFrame() when |local_root| has no parent (setting up the main Frame) 1. RenderFrameImpl will call RenderWidget::CreateForFrame(). 2. RenderWidget::CreateForFrame() will call WebFrameWidget::Create() which makes a WebViewFrameWidget or WebFrameWidgetImpl. When for a main Frame, it makes a WebViewFrameWidget. 3. WebViewFrameWidget depends on being attached to a pre-existing WebViewImpl (and RenderViewImpl/RenderWidget) which has already set up a LayerTreeView, and thus does not set up another LayerTreeView on the new RenderWidget. 4. RenderWidget::CreateForFrame() does not make a new RenderWidget, it returns the existing one on the WebViewImpl. This means RenderWidget::Init() does not occur. R=awong@chromium.org, dcheng@chromium.org, piman@chromium.org TBR=jochen Change-Id: I84cc1c875245b755bd39f6890a839ecda71a20e4 Reviewed-on: https://chromium-review.googlesource.com/1227473 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592051}
-
Mugdha Lakhani authored
1. A check for state needs to be removed from a WPT test, since we've removed this attribute from the BackgroundFetchRegistration object. 2. Update calls in matchImpl() from resolver->Reject to ScriptState::RejectWithDOMException. Change-Id: Ie979ad3675ac7d093ae908604e683802db8115a0 Reviewed-on: https://chromium-review.googlesource.com/1230713Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592050}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6bdfebeb1594..9ec77b5574b4 git log 6bdfebeb1594..9ec77b5574b4 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 mtklein@google.com Revert "implement SkPixmap::erase() with draws" 2018-09-18 caryclark@skia.org fix bookmaker 2018-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a49f60fee74d..95277a300f52 (3 commits) 2018-09-18 bsalomon@google.com WEBGL_video_texture : sharing texture prototype in skia 2018-09-17 mtklein@google.com Revert "implement SkPixmap::getPixel() with this->readPixels()." 2018-09-17 mtklein@google.com simplify src->dst matrix init 2018-09-17 herb@google.com Make atomic lists list for bitmaps and paths 2018-09-17 brianosman@google.com Revert "Add Short4 vertex attributes, and benchmark them as 4.12 colors" 2018-09-17 brianosman@google.com Add Short4 vertex attributes, and benchmark them as 4.12 colors 2018-09-17 bsalomon@google.com When merging into an already chained op update the head's op bounds. 2018-09-17 bungeman@google.com Use onOnceBeforeDraw instead of constructor for glyphs. 2018-09-17 kjlubick@google.com Make fuzz::next overloads more consistent 2018-09-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 017bda429667..a49f60fee74d (3 commits) 2018-09-17 chinmaygarde@google.com Allow users of Skia to optionally link against X11 and GL on Linux. 2018-09-17 mtklein@google.com implement SkPixmap::getPixel() with this->readPixels(). 2018-09-17 mtklein@google.com implement SkPixmap::erase() with draws Created with: gclient setdep -r src/third_party/skia@9ec77b5574b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:776222 TBR=reed@chromium.org Change-Id: I36aaa492376dfc5ad8663c5d5f1b7cdc305148d2 Reviewed-on: https://chromium-review.googlesource.com/1230318Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592049}
-
Matthew Jones authored
This patch only propagates swipe end and fling events to the toolbar swipe layout if it is showing. Previously all touch events to interact with the modified swipe handler would be processed regargless of which layout was showing. The result was incorrect events being triggered and, in this case, showing incorrect buttons in the bottom toolbar. Bug: 884615, 882508 Change-Id: Id791624d1505a18c6fd16bf6a64544a049503d16 Reviewed-on: https://chromium-review.googlesource.com/1228936Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592048}
-
Anne Lim authored
Added skeleton framework for AutofillStrikeDatabase. It will be used to store data about the number of times a user refuses to save their info. Bug: 884817 Change-Id: Iaffac0ab45785e4c0ff261ecb9bbde31e270e00a Reviewed-on: https://chromium-review.googlesource.com/1228774Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#592047}
-
Albert J. Wong authored
ViewHostMsg_ShowWidget and ViewHostMsg_ShowFullscreenWidgetresult in a ViewMsg_SetBounds_ACK message sent to the shown widget. However these messages are handled by RenderViewHostImpl with the routing_id of the widget taken as a data parameter. Since it's easy to get confused about which routing ID is going where this CL renames the local variables to widget_route_id making it clearer which object is being targeted by each message. Bug: 545684 Change-Id: Iba00a3bf8bcd52b43a42a6b49be4275a22ff54f9 Reviewed-on: https://chromium-review.googlesource.com/1228988Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#592046}
-
Dan Zhang authored
Merge http2 part of internal change: 210537018 R=rch@chromium.org Change-Id: Ia31231c598b3d7d8cb79e7b5ebd6f035d3d7b1fa Reviewed-on: https://chromium-review.googlesource.com/1227838Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#592045}
-
Andrew Grieve authored
Also tweaked flag to have files be public by default. Change-Id: Ia1bfe6801e1cde24c428bf86e46582f608d97cb1 Reviewed-on: https://chromium-review.googlesource.com/1229509Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#592044}
-
Samuel Huang authored
Previously the script to upload HTML Viewer statics to the script already exists in depot_tools. This CL renames the script. gs: //chrome-supersize was called "gsutil.py", which is confusing since Change-Id: I6aaf2a45943d3664d04f870095e8f33b17817127 Reviewed-on: https://chromium-review.googlesource.com/1230695Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#592043}
-
Matthew Jones authored
This reverts commit 27d290e8. Reason for revert: Breaks tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Marshmallow%2064%20bit%20Tester/23892 Original change's description: > Fix startup grey status bar on < M devices > > This patch moves the white status bar theme to a version specific > v23 directory to prevent L and below devices from using the flashing > between colors. Logic has also been added to ChromeActivity to prevent > these devices from using the grey (darkened version of white) color on > startup. > > Bug: 881239 > Change-Id: I41e5d959fab96623d254f4ff2dd0ea15cb6f9abc > Reviewed-on: https://chromium-review.googlesource.com/1228496 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591857} TBR=twellington@chromium.org,mdjones@chromium.org Change-Id: Idbd15b881ffe2652aaea6a0a86faf02872256337 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881239 Reviewed-on: https://chromium-review.googlesource.com/1230697Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592042}
-
Mikel Astiz authored
After a long debugging session, we haven't yet found an explanation as per why the processor enters an inconsistent state, where apparently OnSyncStarting() is received twice without OnSyncStopping() in between. As a last resort to continue the investigation, we add even more CHECKs to understand which layer is violating the API contracts. Bug: 876490,885019 Change-Id: Ia15fa29d8bd128730bd79b4760ea233f09d9862e Reviewed-on: https://chromium-review.googlesource.com/1230733Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592041}
-
Jacobo Aragunde Pérez authored
Bug: 884306 Change-Id: Ibeff0b4c01007d9cfa0fbed3115a4acd5c3c8586 Reviewed-on: https://chromium-review.googlesource.com/1230019Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#592040}
-
Hans Wennborg authored
This is already inside an if (is_clang) scope. Bug: none Change-Id: I893f21598d4bc0e26c8d52fae44a48b6767f3eed Reviewed-on: https://chromium-review.googlesource.com/1230043 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592039}
-
Nicolas Ouellet-Payeur authored
Bug: 884221 Change-Id: Iaee4d979888e3bc5acf55f88c3618fd33810adf6 Reviewed-on: https://chromium-review.googlesource.com/1226025Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#592038}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/45b9bc919502..cc38544e3562 git log 45b9bc919502..cc38544e3562 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 pasko@chromium.org androidStartupMetric: remove request_start_time from comments Created with: gclient setdep -r src/third_party/catapult@cc38544e3562 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:883290 TBR=sullivan@chromium.org Change-Id: I237765b77a49da001cbb1ef19f147e4638f5f093 Reviewed-on: https://chromium-review.googlesource.com/1230320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592037}
-
Nicolas Ouellet-Payeur authored
Environment variables on the command-line (alternative browser path and parameters) are expanded before being passed to the external program. On Windows, this means strings like '%HOME%' are expanded. On Linux, this means strings like '$VAR' and '${VAR}' are expanded. Also, a '~' at the beginning of a command-line argument is expanded to the HOME environment variable. Bug: 882520 Change-Id: I9822b465999b3515d37e882f18a19df39b3e64d6 Reviewed-on: https://chromium-review.googlesource.com/1225854Reviewed-by:Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#592036}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/77304e28a65b..9a146dc589d8 git log 77304e28a65b..9a146dc589d8 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 hjd@google.com Merge "perfetto-ui: Add canned queries" Created with: gclient setdep -r src/third_party/perfetto@9a146dc589d8 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8b1f1ea8d95bd19eb461c696f995a872f70a0b6b Reviewed-on: https://chromium-review.googlesource.com/1230321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592035}
-
Owen Min authored
Remove the directory when it's empty and there is no enrollment token. It only deletes $app_data_dir/Google/Chrome Cloud Enrollment/ It does NOT delete $app_data_dir/Google because it's used as default user data dir. Bug: 883869 Change-Id: Ie6071638fcc847dfe9d10e35884585b92b857d3e Reviewed-on: https://chromium-review.googlesource.com/1228946Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#592034}
-
Reza.Zakerinasab authored
TBR=fserb@chromium.org Bug: 845556 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I623dad8aa5342ed2d6f1edd0f70ac3b41dbf84e1 Reviewed-on: https://chromium-review.googlesource.com/1228214Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#592033}
-
Mugdha Lakhani authored
when: 1. recordsAvailable is false 2. the background fetch is incomplete. Bug: 882478 Change-Id: Id849a73370f8f07597039c3ccee5efce828fa452 Reviewed-on: https://chromium-review.googlesource.com/1226913Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592032}
-
Dave Tapuska authored
Use wtf_size_t when dealing with WTF types. BUG=879657 Change-Id: I9db3182f9194360c8729e174a31ac77493f63f87 Reviewed-on: https://chromium-review.googlesource.com/1226023Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#592031}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f9b4845975ff..18b4479cee3f git log f9b4845975ff..18b4479cee3f --date=short --no-merges --format='%ad %ae %s' 2018-09-18 borenet@google.com gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator Created with: gclient setdep -r src/third_party/depot_tools@18b4479cee3f The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6481d510a741df8843c64ab0b0f837f6cf96fd7a Reviewed-on: https://chromium-review.googlesource.com/1230315Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592030}
-
Sean Gilhuly authored
The flag is not respected with OOP-D, so read the flag and send it to the GPU process. Bug: 841801 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I87644f9c10a04491289f9fe89b8cbbd9584bfb2a Reviewed-on: https://chromium-review.googlesource.com/1228497 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#592029}
-
Fredrik Söderquist authored
Intent-to-Ship thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/8B9FbeTBIK0/DNkC2pz-AAAJ Also removing the actual feature and corresponding check, because it's only used in a single spot, so if the feature should need to be unshipped it ought to be a fairly trivial revert. Bug: 707047, 880733 Change-Id: Ie854d7fd9f7a22e9c6144668a37f694dd1c508ee Reviewed-on: https://chromium-review.googlesource.com/1230018Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#592028}
-
Vladislav Kuzkokov authored
This doesn't look as weird as |false| for success and makes it consistent with |setLocalDestinationCapabilities|. Change-Id: I28dd85308bfe89d95aa90a68e6eacffa665e6c10 Reviewed-on: https://chromium-review.googlesource.com/1225766 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#592027}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5f599e700e93..7f0a8877a213 git log 5f599e700e93..7f0a8877a213 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 stevenperron@google.com Move the registration of decorations. (#1895) 2018-09-18 stevenperron@google.com Add dummy loop in merge-return. (#1896) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7f0a8877a213 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4b2a99577848ab8fbab4258b7b6c14d18db683c7 Reviewed-on: https://chromium-review.googlesource.com/1230319Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592026}
-
Ria Jiang authored
Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iebf99dde5bd1524779c417eb72dbe9e887e2457a Reviewed-on: https://chromium-review.googlesource.com/1228477Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592025}
-
Xi Han authored
TBR=jam@chromium.org Bug: 846846 Change-Id: I296abce1c525b642010268d48a50fd4b57573211 Reviewed-on: https://chromium-review.googlesource.com/1228475 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#592024}
-
Mugdha Lakhani authored
from the WPT suite. This was added in response to an ongoing CL in the Fetch spec, which nobody is championing at present and isn't part of the spec. Here's the proposed spec change for reference: https://github.com/whatwg/fetch/pull/519/commits Bug: 884708 Change-Id: I185a876147ab7e02edd611840a237dce1cab750a Reviewed-on: https://chromium-review.googlesource.com/1228060Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#592023}
-
Justin Cohen authored
Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If5a512f4acd9acfa9e606a119686040436436dfd Reviewed-on: https://chromium-review.googlesource.com/1228514Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592022}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/96c8cc90..1bce3d27 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iff0d9caa74a169c8822111d664585f89b608c858 Reviewed-on: https://chromium-review.googlesource.com/1230314Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592021}
-
Gyuyoung Kim authored
ApplyViewportDeltas and RecordWheelAndTouchScrollingCount have been using a raw pointer type for the argument. It would be good if we can use const T& for the arguments if possible. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibdcbc5cd3ebe95cce743b2ffcc84b7dc009a0044 Reviewed-on: https://chromium-review.googlesource.com/1227861Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#592020}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b98184a9ff69..77304e28a65b git log b98184a9ff69..77304e28a65b --date=short --no-merges --format='%ad %ae %s' 2018-09-18 primiano@google.com Fix GCC build Created with: gclient setdep -r src/third_party/perfetto@77304e28a65b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia5ccef74d2cd4c62e2550cfea40ff4f867587c02 Reviewed-on: https://chromium-review.googlesource.com/1230317Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592019}
-
Stephane Zermatten authored
With this change, the controller will start a script automatically, without showing a chip first, if: - there is only one runnable script - that script is flagged with autostart=true by the server - no script has ever run - no tap was recorded Bug: 806868 Change-Id: Ia940af3308679b3c3a95837931081168f57ca16e Reviewed-on: https://chromium-review.googlesource.com/1226596 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#592018}
-