GitLab

We aren't seeing any more crashes due to duplicate field trials, so
we can remove this debug code.

BUG=665129

Review-Url: https://codereview.chromium.org/2536723002
Cr-Commit-Position: refs/heads/master@{#434666}

Issue 618178 describes an example where a Burmese text run starts with a
leading punctuation character followed by a combining spacing mark. This
grapheme cannot be shaped with the default font, since Times for example
cannot display the combination of a left quote with a Burmese combining
mark. Our fallback code attempts to find a fallback font based on the
first character at the beginning of an extracted unshaped sub-run, which
does not lead to finding a font suitable for Myanmar text in this case.
So in a way it runs into a fallback trap, where no fallback hint helps
to find the right fallback font and the whole run ends up as notdef
glyphs.

This CL attempts to resolve this by looking for a better fallback hint
character, which is not script common or inherited, if such is
available. This improves the situation for the Burmese text from the
issue report.

In addition, as a better fix we should give higher importance to the
locale information in font fallback, filed as issue 668706.

BUG=618178
R=eae,kojii,behdad

Review-Url: https://codereview.chromium.org/2530153002
Cr-Commit-Position: refs/heads/master@{#434665}

There has not been a request to implement and ship this feature, so it
should be marked as experimental until such request has been sent out
and consequently approved.

BUG=648240

Review-Url: https://codereview.chromium.org/2530713002
Cr-Commit-Position: refs/heads/master@{#434664}

https://skia.googlesource.com/skia.git/+log/d1bd30515aaa..d5de01364378

$ git log d1bd30515..d5de01364 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 mtklein Some simple pipeline refactoring.
2016-11-28 brianosman GrTextureProducer cleanup, phase one: Bitmap and Image makers
2016-11-28 reed don't rely on canvas being reference counted

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2533823002
Cr-Commit-Position: refs/heads/master@{#434663}

ICU reports its memory allocation failure through UErrorCode, while
Blink would like to crash the renderer using OOM_CRASH()[1].

ICUError provides the unified way to handle ICU errors in Blink.

In this CL, all failures lead to the render crash, just differently by
the error type. We may add lighter methods, such as to crash only if
critical, or to ignore certain types, if needed in future.

[1] https://groups.google.com/a/chromium.org/d/msg/platform-architecture-dev/MP0k9WGnCjA/zIBiJtilBwAJ

Review-Url: https://codereview.chromium.org/2527183002
Cr-Commit-Position: refs/heads/master@{#434662}

Make DeviceActiveDirectoryPolicyStatusProvider observe CloudPolicyStore.

BUG=668652

Review-Url: https://codereview.chromium.org/2531793002
Cr-Commit-Position: refs/heads/master@{#434661}

Currently, we only report UMA statistics on receiving a pressure
change event from the system. This means that we could be missing
many ticks of "normal" pressure from sessions that never encounter
pressure, skewing our stats. Other platforms don't have this issue
since they poll.

This change piggybacks statistic reporting on GetCurrentPressureLevel()
which is called regularly by RendererFrameManager::GetMaxNumberOfSavedFrames()
This also allows us to enable reporting for Sierra.

To make this work, GetCurrentPressureLevel is now declared non-const.
There don't appear to be any const MemoryPressureMonitors in the codebase
at the moment, so this should be safe.

BUG=655304

Review-Url: https://codereview.chromium.org/2495003004
Cr-Commit-Position: refs/heads/master@{#434660}

Add CHECK's to debug QuicStreamSequencerBuffer in weird state. Add a destruction indicator to detect free after use.

Also remove some tests because CHECK's prevent some corner case from
happening.

R=rch@chromium.org
BUG=664200

Review-Url: https://codereview.chromium.org/2519333006
Cr-Commit-Position: refs/heads/master@{#434659}

https://skia.googlesource.com/skia.git/+log/b409c6ae5628..d1bd30515aaa

$ git log b409c6ae5..d1bd30515 --date=short --no-merges --format='%ad %ae %s'
2016-11-24 yujieqin Update PIEX

BUG=32591644

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2532803003
Cr-Commit-Position: refs/heads/master@{#434658}

This patch fixes AXLayoutObject not to add first-letter pseudo elements
twice in the accessibility tree.

Similar fix to the one in WebKit[1], but the condition was changed only
for first-letter pseudo element because of the difference in the layout
tree structure.

[1] https://trac.webkit.org/changeset/203694/

BUG=632453

Review-Url: https://codereview.chromium.org/2524313002
Cr-Commit-Position: refs/heads/master@{#434657}

There's no reason to construct impl directly via
"new CronetUrlRequestContext"; instead test via the
public API (i.e. "new CronetEngine.Builder").

R=kapishnikov
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2528833002
Cr-Commit-Position: refs/heads/master@{#434656}

Removing ASSERT_DEATH.

Origin Review-Url: https://codereview.chromium.org/2516383002
Reverted: https://codereview.chromium.org/2528133002/

BUG=647588

Review-Url: https://codereview.chromium.org/2532913002
Cr-Commit-Position: refs/heads/master@{#434655}

Currently, "encoded_body_length" is dispatched on each ResourceMsg_DataReceived
IPC message. With this series of CLs, it will be dispatched when a resource
loading is completed. This is needed to use mojo data pipe for transferring
the response body.

 - 1/3: https://codereview.chromium.org/2514713002/
 - 2/3: https://codereview.chromium.org/2510333002/
 - 3/3: https://codereview.chromium.org/2506363005/

Design doc: https://docs.google.com/document/d/1Q-LpTPcV8QApeXSL24MVZHjP-uQK7RAK300t_qZaGFQ/edit#

This CL
 - removes encoded_body_length() from RequestPeer::ReceivedData.
 - removes encodedBodyLength parameter from WebURLLoaderClient::didReceiveData,
 - adds totalEncodedBodyLength parameter to WebURLLoaderClient::didFinishLoading,
 - adds totalEncodedBodyLength parameter to WebURLLoaderClient::didFail.

BUG=666216

Review-Url: https://codereview.chromium.org/2510333002
Cr-Commit-Position: refs/heads/master@{#434654}

BUG=None

Review-Url: https://codereview.chromium.org/2533713002
Cr-Commit-Position: refs/heads/master@{#434653}

The key is hard-coded anyways, thus there's no benefit in passing it
around.

BUG=none

Review-Url: https://codereview.chromium.org/2507423002
Cr-Commit-Position: refs/heads/master@{#434652}

BUG=

Review-Url: https://codereview.chromium.org/2530423002
Cr-Commit-Position: refs/heads/master@{#434651}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d0f4f6fb..e9b2ab39

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2536623002
Cr-Commit-Position: refs/heads/master@{#434650}

These additions prevent crashes when running the signin tests and when trying to
edit a bookmark.

BUG=666375

Review-Url: https://codereview.chromium.org/2529203002
Cr-Commit-Position: refs/heads/master@{#434649}

BUG=666704
TBR=mathp@chromium.org
NOTRY=True

Review-Url: https://codereview.chromium.org/2536663002
Cr-Commit-Position: refs/heads/master@{#434648}

BUG=542537

Review-Url: https://codereview.chromium.org/2532823002
Cr-Commit-Position: refs/heads/master@{#434647}

Revert of Blink Animation: Extend Animation's GC lifetime if it has a finish promise. (patchset #2 id:20001 of https://codereview.chromium.org/2536523002/ )

Reason for revert:
Causes unexpected leaks in webkit_tests:
web-animations-api/animation-finish-event-cancelled.html
web-animations-api/animation-cancel-ready-finished-ordering.html
imported/wpt/web-animations/interfaces/Animation/finished.html
web-animations-api/animation-onfinish.html
imported/wpt/web-animations/interfaces/Animation/oncancel.html
http/tests/security/mixedContent/websocket/insecure-websocket-in-secure-page-worker.html

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/342

Original issue's description:
> Blink Animation: Extend Animation's GC lifetime if it has a finish promise.
>
> BUG=617539
>
> Committed: https://crrev.com/bfbc065caf6187d00c0e549f07ad264bb1614873
> Cr-Commit-Position: refs/heads/master@{#434612}

TBR=alancutter@chromium.org,loyso@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=617539

Review-Url: https://codereview.chromium.org/2535793002
Cr-Commit-Position: refs/heads/master@{#434646}

https://skia.googlesource.com/skia.git/+log/064f8e2d7091..b409c6ae5628

$ git log 064f8e2d7..b409c6ae5 --date=short --no-merges --format='%ad %ae %s'
2016-11-28 borenet [nobuildbot] Mac bots

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=brianosman@google.com

Review-Url: https://codereview.chromium.org/2532093002
Cr-Commit-Position: refs/heads/master@{#434645}

This is a follow-up of https://codereview.chromium.org/2526463002/ .

Here is the actual behavior of the system:

X=ExternaStorageDisabled
Y=ExternalStorageReadOnly

  X     Y
False  False : Users can read from and write to external storage media.
False  True : Users can read files in external storage, but cannot write to there.
True  False : Users cannot access external storage at all.
True  True : Users cannot access external storage at all.

If any of the policy value is not configured (=not exist), it is equivalent to false.

If ExternaStorageDisabled = true, any access to removable storage media are denied. In this case, ExternalStorageReadOnly will not be considered because the storage media devices itself will never be accessible by the user.

BUG=669004

Review-Url: https://codereview.chromium.org/2536593002
Cr-Commit-Position: refs/heads/master@{#434644}

Since cross_origin_commit_observer.Wait() does not really stop right
after commit, nothing prevents the history nav to commit too during this
wait.

SitePerProcessBrowserTest.NavigateInUnloadHandler:
Navigation to c.com could commit while ExecuteScript was spinning the
loop, then deleted_observer binds to C's RFH and waits forever.

SitePerProcessBrowserTest.RenderViewHostIsNotReusedAfterDelayedSwapOutACK:
During handling of navigation commit in the browser, SwapOut message is
sent to the renderer, which asks its host to shut down;
commit_observer.WaitForCommit may spin the loop until this request is
satisfied, and after return the test accesses dead objects.

Regarding the change in DOMMessageQueue::WaitForMessage:
It was possible for NavigateInUnloadHandler to fail because of this.
With reordering code in the test itself, this change is not really
necessary, but to me it seems right to keep it - this is not the place
where the loop should be spinned always, unconditionally. BTW, I'm
planning to discuss (on chromium-dev) a broader proposal to change
things like this.

BUG=668707

Review-Url: https://codereview.chromium.org/2523583003
Cr-Commit-Position: refs/heads/master@{#434643}

Together with this roll, the changes of https://codereview.chromium.org/2513393003/ are also applied.
This is because the return value of rtc::TimeMacros and friends have changed in the latest version of WebRTC that we are rolling.

Roll Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b045881..6b56973

$ git log b045881..6b56973 --date=short --no-merges --format=%ad %ae %s
2016-11-28 michaelt@webrtc.org Smooth BWE and pass it to Audio Network Adaptor.
2016-11-28 kjellander@webrtc.org Roll chromium_revision 5e821a77..5c22c2af (432715:434448)
2016-11-28 nisse@webrtc.org Change rtc::TimeNanos and rtc::TimeMicros return value from uint64_t to int64_t.
2016-11-25 solenberg@webrtc.org Revert of Move ADM specific Android files into modules/audio_device/android/ (patchset #2 id:20001 of https://codereview.webrtc.org/2533573002/ )
2016-11-25 solenberg@webrtc.org Move ADM specific Android files into modules/audio_device/android/
2016-11-25 magjed@webrtc.org Reland of Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload (patchset #1 id:1 of https://codereview.webrtc.org/2529143002/ )
2016-11-25 magjed@webrtc.org Revert of Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload (patchset #1 id:40001 of https://codereview.webrtc.org/2525693003/ )
2016-11-25 sprang@webrtc.org Fix perf regression in screenshare temporal layer bitrate allocation
2016-11-25 magjed@webrtc.org iOS HW encoder: Enable H264 High profile support
2016-11-25 magjed@webrtc.org Add H264 profile to webrtc::VideoCodecH264 and webrtc::VideoPayload
2016-11-25 magjed@webrtc.org Android HW encoder: Set constrained baseline as the profile
2016-11-25 ehmaldonado@webrtc.org Get rid of webrtc/base/latebindingsymboltable*
2016-11-25 magjed@webrtc.org Reland of move RTPPayloadStrategy and simplify RTPPayloadRegistry (patchset #1 id:1 of https://codereview.webrtc.org/2528993002/ )
2016-11-25 ehmaldonado@webrtc.org Make Valgrind memcheck work in swarming.

TBR=sergeyu@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2528383002
Cr-Commit-Position: refs/heads/master@{#434642}

This is a cleanup of some recent additions to the Grid class, basically some
renames and an API change. The hasInFlowGridItems was renamed to
hasGridItems because by definition all grid items are in flow children of
the grid container. Apart from that, in order to remove an extra attribute
for the Grid::insert method, a new method called
setHasAnyOrthogonalGridItem was added to track the existence of orthogonal
items.

BUG=627812

Review-Url: https://codereview.chromium.org/2526383004
Cr-Commit-Position: refs/heads/master@{#434641}

Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ )

Reason for revert:
Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done.

Original issue's description:
> Reland "[wrapper-tracing] Enable flag per default"
>
> BUG=chromium:468240
>
> Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1
> Cr-Commit-Position: refs/heads/master@{#433823}

TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:468240, chromium:668060, chromium:668059

Review-Url: https://codereview.chromium.org/2528393002
Cr-Commit-Position: refs/heads/master@{#434640}

toV8({PassRefPtr,RefPtr}) is no longer used after the migration to
Oilpan.  Removes them.

BUG=

Review-Url: https://codereview.chromium.org/2532883002
Cr-Commit-Position: refs/heads/master@{#434639}

BUG=chromium:668742,chromium:668059, chromium:668060

Review-Url: https://codereview.chromium.org/2529353002
Cr-Commit-Position: refs/heads/master@{#434638}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/15e1f72e..d0f4f6fb

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2530393002
Cr-Commit-Position: refs/heads/master@{#434637}

BUG=653826

Review-Url: https://codereview.chromium.org/2533443004
Cr-Commit-Position: refs/heads/master@{#434636}

BUG=655099

Review-Url: https://codereview.chromium.org/2526313002
Cr-Commit-Position: refs/heads/master@{#434635}

BUG=

Review-Url: https://codereview.chromium.org/2529653002
Cr-Commit-Position: refs/heads/master@{#434634}

This CL introduces the SIMPLE_LOAD_EXPERIMENT prerender mode.
In this mode, no prerendering or prefetching happens, but the URLs that
would have been prefetched are recorded, and UMA metrics are reported.

This will be used as a reference point to evaluate the speed
improvements of prerendering and prefetching.

For now both the simple load mode and the prefetch mode record
the FCP histograms.
Prerender will have to be updated to record these histograms as
well in another CL.

BUG=668997

Review-Url: https://codereview.chromium.org/2527233003
Cr-Commit-Position: refs/heads/master@{#434633}

Explained in what cases AndroidStatusFetcher returns false.

BUG=None

Review-Url: https://codereview.chromium.org/2528373002
Cr-Commit-Position: refs/heads/master@{#434632}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/169337da..15e1f72e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2536563002
Cr-Commit-Position: refs/heads/master@{#434631}

It's called NGBlockNode and NGInlineNode now.

Also removed an old TODO about common base class for NGBlockNode and
NGInlineNode. They do have a common base class now.

Review-Url: https://codereview.chromium.org/2530083003
Cr-Commit-Position: refs/heads/master@{#434630}

Resource type isn't passed to browser correctly.
More details in https://crbug.com/664135
This is an attempt to fix it.

BUG=664135

Review-Url: https://codereview.chromium.org/2494713002
Cr-Commit-Position: refs/heads/master@{#434629}

This patch is to confirm if the process allocation works well.

BUG=668633

Review-Url: https://codereview.chromium.org/2528333002
Cr-Commit-Position: refs/heads/master@{#434628}

Prior to this patch, private scripts attempted to get the
"privateScriptController" property off the global object without verifying if
the property actually exists on the global. If the property hasn't been set yet,
this operation could descend into the prototype chain and potentially return
a named property from the WindowProperties object, leading to release asserts
and general confusion.

BUG=668552

Review-Url: https://codereview.chromium.org/2529163002
Cr-Commit-Position: refs/heads/master@{#434627}