- 25 Jan, 2020 40 commits
-
-
Sophie Chang authored
This is safe since the data gets updated serially due to updates all running on the same sequence in the underlying leveldb layer. Change-Id: Ia2b5211f697d8de3226cdbdefb3d0912c39c612a Bug: 1045631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020742Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#735209}
-
Xing Liu authored
This CL finishes the implementation of announcement notification. This feature targets M80. We show a notification on browser start up on Android and desktops for an important informational update. TBR=dtrainor@chromium.org, peter@chromium.org, jwd@chromium.org Bug: 1042124 Change-Id: Ib422c789f06382adac4f25efe0b8c0275e128174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018718 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#735208}
-
Yusuke Sato authored
On ARC, to support board-specific default apps, the arc-setup command creates a symlink from /var/cache/arc_default_apps to /usr/share/google-chrome/extensions/arc/<board>. This doesn't work on ARCVM where arc-setup is not in use. To support ARCVM, this CL checks the current board name in Chrome and construct the /usr/share/google-chrome/extensions/arc/<board> path at runtime. BUG=b:144199481 TEST=try, ARCVM still starts Change-Id: I8dc3f93010d55324914cf774e90c040ef7f0c66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020479 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#735207}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/23521ca334f9..3712b2e4453a git log 23521ca334f9..3712b2e4453a --date=short --first-parent --format='%ad %ae %s' 2020-01-24 jmadill@chromium.org Vulkan: Command graph linearization (Step 1). 2020-01-24 tdusnoki@inf.u-szeged.hu Disable ANGLE GL and Vulkan on Windows on ARM Created with: gclient setdep -r src/third_party/angle@3712b2e4453a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I940c59910fcd404e8b096df54d660d96d863d543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735206}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a033371f89e8..5865d5aa548d Created with: gclient setdep -r src-internal@5865d5aa548d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1010568 Tbr: jbudorick@google.com Change-Id: I2112514875cf0699311ee8fa58be6846db4a5f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021382Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735205}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bf4e7a722ba4..1a5fe235929a git log bf4e7a722ba4..1a5fe235929a --date=short --first-parent --format='%ad %ae %s' 2020-01-24 apolito@google.com add revision to scheduleBuild call for git cl try if needed. Created with: gclient setdep -r src/third_party/depot_tools@1a5fe235929a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043877 Tbr: agable@chromium.org Change-Id: I0996e75df9059eda4723f673a61521373d4dc8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021383Reviewed-by:
-
Demetrios Papadopoulos authored
chrome.js: 816824e445eb7ccc97becd07bdaf638d71b2e543 -> e39fdb69b20d4daad90102ed2944de16874243cf chrome_extensions.js: 5a25bfc4e006f1a965d362e27938611242908acd -> 5be5a82b4b4ef357928edfe3608bb06249114fa4 The chrome.js and chrome_extensions.js files mentioned above were already updated in r733877 to unblock further work, mentioned here for completeness. Other fixes: - Remove obsolete diagnostic group 'ambiguousFunctionDecl', as of https://github.com/google/closure-compiler/commit/391c6c47f8089870fe89839521c0b135051cedf7. - Remove cr.exportPath() tests, since cr.exportPath() is no longer part of --chrome_pass, as of https://github.com/google/closure-compiler/commit/9ef4f419f8909829be9482fe108c6d70cb30dff1 - Fix new "variable goog is undeclared" errors in iOS and compiler_test.py - Fix incorrect usage of a generic type in ui/file_manager - Fix newly found type violations in internet_detail_page.js Bug: 1028829,1044378 Change-Id: I0028085c825790b03036793bcae81767d60cf738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013749Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#735203}
-
John Budorick authored
Suites that start the emulator w/ -writable-system are currently having issues booting within the allotted timeout. Once they fail to boot in time, we don't retry the boot because the exception isn't the type of timeout error we're expecting. This CL significantly raises the timeout when booting w/ -writable-system, and it allows for retries when host-side commands time out. Bug: 922145 Change-Id: If90405aaed14191092e2ce99d0814eee3aa1aa0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020784 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#735202}
-
Stephan Hartmann authored
Add zlib_config target because perfetto depends on it. Bug: 977964 Change-Id: I2aac5c3704f1274f932a61264d1c26a05f2db55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019035Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#735201}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1ea8fb7e2ef3..d93fde1cd5a5 git log 1ea8fb7e2ef3..d93fde1cd5a5 --date=short --first-parent --format='%ad %ae %s' 2020-01-25 dberris@chromium.org E-Divisive: Prevent Negative Indices 2020-01-24 dberris@chromium.org E-Divisive: Support min_segment_size = 0 2020-01-24 rmhasan@google.com [Typ] Add trailing comments to Expectation instance Created with: gclient setdep -r src/third_party/catapult@d93fde1cd5a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1041688,chromium:1044760,chromium:986447 Tbr: oysteine@google.com Change-Id: Ie6534d4eb9494c12ffdd68e83d26a7ea2222d1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021209Reviewed-by:
-
Patrick Monette authored
The feature has been enabled by default for a while now and things are working great. Bug: 943303 Change-Id: I47576be44ffa92b081b65df132c6bc67a3dbca2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017990 Auto-Submit: Patrick Monette <pmonette@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#735199}
-
Robert Ogden authored
This CL finishes moving the feature flags for Isolated Prerender to a separate header file. I decided not to add <Feature>IsEnabled() helpers to the params file since it doesn't seem that much better because tests still need to reference the feature directly anyways. Maybe reconsider if the feature logic gets any more complex in the future. Bug: 1023483 Change-Id: Ic139ed099a44736644c7f5414dfd4bb0e622b077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021311Reviewed-by:
-
Tao Bai authored
-Add WebViewAppStateObserver. -Notify app state change through AwContentsLifecycleNotifier. Bug: 1042048 Change-Id: Ide14e8583e78b4597fcd061c9dabacf2cb35fe61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015407Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#735197}
-
Alison Maher authored
This change adds support for the CSS Layout API Alignment, both in retrieving child baselines and in setting parent baselines. https://drafts.css-houdini.org/css-layout-api/#interaction-alignment Due to recent changes, fragments produce only one baseline. https://chromium-review.googlesource.com/c/chromium/src/+/1988376 As a result, custom LayoutFragments will always produce the first-line baseline. Bug: 726125 Change-Id: Ia92eddcd8cf6d7f1cc58c767cc71a199b0b7418e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015723 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#735196}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/fa06dd0b6210..1d036f776698 git log fa06dd0b6210..1d036f776698 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 rharrison@chromium.org Removing deprecated spvc API usages Created with: gclient setdep -r src/third_party/dawn@1d036f776698 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I37fc495054a7aa1fed44a27b86b07d9ebbddcd76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020667Reviewed-by:
-
Tim Judkins authored
This change adds a checkbox UI element to the extension installation prompt if the feature is enabled. If checked during installation of a local crx file, all requested host permissions for the extension will be withheld by default. The checkbox will also show up on other install prompts with this change (such as the webstore install prompt), but support for it triggering permissions to be withheld will be added in a followup CL. Bug: 984069 Change-Id: I42072d03341fbd9424e1934e71ebf641c1a3165e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983265 Commit-Queue: Tim Judkins <tjudkins@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735194}
-
Eric Karl authored
Bot is already on 10.14, so doesn't make a big difference, but cleaning up legacy exceptions. Bug: 777457, 777590 Change-Id: I2bcfa48bd094272f38274d2d5c98d5a37e7f6f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021186 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#735193}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4cce3fa50ee..2329da078aca git log b4cce3fa50ee..2329da078aca --date=short --first-parent --format='%ad %ae %s' 2020-01-24 ethannicholas@google.com add SkSLInterpreter vector instructions Created with: gclient setdep -r src/third_party/skia@2329da078aca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I5cc8f0e9aa3613374d2a7554dda2864fff2c2207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020519Reviewed-by:
-
Evan Stade authored
This reverts commit 019a8580. Reason for revert: memory regression found by pinpoint Original change's description: > WebLayer: add FindInPage API > > New methods are added to Tab: > - beginFindInPage > - activateNextFindInPageMatch > - endFindInPage > > And a new FindInPageCallback interface is introduced with one method: > - onFindResult > > Also add very basic FIP controls to shell to partially exercise the > new API. > > Notes: > 1. The embedder provides the main find in page UI (the text input). > 2. The embedder is responsible for ending the find session as > appropriate (i.e. when the main find in page UI is dismissed), > which cleans up the in-page UI, consisting of a results sidebar and > text highlighting. Commonly this would happen if the user cancels the > find session or if a navigation occurs. > 3. When the active tab loses focus, the find session is ended and the > result bar is removed. > 4. It is generally expected that the embedder-provided find in page UI > will be hosted in the top view. > > TODO: > 1. The top controls should be forced visible when the new web contents > overlay view holds children. That will definitely be desired for > tab modal dialogs, and is probably desired for find in page as well > (at least judging by what Clank does). > 2. Write tests. > > Bug: 1038415 > Change-Id: I6183172dc3944157aae2db5ebb0aed983a34bffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004072 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734691} TBR=sky@chromium.org,estade@chromium.org,twellington@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1038415 Change-Id: I18896dbf3bf9c65e4ff801cb6061fc955be8809c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020478Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#735191}
-
Alexei Svitkine authored
For each one, I code searched the feature name which returned no results outside of the testing config. This is not an exhaustive list of what can be cleaned up, just an initial set that I found to unbreak Windows telememtry that's broken due to command line limit. Bug: 1045636 Change-Id: Ib2ac57218481321678cdc7b82ce8df8ffd871723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020424 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#735190}
-
Joe Downing authored
TBR: davidben@chromium.org Bug: 1045656 Change-Id: I709806abf7b4918f64a93156b01c9406c8520b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020540Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735189}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 23e3babc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If7d829f7237b6e4fd2938d4215e1065111bd66a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020492Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735188}
-
Omer Katz authored
This changes simplifies the tracing logic and avoid needing to manually call the write barrier on assignments. Bug: 986235 Change-Id: I2ae7b43241e1777dce4efcba5586ef2e1b0b1143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019282 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#735187}
-
Marijn Kruisselbrink authored
This splits of the permission specific parts from ChromeNativeFileSystemPErmissionContext and adds a base::Feature to enable picking which implementation to use. This is in preparation of implementing a new origin-based permission model, while still shipping the old tab-based permission model. Bug: 984769 Change-Id: Ib969278396135bb6da620e70cffdc25f13684d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017668 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#735186}
-
Carlos IL authored
This CL adapts webview tests to run with committed interstitials enabled, and fixes WebViewClient callback invocation issues with CI. All SafeBrowsing CTS tests pass with CI as of this CL, except for android.webkit.cts.WebViewClientTest#testOnSafeBrowsingHit which is fixed in the follow-up CL. Tests will be enabled for committed interstitials using fieldtrial_testing_config.json once the blocking bugs are fixed. Bug: 1031315, 1022477 Change-Id: Iadf1848cd91c29fd3b841429f74fb4e3464a055f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909276 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735185}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9403c3fc39e8..bf4e7a722ba4 git log 9403c3fc39e8..bf4e7a722ba4 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 agable@chromium.org [lucicfg] Update v1.11.17 -> v1.11.18 Created with: gclient setdep -r src/third_party/depot_tools@bf4e7a722ba4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1035470 Tbr: agable@chromium.org Change-Id: I2b133bddf1cfc8b27d670b0a5b94231c9c09c71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020678Reviewed-by:
-
Daniel Murphy authored
This change removes IndexedDB's custom writing of blobs to IndexedDB in lieu of the new WriteBlobToFile API in BlobStorageContext. That API has way more tests than what IndexedDB is doing, and allows IndexedDB to de-couple from using file paths at all. This change also modifies the blob storage WriteBlobToFile code to: 1) Handle the case where the Blob entry has an 'unknown size' length, 2) Add tests for a directory not existing R=mek@chromium.org Bug: 1024966,1015214 Change-Id: Ib7c33ecafd4821203d62654c941b9879ef77db25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994009 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735183}
-
Darwin Huang authored
sqlite 3.31.0 upgrade changes: https://sqlite.org/releaselog/3_31_0.html Bug: 1045591 Change-Id: I564c970c58688acc04af6e3ad578704390180fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020531Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735182}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/955353d9a221..a033371f89e8 Created with: gclient setdep -r src-internal@a033371f89e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045005 Tbr: jbudorick@google.com Change-Id: I108b65648f1ad90d7cffe2bc749bb674727896e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020675Reviewed-by:
-
Eric Karl authored
When we started evicting SW discardable image decodes, we regressed the cache hit rate in low-end, where the GPU discardable limit is very low. Bump this by 512KB, which should be fine as the earlier change reduced SW discardable by ~1MB. Bug: 1029875 Change-Id: I8bcbbd57a4c58f045966aee83993a05f6e302db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020612 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#735180}
-
Ryan Sturm authored
This feature allows us to experiment on Google without possibly creating issues with non-Google DSEs. This will hopefully prevent problems or regressions with other search engines. Bug: 1036489 Change-Id: I688338981460ab3b532577b1bc176fde89fd3e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020534Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#735179}
-
Fredrik Söderquist authored
Moves svg/stroke/pathlength-* and svg/dom/path-queries-pathLength.html to WPT, splitting the latter into two while converting the former to SVG. Change-Id: I04d404dc5f074d4278e5d081a12b960cf1ec98fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019366 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#735178}
-
Michael Forney authored
https://chromium.googlesource.com/linux-syscall-support.git/+log/7bde79cc274d..f70e2f1641e2 $ git log 7bde79cc2..f70e2f164 --date=short --no-merges --format='%ad %ae %s' 2020-01-22 mforney Avoid conflict with pread64/pwrite64 defined by libc Created with: roll-dep src/third_party/lss Change-Id: I5d9d0dbecd7f1ce1f8beb74eb5a5d7b3dec246ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020542Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#735177}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/27ebf37d26a7..1ea8fb7e2ef3 git log 27ebf37d26a7..1ea8fb7e2ef3 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 dberris@chromium.org E-Divisive: Widen Range of Candidates Created with: gclient setdep -r src/third_party/catapult@1ea8fb7e2ef3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1041688 Tbr: oysteine@google.com Change-Id: I97de1a1dcc5314669d8d8e9d6d6f2433e645220e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020672Reviewed-by:
-
Lukasz Anforowicz authored
This CL removes the |reverse_on_redirect| out parameter from the //content-public version of the BrowserURLHandler::RewriteURLIfNecessary method. This is justified by the fact that outside of //content all callers of that method would ignore this out parameter. The CL keeps the |reverse_on_redirect| in the //content-internal overload of the method in BrowserURLHandlerImpl, because the |reverse_on_redirect| out parameter is used from the NavigationControllerImpl code. This CL is intended to be pure refactoring and should introduce no behavior changes. This is followup from discussion in r735048. Bug: 1029161 Change-Id: I4d4322495604d7d67ddf22668eeab33c70fe0cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993724 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735175}
-
wutao authored
This is a preparation to allow access assistant_client in ash directly. It will be called in assistant_context_controller to cache/clear assistant structure. Bug: b/145218971 Test: manual Change-Id: I1b3aa16cd7859ff42366776622d2cee6549c5085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013488 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735174}
-
David Black authored
In conversation starters V2, conversation starters are fetched from the server using the dedicated ConversationStartersClient. When the server call fails to result in a set of conversation starters, we fallback to locally provided conversation starters. Note that this CL fetches as the UI is becoming visible to maximize freshness. This logic may need to be changed once we assess latency. Bug: b:148246719 Change-Id: Icc978d95588cb2088fd7aa7df83be69ded9cb22a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017916 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53faba1c7d1d..5f86e050c2e8 git log 53faba1c7d1d..5f86e050c2e8 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 cjamcl@chromium.org Add MotoG4 images to BUILD Created with: gclient setdep -r src/third_party/devtools-frontend/src@5f86e050c2e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:924693 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf9a0ee95a76e586a8319a7c6a80a70961a65353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020673Reviewed-by:
-
Regan Hsu authored
Copies strings that are used by both OS language page and browser language page top level polymer component, and moves strings used exclusively by OS from browser string provider to OS string provider. Bug: 967888 Change-Id: Ibcba8359e29fa81380ab152e1b7eba6dad27e3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020325 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#735171}
-
Sergey Ulanov authored
Previously fuchsia.media.cdm didn't support unencrypted blocks in secure media streams. See fxb/38253 . To workaround that issue FuchsiaSecureStreamDecryptor had to wait for a valid key_id. This issue is fixed now: CDM API now supports ENCRYPTION_SCHEME_UNENCRYPTED, so the workaround is no longer needed. Updated FuchsiaSecureStreamDecryptor to use the new encryption scheme and removed the workaround. Bug: 1012525 Change-Id: I079948a63c53d7fecdbd877452d1aaa1ec7477e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020537Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735170}
-
