GitLab

This puts the newly added-back vertical margin experiment into
about:flags as well.

Bug: 931332
Change-Id: I8ea314e3ffdefeb434f724b4ef8eb6948737f267
Reviewed-on: https://chromium-review.googlesource.com/c/1470741Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631952}

The test performs a synthetic click from an OOPIF over the OOPIF.
Synthetic mouse clicks over OOPIFs are broken in web_tests due to issue
895001, however this test happens to pass due to the incorrect behaviour
described in issue 923497. Once 923497 is fixed, this test will no longer
pass, so we have the test run without site isolation.

Bug: 895001
Change-Id: I73d8eca31953dab6e19a21e31af130bcbff2c1b9
Reviewed-on: https://chromium-review.googlesource.com/c/1457120Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631951}

Add last feature to UseGoogleLocalNtp experiment.

Bug: None
Change-Id: I06e3ef9caded7fc19735ca0dbf44bc2ea97098a7
Reviewed-on: https://chromium-review.googlesource.com/c/1470975
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631950}

Bug: 924160
Change-Id: I0f7471c8222f21d9707586cb67d54ae243f756ea
Reviewed-on: https://chromium-review.googlesource.com/c/1471012
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631949}

Bug: 719176
Change-Id: I294c4b9b4dd51e9e507e790e901519a882a0ced6
Reviewed-on: https://chromium-review.googlesource.com/c/1462379Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631948}

When setting state=FAILED, we need to assign a fail_state.

Bug: 908991
Change-Id: Id6694bf1e0a5d071a14e1e884b8b319d8f685988
Reviewed-on: https://chromium-review.googlesource.com/c/1470747Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#631947}

This reverts commit 53c99aa1.

Reason for revert: New tests fail on Webkit Win10:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Win10/45950

Original change's description:
> Add vp9-alpha + canvas layout test.
> 
> Apparently we don't have any vpx-alpha layout tests, hence macOS has
> had broken support here for some time.
> 
> BUG=919015
> TEST=fails without the macOS alpha fix.
> 
> Change-Id: I1103f3fd747ca62eff938824bdc0e52899495f64
> Reviewed-on: https://chromium-review.googlesource.com/c/1468597
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631877}

TBR=dalecurtis@chromium.org,dcastagna@chromium.org

Change-Id: Ie0b6c6262b6456813c3fab097f8862989885a48e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 919015
Reviewed-on: https://chromium-review.googlesource.com/c/1471350Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631946}

Though none garbage-collectable Blink objects should be allocated by
PartitionAlloc instead, some objects of //third_party/blink/renderer/bindings/core/v8
has not allocated by the PartitionAlloc so far. This CL adds
USING_FAST_MALLOC() to the classes to make them allocate the memory
from the FastMalloc partition of PartitionAlloc.

But, some of the objects need to use STACK_ALLOCATED() or DISALLOW_NEW().
In such cases, this CL use them instead of USING_FAST_MALLOC().

Bug: 919389
Change-Id: Ic615f17886767dcd0ff4d9a8d9484d96f577af40
Reviewed-on: https://chromium-review.googlesource.com/c/1468859Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#631945}

As a step to deprecate GaiaCookieManagerService, this CL replaces all uses of
GaiaCookieManagerService with AccountsCookieMutator's ones.

Bug: 926873
Change-Id: I04afc8cb5d3576fe1a5281945297e68ca3e5f34b
Reviewed-on: https://chromium-review.googlesource.com/c/1460752Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#631944}

The dash looks like a negative time value. "SPM" is easily found in
code search.

Tweaks the expectations for some fragile shelf view tests that depend
on the exact width of the shelf. I changed the values so the tests will
fail when the "SPM" indicator is removed, to ensure that I clean up
the tests.

Bug: none
Change-Id: Id751760b2786730c479db09ad18e1e6e841119b0
Reviewed-on: https://chromium-review.googlesource.com/c/1466026Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631943}

Added desktop representatives story tag
Method explanation: https://docs.google.com/document/d/1svVVzxk6Lzdjs3WoRMzcKXNTHPfxatlxtbHooSZ0xFU/edit?usp=sharing

17 pages are included in "representative_win_desktop" tag
22 pages are included in "representative_mac_desktop" tag

example of clustered pages:

windows: https://chromeperf.appspot.com/report?sid=b5e731fccfe456b5c7e9e774613513d91926d83610b3c4c548665dc40a8e5b91&start_rev=577077&end_rev=630262
mac: https://chromeperf.appspot.com/report?sid=2425cbaeda8b72903f979fe233c9017fd9eafe2a9fde9818a356cd7fcfb285b7&start_rev=600647&end_rev=630346

Bug: chromium:926995
Change-Id: I1e9aa817dc950bd748603e58196d56b5ad006377
Reviewed-on: https://chromium-review.googlesource.com/c/1457009
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631942}

VizDisplayCompositor has launched on Windows/Linux/Mac. It's enabled for
100% of users in M71+ by finch and default enabled as of M73. Remove
flags entry to prevent turning off the feature and hitting untested
code.

VizDisplayCompositor is almost ready to start the launch process on
Chrome OS. It should basically work with a couple minor issues. Add
flags entry on Chrome OS to allow testing.

Bug: 730193, 732805
Change-Id: I99e4592f8d4ea9a16061e148d7db71153f31e9d2
Reviewed-on: https://chromium-review.googlesource.com/c/1471215Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631941}

This CL was uploaded by git cl split.

R=nharper@chromium.org

Bug: 926235
Change-Id: Ib074504cd24f62401801554e188a18e480bf6d96
Reviewed-on: https://chromium-review.googlesource.com/c/1463501
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631940}

No change to logic or behavior. This only creates a header file for
android_webview::CookieManager. This is necessary for implementing
Cookies APIs for the NetworkService code path, although it's also nice
since chromium generally follows the convention that we define classes
in header files.

Bug: 902641
Test: N/A
Change-Id: I3f7fc7ce8321a4ac7b3016c1a2f0366a9c60958b
Reviewed-on: https://chromium-review.googlesource.com/c/1469425
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631939}

Bug: None
Change-Id: I3d478c275084ded83556d1f730285f1a8bfb3ab0
Reviewed-on: https://chromium-review.googlesource.com/c/1464134Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631938}

Add the followings for the TabModelFilter framework setup:
  1. TabModelFilter, skeleton class for filtering tabs.
  2. TabModelFilterObserver, interface to be notified when
     TabModelFilter changes.
  3. EmptyTabModelFilter, empty implementation of TabModelFilter.

Change-Id: Ifc4f3fc5bfe85f789494d06dacaf4291ec785de5
Bug: 930960
Reviewed-on: https://chromium-review.googlesource.com/c/1461689
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631937}

This will use GPU because we do not have vulkan software rasterization.
Main changes:

1) Have SkiaOutputSurfaceImplOnGpu create an offscreen render surface
   when there is no AcceleratedWidget to render to.

2) Have unittests create a VulkanInstance when making their own
   GpuServiceImpl.

Bug: 930740
Change-Id: Ie5b837bac1bcc5576913c8b1019d34196949d6de
Reviewed-on: https://chromium-review.googlesource.com/c/1464652
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631936}

R=kariah@chromium.org

Change-Id: Id365225d2d1cc2c040ecff67abe5723b12c3d924
Reviewed-on: https://chromium-review.googlesource.com/c/1470527Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631935}

Reenable Skia fuzzers from OSS-Fuzz.
Fix issue breaking textblob_deserialize and image_filter_deserialize
fuzzers.
Add an OWNERS that includes myself and others involved in this effort.

Bug: 903632
Change-Id: I69da3ff34b90ea9acf84c5d1280584b305bebfe5
Reviewed-on: https://chromium-review.googlesource.com/c/1464643
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631934}

TBR: elvin
Change-Id: I7624a09957cfeb29ae157811a21f7ce3ec83b360
Reviewed-on: https://chromium-review.googlesource.com/c/1471235
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631933}

This CL:
* Eliminates NetworkState::IsReconnecting() which would require an
  extra property in the forthcoming mojo network state type.
* Removes the 'Reconnecting' string from the network list UI in the
  system menu ('Connecting' will be shown instead).
* Sets 'connect requested' when transitioning from a connected state
  to a connecting state to better inform the UI when a connecting
  state is important.

Bug: 931506
Change-Id: I06b245f61133edeb6b17b307e0ef8f973f832cd2
Reviewed-on: https://chromium-review.googlesource.com/c/1469428Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631932}

Bug: 931689
Change-Id: I2ee4f576d7054e2dad2beedf016e7d5cd7a97662
Reviewed-on: https://chromium-review.googlesource.com/c/1471231
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631931}

Revert "AudioBus: Convert deprecated uses of FromInterleaved(Partial)/ToInterleaved, remove deprecated ToInterleavedPartial"

This reverts commit e8e3eced.

Reason for revert: Breaks Google ChromeOS compile

https://logs.chromium.org/logs/chromium/bb/chromium.chrome/Google_Chrome_ChromeOS/61651/+/recipes/steps/compile/0/logs/raw_io.output_failure_summary_/0

../../chromeos/services/assistant/audio_decoder/assistant_audio_decoder.cc:139:30: error: unknown type name 'SignedInt16SampleTypeTraits'; did you mean 'media::SignedInt16SampleTypeTraits'?
audio_bus->ToInterleaved<SignedInt16SampleTypeTraits>(audio_bus->frames(),
^~~~~~~~~~~~~~~~~~~~~~~~~~~
media::SignedInt16SampleTypeTraits
../../media/base/audio_sample_types.h:213:7: note: 'media::SignedInt16SampleTypeTraits' declared here
using SignedInt16SampleTypeTraits = FixedSampleTypeTraits<int16_t>;
^
../../chromeos/services/assistant/audio_decoder/assistant_audio_decoder.cc:139:16: error: no matching member function for call to 'ToInterleaved'
audio_bus->ToInterleaved<SignedInt16SampleTypeTraits>(audio_bus->frames(),
~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../media/base/audio_bus.h:265:16: note: candidate function template not viable: no known conversion from 'std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >::value_type *' (aka 'unsigned char *') to 'typename FixedSampleTypeTraits<short>::ValueType *' (aka 'short *') for 2nd argument
void AudioBus::ToInterleaved(
^
2 errors generated.

Original change's description:
> AudioBus: Convert deprecated uses of FromInterleaved(Partial)/ToInterleaved, remove deprecated ToInterleavedPartial
> 
> There is no intended behaviour change.
> 
> Bug: 619623
> Change-Id: I38a3b3b11d81fcec1278855592cde0c355c6e69a
> Reviewed-on: https://chromium-review.googlesource.com/c/1461388
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Yuri Wiitala <miu@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
> Reviewed-by: Tao Wu <wutao@chromium.org>
> Reviewed-by: Max Morin <maxmorin@chromium.org>
> Commit-Queue: Raul Tambre <raul@tambre.ee>
> Cr-Commit-Position: refs/heads/master@{#631900}

TBR=bbudge@chromium.org,dalecurtis@chromium.org,miu@chromium.org,sergeyu@chromium.org,maxmorin@chromium.org,kmackay@chromium.org,wutao@chromium.org,raul@tambre.ee

Change-Id: I4a9a09e8e1e8e5a316144a636dff204b9db74888
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 619623
Reviewed-on: https://chromium-review.googlesource.com/c/1471304Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631930}

Extension developers have kindly tested that their extensions are not
affected by CORB or have fixed their extensions to avoid making
cross-origin requests from content scripts.  Such extensions can be
removed from the CORB allowlist.

Bug: 846346
Change-Id: Ib6d2606bc1f966d39cd09cdaf1fcc4da7202f228
Reviewed-on: https://chromium-review.googlesource.com/c/1405432Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631929}

Screenshots:
With Vasco = https://screenshot.googleplex.com/WKrBtaTnksc.png
Without Vasco = https://screenshot.googleplex.com/BRiZQfbwkuv.png

Vasco will be fixed in a follow-up server-side change.

Bug: 923563
Change-Id: I1fb70dad609af8264085bd85f78c7a7cc036fb65
Reviewed-on: https://chromium-review.googlesource.com/c/1468821Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631928}

http://crrev.com/497194 blocked auditing of extension pages and
remote debugging to avoid crashes. These crashes are gone, and users
are very interested in running Audits panel while remote debugging.

Bug: 734532, 931849
Change-Id: I8b6109062cadd1e76e02a7a235a0627af1b24d97
Reviewed-on: https://chromium-review.googlesource.com/c/1471112
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631927}

Introduces StringUTF8Afapter trait for the protocol generator.

Bug: 929862
Change-Id: Ib1626da948bcbf896429267e5a0ebfa273d6bd27
Reviewed-on: https://chromium-review.googlesource.com/c/1470748Reviewed-by: Johannes Henkel <johannes@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631926}

WindowTreeHost exposes a pixel API, but this doesn't fit well with the
window-service, which operates in DIPs. This provides DIP based functions on
WindowTreeHostMus that in turn call the pixel functions, but remembers the DIP
values. This is important at fractional scales, to minimize rounding errors.

BUG=929894,929914
TEST=covered by tests

Change-Id: I295c4a01e704bf2ce0198366203a3ef90501e6c8
Reviewed-on: https://chromium-review.googlesource.com/c/1469283Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631925}

Bug: 902354, 872096
Change-Id: I96be17278c7cc0147871675e67552cab123a180d
Reviewed-on: https://chromium-review.googlesource.com/c/1452480Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631924}

This change adds ElementTiming support for SVGImageElements. It adds a
layout test to verify that the entry is being created in a simple
example.

Bug: 879270
Change-Id: I39ae0a1209f1b299d6a431ac1ba2fcfa94b25b3e
Reviewed-on: https://chromium-review.googlesource.com/c/1467918
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#631923}

generator_shared_target_name target of mojom template has generated header as public header.
So action generating the header needs to be in public_deps.

See below reference for more details.
https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps

Bug: 931596
Change-Id: I2c60ecb8ce82330edfe9115378e42d00f06124fc
Reviewed-on: https://chromium-review.googlesource.com/c/1469856
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#631922}

This test is changing with an upcoming webrtc update.
Temporarily disabling the test until the roll and the expectations
are updated.

Bug: webrtc:10075
Change-Id: If1c9d339498e4d065babedc5b3be194e3f822414
Reviewed-on: https://chromium-review.googlesource.com/c/1471011Reviewed-by: Steve Anton <steveanton@chromium.org>
Commit-Queue: Amit Hilbuch <amithi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631921}

- Hide voice model settings if activity control state is false.
- Add a min-width to the DspState select box.

Bug: b/124246347, b/123376071
Change-Id: Ie025778aaf3173a9c8cb3fa56f0b6aff143d1704
Reviewed-on: https://chromium-review.googlesource.com/c/1464436
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631920}

xkb_keysym.h includes ui/base/buildflags.h, so action target generating ui/base/buildflags.h
needs to be in public_deps.

See below reference for more details.
https://gn.googlesource.com/gn/+/master/docs/reference.md#var_public_deps

Bug: 931596
Change-Id: Ib4d4a90c4dd700730dd43c1bd488c8dce43f2acf
Reviewed-on: https://chromium-review.googlesource.com/c/1469818Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Gary Kacmarcik <garykac@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631919}

https://chromium-review.googlesource.com/c/chromium/src/+/1455266 was
reverted but developing the CL uncovered an existing problem highlighted
by these tests. alexclarke@ is working on fixing that in parallel so we
can reland the tests (DISABLED for alexclarke to enable when
base/task/sequence_managre is fixed).

TBR=alexclarke@chromium.org, fdoray@chromium.org

Bug: 885371, 929263, 930940
Change-Id: I137322736ae8d21265c9bbf3c5442210662df837
Reviewed-on: https://chromium-review.googlesource.com/c/1471233Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631918}

Bug: chromium:930833, chromium:931417
Change-Id: Ib110d5291477f7ae45e474539dfdba932e6a3cac
Reviewed-on: https://chromium-review.googlesource.com/c/1471212
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631917}

This reverts commit e14b9977.

Reason for revert: Broke NVIDIA Shield TV bots on GPU waterfall per Issue 931705

Original change's description:
> [Background Sync] Add field trial testing config
> 
> for using BackgroundTaskScheduler to wake Chrome up.
> This is necessary to be able to roll the change out on Beta and
> Stable.
> 
> Bug: 924490
> Change-Id: I63d2ef5c8bab06b247525cfa8f3f0c037ecb43cb
> Reviewed-on: https://chromium-review.googlesource.com/c/1463440
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Commit-Queue: Mugdha Lakhani <nator@google.com>
> Cr-Commit-Position: refs/heads/master@{#631636}

TBR=isherman@chromium.org,nator@chromium.org

Change-Id: I8423d28795ada1db4dde6f508374e9e4b2bc670c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 924490, 931705
Reviewed-on: https://chromium-review.googlesource.com/c/1471243Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631916}

Catch more edge cases where last committed item can be nil if
navigating when about://newtab is still loading.

Bug: 931273
TBR: sdefresne@
Change-Id: I29bdd0a5f8c5b6e9a098face36c87c6bc0b5ee13
Reviewed-on: https://chromium-review.googlesource.com/c/1469427
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631915}

This reverts commit be13c389.

Reason for revert: Looks like this caused fast/workers/worker-constructor.html to fail, e.g.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20%28retina%29/10222

Original change's description:
> Updating test from legacy harness
> 
> Updating some tests in fast/workers from the legacy test harness to
> testharness.js in preparation to be upstreamed to external/wpt/workers.
> 
> Bug: 795636
> Change-Id: I0ccda4a23d6ac54c34fe60613ce6559d6681434d
> Reviewed-on: https://chromium-review.googlesource.com/c/1451424
> Commit-Queue: Katie Dillon <kdillon@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631812}

TBR=hiroshige@chromium.org,nhiroki@chromium.org,kdillon@chromium.org

Change-Id: I068d391e225d2090a42644adc9f79536f03cafd3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 795636
Reviewed-on: https://chromium-review.googlesource.com/c/1471263Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631914}

This makes it focusable with the keyboard via F6.

Bug: 930971
Change-Id: I3f277217443672be4136f9728bfd0a4f2d35f17d
Reviewed-on: https://chromium-review.googlesource.com/c/1465554Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631913}