- 20 Mar, 2020 40 commits
-
-
Mason Freed authored
This CL adds the ability to control the delegatesFocus (and eventually the manualSlotting) parameter of the attachShadow command using declarative Shadow DOM. Bug: 1042130 Change-Id: I8cc973ca196151fdc29a1194e25eb86f15849e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107362 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#752229}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1893040e26c0..c51d2249e898 Created with: gclient setdep -r src-internal@c51d2249e898 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I88fd1fd094732f011a21f9430d78242db9159e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113313Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752228}
-
David Van Cleve authored
This CL adds a new Mojo interface to the network service, HasTrustTokenAnswerer, providing one method HasTrustToken(url.mojom.Origin issuer) => (error or bool) returning whether the user has any trust tokens (https://github.com/wicg/trust-token-api) for the token issuer origin given by |issuer|. The method first checks if it can associate the calling top-level context (in the sense of TrustTokenStore::SetAssociation) with |issuer| and, if not, fails. For this reason, each instance of the interface is logically scoped to a single top-level context; it is expected that, when the interface is provided to the renderer, each Mojo handle will be bound to a single calling context (with a fixed top-frame origin). This will be used to implement the Trust Token API's Document.hasTrustToken method as a thin wrapper around the Mojo interface (see the child CL at https://crrev.com/c/2103082). Test: adds unit tests Bug: 1061116 Change-Id: Ie67858d65f0fa3a61820db79a904678f4932179d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103079Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#752227}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fa64482db516..c81db8c596ed git log fa64482db516..c81db8c596ed --date=short --first-parent --format='%ad %ae %s' 2020-03-20 ehmaldonado@google.com git-cl: Remove GetIsGerrit. Created with: gclient setdep -r src/third_party/depot_tools@c81db8c596ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ic97bcda2219bb71cbdc14f0ae3f4a9da23fda305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#752226}
-
Qingwen Pi authored
This implementation will be used in multizone code to remove ::media::DecoderBuffer dependency. Bug: b/149422033 Change-Id: Ic4c327e7c69b5136a02de91487db2f2beb32201d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113438 Commit-Queue: Qingwen Pi <qwp@google.com> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#752225}
-
Martin Barbella authored
Change-Id: Ic4ef7ae917e6e75e0e6700c2b7676ca18230f839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113077 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#752224}
-
Khushal Sagar authored
TBR=dcastagna@chromium.org Bug: 976583 Change-Id: Icb35e67674cf1e4b1e60c3eaded37d2236b2026f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112987 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#752223}
-
Yue Zhang authored
Bug: 1035995, 1063334 Change-Id: I8e5e03ea7919665e7b2f97a6ec53306c41acc828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112986 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752222}
-
Demetrios Papadopoulos authored
Specifically moving the following surfaces: - manage_profile.html subpage was already a dependency of lazy_load.html, but it was also (accidentally) still a dependency of people_page.html, causing it to be part of vulcanized.html in Polymer 2 and shared.rollup.js in Polymer 3. - signout_dialog.html and import_data_dialog.html similar to previous change for the CBD dialog. - sync_controls.html and sync_page.html subpages vulcanized.html: 276K -> 234K (-15%) crisper.js: 336K -> 299K (-11%) lazy_load.vulcanized.html: 183K -> 226K lazy_load.crisper.js: 233K -> 271K Also updating Polymer3 related files (settings.js, lazy_load.js) accordingly. Bug: 1026064 Change-Id: I790a29074181b9f908290b76e74aea98b3d1e86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110675 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#752221}
-
danakj authored
This was included for a single method, which does not need web test stuff at all. Move the method (and its companion) over to another file in content/public/test/. R=nasko@chromium.org Bug: 866140 Change-Id: Iad7d324b4c2d839d406b09d4f1c2397c523c309b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112902 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#752220}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/9d6efa3a2860..dba08d7f6fed git log 9d6efa3a2860..dba08d7f6fed --date=short --first-parent --format='%ad %ae %s' 2020-03-20 miu@chromium.org Cast Streaming Sender: Add network bandwidth estimation Created with: gclient setdep -r src/third_party/openscreen/src@dba08d7f6fed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I662a6ec9fbf7b81b4b3c211e0d7a57e73dc122ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113312Reviewed-by:
-
John Rummell authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/d2350e1645b5..31886e8f39a4 $ git log d2350e164..31886e8f3 --date=short --no-merges --format='%ad %ae %s' 2020-03-20 jrummell Revert "Add configure flag --disable-mips32r6 for Linux MIPS64 builds" 2020-03-18 jrummell Check that ogg stream contains enough data while checking codec 2020-03-17 liberato Upload ffmpeg configs, etc., for review if tests pass. Created with: roll-dep src/third_party/ffmpeg Bug: 1054229 Change-Id: I3c60e5b749208a937e477dfd31312a2f5c780669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112980Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#752218}
-
Yuke Liao authored
Due to a limitation in the Clang coverage tooling, coverage profling from browser_tests often get corrupted on coverage CI builders on Linux platform , so this CL runs browser_tests without sandbox, and this CL only applies to the CI builder (not CQ). Bug: 1016929 Change-Id: Ic5e2ca3ebb2ea1a77c8456689e2513318b67c5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112985Reviewed-by:
Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#752217}
-
David Bokan authored
The source of the attached bug is calls to ScrollableArea::ShowOverlayScrollbars from PaintLayerScrollableArea::VisibleSizeChanged. This call is performed to flash scrollbars when a scroller is initialized or resized. However, this behavior doesn't apply on the Mac platform. ShowOverlayScrollbars sets the overlay state to showing in ScrollableArea which makes scrollbars visible to hit testing. On non-Mac platforms it'll also cause scrollbars to be visibly shown; however, this mechanism doesn't actually cause scrollbars to paint visible on Mac - that's handled by ScrollAnimatorMac and there's no signal to it to do so here. Furthermore, it starts a timer to fade out the scrollbars but this only happens on platforms where Chromium code owns scrollbar fade out (Android, ChromeOS). This means that on Mac we're in a situation where the scrollbar is visible to hit testing but isn't visible on the screen. This causes us to inadvertently send mouse enter events to the scrollbar causing it to activate unexpectedly. The solution here is to avoid setting the overlay state from this method on Mac. We already plumb all the necessary signals (like content resize) to ScrollAnimatorMac so it should be in full control of the scrollbar visibility state. This CL splits the setter method into one that's called only from Mac's scrollbar painting APIs and one that's called from all the other places where its needed. This allows us to DCHECK that we're not setting this value without going through the Mac painter. Some additional notes: - Select listboxes have an overflow-y:scroll style which means they should get a scrollbar even when there's no overflow. However, there appears to be some issue here; during page load, the listbox adds and then removes its scrollbar. When clicked, it then adds a vertical scrollbar. This happens due to a style-related change (probably focus). It's not clear to me why the scrollbar was removed but this is the reason the test case in https://crbug.com/1039501#c22 requires a click to reproduce. Perhaps we should only be adding scrollbars for non-overflowing content when they're non-overlay. - The scrollbar doesn't fade out because the MouseMovedInContentArea signal is sent only if the scrollable area has overflow (see EventHandler::HandleMouseMoveEvent). It's not clear if that's correct but at the very least it should be up to the ScrollableArea to determine that. The signals for MouseEnteredScrollbar and similar do not have a similar restriction. They probably should (or DCHECK that the scroller has overflow). This can be done in a followup. - It's not clear to me why the geometry of the scrollbar is wrong; it's a small square located on the left rather than right of the scroller. My guess is that it's unexpectedly shown and the code doesn't handle the case where there's no overflow but I haven't investigated this. Bug: 1039501 Change-Id: Id7ba50ffa18994f0fe757f0881be4b7db68df60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110676Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#752216}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/62b7255252fd..07467b4acaa6 git log 62b7255252fd..07467b4acaa6 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 geofflang@chromium.org Remove GL_CHROMIUM_path_rendering 2020-03-20 geofflang@google.com Android.bp: Ignore unknown warning flags. 2020-03-20 sugoi@google.com ASTC: LDR support doesn't imply HDR support 2020-03-20 thakis@chromium.org Suppress two -Wunreachable-code warnings on Fuchsia in Angle. 2020-03-20 jmadill@chromium.org Vulkan: Fix Framebuffer cache depth/stencil issue. 2020-03-20 jmadill@chromium.org Add optimized rendering feedback loop tracking. 2020-03-20 cnorthrop@google.com Perf: Limit TracePerfTest to single compressed TRex Created with: gclient setdep -r src/third_party/angle@07467b4acaa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1063193,chromium:346399 Tbr: courtneygo@google.com Change-Id: I2afabd50f1fe5618786d138eee3132b1d4b82aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112977Reviewed-by:
-
Scott Violet authored
weblayer shell has a slightly smaller height than chrome. The size is such that this test ends up failing because the generated touch event is outside the visible area. This patch shrinks the height slightly so that it passes on weblayer. I don't believe shrinking the height of this target impacts the overall test.. BUG=1049426 TEST=test only change Change-Id: Ie0f2fadc4ec613d92c074b60eb87c97d70f78094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112984Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#752214}
-
Robert Ma authored
The test does not seem to be flaky recently. TBR=smcgruer Fixed: 986477 Change-Id: Ic09e0466315be8d39d7acfe406be5e6bfd29525a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113511Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#752213}
-
Yue Zhang authored
As it is suggested here https://cs.chromium.org/chromium/src/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/CriteriaHelper.java?l=113&rcl=2e9059b1209182ea41862d3cba9375a7ea179dd4, pollUiThread should be the more proper one used in InstrumentationTests. This CL replaces the pollInstrumentationThread usage with pollUiThread in tab_ui tests if appropriate. Also, this CL re-enables the tests disabled here http://crrev.com/c/2108528 to see if this CL fixes the real culprit. Bug: 1062659 Change-Id: I986d1904f8963588014ca6d203d10f453148497f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109125 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Removes one browsertest each from the bluetooth, serial, and usb chooser dialogs; these browser tests covered the "bubble dismisses on navigation" behavior, which is now provided by LocationBarBubbleDelegateView and tested as part of that class's tests. 2) Removes some code from VRUiHostImpl that observed the chrome BubbleManager. This code was now dead, since no bubbles use the BubbleManager any more. 3) Removes ChooserBubbleDelegate, the only remaining BubbleDelegate in //chrome, now no longer used anywhere. 4) Removes ChromeBubbleManager, now no longer used anywhere. 5) Removes dependencies from //chrome on //components/bubble. Bug: 496955 Change-Id: Ife81ad2ae9e5409e4a78fe2f4ac8df81decccdc2 Tbr: rdevlin.cronin@chromium.org,avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112234 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#752211}
-
Luum Habtemariam authored
We previously implemented this generic ppd as a fallback for Epson printers that failed ppd matching. This led to some unforeseen issues detailed in the bug below; as such this special handling is no longer needed and this change removes it. Bug: chromium:1049850 Test: tba Change-Id: I45c9dce72205f8ed9255d983cac8b1a739fa388a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087959 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#752210}
-
Chris Harrelson authored
This is a re-land of [2]. It was reverted due to a flakiness introduce in [3]. The reason for the flakiness appears to have a couple of sources: (a) sometimes the image for one of the ref/non-ref will load a bit faster (b) scrollbars present in the ref case, because the image is not clipped by overflow:hidden (c) 8px margin (a) is fixed by using reftest-wait. (b) is fixed by adding overflow:hidden to the HTML element; (c) is fixed with margin:0. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1773869 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2103708 [3] external/wpt/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html Bug: 992765, 999019, 995119, 999209, 1045745 Change-Id: I6ad8c5564f65d131da9b04180499a4bd98a4c8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111906Reviewed-by:
-
Rakina Zata Amni authored
We've added a "level" param for ProactivelySwapBrowsingInstance in https://chromium-review.googlesource.com/c/chromium/src/+/2043521, so we should update the field trial config. See cr/301790432. Bug: 977562 Change-Id: Ica9231513f541c93e8085b0f06a73bc36fcaed2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109578 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#752208}
-
Tricia Crichton authored
Improve the standard message on the need to protect ChromeDriver. The current message is sometimes taken by users as an error statement. Bug: chromedriver:3351 Change-Id: Ic4d8f7bd4413a5472288133b52c0d61b97665849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108786Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#752207}
-
Eugene Zemtsov authored
Adding all WebMediaPlayer related memory dumpers to the allowlist for the background collection. It would let media memory data to be uploaded via standard memory reporting pipeline. Also making sure that play state is not reported in the backgounrd mode, otherwise it triggers a DCHECK. Bug: 1056839 Change-Id: Id19f588f286b011a30345f6d1f150e2788515fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112332 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#752206}
-
Dana Fried authored
ToolbarActionIconView now queries its delegate for icon size instead of it being a configurable parameter on creation. Parameter on creation didn't work anyway because the value would later be overridden when tablet mode was toggled (i.e. this never worked correctly). Bug: 1063423, 1061634 Change-Id: I586a7a0e8aa49649e2be08ad7c73b8113730ee98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112588Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#752205}
-
Martin Barbella authored
This is consistent with other attributes, and looks cleaner when adding grammars to targets. Change-Id: I149fc1bb2b0a515280d649a50d149de424b3a102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111391 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Auto-Submit: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#752204}
-
Taylor Brandstetter authored
This incorporates over a year and a half of changes, including several fixes for security vulnerabilities. Had been prevented from updating it due to a deadlock issue, however the commits that introduced that issue have been reverted. Intentionally not updating to tip-of-tree since there are changes in progress; will roll again when more confident things are stable. Commit log since last roll: https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/7a8bc9a90ca9..bee946a60675 Bug: chromium:1025302 Change-Id: Ie21cd4db12cbae07a764f6f1373eb964c88c56c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094540 Commit-Queue: Taylor <deadbeef@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#752203}
-
John Lee authored
Fixed: 964891 Change-Id: Idc993115825dffbcc6cb84edf5117d4b7430c751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110524Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#752202}
-
Brian Sheedy authored
Adds the configs for "Win10 FYI x64 SkiaRenderer Dawn Release (NVIDIA)" and its manual trybot counterpart "gpu-fyi-try-win10-nvidia-sk-dawn-rel-64". Bug: 1062399 Change-Id: I0a7ad25e9635fbf319bb6f02cc2e0fe8c0569019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111760Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#752201}
-
Wei-Yin Chen (陳威尹) authored
The parameter "thumbnail_aspect_ratio" is still not specified yet. See also: go/clank-sand-wedge Bug: 930979 Change-Id: Ie7318a57c041b39a6dd55b7929c9c1d80f21b40e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112112Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#752200}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fc407350ad45..bf198e71ef28 git log fc407350ad45..bf198e71ef28 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 thestig@chromium.org Initialize CPDF_TextState members in the header. 2020-03-20 thestig@chromium.org Mark CPDF_Parser::SetLinearizedHeader() as ForTesting. 2020-03-20 tsepez@chromium.org Make CFXJSE_Value use fxv8 helpers for aggregate type access. Created with: gclient setdep -r src/third_party/pdfium@bf198e71ef28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia6d23322f7c62e6ce80e964f1f4e87389348172f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113310Reviewed-by:
-
John Lee authored
https://imgur.com/a/8zA9Fxq Bug: 1048552 Change-Id: I10da9e12e233b4afade004a21a4ee25ba61d1c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112811Reviewed-by:
-
Vasiliy Telezhnikov authored
This CL converts resource_dirs to sources for android_resources in BUILD.gn files in chrome/ content/ and tools/. Details: https://crbug.com/1026378 https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/KAFsfaoq7y4/OC4v5sb9BQAJ Bug: 1062263 Change-Id: I2f4dc5c7e3cdb89c28398ddcfa1b5b21b2184282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108615 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#752197}
-
Adam Langley authored
This change switches the QR-based handshake from NNpsk0 to KNpsk0. I.e. it gives the desktop a public-key. That key is included in the QR code and means that an attacker who sees the QR code cannot impersonate the desktop and pair with the phone. (The other direction is still possible, however, and seems fundamental without the user entering a confirmation code on the desktop.) BUG=1002262 Change-Id: I7254a8aa17df71d2bcabb4371a1c18914ed20641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109032 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#752196}
-
Daniel Clark authored
I got mixed up when looking at the high contrast results for crrev.com/c/2083866 and thought that shading the hovered cells was correct. Instead, the old behavior for date/week as well as month, time, etc was to just draw an border for hover in high contrast mode. This change restores the old behavior of just drawing a border on hover for date and week in high contrast mode by mirroring the rules for these controls in the forced-colors block. Month wasn't broken by this because my change didn't affect the structure of its highlight rule in the same way that it did for date and week. Change-Id: I20fc850a782ade1170ea05653e454d827a59589c Bug: 1062017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103727 Commit-Queue: Dan Clark <daniec@microsoft.com> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#752195}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e5753d2fb87e..11652ff8f8b3 git log e5753d2fb87e..11652ff8f8b3 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 cwallez@chromium.org Implement the webgpu.h swapchains on Metal 2020-03-20 cwallez@chromium.org Change present modes to match webgpu.h Created with: gclient setdep -r src/third_party/dawn@11652ff8f8b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iabc5b4ae894d0f7233f2081b13eb83891e0e5e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112975Reviewed-by:
-
Patrick Monette authored
Now that all public functions of PerformanceManagerImpl() are static, the only remaining uses of GetInstance() was to check if the performance manager was initialized. Bug: 1013127 Change-Id: Id919af9cb9051bca45b911e5788fea0f83772ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108090 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#752193}
-
Lijin Shen authored
The bg color of pressed filled button is white, making the button invisible when being pressed. Bug: 1063302 Change-Id: Ie4937f5ba82d4b3ab741b5b397065b7ddd0d84f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112756 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#752192}
-
Johannes Henkel authored
New Rev: b7cda08cd6e522df2159413ba5f29d2a953cc1c4 Upstream Review: "Drop redundant std::move in inspector_protocol." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2112636 TBR=caseq Change-Id: I647ddff93daeb6b3d47f5736b2b5fc99e4214209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112978Reviewed-by:
Johannes Henkel <johannes@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#752191}
-
Evan Stade authored
The PermissionsClient is used to retrieve the chooser context based on the ContentSettingsType. WebLayer will not support USB for the time being, so it returns null for every type. Chrome's implementation only works for USB_CHOOSER_DATA but can easily be expanded to other *_CHOOSER_DATA types as needed. FooChooserContext::GetObjectName is also made a virtual non-static, renamed to GetObjectDisplayName with a return type of string16, which is what user-facing strings should always use. Bug: 1058600 Change-Id: Ida9c37aaa7ca84374640444c846afb08a3e286c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107801 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#752190}
-
