- 16 May, 2014 40 commits
-
-
caseq@chromium.org authored
This would let us link it to the inspected page in DevTools, as we already do with other events coming from LTHI. BUG=361045 Review URL: https://codereview.chromium.org/290083007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271074 0039d316-1c4b-4281-b951-d872f2087c98
-
bruening@google.com authored
TBR=zhaoqin@chromium.org BUG=NONE Review URL: https://codereview.chromium.org/287143005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271072 0039d316-1c4b-4281-b951-d872f2087c98
-
kaznacheev@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/274573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271071 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271070 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
NOTRY=true BUG=369680 Review URL: https://codereview.chromium.org/290143004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271069 0039d316-1c4b-4281-b951-d872f2087c98
-
johannkoenig@chromium.org authored
undo https://codereview.chromium.org/288033020 R=mallinath@chromium.org, tomfinegan@chromium.org Review URL: https://codereview.chromium.org/289003009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271068 0039d316-1c4b-4281-b951-d872f2087c98
-
sungmann.cho@navercorp.com authored
BUG=350233 Review URL: https://codereview.chromium.org/275373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271066 0039d316-1c4b-4281-b951-d872f2087c98
-
ttuttle@chromium.org authored
For privacy reasons, we want Domain Reliability uploads to be cookieless. Add a unit test for this. BUG=356791 Review URL: https://codereview.chromium.org/290093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271065 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
Few changes involved: 1) Using TestBookmarkClient to create BookmarkModel. 2) Removes unnecessary TestBrowserThreadBundle 3) With the above changes TestingProfile and BookmarkModelFactory goes away. BUG=367834 TEST=components_unittests --gtest_filter=BookmarkModel* R=blundell@chromium.org, sdefresne@chromium.org Review URL: https://codereview.chromium.org/291503007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271064 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
Impl side posts callbacks for releasing resources on SingleThreadProxy::Stop, and there is no reason to have these be real post tasks. BUG=344087 Review URL: https://codereview.chromium.org/284233005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271063 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271062 0039d316-1c4b-4281-b951-d872f2087c98
-
johannkoenig@chromium.org authored
Add arm64-specific build rules https://codereview.chromium.org/290653003 R=tomfinegan@chromium.org Review URL: https://codereview.chromium.org/288033020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271061 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Review URL: https://codereview.chromium.org/290003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271060 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
BUG=374305 R=boliu@chromium.org Review URL: https://codereview.chromium.org/289163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271059 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271058 0039d316-1c4b-4281-b951-d872f2087c98
-
andrewhayden@chromium.org authored
that only surfaces when using dynamic CLD. Dynamic CLD is not currently enabled on any platforms, making this a no-op on all platforms at present. For more information, see CLD2 issue 14: https://code.google.com/p/cld2/issues/detail?id=14 BUG=367239 Review URL: https://codereview.chromium.org/282133006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271057 0039d316-1c4b-4281-b951-d872f2087c98
-
ckocagil@chromium.org authored
R=brettw@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/266893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271056 0039d316-1c4b-4281-b951-d872f2087c98
-
hubbe@chromium.org authored
Currently, UdpTransport.SendAndReceive hangs forever if the hardcoded port it tries to use is occupied. This change makes it use a free local port instead. Review URL: https://codereview.chromium.org/283233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271055 0039d316-1c4b-4281-b951-d872f2087c98
-
siggi@chromium.org authored
Revert of Add instrumentation help figure out why the client ID is sometimes (https://codereview.chromium.org/275213003/) Reason for revert: We've collected enough data, so this instrumentation can now go. Original issue's description: > Add instrumentation help figure out why the client ID is sometimes > missing from uploaded crashes. > > BUG=371817 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269715 TBR=rsesek@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=371817 Review URL: https://codereview.chromium.org/287173003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271054 0039d316-1c4b-4281-b951-d872f2087c98
-
nednguyen@google.com authored
NOTRY=True NOTREECHECKS=True BUG=373812 Review URL: https://codereview.chromium.org/282383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271053 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
Review URL: https://codereview.chromium.org/278953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271052 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271051 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@google.com authored
Includes the deps2git roll to remove special cased ffmpeg setup. BUG=329002 TEST=gclient sync works R=mmoss@chromium.org Review URL: https://codereview.chromium.org/191553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271050 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271049 0039d316-1c4b-4281-b951-d872f2087c98
-
robertphillips@google.com authored
https://code.google.com/p/skia/source/list?num=1&start=14757 TBR= BUG= Review URL: https://codereview.chromium.org/287063008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271048 0039d316-1c4b-4281-b951-d872f2087c98
-
bulach@chromium.org authored
The underlying rule is now "long" by default. Mechanical change: git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d Relands crrev.com/270750 (reverted by 270849) BUG=317523 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/288223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271047 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
This also cleans up the main VLOG in renderer_accessibility_complete so that it uses the new function in ui to convert an AXEvent to a string, and removes the NDEBUG since this is quite useful logging in release builds. Instead of the old switch, use --vmodule="*accessibility*=0" to log accessibility messages that are normally suppressed, possibly combined with --enable-logging=stderr to send them right to your terminal and --log-level=2 to optionally suppress most other log messages. BUG=350457 R=aboxhall@chromium.org, jam@chromium.org Review URL: https://codereview.chromium.org/284203005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271046 0039d316-1c4b-4281-b951-d872f2087c98
-
ttuttle@chromium.org authored
Don't waste space including resources with empty beacons and 0 counters in uploads. BUG=356791 Review URL: https://codereview.chromium.org/284283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271045 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
Make some methods take Node/View* instead of NodeId/ViewId. These functions needs the Nodes anyway, so no point in converting to id, then back to node multiple times. Also remove TODOs that aren't going to happen. BUG=365012 TEST=covered by tests R=ben@chromium.org Review URL: https://codereview.chromium.org/284113008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271044 0039d316-1c4b-4281-b951-d872f2087c98
-
ttuttle@chromium.org authored
We'd grown a couple of copies of code to create various test objects. Deduplicate them into test_util and call them there. BUG=356791 Review URL: https://codereview.chromium.org/291493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271043 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
Chrome treats the user ID passed in via chromeos::switches::kLoginUser as if someone had authenticated against GAIA using this ID. During GAIA authentication, the user ID is canonicalized. If authentication is short-circuited using this switch, the user ID should thus be canonicalized as well. BUG=367847 TEST=None TBR=stevenjb (chrome/browser/extensions/api/networking_private/networking_private_apitest.cc) Review URL: https://codereview.chromium.org/290123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271042 0039d316-1c4b-4281-b951-d872f2087c98
-
yunlian@chromium.org authored
BUG=chromium:373548 TEST=the warnings are gone. Review URL: https://codereview.chromium.org/288903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271041 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=374058 Review URL: https://codereview.chromium.org/291483005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271040 0039d316-1c4b-4281-b951-d872f2087c98
-
hans@chromium.org authored
This dir will be put on the include path for MSVC to pick up when invoked as fallback compiler. BUG=345874 NOTRY=true Review URL: https://codereview.chromium.org/281413006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271039 0039d316-1c4b-4281-b951-d872f2087c98
-
ttuttle@chromium.org authored
I was copying the error code out of the URLRequestStatus of a monitored request whether or not the status was FAILED; in cases where it wasn't, the error would be something random (often QUIC_PROTOCOL_ERROR). This change makes sure that we only copy the error code when we should, and adds a unit test to make sure that beacons for successful requests contain net::OK even if the error field contains something else. BUG=356791 Review URL: https://codereview.chromium.org/284103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271038 0039d316-1c4b-4281-b951-d872f2087c98
-
pasko@chromium.org authored
BUG=366632 Review URL: https://codereview.chromium.org/283963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271037 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
It is not necessary for WindowTreeHostOzone to call into the event-factory to explicitly request it to start receiving events. The evdev implementation can start listening to the events immediately, and the canca implementation can start listening for events when the dispatcher list changes (this is the same we do for the libevent based x11 event-source). BUG=361137 R=spang@chromium.org Review URL: https://codereview.chromium.org/285303004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271036 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
BUG=373537 Review URL: https://codereview.chromium.org/290653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271035 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
Changes in this CL: - Add cdm_factory.h to support platform specific CDM creation. - Detach BrowserMediaPlayerManager from MediaDrmBridge. - Store the security origin of CDMs in the manager so that CDMs don't need to know it. - Keep the CDM ID in the manager so that CDMs don't see it. BUG=338910 TEST=Test page plays and tests still pass. Review URL: https://codereview.chromium.org/276973005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271034 0039d316-1c4b-4281-b951-d872f2087c98
-
ericu@chromium.org authored
This closed the tree: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/11008/steps/interactive_ui_tests/logs/stdio > [DevTools] Interactive test for DevTools touch emulation. > > BUG=337142 > > Review URL: https://codereview.chromium.org/249613002 TBR=dgozman@chromium.org Review URL: https://codereview.chromium.org/287153007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271032 0039d316-1c4b-4281-b951-d872f2087c98
-